mirror of
https://github.com/MichMich/MagicMirror.git
synced 2026-04-24 06:47:07 +00:00
df8a882966
I was playing around with the newsfeed notification system (`ARTICLE_MORE_DETAILS`, `ARTICLE_TOGGLE_FULL`, …) and discovered some issues with the full article view: The iframe was loading the CORS proxy URL instead of the actual article URL, which could cause blank screens depending on the feed. Also, many news sites block iframes entirely (`X-Frame-Options: DENY`) and the user got no feedback at all — just an empty page. On top of that, scrolling used `window.scrollTo()` which moved the entire MagicMirror page instead of just the article. This PR cleans that up: - Use the raw article URL for the iframe (CORS proxy is only needed for server-side feed fetching) - Check `X-Frame-Options` / `Content-Security-Policy` headers server-side before showing the iframe — if the site blocks it, show a brief "Article cannot be displayed here." message and return to normal view - Show the iframe as a fixed full-screen overlay so other modules aren't affected, scroll via `container.scrollTop` - Keep the progressive disclosure behavior for `ARTICLE_MORE_DETAILS` (title → description → iframe → scroll) - Delete `fullarticle.njk`, replace with `getDom()` override - Fix `ARTICLE_INFO_RESPONSE` returning proxy URL instead of real URL - A few smaller fixes (negative scroll, null guard) - Add `NEWSFEED_ARTICLE_UNAVAILABLE` translation to all 47 language files - Add e2e tests for the notification handlers (`ARTICLE_NEXT`, `ARTICLE_PREVIOUS`, `ARTICLE_INFO_REQUEST`, `ARTICLE_LESS_DETAILS`) ## What this means for users - The full article view now works reliably across different feeds - If a news site blocks iframes, the user sees a brief message instead of a blank screen - Additional e2e tests make the module more robust and less likely to break silently in future MagicMirror versions
55 lines
1.9 KiB
JSON
55 lines
1.9 KiB
JSON
{
|
|
"LOADING": "Besig om te laai …",
|
|
|
|
"DAYBEFOREYESTERDAY": "Eergister",
|
|
"YESTERDAY": "Gister",
|
|
"TODAY": "Vandag",
|
|
"TOMORROW": "Môre",
|
|
"DAYAFTERTOMORROW": "Oormôre",
|
|
"RUNNING": "Eindig in",
|
|
"EMPTY": "Geen komende gebeurtenisse.",
|
|
"WEEK": "Week {weekNumber}",
|
|
|
|
"N": "N",
|
|
"NNE": "NNO",
|
|
"NE": "NO",
|
|
"ENE": "ONO",
|
|
"E": "O",
|
|
"ESE": "OSO",
|
|
"SE": "SO",
|
|
"SSE": "SSO",
|
|
"S": "S",
|
|
"SSW": "SSW",
|
|
"SW": "SW",
|
|
"WSW": "WSW",
|
|
"W": "W",
|
|
"WNW": "WNW",
|
|
"NW": "NW",
|
|
"NNW": "NNW",
|
|
|
|
"FEELS": "Voel soos {DEGREE}",
|
|
"PRECIP_POP": "Neerslag waarskynlikheid",
|
|
"PRECIP_AMOUNT": "Neerslag hoeveelheid",
|
|
|
|
"MODULE_CONFIG_CHANGED": "Die konfigurasie opsies vir die {MODULE_NAME} module het verander.\nGaan asseblief die dokumentasie na.",
|
|
"MODULE_CONFIG_ERROR": "Fout in die {MODULE_NAME} module. {ERROR}",
|
|
"MODULE_ERROR_MALFORMED_URL": "Ongeldige URL.",
|
|
"MODULE_ERROR_NO_CONNECTION": "Geen internetverbinding.",
|
|
"MODULE_ERROR_UNAUTHORIZED": "Owerheid het misluk.",
|
|
"MODULE_ERROR_RATE_LIMITED": "Te veel versoeke. Probeer later weer.",
|
|
"MODULE_ERROR_SERVER_ERROR": "Bediener fout. Probeer later weer.",
|
|
"MODULE_ERROR_CLIENT_ERROR": "Versoek het misluk.",
|
|
"MODULE_ERROR_UNSPECIFIED": "Gaan die logs na vir meer besonderhede.",
|
|
|
|
"NEWSFEED_NO_ITEMS": "Geen nuus op die oomblik.",
|
|
"NEWSFEED_ARTICLE_UNAVAILABLE": "Artikel kan nie hier vertoon word nie.",
|
|
|
|
"UPDATE_NOTIFICATION": "MagicMirror² update beskikbaar.",
|
|
"UPDATE_NOTIFICATION_MODULE": "Update beskikbaar vir {MODULE_NAME} module.",
|
|
"UPDATE_INFO_SINGLE": "Die huidige installasie is {COMMIT_COUNT} commit agter op die {BRANCH_NAME} branch.",
|
|
"UPDATE_INFO_MULTIPLE": "Die huidige installasie is {COMMIT_COUNT} commits agter op die {BRANCH_NAME} branch.",
|
|
"UPDATE_NOTIFICATION_DONE": "Update voltooi vir {MODULE_NAME} module.",
|
|
"UPDATE_NOTIFICATION_ERROR": "Fout tydens opdatering van {MODULE_NAME} module.",
|
|
"UPDATE_NOTIFICATION_NEED-RESTART": "MagicMirror moet herbegin word."
|
|
}
|