mirror of
https://github.com/MichMich/MagicMirror.git
synced 2026-04-24 06:47:07 +00:00
df8a882966
I was playing around with the newsfeed notification system (`ARTICLE_MORE_DETAILS`, `ARTICLE_TOGGLE_FULL`, …) and discovered some issues with the full article view: The iframe was loading the CORS proxy URL instead of the actual article URL, which could cause blank screens depending on the feed. Also, many news sites block iframes entirely (`X-Frame-Options: DENY`) and the user got no feedback at all — just an empty page. On top of that, scrolling used `window.scrollTo()` which moved the entire MagicMirror page instead of just the article. This PR cleans that up: - Use the raw article URL for the iframe (CORS proxy is only needed for server-side feed fetching) - Check `X-Frame-Options` / `Content-Security-Policy` headers server-side before showing the iframe — if the site blocks it, show a brief "Article cannot be displayed here." message and return to normal view - Show the iframe as a fixed full-screen overlay so other modules aren't affected, scroll via `container.scrollTop` - Keep the progressive disclosure behavior for `ARTICLE_MORE_DETAILS` (title → description → iframe → scroll) - Delete `fullarticle.njk`, replace with `getDom()` override - Fix `ARTICLE_INFO_RESPONSE` returning proxy URL instead of real URL - A few smaller fixes (negative scroll, null guard) - Add `NEWSFEED_ARTICLE_UNAVAILABLE` translation to all 47 language files - Add e2e tests for the notification handlers (`ARTICLE_NEXT`, `ARTICLE_PREVIOUS`, `ARTICLE_INFO_REQUEST`, `ARTICLE_LESS_DETAILS`) ## What this means for users - The full article view now works reliably across different feeds - If a news site blocks iframes, the user sees a brief message instead of a blank screen - Additional e2e tests make the module more robust and less likely to break silently in future MagicMirror versions
54 lines
1.8 KiB
JSON
54 lines
1.8 KiB
JSON
{
|
|
"LOADING": "Loading …",
|
|
|
|
"YESTERDAY": "Yesterday",
|
|
"TODAY": "Today",
|
|
"TOMORROW": "Tomorrow",
|
|
"RUNNING": "Ends in",
|
|
"EMPTY": "No upcoming events.",
|
|
"WEEK": "Week {weekNumber}",
|
|
"WEEK_SHORT": "W{weekNumber}",
|
|
|
|
"N": "N",
|
|
"NNE": "NNE",
|
|
"NE": "NE",
|
|
"ENE": "ENE",
|
|
"E": "E",
|
|
"ESE": "ESE",
|
|
"SE": "SE",
|
|
"SSE": "SSE",
|
|
"S": "S",
|
|
"SSW": "SSW",
|
|
"SW": "SW",
|
|
"WSW": "WSW",
|
|
"W": "W",
|
|
"WNW": "WNW",
|
|
"NW": "NW",
|
|
"NNW": "NNW",
|
|
|
|
"FEELS": "Feels like {DEGREE}",
|
|
"PRECIP_POP": "PoP",
|
|
"PRECIP_AMOUNT": "Precipitation amount",
|
|
|
|
"MODULE_CONFIG_CHANGED": "The configuration options for the {MODULE_NAME} module have changed.\nPlease check the documentation.",
|
|
"MODULE_CONFIG_ERROR": "Error in the {MODULE_NAME} module. {ERROR}",
|
|
"MODULE_ERROR_MALFORMED_URL": "Malformed url.",
|
|
"MODULE_ERROR_NO_CONNECTION": "No internet connection.",
|
|
"MODULE_ERROR_UNAUTHORIZED": "Authorization failed.",
|
|
"MODULE_ERROR_RATE_LIMITED": "Too many requests. Retrying later.",
|
|
"MODULE_ERROR_SERVER_ERROR": "Server error. Retrying later.",
|
|
"MODULE_ERROR_CLIENT_ERROR": "Request failed.",
|
|
"MODULE_ERROR_UNSPECIFIED": "Check logs for more details.",
|
|
|
|
"NEWSFEED_NO_ITEMS": "No news at the moment.",
|
|
"NEWSFEED_ARTICLE_UNAVAILABLE": "Article cannot be displayed here.",
|
|
|
|
"UPDATE_NOTIFICATION": "MagicMirror² update available.",
|
|
"UPDATE_NOTIFICATION_MODULE": "Update available for {MODULE_NAME} module.",
|
|
"UPDATE_INFO_SINGLE": "The current installation is {COMMIT_COUNT} commit behind on the {BRANCH_NAME} branch.",
|
|
"UPDATE_INFO_MULTIPLE": "The current installation is {COMMIT_COUNT} commits behind on the {BRANCH_NAME} branch.",
|
|
"UPDATE_NOTIFICATION_DONE": "Update done for {MODULE_NAME} module",
|
|
"UPDATE_NOTIFICATION_ERROR": "Update error for {MODULE_NAME} module",
|
|
"UPDATE_NOTIFICATION_NEED-RESTART": "Restarting of MagicMirror is required."
|
|
}
|