mirror of
https://github.com/MichMich/MagicMirror.git
synced 2026-04-24 06:47:07 +00:00
I was playing around with the newsfeed notification system (`ARTICLE_MORE_DETAILS`, `ARTICLE_TOGGLE_FULL`, …) and discovered some issues with the full article view: The iframe was loading the CORS proxy URL instead of the actual article URL, which could cause blank screens depending on the feed. Also, many news sites block iframes entirely (`X-Frame-Options: DENY`) and the user got no feedback at all — just an empty page. On top of that, scrolling used `window.scrollTo()` which moved the entire MagicMirror page instead of just the article. This PR cleans that up: - Use the raw article URL for the iframe (CORS proxy is only needed for server-side feed fetching) - Check `X-Frame-Options` / `Content-Security-Policy` headers server-side before showing the iframe — if the site blocks it, show a brief "Article cannot be displayed here." message and return to normal view - Show the iframe as a fixed full-screen overlay so other modules aren't affected, scroll via `container.scrollTop` - Keep the progressive disclosure behavior for `ARTICLE_MORE_DETAILS` (title → description → iframe → scroll) - Delete `fullarticle.njk`, replace with `getDom()` override - Fix `ARTICLE_INFO_RESPONSE` returning proxy URL instead of real URL - A few smaller fixes (negative scroll, null guard) - Add `NEWSFEED_ARTICLE_UNAVAILABLE` translation to all 47 language files - Add e2e tests for the notification handlers (`ARTICLE_NEXT`, `ARTICLE_PREVIOUS`, `ARTICLE_INFO_REQUEST`, `ARTICLE_LESS_DETAILS`) ## What this means for users - The full article view now works reliably across different feeds - If a news site blocks iframes, the user sees a brief message instead of a blank screen - Additional e2e tests make the module more robust and less likely to break silently in future MagicMirror versions
55 lines
2.0 KiB
JSON
55 lines
2.0 KiB
JSON
{
|
|
"LOADING": "Laadimine…",
|
|
|
|
"DAYBEFOREYESTERDAY": "Üleeile",
|
|
"YESTERDAY": "Eile",
|
|
"TODAY": "Täna",
|
|
"TOMORROW": "Homme",
|
|
"DAYAFTERTOMORROW": "Ülehomme",
|
|
"RUNNING": "Lõpeb",
|
|
"EMPTY": "Eelolevaid sündmusi pole.",
|
|
"WEEK": "Nädal {weekNumber}",
|
|
|
|
"N": "Põhi",
|
|
"NNE": "Põhjakirre",
|
|
"NE": "Kirre",
|
|
"ENE": "Idakirre",
|
|
"E": "Ida",
|
|
"ESE": "Idakagu",
|
|
"SE": "Kagu",
|
|
"SSE": "Lõunakagu",
|
|
"S": "Lõuna",
|
|
"SSW": "Lõunaedel",
|
|
"SW": "Edel",
|
|
"WSW": "Lääneedel",
|
|
"W": "Lääs",
|
|
"WNW": "Lääneloe",
|
|
"NW": "Loe",
|
|
"NNW": "Põhjaloe",
|
|
|
|
"FEELS": "Tajutav temperatuur {DEGREE}",
|
|
"PRECIP_POP": "Sademete tõenäosus",
|
|
"PRECIP_AMOUNT": "Sademete hulk",
|
|
|
|
"MODULE_CONFIG_CHANGED": "Konfiguratiooni sätted {MODULE_NAME} moodulile on muutunud.\nPalun vaadake dokumentatsiooni.",
|
|
"MODULE_CONFIG_ERROR": "Error moodulis {MODULE_NAME}. {ERROR}",
|
|
"MODULE_ERROR_MALFORMED_URL": "Ebakorrektne url.",
|
|
"MODULE_ERROR_NO_CONNECTION": "Interneti ühendus puudub.",
|
|
"MODULE_ERROR_UNAUTHORIZED": "Autoriseerimine ebaõnnestus.",
|
|
"MODULE_ERROR_RATE_LIMITED": "Liiga palju päringuid. Proovin hiljem uuesti.",
|
|
"MODULE_ERROR_SERVER_ERROR": "Serveri viga. Proovin hiljem uuesti.",
|
|
"MODULE_ERROR_CLIENT_ERROR": "Päring ebaõnnestus.",
|
|
"MODULE_ERROR_UNSPECIFIED": "Lisateabe saamiseks kontrollige logifaile.",
|
|
|
|
"NEWSFEED_NO_ITEMS": "Hetkel ei ole uudiseid.",
|
|
"NEWSFEED_ARTICLE_UNAVAILABLE": "Artiklit ei saa siin kuvada.",
|
|
|
|
"UPDATE_NOTIFICATION": "MagicMirror²'le on uuendus saadaval.",
|
|
"UPDATE_NOTIFICATION_MODULE": "Uuendus saadaval {MODULE_NAME} moodulile.",
|
|
"UPDATE_INFO_SINGLE": "Praegune paigaldus on {COMMIT_COUNT} muudatust tagapool {BRANCH_NAME} harus.",
|
|
"UPDATE_INFO_MULTIPLE": "Praegune paigaldus on {COMMIT_COUNT} muudatust tagapool {BRANCH_NAME} harus.",
|
|
"UPDATE_NOTIFICATION_DONE": "{MODULE_NAME} moodul uuendati edukalt",
|
|
"UPDATE_NOTIFICATION_ERROR": "{MODULE_NAME} mooduli uuendamine ebaõnnestus",
|
|
"UPDATE_NOTIFICATION_NEED-RESTART": "Palun taaskäivitage MagicMirror."
|
|
}
|