mirror of
https://github.com/MichMich/MagicMirror.git
synced 2026-04-25 15:22:06 +00:00
df8a882966
I was playing around with the newsfeed notification system (`ARTICLE_MORE_DETAILS`, `ARTICLE_TOGGLE_FULL`, …) and discovered some issues with the full article view: The iframe was loading the CORS proxy URL instead of the actual article URL, which could cause blank screens depending on the feed. Also, many news sites block iframes entirely (`X-Frame-Options: DENY`) and the user got no feedback at all — just an empty page. On top of that, scrolling used `window.scrollTo()` which moved the entire MagicMirror page instead of just the article. This PR cleans that up: - Use the raw article URL for the iframe (CORS proxy is only needed for server-side feed fetching) - Check `X-Frame-Options` / `Content-Security-Policy` headers server-side before showing the iframe — if the site blocks it, show a brief "Article cannot be displayed here." message and return to normal view - Show the iframe as a fixed full-screen overlay so other modules aren't affected, scroll via `container.scrollTop` - Keep the progressive disclosure behavior for `ARTICLE_MORE_DETAILS` (title → description → iframe → scroll) - Delete `fullarticle.njk`, replace with `getDom()` override - Fix `ARTICLE_INFO_RESPONSE` returning proxy URL instead of real URL - A few smaller fixes (negative scroll, null guard) - Add `NEWSFEED_ARTICLE_UNAVAILABLE` translation to all 47 language files - Add e2e tests for the notification handlers (`ARTICLE_NEXT`, `ARTICLE_PREVIOUS`, `ARTICLE_INFO_REQUEST`, `ARTICLE_LESS_DETAILS`) ## What this means for users - The full article view now works reliably across different feeds - If a news site blocks iframes, the user sees a brief message instead of a blank screen - Additional e2e tests make the module more robust and less likely to break silently in future MagicMirror versions
55 lines
2.0 KiB
JSON
55 lines
2.0 KiB
JSON
{
|
|
"LOADING": "Lataa …",
|
|
|
|
"DAYBEFOREYESTERDAY": "Toissapäivänä",
|
|
"YESTERDAY": "Eilen",
|
|
"TODAY": "Tänään",
|
|
"TOMORROW": "Huomenna",
|
|
"DAYAFTERTOMORROW": "Ylihuomenna",
|
|
"RUNNING": "Päättyy {timeUntilEnd} päästä",
|
|
"EMPTY": "Ei tulevia tapahtumia.",
|
|
"WEEK": "Viikko {weekNumber}",
|
|
|
|
"N": "P",
|
|
"NNE": "PPI",
|
|
"NE": "PI",
|
|
"ENE": "IPI",
|
|
"E": "I",
|
|
"ESE": "IEI",
|
|
"SE": "EI",
|
|
"SSE": "EEI",
|
|
"S": "E",
|
|
"SSW": "EEL",
|
|
"SW": "EL",
|
|
"WSW": "LEL",
|
|
"W": "L",
|
|
"WNW": "LPL",
|
|
"NW": "PL",
|
|
"NNW": "PPL",
|
|
|
|
"FEELS": "Tuntuu kuin {DEGREE}",
|
|
"PRECIP_POP": "Sateen todennäköisyys",
|
|
"PRECIP_AMOUNT": "Sateen määrä",
|
|
|
|
"MODULE_CONFIG_CHANGED": "Moduulin {MODULE_NAME} asetukset on muutettu.\nOle hyvä ja tarkista dokumentaatio.",
|
|
"MODULE_CONFIG_ERROR": "Virhe moduulissa {MODULE_NAME}. {ERROR}",
|
|
"MODULE_ERROR_MALFORMED_URL": "Virheellinen url.",
|
|
"MODULE_ERROR_NO_CONNECTION": "Ei internet-yhteyttä.",
|
|
"MODULE_ERROR_UNAUTHORIZED": "Valtuutus epäonnistui.",
|
|
"MODULE_ERROR_RATE_LIMITED": "Liikaa pyyntöjä. Yritetään myöhemmin uudelleen.",
|
|
"MODULE_ERROR_SERVER_ERROR": "Palvelinvirhe. Yritetään myöhemmin uudelleen.",
|
|
"MODULE_ERROR_CLIENT_ERROR": "Pyyntö epäonnistui.",
|
|
"MODULE_ERROR_UNSPECIFIED": "Tarkista lokitiedostot saadaksesi lisätietoja.",
|
|
|
|
"NEWSFEED_NO_ITEMS": "Ei uutisia tällä hetkellä.",
|
|
"NEWSFEED_ARTICLE_UNAVAILABLE": "Artikkelia ei voi näyttää täällä.",
|
|
|
|
"UPDATE_NOTIFICATION": "MagicMirror² päivitys saatavilla.",
|
|
"UPDATE_NOTIFICATION_MODULE": "Päivitys saatavilla moduulille {MODULE_NAME}.",
|
|
"UPDATE_INFO_SINGLE": "Nykyasennus on {COMMIT_COUNT} muutoksen jäljessä {BRANCH_NAME} haaraan nähden.",
|
|
"UPDATE_INFO_MULTIPLE": "Nykyasennus on {COMMIT_COUNT} muutosta jäljessä {BRANCH_NAME} haaraan nähden.",
|
|
"UPDATE_NOTIFICATION_DONE": "Päivitys moduulille {MODULE_NAME} valmis.",
|
|
"UPDATE_NOTIFICATION_ERROR": "Virhe moduulin {MODULE_NAME} päivityksessä.",
|
|
"UPDATE_NOTIFICATION_NEED-RESTART": "MagicMirror tulee käynnistää uudelleen."
|
|
}
|