mirror of
https://github.com/MichMich/MagicMirror.git
synced 2026-04-24 06:47:07 +00:00
df8a882966
I was playing around with the newsfeed notification system (`ARTICLE_MORE_DETAILS`, `ARTICLE_TOGGLE_FULL`, …) and discovered some issues with the full article view: The iframe was loading the CORS proxy URL instead of the actual article URL, which could cause blank screens depending on the feed. Also, many news sites block iframes entirely (`X-Frame-Options: DENY`) and the user got no feedback at all — just an empty page. On top of that, scrolling used `window.scrollTo()` which moved the entire MagicMirror page instead of just the article. This PR cleans that up: - Use the raw article URL for the iframe (CORS proxy is only needed for server-side feed fetching) - Check `X-Frame-Options` / `Content-Security-Policy` headers server-side before showing the iframe — if the site blocks it, show a brief "Article cannot be displayed here." message and return to normal view - Show the iframe as a fixed full-screen overlay so other modules aren't affected, scroll via `container.scrollTop` - Keep the progressive disclosure behavior for `ARTICLE_MORE_DETAILS` (title → description → iframe → scroll) - Delete `fullarticle.njk`, replace with `getDom()` override - Fix `ARTICLE_INFO_RESPONSE` returning proxy URL instead of real URL - A few smaller fixes (negative scroll, null guard) - Add `NEWSFEED_ARTICLE_UNAVAILABLE` translation to all 47 language files - Add e2e tests for the notification handlers (`ARTICLE_NEXT`, `ARTICLE_PREVIOUS`, `ARTICLE_INFO_REQUEST`, `ARTICLE_LESS_DETAILS`) ## What this means for users - The full article view now works reliably across different feeds - If a news site blocks iframes, the user sees a brief message instead of a blank screen - Additional e2e tests make the module more robust and less likely to break silently in future MagicMirror versions
55 lines
2.2 KiB
JSON
55 lines
2.2 KiB
JSON
{
|
|
"LOADING": "טוען...",
|
|
|
|
"DAYBEFOREYESTERDAY": "שלשום",
|
|
"YESTERDAY": "אתמול",
|
|
"TODAY": "היום",
|
|
"TOMORROW": "מחר",
|
|
"DAYAFTERTOMORROW": "בעוד יומיים",
|
|
"RUNNING": "מסתיים ב",
|
|
"EMPTY": "אין ארועים",
|
|
"WEEK": "{weekNumber} שבוע",
|
|
|
|
"N": "צ",
|
|
"NNE": "צ-צ-מז",
|
|
"NE": "צ-מז",
|
|
"ENE": "מז-צ-מז",
|
|
"E": "מז",
|
|
"ESE": "מז-ד-מז",
|
|
"SE": "ד-מז",
|
|
"SSE": "ד-ד-מז",
|
|
"S": "ד",
|
|
"SSW": "ד-ד-מע",
|
|
"SW": "ד-מע",
|
|
"WSW": "מע-ד-מע",
|
|
"W": "מע",
|
|
"WNW": "מע-ז-מע",
|
|
"NW": "ז-מע",
|
|
"NNW": "צ-צ-מע",
|
|
|
|
"FEELS": "מרגיש כמו {DEGREE}",
|
|
"PRECIP_POP": "משקעים",
|
|
"PRECIP_AMOUNT": "כמות משקעים",
|
|
|
|
"MODULE_CONFIG_CHANGED": "אפשרויות התצורה עבור מודול {MODULE_NAME} השתנו.\nאנא בדוק את התיעוד.",
|
|
"MODULE_CONFIG_ERROR": "שגיאה במודול {MODULE_NAME}. {ERROR}",
|
|
"MODULE_ERROR_MALFORMED_URL": "כתובת אתר לא תקינה.",
|
|
"MODULE_ERROR_NO_CONNECTION": "אין חיבור לאינטרנט.",
|
|
"MODULE_ERROR_UNAUTHORIZED": "הזדהות נכשלה.",
|
|
"MODULE_ERROR_RATE_LIMITED": "יותר מדי בקשות. מנסה שוב מאוחר יותר.",
|
|
"MODULE_ERROR_SERVER_ERROR": "שגיאת שרת. מנסה שוב מאוחר יותר.",
|
|
"MODULE_ERROR_CLIENT_ERROR": "הבקשה נכשלה.",
|
|
"MODULE_ERROR_UNSPECIFIED": "בדוק את היומנים לפרטים נוספים.",
|
|
|
|
"NEWSFEED_NO_ITEMS": "אין חדשות כרגע.",
|
|
"NEWSFEED_ARTICLE_UNAVAILABLE": "לא ניתן להציג את המאמר כאן.",
|
|
|
|
"UPDATE_NOTIFICATION": "עדכון זמין ל-MagicMirror²",
|
|
"UPDATE_NOTIFICATION_MODULE": "עדכון זמין ב-{MODULE_NAME} מודול",
|
|
"UPDATE_INFO_SINGLE": "ההתקנה הנוכחית נמצאת מאחור הענף {BRANCH_NAME} ב-{COMMIT_COUNT} מופע",
|
|
"UPDATE_INFO_MULTIPLE": "ההתקנה הנוכחית נמצאת מאחור הענף {BRANCH_NAME} ב-{COMMIT_COUNT} מופעים",
|
|
"UPDATE_NOTIFICATION_DONE": "העדכון הסתיים עבור מודול {MODULE_NAME}",
|
|
"UPDATE_NOTIFICATION_ERROR": "שגיאת עדכון עבור מודול {MODULE_NAME}",
|
|
"UPDATE_NOTIFICATION_NEED-RESTART": "יש צורך לאתחל את ה-MagicMirror"
|
|
}
|