mirror of
https://github.com/MichMich/MagicMirror.git
synced 2026-04-24 06:47:07 +00:00
I was playing around with the newsfeed notification system (`ARTICLE_MORE_DETAILS`, `ARTICLE_TOGGLE_FULL`, …) and discovered some issues with the full article view: The iframe was loading the CORS proxy URL instead of the actual article URL, which could cause blank screens depending on the feed. Also, many news sites block iframes entirely (`X-Frame-Options: DENY`) and the user got no feedback at all — just an empty page. On top of that, scrolling used `window.scrollTo()` which moved the entire MagicMirror page instead of just the article. This PR cleans that up: - Use the raw article URL for the iframe (CORS proxy is only needed for server-side feed fetching) - Check `X-Frame-Options` / `Content-Security-Policy` headers server-side before showing the iframe — if the site blocks it, show a brief "Article cannot be displayed here." message and return to normal view - Show the iframe as a fixed full-screen overlay so other modules aren't affected, scroll via `container.scrollTop` - Keep the progressive disclosure behavior for `ARTICLE_MORE_DETAILS` (title → description → iframe → scroll) - Delete `fullarticle.njk`, replace with `getDom()` override - Fix `ARTICLE_INFO_RESPONSE` returning proxy URL instead of real URL - A few smaller fixes (negative scroll, null guard) - Add `NEWSFEED_ARTICLE_UNAVAILABLE` translation to all 47 language files - Add e2e tests for the notification handlers (`ARTICLE_NEXT`, `ARTICLE_PREVIOUS`, `ARTICLE_INFO_REQUEST`, `ARTICLE_LESS_DETAILS`) ## What this means for users - The full article view now works reliably across different feeds - If a news site blocks iframes, the user sees a brief message instead of a blank screen - Additional e2e tests make the module more robust and less likely to break silently in future MagicMirror versions
54 lines
1.8 KiB
JSON
54 lines
1.8 KiB
JSON
{
|
|
"LOADING": "Memuat …",
|
|
|
|
"YESTERDAY": "Kemarin",
|
|
"TODAY": "Hari ini",
|
|
"TOMORROW": "Besok",
|
|
"DAYAFTERTOMORROW": "Lusa",
|
|
"RUNNING": "Berakhir dalam",
|
|
"EMPTY": "Tidak ada agenda",
|
|
"WEEK": "Pekan",
|
|
|
|
"N": "U",
|
|
"NNE": "UTL",
|
|
"NE": "TL",
|
|
"ENE": "TTL",
|
|
"E": "T",
|
|
"ESE": "TMg",
|
|
"SE": "TG",
|
|
"SSE": "SMg",
|
|
"S": "S",
|
|
"SSW": "SBD",
|
|
"SW": "BD",
|
|
"WSW": "BBD",
|
|
"W": "B",
|
|
"WNW": "BBL",
|
|
"NW": "BL",
|
|
"NNW": "UBL",
|
|
|
|
"FEELS": "Terasa {DEGREE}",
|
|
"PRECIP_POP": "Kemungkinan curah hujan",
|
|
"PRECIP_AMOUNT": "Jumlah curah hujan",
|
|
|
|
"MODULE_CONFIG_CHANGED": "Opsi konfigurasi modul {MODULE_NAME} telah diubah.\nSilakan periksa dokumentasi.",
|
|
"MODULE_CONFIG_ERROR": "Terjadi kesalahan pada modul {MODULE_NAME}. {ERROR}",
|
|
"MODULE_ERROR_MALFORMED_URL": "URL tidak valid.",
|
|
"MODULE_ERROR_NO_CONNECTION": "Tidak ada koneksi internet.",
|
|
"MODULE_ERROR_UNAUTHORIZED": "Gagal otentikasi.",
|
|
"MODULE_ERROR_RATE_LIMITED": "Terlalu banyak permintaan. Mencoba lagi nanti.",
|
|
"MODULE_ERROR_SERVER_ERROR": "Kesalahan server. Mencoba lagi nanti.",
|
|
"MODULE_ERROR_CLIENT_ERROR": "Permintaan gagal.",
|
|
"MODULE_ERROR_UNSPECIFIED": "Silakan periksa log untuk informasi lebih lanjut.",
|
|
|
|
"NEWSFEED_NO_ITEMS": "Saat ini tidak ada berita.",
|
|
"NEWSFEED_ARTICLE_UNAVAILABLE": "Artikel tidak dapat ditampilkan di sini.",
|
|
|
|
"UPDATE_NOTIFICATION": "Memperbarui MagicMirror² tersedia.",
|
|
"UPDATE_NOTIFICATION_MODULE": "Memperbarui tersedia untuk modul {MODULE_NAME}.",
|
|
"UPDATE_INFO_SINGLE": "Instalasi saat ini tertinggal {COMMIT_COUNT} commit pada cabang {BRANCH_NAME}.",
|
|
"UPDATE_INFO_MULTIPLE": "Instalasi saat ini tertinggal {COMMIT_COUNT} commits pada cabang {BRANCH_NAME}.",
|
|
"UPDATE_NOTIFICATION_DONE": "Pembaruan modul {MODULE_NAME} selesai.",
|
|
"UPDATE_NOTIFICATION_ERROR": "Terjadi kesalahan saat memperbarui modul {MODULE_NAME}.",
|
|
"UPDATE_NOTIFICATION_NEED-RESTART": "Diperlukan restart MagicMirror."
|
|
}
|