mirror of
https://github.com/MichMich/MagicMirror.git
synced 2026-04-25 15:22:06 +00:00
df8a882966
I was playing around with the newsfeed notification system (`ARTICLE_MORE_DETAILS`, `ARTICLE_TOGGLE_FULL`, …) and discovered some issues with the full article view: The iframe was loading the CORS proxy URL instead of the actual article URL, which could cause blank screens depending on the feed. Also, many news sites block iframes entirely (`X-Frame-Options: DENY`) and the user got no feedback at all — just an empty page. On top of that, scrolling used `window.scrollTo()` which moved the entire MagicMirror page instead of just the article. This PR cleans that up: - Use the raw article URL for the iframe (CORS proxy is only needed for server-side feed fetching) - Check `X-Frame-Options` / `Content-Security-Policy` headers server-side before showing the iframe — if the site blocks it, show a brief "Article cannot be displayed here." message and return to normal view - Show the iframe as a fixed full-screen overlay so other modules aren't affected, scroll via `container.scrollTop` - Keep the progressive disclosure behavior for `ARTICLE_MORE_DETAILS` (title → description → iframe → scroll) - Delete `fullarticle.njk`, replace with `getDom()` override - Fix `ARTICLE_INFO_RESPONSE` returning proxy URL instead of real URL - A few smaller fixes (negative scroll, null guard) - Add `NEWSFEED_ARTICLE_UNAVAILABLE` translation to all 47 language files - Add e2e tests for the notification handlers (`ARTICLE_NEXT`, `ARTICLE_PREVIOUS`, `ARTICLE_INFO_REQUEST`, `ARTICLE_LESS_DETAILS`) ## What this means for users - The full article view now works reliably across different feeds - If a news site blocks iframes, the user sees a brief message instead of a blank screen - Additional e2e tests make the module more robust and less likely to break silently in future MagicMirror versions
55 lines
1.9 KiB
JSON
55 lines
1.9 KiB
JSON
{
|
|
"LOADING": "Hleð upp …",
|
|
|
|
"DAYBEFOREYESTERDAY": "Í fyrradag",
|
|
"YESTERDAY": "Í gær",
|
|
"TODAY": "Í dag",
|
|
"TOMORROW": "Á morgun",
|
|
"DAYAFTERTOMORROW": "Ekki á morgun, heldur hinn",
|
|
"RUNNING": "Endar eftir",
|
|
"EMPTY": "Ekkert framundan.",
|
|
"WEEK": "Vika {weekNumber}",
|
|
|
|
"N": "N",
|
|
"NNE": "NNA",
|
|
"NE": "NA",
|
|
"ENE": "ANA",
|
|
"E": "A",
|
|
"ESE": "ASA",
|
|
"SE": "SA",
|
|
"SSE": "SSA",
|
|
"S": "S",
|
|
"SSW": "SSV",
|
|
"SW": "SV",
|
|
"WSW": "VSV",
|
|
"W": "V",
|
|
"WNW": "VNV",
|
|
"NW": "NV",
|
|
"NNW": "NNV",
|
|
|
|
"FEELS": "Kælist á {DEGREE}",
|
|
"PRECIP_POP": "Úrkoma",
|
|
"PRECIP_AMOUNT": "Magn úrkomu",
|
|
|
|
"MODULE_CONFIG_CHANGED": "Stillingar fyrir {MODULE_NAME} module hafa breyst.\nVinsamlegast skoðaðu skjöl.",
|
|
"MODULE_CONFIG_ERROR": "Villa í {MODULE_NAME} module. {ERROR}",
|
|
"MODULE_ERROR_MALFORMED_URL": "Villa í slóð.",
|
|
"MODULE_ERROR_NO_CONNECTION": "Engin nettenging.",
|
|
"MODULE_ERROR_UNAUTHORIZED": "Auðkenning mistókst.",
|
|
"MODULE_ERROR_RATE_LIMITED": "Of margar beiðnir. Reyni aftur síðar.",
|
|
"MODULE_ERROR_SERVER_ERROR": "Villa í þjóni. Reyni aftur síðar.",
|
|
"MODULE_ERROR_CLIENT_ERROR": "Beiðni mistókst.",
|
|
"MODULE_ERROR_UNSPECIFIED": "Vinsamlegast athugaðu skráningu fyrir frekari upplýsingar.",
|
|
|
|
"NEWSFEED_NO_ITEMS": "Engar fréttir í boði núna.",
|
|
"NEWSFEED_ARTICLE_UNAVAILABLE": "Grein er ekki hægt að sýna hér.",
|
|
|
|
"UPDATE_NOTIFICATION": "MagicMirror² uppfærsla í boði.",
|
|
"UPDATE_NOTIFICATION_MODULE": "Uppfærsla í boði fyrir {MODULE_NAME} module.",
|
|
"UPDATE_INFO_SINGLE": "Núverandi kerfi er {COMMIT_COUNT} commit á eftir {BRANCH_NAME} branchinu.",
|
|
"UPDATE_INFO_MULTIPLE": "Núverandi kerfi er {COMMIT_COUNT} commits á eftir {BRANCH_NAME} branchinu.",
|
|
"UPDATE_NOTIFICATION_DONE": "Uppfærsla lokið fyrir {MODULE_NAME} module",
|
|
"UPDATE_NOTIFICATION_ERROR": "Villa við uppfærslu fyrir {MODULE_NAME} module",
|
|
"UPDATE_NOTIFICATION_NEED-RESTART": "Endurræsa MagicMirror er nauðsynlegt."
|
|
}
|