mirror of
https://github.com/MichMich/MagicMirror.git
synced 2026-04-25 15:22:06 +00:00
df8a882966
I was playing around with the newsfeed notification system (`ARTICLE_MORE_DETAILS`, `ARTICLE_TOGGLE_FULL`, …) and discovered some issues with the full article view: The iframe was loading the CORS proxy URL instead of the actual article URL, which could cause blank screens depending on the feed. Also, many news sites block iframes entirely (`X-Frame-Options: DENY`) and the user got no feedback at all — just an empty page. On top of that, scrolling used `window.scrollTo()` which moved the entire MagicMirror page instead of just the article. This PR cleans that up: - Use the raw article URL for the iframe (CORS proxy is only needed for server-side feed fetching) - Check `X-Frame-Options` / `Content-Security-Policy` headers server-side before showing the iframe — if the site blocks it, show a brief "Article cannot be displayed here." message and return to normal view - Show the iframe as a fixed full-screen overlay so other modules aren't affected, scroll via `container.scrollTop` - Keep the progressive disclosure behavior for `ARTICLE_MORE_DETAILS` (title → description → iframe → scroll) - Delete `fullarticle.njk`, replace with `getDom()` override - Fix `ARTICLE_INFO_RESPONSE` returning proxy URL instead of real URL - A few smaller fixes (negative scroll, null guard) - Add `NEWSFEED_ARTICLE_UNAVAILABLE` translation to all 47 language files - Add e2e tests for the notification handlers (`ARTICLE_NEXT`, `ARTICLE_PREVIOUS`, `ARTICLE_INFO_REQUEST`, `ARTICLE_LESS_DETAILS`) ## What this means for users - The full article view now works reliably across different feeds - If a news site blocks iframes, the user sees a brief message instead of a blank screen - Additional e2e tests make the module more robust and less likely to break silently in future MagicMirror versions
55 lines
1.9 KiB
JSON
55 lines
1.9 KiB
JSON
{
|
|
"LOADING": "Lastar …",
|
|
|
|
"DAYBEFOREYESTERDAY": "I forgårs",
|
|
"YESTERDAY": "I går",
|
|
"TODAY": "I dag",
|
|
"TOMORROW": "I morgon",
|
|
"DAYAFTERTOMORROW": "I overmorgon",
|
|
"RUNNING": "Sluttar om",
|
|
"EMPTY": "Ingen komande hendingar.",
|
|
"WEEK": "Veke {weekNumber}",
|
|
|
|
"N": "N",
|
|
"NNE": "NNA",
|
|
"NE": "NA",
|
|
"ENE": "ANA",
|
|
"E": "A",
|
|
"ESE": "ASA",
|
|
"SE": "SA",
|
|
"SSE": "SSA",
|
|
"S": "S",
|
|
"SSW": "SSV",
|
|
"SW": "SV",
|
|
"WSW": "VSV",
|
|
"W": "V",
|
|
"WNW": "VNV",
|
|
"NW": "NV",
|
|
"NNW": "NNV",
|
|
|
|
"FEELS": "Kjenst som {DEGREE}",
|
|
"PRECIP_POP": "Sannsyn for nedbør",
|
|
"PRECIP_AMOUNT": "Nedbørsmengde",
|
|
|
|
"MODULE_CONFIG_CHANGED": "Innstillingane for {MODULE_NAME} modulen har endra seg.\nVennligst sjekk dokumentasjonen.",
|
|
"MODULE_CONFIG_ERROR": "Feil i {MODULE_NAME} modulen. {ERROR}",
|
|
"MODULE_ERROR_MALFORMED_URL": "Ugyldig URL.",
|
|
"MODULE_ERROR_NO_CONNECTION": "Ingen internettforbindelse.",
|
|
"MODULE_ERROR_UNAUTHORIZED": "Autentisering mislyktes.",
|
|
"MODULE_ERROR_RATE_LIMITED": "For mange førespurnader. Prøvar igjen seinare.",
|
|
"MODULE_ERROR_SERVER_ERROR": "Serverfeil. Prøvar igjen seinare.",
|
|
"MODULE_ERROR_CLIENT_ERROR": "Førespurnaden feila.",
|
|
"MODULE_ERROR_UNSPECIFIED": "Vennligst sjekk loggfilene for meir informasjon.",
|
|
|
|
"NEWSFEED_NO_ITEMS": "Ingen nyhende tilgjengeleg no.",
|
|
"NEWSFEED_ARTICLE_UNAVAILABLE": "Artikkelen kan ikkje visast her.",
|
|
|
|
"UPDATE_NOTIFICATION": "MagicMirror² oppdatering er tilgjengeleg.",
|
|
"UPDATE_NOTIFICATION_MODULE": "Oppdatering tilgjengeleg for modulen {MODULE_NAME}.",
|
|
"UPDATE_INFO_SINGLE": "noverande installasjon er {COMMIT_COUNT} commit bak {BRANCH_NAME} greinen.",
|
|
"UPDATE_INFO_MULTIPLE": "noverande installasjon er {COMMIT_COUNT} commits bak {BRANCH_NAME} greinen.",
|
|
"UPDATE_NOTIFICATION_DONE": "Oppdateringa av modulen {MODULE_NAME} er fullført.",
|
|
"UPDATE_NOTIFICATION_ERROR": "Det oppstod ein feil under oppdateringa av modulen {MODULE_NAME}.",
|
|
"UPDATE_NOTIFICATION_NEED-RESTART": "Det er nødvendig med ein omstart av MagicMirror."
|
|
}
|