Files
Karsten Hassel d05ea751d9 Release 2.35.0 (#4072)
## Release Notes
Thanks to: @angeldeejay, @in-voker, @JHWelch, @khassel,
@KristjanESPERANTO, @rejas, @sdetweil
> ⚠️ This release needs nodejs version >=22.21.1 <23 || >=24 (no change
to previous release)

[Compare to previous Release
v2.34.0](https://github.com/MagicMirrorOrg/MagicMirror/compare/v2.34.0...v2.25.0)

> ⚠️ We introduced some internal changes with this release, please read
[this forum
post](https://forum.magicmirror.builders/topic/20138/upcoming-release-april-1-2026-breaking-changes-some-operational-changes)
before upgrading!

### [core]
- Prepare Release 2.35.0 (#4071)
- docs: add security policy and vulnerability reporting guidelines
(#4069)
- refactor: simplify internal `require()` calls (#4056)
- allow environment variables in cors urls (#4033)
- fix cors proxy getting binary data (e.g. png, webp) (#4030)
- fix: correct secret redaction and optimize loadConfig (#4031)
- change loading config.js, allow variables in config.js and try to
protect sensitive data (#4029)
- remove kioskmode (#4027)
- Add dark theme logo (#4026)
- move custom.css from css to config (#4020)
- move default modules from /modules/default to /defaultmodules (#4019)
- update node versions in workflows (#4018)
- [core] refactor: extract and centralize HTTP fetcher (#4016)
- fix systeminformation not displaying electron version (#4012)
- Update node-ical and support it's rrule-temporal changes (#4010)
- Change default start scripts from X11 to Wayland (#4011)
- refactor: unify favicon for index.html and Electron (#4006)
- [core] run systeminformation in subprocess so the info is always
displayed (#4002)
- set next release dev number (#4000)

### [dependencies]
- update dependencies (#4068)
- update dependencies incl. electron to v41 (#4058)
- chore: upgrade ESLint to v10 and fix newly surfaced issues (#4057)
- chore: update ESLint and plugins, simplify config, apply new rules
(#4052)
- chore: update dependencies + add exports, files, and sideEffects
fields to package.json (#4040)
- [core] refactor: enable ESLint rule require-await and handle detected
issues (#4038)
- Update node-ical and other deps (#4025)
- chore: update dependencies (#4021)
- chore(eslint): migrate from eslint-plugin-vitest to
@vitest/eslint-plugin and run rules only on test files (#4014)
- Update deps as requested by dependabot (#4008)
- update Collaboration.md and dependencies (#4001)

### [logging]
- refactor: further logger clean-up (#4050)
- Fix Node.js v25 logging prefix and modernize logger (#4049)

### [modules/calendar]
- fix(calendar): make showEnd behavior more consistent across time
formats (#4059)
- test(calendar): fix hardcoded date in event shape test (#4055)
- [calendar] refactor: delegate event expansion to node-ical's
expandRecurringEvent (#4047)
- calendar.js: remove useless hasCalendarURL function (#4028)
- fix(calendar): update to node-ical 0.23.1 and fix full-day recurrence
lookup (#4013)
- fix(calendar): correct day-of-week for full-day recurring events
across all timezones (#4004)

### [modules/newsfeed]
- fix(newsfeed): fix full article view and add framing check (#4039)
- [newsfeed] refactor: migrate to centralized HTTPFetcher (#4023)

### [modules/weather]
- fix(weather): fix openmeteo forecast stuck in the past (#4064)
- fix(weather): fix weathergov forecast day labels off by one (#4065)
- weather: fixes for templates (#4054)
- weather: add possibility to override njk's and css (#4051)
- Use getDateString in openmeteo (#4046)
- [weather] refactor: migrate to server-side providers with centralized
HTTPFetcher (#4032)
- [weather] feat: add Weather API Provider  (#4036)

### [testing]
- chore: remove obsolete Jest config and unit test global setup (#4044)
- replace template_spec test with config_variables test (#4034)
- refactor(clientonly): modernize code structure and add comprehensive
tests (#4022)
- Switch to undici Agent for HTTPS requests (#4015)
- chore: migrate CI workflows to ubuntu-slim for faster startup times
(#4007)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com>
Co-authored-by: Bugsounet - Cédric <github@bugsounet.fr>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: sam detweiler <sdetweil@gmail.com>
Co-authored-by: Veeck <github@veeck.de>
Co-authored-by: veeck <gitkraken@veeck.de>
Co-authored-by: Magnus <34011212+MagMar94@users.noreply.github.com>
Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com>
Co-authored-by: DevIncomin <56730075+Developer-Incoming@users.noreply.github.com>
Co-authored-by: Nathan <n8nyoung@gmail.com>
Co-authored-by: mixasgr <mixasgr@users.noreply.github.com>
Co-authored-by: Savvas Adamtziloglou <savvas-gr@greeklug.gr>
Co-authored-by: Konstantinos <geraki@gmail.com>
Co-authored-by: OWL4C <124401812+OWL4C@users.noreply.github.com>
Co-authored-by: BugHaver <43462320+bughaver@users.noreply.github.com>
Co-authored-by: BugHaver <43462320+lsaadeh@users.noreply.github.com>
Co-authored-by: Koen Konst <koenspero@gmail.com>
Co-authored-by: Koen Konst <c.h.konst@avisi.nl>
Co-authored-by: dathbe <github@beffa.us>
Co-authored-by: Marcel <m-idler@users.noreply.github.com>
Co-authored-by: Kevin G. <crazylegstoo@gmail.com>
Co-authored-by: Jboucly <33218155+jboucly@users.noreply.github.com>
Co-authored-by: Jboucly <contact@jboucly.fr>
Co-authored-by: Jarno <54169345+jarnoml@users.noreply.github.com>
Co-authored-by: Jordan Welch <JordanHWelch@gmail.com>
Co-authored-by: Blackspirits <blackspirits@gmail.com>
Co-authored-by: Samed Ozdemir <samed@xsor.io>
Co-authored-by: in-voker <58696565+in-voker@users.noreply.github.com>
Co-authored-by: Andrés Vanegas Jiménez <142350+angeldeejay@users.noreply.github.com>
2026-04-01 12:35:16 +02:00

470 lines
14 KiB
JavaScript

const Log = require("logger");
const { formatTimezoneOffset, getDateString, validateCoordinates } = require("../provider-utils");
const HTTPFetcher = require("#http_fetcher");
/**
* Server-side weather provider for Yr.no (Norwegian Meteorological Institute)
* Terms of service: https://developer.yr.no/doc/TermsOfService/
*
* Note: Minimum update interval is 10 minutes (600000 ms) per API terms
*/
class YrProvider {
constructor (config) {
this.config = {
apiBase: "https://api.met.no/weatherapi",
forecastApiVersion: "2.0",
sunriseApiVersion: "3.0",
altitude: 0,
lat: 0,
lon: 0,
currentForecastHours: 1, // 1, 6 or 12
type: "current",
updateInterval: 10 * 60 * 1000, // 10 minutes minimum
...config
};
// Enforce 10 minute minimum per API terms
if (this.config.updateInterval < 600000) {
Log.warn("[yr] Minimum update interval is 10 minutes (600000 ms). Adjusting configuration.");
this.config.updateInterval = 600000;
}
this.fetcher = null;
this.onDataCallback = null;
this.onErrorCallback = null;
this.locationName = null;
// Cache for sunrise/sunset data
this.stellarData = null;
this.stellarDataDate = null;
// Cache for weather data (If-Modified-Since support)
this.weatherCache = {
data: null,
lastModified: null,
expires: null
};
}
async initialize () {
// Yr.no requires max 4 decimal places
validateCoordinates(this.config, 4);
await this.#fetchStellarData();
this.#initializeFetcher();
}
setCallbacks (onData, onError) {
this.onDataCallback = onData;
this.onErrorCallback = onError;
}
start () {
if (this.fetcher) {
this.fetcher.startPeriodicFetch();
}
}
stop () {
if (this.fetcher) {
this.fetcher.clearTimer();
}
}
async #fetchStellarData () {
const today = getDateString(new Date());
// Check if we already have today's data
if (this.stellarDataDate === today && this.stellarData) {
return;
}
const url = this.#getSunriseUrl();
try {
const controller = new AbortController();
const timeoutId = setTimeout(() => controller.abort(), 10000);
const response = await fetch(url, {
headers: {
"User-Agent": "MagicMirror",
Accept: "application/json"
},
signal: controller.signal
});
clearTimeout(timeoutId);
if (!response.ok) {
Log.warn(`[yr] Could not fetch stellar data: HTTP ${response.status}`);
this.stellarDataDate = today;
} else {
// Parse and store the stellar data
const data = await response.json();
// Transform single-day response into array format expected by #getStellarInfoForDate
if (data && data.properties) {
this.stellarData = [
{
date: data.when.interval[0], // ISO date string
sunrise: data.properties.sunrise,
sunset: data.properties.sunset
}
];
}
this.stellarDataDate = today;
}
} catch (error) {
Log.warn("[yr] Failed to fetch stellar data:", error);
}
}
#initializeFetcher () {
const url = this.#getForecastUrl();
const headers = {
"User-Agent": "MagicMirror",
Accept: "application/json"
};
// Add If-Modified-Since header if we have cached data
if (this.weatherCache.lastModified) {
headers["If-Modified-Since"] = this.weatherCache.lastModified;
}
this.fetcher = new HTTPFetcher(url, {
reloadInterval: this.config.updateInterval,
headers,
logContext: "weatherprovider.yr"
});
this.fetcher.on("response", async (response) => {
try {
// Handle 304 Not Modified - use cached data
if (response.status === 304) {
Log.log("[yr] Data not modified, using cache");
if (this.weatherCache.data) {
this.#handleResponse(this.weatherCache.data, true);
}
return;
}
const data = await response.json();
// Store cache headers
const lastModified = response.headers.get("Last-Modified");
const expires = response.headers.get("Expires");
if (lastModified) {
this.weatherCache.lastModified = lastModified;
}
if (expires) {
this.weatherCache.expires = expires;
}
this.weatherCache.data = data;
// Update headers for next request
if (lastModified && this.fetcher) {
this.fetcher.customHeaders["If-Modified-Since"] = lastModified;
}
this.#handleResponse(data, false);
} catch (error) {
Log.error("[yr] Failed to parse JSON:", error);
if (this.onErrorCallback) {
this.onErrorCallback({
message: "Failed to parse API response",
translationKey: "MODULE_ERROR_UNSPECIFIED"
});
}
}
});
this.fetcher.on("error", (errorInfo) => {
if (this.onErrorCallback) {
this.onErrorCallback(errorInfo);
}
});
}
async #handleResponse (data, fromCache = false) {
try {
if (!data.properties || !data.properties.timeseries) {
throw new Error("Invalid weather data");
}
// Refresh stellar data if needed (new day or using cached weather data)
if (fromCache) {
await this.#fetchStellarData();
}
let weatherData;
switch (this.config.type) {
case "current":
weatherData = this.#generateCurrentWeather(data);
break;
case "forecast":
case "daily":
weatherData = this.#generateForecast(data);
break;
case "hourly":
weatherData = this.#generateHourly(data);
break;
default:
throw new Error(`Unknown weather type: ${this.config.type}`);
}
if (this.onDataCallback) {
this.onDataCallback(weatherData);
}
} catch (error) {
Log.error("[yr] Error processing weather data:", error);
if (this.onErrorCallback) {
this.onErrorCallback({
message: error.message,
translationKey: "MODULE_ERROR_UNSPECIFIED"
});
}
}
}
#generateCurrentWeather (data) {
const now = new Date();
const timeseries = data.properties.timeseries;
// Find closest forecast in the past
let forecast = timeseries[0];
let closestDiff = Math.abs(now - new Date(forecast.time));
for (const entry of timeseries) {
const entryTime = new Date(entry.time);
const diff = now - entryTime;
if (diff > 0 && diff < closestDiff) {
closestDiff = diff;
forecast = entry;
}
}
const forecastXHours = this.#getForecastForXHours(forecast.data);
const stellarInfo = this.#getStellarInfoForDate(new Date(forecast.time));
const current = {};
current.date = new Date(forecast.time);
current.temperature = forecast.data.instant.details.air_temperature;
current.windSpeed = forecast.data.instant.details.wind_speed;
current.windFromDirection = forecast.data.instant.details.wind_from_direction;
current.humidity = forecast.data.instant.details.relative_humidity;
current.weatherType = this.#convertWeatherType(
forecastXHours.summary?.symbol_code,
stellarInfo ? this.#isDayTime(current.date, stellarInfo) : true
);
current.precipitationAmount = forecastXHours.details?.precipitation_amount;
current.precipitationProbability = forecastXHours.details?.probability_of_precipitation;
current.minTemperature = forecastXHours.details?.air_temperature_min;
current.maxTemperature = forecastXHours.details?.air_temperature_max;
if (stellarInfo) {
current.sunrise = new Date(stellarInfo.sunrise.time);
current.sunset = new Date(stellarInfo.sunset.time);
}
return current;
}
#generateForecast (data) {
const timeseries = data.properties.timeseries;
const dailyData = new Map();
// Collect all data points for each day
for (const entry of timeseries) {
const date = new Date(entry.time);
const dateStr = getDateString(date);
if (!dailyData.has(dateStr)) {
dailyData.set(dateStr, {
date: date,
temps: [],
precip: [],
precipProb: [],
symbols: []
});
}
const dayData = dailyData.get(dateStr);
// Collect temperature from instant data
if (entry.data.instant?.details?.air_temperature !== undefined) {
dayData.temps.push(entry.data.instant.details.air_temperature);
}
// Collect data from forecast periods (prefer longer periods to avoid double-counting)
const forecast = entry.data.next_12_hours || entry.data.next_6_hours || entry.data.next_1_hours;
if (forecast) {
if (forecast.details?.precipitation_amount !== undefined) {
dayData.precip.push(forecast.details.precipitation_amount);
}
if (forecast.details?.probability_of_precipitation !== undefined) {
dayData.precipProb.push(forecast.details.probability_of_precipitation);
}
if (forecast.summary?.symbol_code) {
dayData.symbols.push(forecast.summary.symbol_code);
}
}
}
// Convert collected data to forecast objects
const days = [];
for (const [dateStr, data] of dailyData) {
const stellarInfo = this.#getStellarInfoForDate(data.date);
const dayData = {
date: data.date,
minTemperature: data.temps.length > 0 ? Math.min(...data.temps) : null,
maxTemperature: data.temps.length > 0 ? Math.max(...data.temps) : null,
precipitationAmount: data.precip.length > 0 ? Math.max(...data.precip) : null,
precipitationProbability: data.precipProb.length > 0 ? Math.max(...data.precipProb) : null,
weatherType: data.symbols.length > 0 ? this.#convertWeatherType(data.symbols[0], true) : null
};
if (stellarInfo) {
dayData.sunrise = new Date(stellarInfo.sunrise.time);
dayData.sunset = new Date(stellarInfo.sunset.time);
}
days.push(dayData);
}
// Sort by date to ensure correct order
return days.sort((a, b) => a.date - b.date);
}
#generateHourly (data) {
const hours = [];
const timeseries = data.properties.timeseries;
for (const entry of timeseries) {
const forecast1h = entry.data.next_1_hours;
if (!forecast1h) continue;
const date = new Date(entry.time);
const stellarInfo = this.#getStellarInfoForDate(date);
const hourly = {
date: date,
temperature: entry.data.instant.details.air_temperature,
windSpeed: entry.data.instant.details.wind_speed,
windFromDirection: entry.data.instant.details.wind_from_direction,
humidity: entry.data.instant.details.relative_humidity,
precipitationAmount: forecast1h.details?.precipitation_amount,
precipitationProbability: forecast1h.details?.probability_of_precipitation,
weatherType: this.#convertWeatherType(
forecast1h.summary?.symbol_code,
stellarInfo ? this.#isDayTime(date, stellarInfo) : true
)
};
hours.push(hourly);
}
return hours;
}
#getForecastForXHours (data) {
const hours = this.config.currentForecastHours;
if (hours === 12 && data.next_12_hours) {
return data.next_12_hours;
} else if (hours === 6 && data.next_6_hours) {
return data.next_6_hours;
} else if (data.next_1_hours) {
return data.next_1_hours;
}
return data.next_6_hours || data.next_12_hours || data.next_1_hours || {};
}
#getStellarInfoForDate (date) {
if (!this.stellarData) return null;
const dateStr = getDateString(date);
for (const day of this.stellarData) {
const dayDate = day.date.split("T")[0];
if (dayDate === dateStr) {
return day;
}
}
return null;
}
#isDayTime (date, stellarInfo) {
if (!stellarInfo || !stellarInfo.sunrise || !stellarInfo.sunset) {
return true;
}
const sunrise = new Date(stellarInfo.sunrise.time);
const sunset = new Date(stellarInfo.sunset.time);
return date >= sunrise && date < sunset;
}
#convertWeatherType (symbolCode, isDayTime) {
if (!symbolCode) return null;
// Yr.no uses symbol codes like "clearsky_day", "partlycloudy_night", etc.
const symbol = symbolCode.replace(/_day|_night/g, "");
const mappings = {
clearsky: isDayTime ? "day-sunny" : "night-clear",
fair: isDayTime ? "day-sunny" : "night-clear",
partlycloudy: isDayTime ? "day-cloudy" : "night-cloudy",
cloudy: "cloudy",
fog: "fog",
lightrainshowers: isDayTime ? "day-showers" : "night-showers",
rainshowers: isDayTime ? "showers" : "night-showers",
heavyrainshowers: isDayTime ? "day-rain" : "night-rain",
lightrain: isDayTime ? "day-sprinkle" : "night-sprinkle",
rain: isDayTime ? "rain" : "night-rain",
heavyrain: isDayTime ? "rain" : "night-rain",
lightsleetshowers: isDayTime ? "day-sleet" : "night-sleet",
sleetshowers: isDayTime ? "sleet" : "night-sleet",
heavysleetshowers: isDayTime ? "sleet" : "night-sleet",
lightsleet: isDayTime ? "day-sleet" : "night-sleet",
sleet: "sleet",
heavysleet: "sleet",
lightsnowshowers: isDayTime ? "day-snow" : "night-snow",
snowshowers: isDayTime ? "snow" : "night-snow",
heavysnowshowers: isDayTime ? "snow" : "night-snow",
lightsnow: isDayTime ? "day-snow" : "night-snow",
snow: "snow",
heavysnow: "snow",
lightrainandthunder: isDayTime ? "day-thunderstorm" : "night-thunderstorm",
rainandthunder: isDayTime ? "thunderstorm" : "night-thunderstorm",
heavyrainandthunder: isDayTime ? "thunderstorm" : "night-thunderstorm",
lightsleetandthunder: isDayTime ? "day-sleet-storm" : "night-sleet-storm",
sleetandthunder: isDayTime ? "day-sleet-storm" : "night-sleet-storm",
heavysleetandthunder: isDayTime ? "day-sleet-storm" : "night-sleet-storm",
lightsnowandthunder: isDayTime ? "day-snow-thunderstorm" : "night-snow-thunderstorm",
snowandthunder: isDayTime ? "day-snow-thunderstorm" : "night-snow-thunderstorm",
heavysnowandthunder: isDayTime ? "day-snow-thunderstorm" : "night-snow-thunderstorm"
};
return mappings[symbol] || null;
}
#getForecastUrl () {
const { lat, lon, altitude } = this.config;
return `${this.config.apiBase}/locationforecast/${this.config.forecastApiVersion}/complete?altitude=${altitude}&lat=${lat}&lon=${lon}`;
}
#getSunriseUrl () {
const { lat, lon } = this.config;
const today = getDateString(new Date());
const offset = formatTimezoneOffset(-new Date().getTimezoneOffset());
return `${this.config.apiBase}/sunrise/${this.config.sunriseApiVersion}/sun?lat=${lat}&lon=${lon}&date=${today}&offset=${offset}`;
}
}
module.exports = YrProvider;