mirror of
https://github.com/MichMich/MagicMirror.git
synced 2026-04-25 23:32:10 +00:00
## Release Notes Thanks to: @angeldeejay, @in-voker, @JHWelch, @khassel, @KristjanESPERANTO, @rejas, @sdetweil > ⚠️ This release needs nodejs version >=22.21.1 <23 || >=24 (no change to previous release) [Compare to previous Release v2.34.0](https://github.com/MagicMirrorOrg/MagicMirror/compare/v2.34.0...v2.25.0) > ⚠️ We introduced some internal changes with this release, please read [this forum post](https://forum.magicmirror.builders/topic/20138/upcoming-release-april-1-2026-breaking-changes-some-operational-changes) before upgrading! ### [core] - Prepare Release 2.35.0 (#4071) - docs: add security policy and vulnerability reporting guidelines (#4069) - refactor: simplify internal `require()` calls (#4056) - allow environment variables in cors urls (#4033) - fix cors proxy getting binary data (e.g. png, webp) (#4030) - fix: correct secret redaction and optimize loadConfig (#4031) - change loading config.js, allow variables in config.js and try to protect sensitive data (#4029) - remove kioskmode (#4027) - Add dark theme logo (#4026) - move custom.css from css to config (#4020) - move default modules from /modules/default to /defaultmodules (#4019) - update node versions in workflows (#4018) - [core] refactor: extract and centralize HTTP fetcher (#4016) - fix systeminformation not displaying electron version (#4012) - Update node-ical and support it's rrule-temporal changes (#4010) - Change default start scripts from X11 to Wayland (#4011) - refactor: unify favicon for index.html and Electron (#4006) - [core] run systeminformation in subprocess so the info is always displayed (#4002) - set next release dev number (#4000) ### [dependencies] - update dependencies (#4068) - update dependencies incl. electron to v41 (#4058) - chore: upgrade ESLint to v10 and fix newly surfaced issues (#4057) - chore: update ESLint and plugins, simplify config, apply new rules (#4052) - chore: update dependencies + add exports, files, and sideEffects fields to package.json (#4040) - [core] refactor: enable ESLint rule require-await and handle detected issues (#4038) - Update node-ical and other deps (#4025) - chore: update dependencies (#4021) - chore(eslint): migrate from eslint-plugin-vitest to @vitest/eslint-plugin and run rules only on test files (#4014) - Update deps as requested by dependabot (#4008) - update Collaboration.md and dependencies (#4001) ### [logging] - refactor: further logger clean-up (#4050) - Fix Node.js v25 logging prefix and modernize logger (#4049) ### [modules/calendar] - fix(calendar): make showEnd behavior more consistent across time formats (#4059) - test(calendar): fix hardcoded date in event shape test (#4055) - [calendar] refactor: delegate event expansion to node-ical's expandRecurringEvent (#4047) - calendar.js: remove useless hasCalendarURL function (#4028) - fix(calendar): update to node-ical 0.23.1 and fix full-day recurrence lookup (#4013) - fix(calendar): correct day-of-week for full-day recurring events across all timezones (#4004) ### [modules/newsfeed] - fix(newsfeed): fix full article view and add framing check (#4039) - [newsfeed] refactor: migrate to centralized HTTPFetcher (#4023) ### [modules/weather] - fix(weather): fix openmeteo forecast stuck in the past (#4064) - fix(weather): fix weathergov forecast day labels off by one (#4065) - weather: fixes for templates (#4054) - weather: add possibility to override njk's and css (#4051) - Use getDateString in openmeteo (#4046) - [weather] refactor: migrate to server-side providers with centralized HTTPFetcher (#4032) - [weather] feat: add Weather API Provider (#4036) ### [testing] - chore: remove obsolete Jest config and unit test global setup (#4044) - replace template_spec test with config_variables test (#4034) - refactor(clientonly): modernize code structure and add comprehensive tests (#4022) - Switch to undici Agent for HTTPS requests (#4015) - chore: migrate CI workflows to ubuntu-slim for faster startup times (#4007) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com> Co-authored-by: Bugsounet - Cédric <github@bugsounet.fr> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sam detweiler <sdetweil@gmail.com> Co-authored-by: Veeck <github@veeck.de> Co-authored-by: veeck <gitkraken@veeck.de> Co-authored-by: Magnus <34011212+MagMar94@users.noreply.github.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: DevIncomin <56730075+Developer-Incoming@users.noreply.github.com> Co-authored-by: Nathan <n8nyoung@gmail.com> Co-authored-by: mixasgr <mixasgr@users.noreply.github.com> Co-authored-by: Savvas Adamtziloglou <savvas-gr@greeklug.gr> Co-authored-by: Konstantinos <geraki@gmail.com> Co-authored-by: OWL4C <124401812+OWL4C@users.noreply.github.com> Co-authored-by: BugHaver <43462320+bughaver@users.noreply.github.com> Co-authored-by: BugHaver <43462320+lsaadeh@users.noreply.github.com> Co-authored-by: Koen Konst <koenspero@gmail.com> Co-authored-by: Koen Konst <c.h.konst@avisi.nl> Co-authored-by: dathbe <github@beffa.us> Co-authored-by: Marcel <m-idler@users.noreply.github.com> Co-authored-by: Kevin G. <crazylegstoo@gmail.com> Co-authored-by: Jboucly <33218155+jboucly@users.noreply.github.com> Co-authored-by: Jboucly <contact@jboucly.fr> Co-authored-by: Jarno <54169345+jarnoml@users.noreply.github.com> Co-authored-by: Jordan Welch <JordanHWelch@gmail.com> Co-authored-by: Blackspirits <blackspirits@gmail.com> Co-authored-by: Samed Ozdemir <samed@xsor.io> Co-authored-by: in-voker <58696565+in-voker@users.noreply.github.com> Co-authored-by: Andrés Vanegas Jiménez <142350+angeldeejay@users.noreply.github.com>
235 lines
7.9 KiB
JavaScript
235 lines
7.9 KiB
JavaScript
const fs = require("node:fs");
|
|
const { expect } = require("playwright/test");
|
|
const helpers = require("../helpers/global-setup");
|
|
|
|
const runTests = () => {
|
|
let page;
|
|
|
|
describe("Default configuration", () => {
|
|
beforeAll(async () => {
|
|
await helpers.startApplication("tests/configs/modules/newsfeed/default.js");
|
|
await helpers.getDocument();
|
|
page = helpers.getPage();
|
|
});
|
|
|
|
it("should show the newsfeed title", async () => {
|
|
await expect(page.locator(".newsfeed .newsfeed-source")).toContainText("Rodrigo Ramirez Blog");
|
|
});
|
|
|
|
it("should show the newsfeed article", async () => {
|
|
await expect(page.locator(".newsfeed .newsfeed-title")).toContainText("QPanel");
|
|
});
|
|
|
|
it("should NOT show the newsfeed description", async () => {
|
|
await page.locator(".newsfeed").waitFor({ state: "visible" });
|
|
await expect(page.locator(".newsfeed .newsfeed-desc")).toHaveCount(0);
|
|
});
|
|
});
|
|
|
|
describe("Custom configuration", () => {
|
|
beforeAll(async () => {
|
|
await helpers.startApplication("tests/configs/modules/newsfeed/prohibited_words.js");
|
|
await helpers.getDocument();
|
|
page = helpers.getPage();
|
|
});
|
|
|
|
it("should not show articles with prohibited words", async () => {
|
|
await expect(page.locator(".newsfeed .newsfeed-title")).toContainText("Problema VirtualBox");
|
|
});
|
|
|
|
it("should show the newsfeed description", async () => {
|
|
const locator = page.locator(".newsfeed .newsfeed-desc");
|
|
await expect(locator).toBeVisible();
|
|
const text = await locator.textContent();
|
|
expect(text).toMatch(/\S/);
|
|
});
|
|
});
|
|
|
|
describe("Invalid configuration", () => {
|
|
beforeAll(async () => {
|
|
await helpers.startApplication("tests/configs/modules/newsfeed/incorrect_url.js");
|
|
await helpers.getDocument();
|
|
page = helpers.getPage();
|
|
});
|
|
|
|
it("should show malformed url warning", async () => {
|
|
await expect(page.locator(".newsfeed .small")).toContainText("Error in the Newsfeed module. Malformed url.");
|
|
});
|
|
});
|
|
|
|
describe("Ignore items", () => {
|
|
beforeAll(async () => {
|
|
await helpers.startApplication("tests/configs/modules/newsfeed/ignore_items.js");
|
|
await helpers.getDocument();
|
|
page = helpers.getPage();
|
|
});
|
|
|
|
it("should show empty items info message", async () => {
|
|
await expect(page.locator(".newsfeed .small")).toContainText("No news at the moment.");
|
|
});
|
|
});
|
|
};
|
|
|
|
describe("Newsfeed module > Notifications", () => {
|
|
let page;
|
|
|
|
afterAll(async () => {
|
|
await helpers.stopApplication();
|
|
});
|
|
|
|
/**
|
|
* Helper: call notificationReceived on the newsfeed module directly.
|
|
* @param {object} p - playwright page
|
|
* @param {string} notification - notification name
|
|
* @param {object} payload - notification payload
|
|
* @returns {Promise<void>} resolves when the notification has been dispatched
|
|
*/
|
|
const notify = (p, notification, payload = {}) => p.evaluate(
|
|
({ n, pl }) => {
|
|
const nf = MM.getModules().find((m) => m.name === "newsfeed");
|
|
nf.notificationReceived(n, pl, nf);
|
|
},
|
|
{ n: notification, pl: payload }
|
|
);
|
|
|
|
beforeAll(async () => {
|
|
await helpers.startApplication("tests/configs/modules/newsfeed/notifications.js");
|
|
await helpers.getDocument();
|
|
page = helpers.getPage();
|
|
await expect(page.locator(".newsfeed .newsfeed-title")).toBeVisible();
|
|
});
|
|
|
|
it("ARTICLE_NEXT should show the next article", async () => {
|
|
const title1 = await page.locator(".newsfeed .newsfeed-title").textContent();
|
|
await notify(page, "ARTICLE_NEXT");
|
|
await expect(page.locator(".newsfeed .newsfeed-title")).not.toContainText(title1.trim());
|
|
});
|
|
|
|
it("ARTICLE_PREVIOUS should return to the previous article", async () => {
|
|
// Start at article 0, go to article 1, then back
|
|
await page.evaluate(() => {
|
|
const nf = MM.getModules().find((m) => m.name === "newsfeed");
|
|
nf.activeItem = 0;
|
|
nf.resetDescrOrFullArticleAndTimer();
|
|
nf.updateDom(0);
|
|
});
|
|
await expect(page.locator(".newsfeed .newsfeed-title")).toContainText("QPanel");
|
|
const title0 = await page.locator(".newsfeed .newsfeed-title").textContent();
|
|
|
|
await notify(page, "ARTICLE_NEXT");
|
|
await expect(page.locator(".newsfeed .newsfeed-title")).not.toContainText(title0.trim());
|
|
|
|
await notify(page, "ARTICLE_PREVIOUS");
|
|
await expect(page.locator(".newsfeed .newsfeed-title")).toContainText(title0.trim());
|
|
});
|
|
|
|
it("ARTICLE_NEXT should wrap around from the last article to the first", async () => {
|
|
// Jump to the last article
|
|
await page.evaluate(() => {
|
|
const nf = MM.getModules().find((m) => m.name === "newsfeed");
|
|
nf.activeItem = nf.newsItems.length - 1;
|
|
nf.resetDescrOrFullArticleAndTimer();
|
|
nf.updateDom(0);
|
|
});
|
|
await expect(page.locator(".newsfeed .newsfeed-title")).toBeVisible();
|
|
const titleLast = await page.locator(".newsfeed .newsfeed-title").textContent();
|
|
|
|
await notify(page, "ARTICLE_NEXT");
|
|
await expect(page.locator(".newsfeed .newsfeed-title")).not.toContainText(titleLast.trim());
|
|
|
|
// activeItem should now be 0
|
|
const activeItem = await page.evaluate(() => MM.getModules().find((m) => m.name === "newsfeed").activeItem);
|
|
expect(activeItem).toBe(0);
|
|
});
|
|
|
|
it("ARTICLE_PREVIOUS should wrap around from the first article to the last", async () => {
|
|
await page.evaluate(() => {
|
|
const nf = MM.getModules().find((m) => m.name === "newsfeed");
|
|
nf.activeItem = 0;
|
|
nf.resetDescrOrFullArticleAndTimer();
|
|
});
|
|
await notify(page, "ARTICLE_PREVIOUS");
|
|
|
|
const activeItem = await page.evaluate(() => {
|
|
const nf = MM.getModules().find((m) => m.name === "newsfeed");
|
|
return { activeItem: nf.activeItem, total: nf.newsItems.length };
|
|
});
|
|
expect(activeItem.activeItem).toBe(activeItem.total - 1);
|
|
});
|
|
|
|
it("ARTICLE_INFO_REQUEST should respond with title, source, date, desc and raw url", async () => {
|
|
await page.evaluate(() => {
|
|
const nf = MM.getModules().find((m) => m.name === "newsfeed");
|
|
nf.activeItem = 0;
|
|
nf.resetDescrOrFullArticleAndTimer();
|
|
});
|
|
|
|
const info = await page.evaluate(() => new Promise((resolve, reject) => {
|
|
const timer = setTimeout(() => reject(new Error("ARTICLE_INFO_RESPONSE timeout")), 3000);
|
|
const origSend = MM.sendNotification.bind(MM);
|
|
MM.sendNotification = function (n, p, s) {
|
|
if (n === "ARTICLE_INFO_RESPONSE") {
|
|
clearTimeout(timer);
|
|
MM.sendNotification = origSend;
|
|
resolve(p);
|
|
}
|
|
return origSend(n, p, s);
|
|
};
|
|
const nf = MM.getModules().find((m) => m.name === "newsfeed");
|
|
nf.notificationReceived("ARTICLE_INFO_REQUEST", {}, nf);
|
|
}));
|
|
|
|
expect(info).toHaveProperty("title");
|
|
expect(info).toHaveProperty("source");
|
|
expect(info).toHaveProperty("date");
|
|
expect(info).toHaveProperty("desc");
|
|
expect(info).toHaveProperty("url");
|
|
expect(info.title).toBe("QPanel 0.13.0");
|
|
expect(info.source).toBe("Rodrigo Ramirez Blog");
|
|
// URL must be the raw article URL, not a CORS proxy URL
|
|
expect(info.url).toMatch(/^https?:\/\//);
|
|
expect(info.url).not.toContain("localhost");
|
|
});
|
|
|
|
it("ARTICLE_LESS_DETAILS should reset the full article view", async () => {
|
|
// Simulate full article view being active
|
|
await page.evaluate(() => {
|
|
const nf = MM.getModules().find((m) => m.name === "newsfeed");
|
|
nf.config.showFullArticle = true;
|
|
nf.articleFrameCheckPending = false;
|
|
nf.articleUnavailable = false;
|
|
});
|
|
|
|
await notify(page, "ARTICLE_LESS_DETAILS");
|
|
|
|
const state = await page.evaluate(() => {
|
|
const nf = MM.getModules().find((m) => m.name === "newsfeed");
|
|
return { showFullArticle: nf.config.showFullArticle };
|
|
});
|
|
expect(state.showFullArticle).toBe(false);
|
|
// Normal newsfeed title should be visible again
|
|
await expect(page.locator(".newsfeed .newsfeed-title")).toBeVisible();
|
|
});
|
|
});
|
|
|
|
describe("Newsfeed module", () => {
|
|
afterAll(async () => {
|
|
await helpers.stopApplication();
|
|
});
|
|
|
|
runTests();
|
|
});
|
|
|
|
describe("Newsfeed module located in config directory", () => {
|
|
beforeAll(() => {
|
|
fs.cpSync(`${global.root_path}/${global.defaultModulesDir}/newsfeed`, `${global.root_path}/config/newsfeed`, { recursive: true });
|
|
process.env.MM_MODULES_DIR = "config";
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await helpers.stopApplication();
|
|
});
|
|
|
|
runTests();
|
|
});
|