MagicMirror

mirror of https://github.com/MichMich/MagicMirror.git synced 2026-06-03 09:51:14 +00:00

Files

Kristjan ESPERANTO 13d51cfce9 CodeQL cleanup for alerts #18 , #19 , #20 (#4153 )

Small cleanup PR to close three CodeQL alerts, without changing app
behavior.

-
[#18](https://github.com/MagicMirrorOrg/MagicMirror/security/code-scanning/18)
in `js/loader.js`
-
[#19](https://github.com/MagicMirrorOrg/MagicMirror/security/code-scanning/19)
in `js/socketclient.js`
-
[#20](https://github.com/MagicMirrorOrg/MagicMirror/security/code-scanning/20)
in `tests/electron/modules/calendar_spec.js`

For `Loader` and `MMSocket`, make the global export explicit via
`globalThis` (instead of suppressing `no-unused-vars`).
For calendar tests, remove the unused debug helper `logAllText`.
Also includes a tiny e2e cleanup: `MM_PORT` is cleared in `afterAll`.

Outcome: Three open CodeQL alerts are addressed with small, low-risk
changes. The global intent for `Loader` and `MMSocket` is explicit, dead
test helper code is removed, and e2e test state is cleaned up more
reliably between runs.

With this, all current [code scanning
issues](https://github.com/MagicMirrorOrg/MagicMirror/security/code-scanning)
should be resolved in the develop branch 🎈

2026-05-12 23:32:16 +02:00

alias-resolver.js

chore: update ESLint and plugins, simplify config, apply new rules (#4052 )

2026-03-07 08:34:28 -07:00

animateCSS.js

refactor: enable ESLint rule "no-unused-vars" and handle related issues (#4080 )

2026-04-02 08:56:27 +02:00

app.js

fix(systeminformation): output right 'used node' version (from parent process) (#4141 )

2026-05-06 19:10:57 +02:00

check_config.js

change loading config.js, allow variables in config.js and try to protect sensitive data (#4029 )