mirror of
https://github.com/MichMich/MagicMirror.git
synced 2026-04-23 14:27:01 +00:00
On Node.js v25, the log prefix in the terminal stopped working - instead of seeing something like: ``` [2026-03-05 23:00:00.000] [LOG] [app] Starting MagicMirror: v2.35.0 ``` the output was: ``` [2026-03-05 23:00:00.000] :pre() Starting MagicMirror: v2.35.0 ``` Reported in #4048. ## Why did it break? The logger used the `console-stamp` package to format log output. One part of that formatting used `styleText("grey", ...)` to color the caller prefix gray. Node.js v25 dropped `"grey"` as a valid color name (only `"gray"` with an "a" is accepted now). This caused `styleText` to throw an error internally - and `console-stamp` silently swallowed that error and fell back to returning its raw `:pre()` format string as the prefix. Not ideal. ## What's in this PR? **1. The actual fix** - `"grey"` → `"gray"`. **2. Cleaner stack trace approach** - the previous code set `Error.prepareStackTrace` *after* creating the `Error`, which is fragile and was starting to behave differently across Node versions. Replaced with straightforward string parsing of `new Error().stack`. **3. Removed the `console-stamp` dependency** - all formatting is now done with plain Node.js built-ins (`node:util` `styleText`). Same visual result, no external dependency. **4. Simplified the module wrapper** - the logger was wrapped in a UMD pattern, which is meant for environments like AMD/RequireJS. MagicMirror only runs in two places: Node.js and the browser. Replaced with a simple check (`typeof module !== "undefined"`), which is much easier to follow.
116 lines
4.0 KiB
JavaScript
116 lines
4.0 KiB
JavaScript
// Logger for MagicMirror² — works both in Node.js (CommonJS) and the browser (global).
|
|
(function () {
|
|
if (typeof module !== "undefined") {
|
|
if (process.env.mmTestMode !== "true") {
|
|
const { styleText } = require("node:util");
|
|
|
|
const LABEL_COLORS = { error: "red", warn: "yellow", debug: "bgBlue", info: "blue" };
|
|
const MSG_COLORS = { error: "red", warn: "yellow", info: "blue" };
|
|
|
|
const formatTimestamp = () => {
|
|
const d = new Date();
|
|
const pad2 = (n) => String(n).padStart(2, "0");
|
|
const pad3 = (n) => String(n).padStart(3, "0");
|
|
const date = `${d.getFullYear()}-${pad2(d.getMonth() + 1)}-${pad2(d.getDate())}`;
|
|
const time = `${pad2(d.getHours())}:${pad2(d.getMinutes())}:${pad2(d.getSeconds())}.${pad3(d.getMilliseconds())}`;
|
|
return `[${date} ${time}]`;
|
|
};
|
|
|
|
const getCallerPrefix = () => {
|
|
try {
|
|
const lines = new Error().stack.split("\n");
|
|
for (const line of lines) {
|
|
if (line.includes("node:") || line.includes("js/logger.js") || line.includes("node_modules")) continue;
|
|
const match = line.match(/\((.+?\.js):\d+:\d+\)/) || line.match(/at\s+(.+?\.js):\d+:\d+/);
|
|
if (match) {
|
|
const file = match[1];
|
|
const baseName = file.replace(/.*\/(.*)\.js/, "$1");
|
|
const parentDir = file.replace(/.*\/(.*)\/.*\.js/, "$1");
|
|
return styleText("gray", parentDir === "js" ? `[${baseName}]` : `[${parentDir}]`);
|
|
}
|
|
}
|
|
} catch (err) { /* ignore */ }
|
|
return styleText("gray", "[unknown]");
|
|
};
|
|
|
|
// Patch console methods to prepend timestamp, level label, and caller prefix.
|
|
for (const method of ["debug", "log", "info", "warn", "error"]) {
|
|
const original = console[method].bind(console);
|
|
const labelRaw = `[${method.toUpperCase()}]`.padEnd(7);
|
|
const label = LABEL_COLORS[method] ? styleText(LABEL_COLORS[method], labelRaw) : labelRaw;
|
|
console[method] = (...args) => {
|
|
const prefix = `${formatTimestamp()} ${label} ${getCallerPrefix()}`;
|
|
const msgColor = MSG_COLORS[method];
|
|
if (msgColor && args.length > 0 && typeof args[0] === "string") {
|
|
original(prefix, styleText(msgColor, args[0]), ...args.slice(1));
|
|
} else {
|
|
original(prefix, ...args);
|
|
}
|
|
};
|
|
}
|
|
}
|
|
// Node, CommonJS
|
|
module.exports = makeLogger();
|
|
} else {
|
|
// Browser globals
|
|
window.Log = makeLogger();
|
|
}
|
|
|
|
/**
|
|
* Creates the logger object. Logging is disabled when running in test mode
|
|
* (Node.js) or inside jsdom (browser).
|
|
* @returns {object} The logger object with log level methods.
|
|
*/
|
|
function makeLogger () {
|
|
const enableLog = typeof module !== "undefined"
|
|
? process.env.mmTestMode !== "true"
|
|
: typeof window === "object" && window.name !== "jsdom";
|
|
|
|
let logLevel;
|
|
|
|
if (enableLog) {
|
|
logLevel = {
|
|
debug: Function.prototype.bind.call(console.debug, console),
|
|
log: Function.prototype.bind.call(console.log, console),
|
|
info: Function.prototype.bind.call(console.info, console),
|
|
warn: Function.prototype.bind.call(console.warn, console),
|
|
error: Function.prototype.bind.call(console.error, console),
|
|
group: Function.prototype.bind.call(console.group, console),
|
|
groupCollapsed: Function.prototype.bind.call(console.groupCollapsed, console),
|
|
groupEnd: Function.prototype.bind.call(console.groupEnd, console),
|
|
time: Function.prototype.bind.call(console.time, console),
|
|
timeEnd: Function.prototype.bind.call(console.timeEnd, console),
|
|
timeStamp: console.timeStamp ? Function.prototype.bind.call(console.timeStamp, console) : function () {}
|
|
};
|
|
|
|
logLevel.setLogLevel = function (newLevel) {
|
|
if (newLevel) {
|
|
Object.keys(logLevel).forEach(function (key) {
|
|
if (!newLevel.includes(key.toLocaleUpperCase())) {
|
|
logLevel[key] = function () {};
|
|
}
|
|
});
|
|
}
|
|
};
|
|
} else {
|
|
logLevel = {
|
|
debug () {},
|
|
log () {},
|
|
info () {},
|
|
warn () {},
|
|
error () {},
|
|
group () {},
|
|
groupCollapsed () {},
|
|
groupEnd () {},
|
|
time () {},
|
|
timeEnd () {},
|
|
timeStamp () {}
|
|
};
|
|
|
|
logLevel.setLogLevel = function () {};
|
|
}
|
|
|
|
return logLevel;
|
|
}
|
|
}());
|