MagicMirror/.github/PULL_REQUEST_TEMPLATE.md at 79ea2633a7baeadfb4d8d5ca970983daa55ead60

mirror of https://github.com/MichMich/MagicMirror.git synced 2026-06-04 02:10:43 +00:00

Files

Kristjan ESPERANTO 2850e14172 Unify linting: replace Stylelint and markdownlint with ESLint (#4148 )

We were running three separate lint tools (ESLint, Stylelint,
markdownlint-cli2) and a separate Prettier step. This PR consolidates
everything: `@eslint/css` and `@eslint/markdown` bring CSS and Markdown
linting into ESLint, so one tool now covers JS, CSS, and Markdown. The
Prettier step got merged into the lint scripts too, so there's now just
`test:lint` to check things and `lint:fix` to fix them.

Outcome: fewer tools to maintain, simpler/fewer scripts, fewer config
files.

As a side effect, the dependabot alerts
https://github.com/MagicMirrorOrg/MagicMirror/security/dependabot/140
and
https://github.com/MagicMirrorOrg/MagicMirror/security/dependabot/141
are resolved, as we no longer use the vulnerable `fast-uri` package
(which was a dependency of `stylelint`).

2026-05-09 12:01:18 +02:00

936 B

Raw Blame History

Hello and thank you for wanting to contribute to the MagicMirror² project!

Please make sure that you have followed these 3 rules before submitting your Pull Request:

Base your pull requests against the develop branch.

Include these infos in the description:

Does the pull request solve a related issue?

If so, can you reference the issue like this Fixes #<issue_number>?

What does the pull request accomplish? Use a list if needed.

If it includes major visual changes please add screenshots.

Please run node --run lint:fix before submitting so that style issues are fixed.

Note: Sometimes the development moves very fast. It is highly recommended that you update your branch of develop before creating a pull request to send us your changes. This makes everyone's lives easier (including yours) and helps us out on the development team.

Thanks again and have a nice day!

936 B Raw Blame History

936 B

Raw Blame History