mirror of
https://github.com/MichMich/MagicMirror.git
synced 2026-04-29 01:03:11 +00:00
5c1cc476f3
This migrates the Newsfeed module to use the centralized HTTPFetcher class (introduced in #4016), following the same pattern as the Calendar module. This continues the refactoring effort to centralize HTTP error handling across all modules. ## Changes **NewsfeedFetcher:** - Refactored from function constructor to ES6 class (like the calendar module in #3959) - Replaced manual fetch() + timer handling with HTTPFetcher composition - Uses structured error objects with translation keys - Inherits smart retry strategies (401/403, 429, 5xx backoff) - Inherits timeout handling (30s) and AbortController **node_helper.js:** - Updated error handler to use `errorInfo.translationKey` - Simplified property access (`fetcher.url`, `fetcher.items`) **Cleanup:** - Removed `js/module_functions.js` (`scheduleTimer` no longer needed) - Removed `#module_functions` import from package.json ## Related Part of the HTTPFetcher migration effort started in #4016. Next candidate: Weather module (client-side → server-side migration).
78 lines
2.2 KiB
JavaScript
78 lines
2.2 KiB
JavaScript
const NodeHelper = require("node_helper");
|
|
const Log = require("logger");
|
|
const NewsfeedFetcher = require("./newsfeedfetcher");
|
|
|
|
module.exports = NodeHelper.create({
|
|
// Override start method.
|
|
start () {
|
|
Log.log(`Starting node helper for: ${this.name}`);
|
|
this.fetchers = [];
|
|
},
|
|
|
|
// Override socketNotificationReceived received.
|
|
socketNotificationReceived (notification, payload) {
|
|
if (notification === "ADD_FEED") {
|
|
this.createFetcher(payload.feed, payload.config);
|
|
}
|
|
},
|
|
|
|
/**
|
|
* Creates a fetcher for a new feed if it doesn't exist yet.
|
|
* Otherwise it reuses the existing one.
|
|
* @param {object} feed The feed object
|
|
* @param {object} config The configuration object
|
|
*/
|
|
createFetcher (feed, config) {
|
|
const url = feed.url || "";
|
|
const encoding = feed.encoding || "UTF-8";
|
|
const reloadInterval = feed.reloadInterval || config.reloadInterval || 5 * 60 * 1000;
|
|
const useCorsProxy = feed.useCorsProxy ?? true;
|
|
|
|
try {
|
|
new URL(url);
|
|
} catch (error) {
|
|
Log.error("Error: Malformed newsfeed url: ", url, error);
|
|
this.sendSocketNotification("NEWSFEED_ERROR", { error_type: "MODULE_ERROR_MALFORMED_URL" });
|
|
return;
|
|
}
|
|
|
|
let fetcher;
|
|
if (typeof this.fetchers[url] === "undefined") {
|
|
Log.log(`Create new newsfetcher for url: ${url} - Interval: ${reloadInterval}`);
|
|
fetcher = new NewsfeedFetcher(url, reloadInterval, encoding, config.logFeedWarnings, useCorsProxy);
|
|
|
|
fetcher.onReceive(() => {
|
|
this.broadcastFeeds();
|
|
});
|
|
|
|
fetcher.onError((fetcher, errorInfo) => {
|
|
Log.error("Error: Could not fetch newsfeed: ", fetcher.url, errorInfo.message || errorInfo);
|
|
this.sendSocketNotification("NEWSFEED_ERROR", {
|
|
error_type: errorInfo.translationKey
|
|
});
|
|
});
|
|
|
|
this.fetchers[url] = fetcher;
|
|
} else {
|
|
Log.log(`Use existing newsfetcher for url: ${url}`);
|
|
fetcher = this.fetchers[url];
|
|
fetcher.setReloadInterval(reloadInterval);
|
|
fetcher.broadcastItems();
|
|
}
|
|
|
|
fetcher.startFetch();
|
|
},
|
|
|
|
/**
|
|
* Creates an object with all feed items of the different registered feeds,
|
|
* and broadcasts these using sendSocketNotification.
|
|
*/
|
|
broadcastFeeds () {
|
|
const feeds = {};
|
|
for (const url in this.fetchers) {
|
|
feeds[url] = this.fetchers[url].items;
|
|
}
|
|
this.sendSocketNotification("NEWS_ITEMS", feeds);
|
|
}
|
|
});
|