mirror of
https://github.com/MichMich/MagicMirror.git
synced 2025-11-30 18:11:44 +00:00
The envcanada provider in the default Weather module was fixed in MM v2.33.0 to use a new URL hierarchy that Environment Canada implemented to access weather data for Canadian locations. Subsequent to this provider update, Environment Canada has implemented one further update to their URL hierarchy to make it easier to access 'current day' weather data. Tis change was raised in Issue #3912 as a Bug, which is addressed in this Provider update. There are no Magic Mirror UI changes from this update. The fix is to add one additional element to the URL used to access Environment Canada XML-based weather data. This PR is also taking the opportunity to make one further small fix to how windspeed is handled in this Provider. Most of the time, Env Canada provides an expected numeric value. There are instances, however, where the value provided is 'calm', which the Weather module does not expect. The Provider code has been changed to detect a 'calm' windspeed and convert it to '0' for the purposes of the Weather module. Note that in the world of weather/climate analysis, a windspeed of 'calm' is used as a synonym for a windspeed of 0. Note that a ChangeLog entry is included in this PR.