mirror of
https://github.com/MichMich/MagicMirror.git
synced 2025-12-02 11:01:52 +00:00
f29f424a62
### 1. Replace `XMLHttpRequest` with the modern `fetch` API for loading translation files #### Changes - **translator.js**: Use `fetch` with `async/await` instead of XHR callbacks - **loader.js**: Align URL handling and add error handling (follow-up to fetch migration) - **Tests**: Update infrastructure for `fetch` compatibility #### Benefits - Modern standard API - Cleaner, more readable code - Better error handling and fallback mechanisms ### 2. Migrate e2e tests to Playwright This wasn't originally planned for this PR, but is related. While investigating suspicious log entries which surfaced after the fetch migration I kept running into JSDOM’s limitations. That pushed me to migrate the E2E suite to Playwright instead. #### Changes - switch e2e harness to Playwright (`tests/e2e/helpers/global-setup.js`) - rewrite specs to use Playwright locators + shared `expectTextContent` - install Chromium via `npx playwright install --with-deps` in CI #### Benefits - much closer to real browser behaviour - and no more fighting JSDOM’s quirks
54 lines
1.7 KiB
JavaScript
54 lines
1.7 KiB
JavaScript
const { expect } = require("playwright/test");
|
|
const helpers = require("../helpers/global-setup");
|
|
|
|
describe("Alert module", () => {
|
|
let page;
|
|
|
|
afterAll(async () => {
|
|
await helpers.stopApplication();
|
|
});
|
|
|
|
describe("with welcome_message set to false", () => {
|
|
beforeAll(async () => {
|
|
await helpers.startApplication("tests/configs/modules/alert/welcome_false.js");
|
|
await helpers.getDocument();
|
|
page = helpers.getPage();
|
|
});
|
|
|
|
it("should not show any welcome message", async () => {
|
|
// Wait a bit to ensure no message appears
|
|
await new Promise((resolve) => setTimeout(resolve, 1000));
|
|
|
|
// Check that no alert/notification elements are present
|
|
await expect(page.locator(".ns-box .ns-box-inner .light.bright.small")).toHaveCount(0);
|
|
});
|
|
});
|
|
|
|
describe("with welcome_message set to true", () => {
|
|
beforeAll(async () => {
|
|
await helpers.startApplication("tests/configs/modules/alert/welcome_true.js");
|
|
await helpers.getDocument();
|
|
page = helpers.getPage();
|
|
|
|
// Wait for the application to initialize
|
|
await new Promise((resolve) => setTimeout(resolve, 1000));
|
|
});
|
|
|
|
it("should show the translated welcome message", async () => {
|
|
await expect(page.locator(".ns-box .ns-box-inner .light.bright.small")).toContainText("Welcome, start was successful!");
|
|
});
|
|
});
|
|
|
|
describe("with welcome_message set to custom string", () => {
|
|
beforeAll(async () => {
|
|
await helpers.startApplication("tests/configs/modules/alert/welcome_string.js");
|
|
await helpers.getDocument();
|
|
page = helpers.getPage();
|
|
});
|
|
|
|
it("should show the custom welcome message", async () => {
|
|
await expect(page.locator(".ns-box .ns-box-inner .light.bright.small")).toContainText("Custom welcome message!");
|
|
});
|
|
});
|
|
});
|