kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-12-01 02:31:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

res_fax.c: lower FAXOPT read warning to debug level

Browse Source 
Reading ${FAXOPT()} before a fax session is common in dialplans to check fax state.
Currently this logs an error even when no fax datastore exists, creating excessive noise.
Change these messages to ast_debug(3, …) so they appear only with debug enabled.

Resolves: #1509
This commit is contained in:
phoneben
2025-10-03 00:25:01 +03:00
parent ddc38c6e48
commit 16bdaaa523
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
res/res_fax.c
View File

@@ -4631,7 +4631,7 @@ static int acf_faxopt_read(struct ast_channel *chan, const char *cmd, char *data
char *filenames; char *filenames;
if (!details) { if (!details) {
ast_log(LOG_ERROR, "channel '%s' can't read FAXOPT(%s) because it has never been written.\n", ast_channel_name(chan), data); ast_debug(3, "channel '%s' can't read FAXOPT(%s) because it has never been written.\n", ast_channel_name(chan), data);
return -1; return -1;
} }
if (!strcasecmp(data, "ecm")) { if (!strcasecmp(data, "ecm")) {
@@ -4645,14 +4645,14 @@ static int acf_faxopt_read(struct ast_channel *chan, const char *cmd, char *data
ast_copy_string(buf, details->error, len); ast_copy_string(buf, details->error, len);
} else if (!strcasecmp(data, "filename")) { } else if (!strcasecmp(data, "filename")) {
if (AST_LIST_EMPTY(&details->documents)) { if (AST_LIST_EMPTY(&details->documents)) {
ast_log(LOG_ERROR, "channel '%s' can't read FAXOPT(%s) because it has never been written.\n", ast_channel_name(chan), data); ast_debug(3, "channel '%s' can't read FAXOPT(%s) because it has never been written.\n", ast_channel_name(chan), data);
res = -1; res = -1;
} else { } else {
ast_copy_string(buf, AST_LIST_FIRST(&details->documents)->filename, len); ast_copy_string(buf, AST_LIST_FIRST(&details->documents)->filename, len);
} }
} else if (!strcasecmp(data, "filenames")) { } else if (!strcasecmp(data, "filenames")) {
if (AST_LIST_EMPTY(&details->documents)) { if (AST_LIST_EMPTY(&details->documents)) {
ast_log(LOG_ERROR, "channel '%s' can't read FAXOPT(%s) because it has never been written.\n", ast_channel_name(chan), data); ast_debug(3, "channel '%s' can't read FAXOPT(%s) because it has never been written.\n", ast_channel_name(chan), data);
res = -1; res = -1;
} else if ((filenames = generate_filenames_string(details, "", ","))) { } else if ((filenames = generate_filenames_string(details, "", ","))) {
ast_copy_string(buf, filenames, len); ast_copy_string(buf, filenames, len);