From 23d1c9186d8ce18a37c856a5242a4a525c500f97 Mon Sep 17 00:00:00 2001 From: Mark Michelson Date: Wed, 17 Feb 2010 22:44:53 +0000 Subject: [PATCH] Fix a couple of bugs in test tab completion. 1. Add missing unlock of lists. 2. Swap order of arguments to test_cat_cmp in complete_test_name. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247381 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- main/test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/main/test.c b/main/test.c index 41e00a89f1..082af29018 100644 --- a/main/test.c +++ b/main/test.c @@ -579,6 +579,7 @@ static char *complete_test_category(const char *line, const char *word, int pos, break; } } + AST_LIST_UNLOCK(&tests); return ret; } @@ -591,11 +592,12 @@ static char *complete_test_name(const char *line, const char *word, int pos, int AST_LIST_LOCK(&tests); AST_LIST_TRAVERSE(&tests, test, entry) { - if (!test_cat_cmp(category, test->info.category) && (!strncasecmp(word, test->info.name, wordlen) && ++which > state)) { + if (!test_cat_cmp(test->info.category, category) && (!strncasecmp(word, test->info.name, wordlen) && ++which > state)) { ret = ast_strdup(test->info.name); break; } } + AST_LIST_UNLOCK(&tests); return ret; }