kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2026-06-09 03:45:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

res_pjsip_messaging: Update To URI only if it is a SIP(S) URI

Browse Source 
When a message is sent via ARI, the ARI endpoint only provides a To
field which is also used as destination field. This means that the To
field might not necessarily contain a SIP URI but might instead specify
an Asterisk endpoint (in MessageDestinationInfo format). This led to
many warnings even though the message was sent correctly.

The fix is to only call `ast_sip_update_to_uri` if the To field starts
with the sip: or sips: scheme.

Resolves: #1357
This commit is contained in:
Maximilian Fridrich
2026-05-07 08:53:28 +02:00
parent 08a5097569
commit 6ed90d4180
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
res/res_pjsip_messaging.c
View File

@@ -959,7 +959,15 @@ static int msg_send(void *data)
if (ast_begins_with(msg_to, "pjsip:")) {
msg_to += 6;
}
ast_sip_update_to_uri(tdata, msg_to);
/*
* Only attempt to update the To URI if it's actually a SIP/SIPS URI.
* When sending via ARI, the To field is also used as destination
* (MessageDestinationInfo) and therefore might not contain a SIP URI.
* ast_sip_create_request still sets the correct To header.
*/
if (ast_begins_with(msg_to, "sip:") || ast_begins_with(msg_to, "sips:")) {
ast_sip_update_to_uri(tdata, msg_to);
}
} else {
/*
* If there was no To in the message, it's still possible