kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2026-06-09 03:45:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

res_stir_shaken: avoid direct ASN1_STRING accesses

Browse Source 
https://github.com/openssl/openssl/issues/29117

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Resolves: #1952
This commit is contained in:
Bernd Kuhls
2026-05-02 14:20:05 +02:00
parent 9d608b50c1
commit ba98ceae97
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
res/res_stir_shaken/verification.c
View File

@@ -266,10 +266,10 @@ static enum ast_stir_shaken_vs_response_code
LOG_ERROR, "%s: Cert '%s' doesn't have a TNAuthList extension\n",
ctx->tag, ctx->public_url);
}
octet_str_data = tn_exten->data;
octet_str_data = ASN1_STRING_get0_data(tn_exten);
/* The first call to ASN1_get_object should return a SEQUENCE */
ret = ASN1_get_object(&octet_str_data, &xlen, &tag, &xclass, tn_exten->length);
ret = ASN1_get_object(&octet_str_data, &xlen, &tag, &xclass, ASN1_STRING_length(tn_exten));
if (IS_GET_OBJ_ERR(ret)) {
crypto_log_openssl(LOG_ERROR, "%s: Cert '%s' has malformed TNAuthList extension\n",
ctx->tag, ctx->public_url);
@@ -293,7 +293,7 @@ static enum ast_stir_shaken_vs_response_code
* ATIS-1000080 however limits this to only ASN1_TAG_TNAUTH_SPC
*
*/
ret = ASN1_get_object(&octet_str_data, &xlen, &tag, &xclass, tn_exten->length);
ret = ASN1_get_object(&octet_str_data, &xlen, &tag, &xclass, ASN1_STRING_length(tn_exten));
if (IS_GET_OBJ_ERR(ret)) {
crypto_log_openssl(LOG_ERROR, "%s: Cert '%s' has malformed TNAuthList extension\n",
ctx->tag, ctx->public_url);
@@ -307,7 +307,7 @@ static enum ast_stir_shaken_vs_response_code
}
/* The third call to ASN1_get_object should contain the SPC */
ret = ASN1_get_object(&octet_str_data, &xlen, &tag, &xclass, tn_exten->length);
ret = ASN1_get_object(&octet_str_data, &xlen, &tag, &xclass, ASN1_STRING_length(tn_exten));
if (ret != 0) {
SCOPE_EXIT_LOG_RTN_VALUE(AST_STIR_SHAKEN_VS_CERT_NO_SPC_IN_TN_AUTH_EXT,
LOG_ERROR, "%s: Cert '%s' has malformed TNAuthList extension (no SPC)\n",