kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-18 10:44:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

various files - fix some alerts raised by lgtm code analysis

Browse Source 
This patch fixes several issues reported by the lgtm code analysis tool:

https://lgtm.com/projects/g/asterisk/asterisk

Not all reported issues were addressed in this patch. This patch mostly fixes
confirmed reported errors, potential problematic code points, and a few other
"low hanging" warnings or recommendations found in core supported modules.
These include, but are not limited to the following:

* innapropriate stack allocation in loops
* buffer overflows
* variable declaration "hiding" another variable declaration
* comparisons results that are always the same
* ambiguously signed bit-field members
* missing header guards

Change-Id: Id4a881686605d26c94ab5409bc70fcc21efacc25
This commit is contained in:
Kevin Harwell
2019-10-23 12:36:17 -05:00
committed by George Joseph
parent 990a91b44a
commit bdd785d31c
49 changed files with 324 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
formats/format_g726.c
View File

@@ -199,7 +199,7 @@ static off_t g726_tell(struct ast_filestream *fs)
return ftello(fs->f) << 1;
}
static struct ast_format_def f[] = {
static struct ast_format_def f_def[] = {
{
.name = "g726-40",
.exts = "g726-40",
@@ -259,9 +259,9 @@ static int unload_module(void)
{
int i;
for (i = 0; f[i].desc_size ; i++) {
if (ast_format_def_unregister(f[i].name))
ast_log(LOG_WARNING, "Failed to unregister format %s.\n", f[i].name);
for (i = 0; f_def[i].desc_size ; i++) {
if (ast_format_def_unregister(f_def[i].name))
ast_log(LOG_WARNING, "Failed to unregister format %s.\n", f_def[i].name);
}
return(0);
}
@@ -270,10 +270,10 @@ static int load_module(void)
{
int i;
for (i = 0; f[i].desc_size ; i++) {
f[i].format = ast_format_g726;
if (ast_format_def_register(&f[i])) { /* errors are fatal */
ast_log(LOG_WARNING, "Failed to register format %s.\n", f[i].name);
for (i = 0; f_def[i].desc_size ; i++) {
f_def[i].format = ast_format_g726;
if (ast_format_def_register(&f_def[i])) { /* errors are fatal */
ast_log(LOG_WARNING, "Failed to register format %s.\n", f_def[i].name);
unload_module();
return AST_MODULE_LOAD_DECLINE;
}

4
formats/msgsm.h
View File

@@ -1,4 +1,6 @@
/* Conversion routines derived from code by guido@sienanet.it */
#ifndef ASTERISK_MSGSM_H
#define ASTERISK_MSGSM_H
#define GSM_MAGIC 0xD
@@ -687,3 +689,5 @@ static inline void conv65( wav_byte * c, gsm_byte * d){
writeGSM_33(d+33);
}
#endif /* ASTERISK_MSGSM_H */