Commit Graph

674 Commits

Author SHA1 Message Date
Olle Johansson 64b3683dbe Adding a few Todo's to res_jabber so we don't forget.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68030 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 10:00:17 +00:00
Olle Johansson b857aed39e Ok, we found out that this is not about if you have any *active* clients using TLS, but
if you have initialized TLS at all during the lifetime of the module. So if you reload
to disable TLS, it won't help.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68028 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 09:55:13 +00:00
Olle Johansson dd7f6f8e21 If you have a jabber client that uses TLS, refuse unload. Bad fix, but will prevent
crashes while we are trying to find a workaround.

Iksemel development seems to have stalled and we might have to stop using the 
TCP/TLS connections in that library and use our own, which would scale better
from a poll/select perspective I guess. It would also make it easier to migrate
to OpenSSL and stop Asterisk from depending on both OpenSSL and GnuTLS.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68027 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 09:42:26 +00:00
Olle Johansson ff2943dd59 Issue #9738 - Make sure we can unload res_jabber. Patch by phsultan - thanks!
Due to a bug in the iksemel library, this will not work if you are using GTLS
in the connection. That's being investigated. If you figure out a way to handle
that without us having to patch iksemel, let us know in the bug report. Thanks.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67993 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 09:00:44 +00:00
Russell Bryant b310d22e7c Disable reload functionality in res_snmp. It is not possible to initialize the
snmp library more than once without completely unloading the module and loading
it again.
(issue #9571, reported by hristo, additional helpful debug information from festr,
 patch from me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67872 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 22:08:02 +00:00
Joshua Colp ed7775bc53 Make the new "agi debug off" CLI command work. (issue #9890 reported by eliel)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67597 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 12:34:06 +00:00
Joshua Colp 26038a4b77 Returning a value that indicates the parking of a call was a success when it really wasn't (because the parking slot selected was in use) is the wrong thing to do. (issue #9723 reported by mdu113)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67064 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 17:41:59 +00:00
Tilghman Lesher c314f35ac2 Issue 9739 - Malformed jid causes a crash
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67021 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 15:50:16 +00:00
Russell Bryant 19a2be29f3 Change a couple of header files to not use "new", which is a reserved keyword
in C++.  (issue #9830, reported by osk)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66775 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-31 18:41:58 +00:00
Kevin P. Fleming 5f9897ba56 handle the GNUTLS library properly in the configure script and build system
don't build in OSP support unless we have found and are allowed to use SSL support


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66157 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-25 14:28:46 +00:00
Olle Johansson 6cfe6a550e Issue 8409 - phsultan - Fix "login" as component to jabber server.
...and, by accident, fix a bug in chan_sip for stopping a loop on retransmits
   of BYE requests.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@65836 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-24 14:38:30 +00:00
Joshua Colp 0a992b39de res_agi needs to export two symbols (ast_agi_register and ast_agi_unregister) for usage by others. (issue #9755 reported by mnicholson)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@65250 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-20 17:59:58 +00:00
Russell Bryant 69cd2cb213 Properly fix a problem that occurs when you set PARKINGEXTEN to an exten where
a call is already parked.  (issue #9723, patch by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@64426 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-15 19:52:18 +00:00
Russell Bryant 39ebbfe69d When someone requests a specific parking space using the PARKINGEXTEN variable,
ensure that no other caller is already there.
(issue #9723, reported by mdu113, patch by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@64353 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-14 21:16:39 +00:00
Joshua Colp 438335c9a7 Make the PARKINGEXTEN feature of parking actually work. (issue #9708 reported by mdu113)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63872 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-11 15:43:14 +00:00
Russell Bryant 1fb11df91a I mixed up the use of the find_feature() function, so I renamed it
find_dynamic_feature, and changed the code to use the correct lock when
using it.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63448 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-08 16:53:09 +00:00
Russell Bryant fd993ffd7d Use a read/write lock when accessing the built-in features.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63445 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-08 16:30:43 +00:00
Jason Parker 9ad1e5d09c Fix a crash when checking version attribute in an incoming XML caps element.
Issue 9667, patch by phsultan.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63099 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-04 20:03:49 +00:00
Kevin P. Fleming b488e05054 Merged revisions 62841 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r62841 | kpfleming | 2007-05-02 20:23:00 -0400 (Wed, 02 May 2007) | 2 lines

doh... initializing the pointer variable will work just a bit better

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@62842 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-03 00:23:37 +00:00
Kevin P. Fleming ae0f7a3247 Merged revisions 62796 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r62796 | kpfleming | 2007-05-02 19:53:46 -0400 (Wed, 02 May 2007) | 7 lines

increase reliability and efficiency of static Realtime config loading via ODBC:
	don't request fields we aren't going to use
	don't request sorting on fields that are pointless to sort on
	explicitly request the fields we want, because we can't expect the database to always return them in the order they were created
	
(reported by blitzrage in person (!), patch by me)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@62807 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-03 00:02:57 +00:00
Kevin P. Fleming 51d6dd84e6 improve static Realtime config loading from PostgreSQL:
don't request sorting on fields that are pointless to sort on
	use ast_build_string() instead of snprintf()
	don't request the list of fieldnames that resulted from the query when we both knew what they were before we ran the query _AND_ we aren't going to do anything with them anyway

(patch by me, inspired by blitzrage's bug report about res_config_odbc)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@62797 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-02 23:57:23 +00:00
Russell Bryant 6e13855338 Merged revisions 62547 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r62547 | russell | 2007-05-01 16:55:19 -0500 (Tue, 01 May 2007) | 4 lines

Remove an unnecessary check that makes it so if you hang up after doing an
attended transfer before the target extension answers the channel, the transfer
is not successful.  (issue #9338, patch by svanlund)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@62548 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-01 21:57:10 +00:00
Joshua Colp 1c6f5bd851 Don't always say that the channel is being paused if it is actually being unpaused in the Manager ack message. (reported by jsmith in #asterisk-bugs)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61961 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-26 01:48:55 +00:00
Steve Murphy 18ad368048 Finished up a previous fix to overcome a compiler warning; the app NoCDR() has been updated to mark the channel CDR as POST_DISABLED instead of destroying the CDR; this way its flags are propagated thru a bridge and the CDR is actually dropped. The cases where only one channel in a bridge has a CDR was cleaned up.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61136 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-10 05:18:26 +00:00
Kevin P. Fleming bf4969f66e fix up some warnings found using --enable-dev-mode
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61070 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-09 19:55:14 +00:00
Steve Murphy 7d5a79a0b9 This is a big improvement over the current CDR fixes. It may still need refinement, but this won't have as many folks bothered.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@60989 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-09 18:32:07 +00:00
Olle Johansson a1bdbc0289 Add final new line after JabberEvent
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@60984 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-09 18:02:17 +00:00
Joshua Colp f996b1cbc8 Add support for returning different types of results (ie: NBest).
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@60361 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-06 01:14:00 +00:00
Steve Murphy 798039b4d8 several changes via kpflemings review
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59522 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-30 17:51:17 +00:00
Steve Murphy 9c69e34f62 These mods fix CDR issues from 8221, 8593, 8680, 8743, and perhaps others. Mainly with CDRs generated from transfer situations.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59486 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-30 14:11:59 +00:00
Russell Bryant 0cb0e410ba When building a response to a subscription, the "from" must be the full Jabber
ID.  This fixes some problems where jabber users are not able to add their
Asterisk account to their user list, since they are unable to get Asterisk
to approve their subscription.  (issue #8210, reported by caspy, and verified
by bradtem)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59363 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-29 17:43:52 +00:00
Tilghman Lesher fdfe1581e1 Another crash that I thought we had fixed already - Issue 9396
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59289 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-28 03:38:09 +00:00
Joshua Colp 5d7bf5eb71 Merged revisions 59086 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r59086 | file | 2007-03-21 14:03:20 -0400 (Wed, 21 Mar 2007) | 2 lines

Indicate the filename changed when it is changed. (issue #9311 reported by jsmith)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59087 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-21 18:04:58 +00:00
Tilghman Lesher ec21f50132 Fix segfault (Issue 9236)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@58479 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-08 21:33:03 +00:00
Joshua Colp a00f75604b Don't reference a potentially NULL pointer. (issue #9199 reported by klolik)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@57770 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-05 03:35:03 +00:00
Jason Parker e0b88aba12 No need to cast nor free with strdupa (thanks file)
55555!


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@55555 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-20 16:53:45 +00:00
Olle Johansson 920f332399 - Not sending arguments to an application is not "out of memory"
- Making error messages a bit more clear


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@55483 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-19 21:12:55 +00:00
Russell Bryant 2986791f67 Clean up a few coding guidelines issues - spaces to tabs, use sizeof() to pass
the size of a static buffer, add spaces ...


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@54888 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-16 17:40:38 +00:00
Olle Johansson a945ccf652 Merged revisions 54771 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r54771 | oej | 2007-02-16 12:38:03 +0100 (Fri, 16 Feb 2007) | 2 lines

Issue #9069 - If we open with TH we should not close with /TD. (seanbright)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@54772 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-16 11:39:55 +00:00
Kevin P. Fleming 07462b8d1b add some inter-module dependencies
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53780 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-09 23:51:41 +00:00
Tilghman Lesher 27475a306d Text fix for jabber reload command (reported by bkruse via IRC)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53294 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-07 05:24:31 +00:00
Joshua Colp 9b42bff145 Merged revisions 53084 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r53084 | file | 2007-02-01 15:03:10 -0600 (Thu, 01 Feb 2007) | 2 lines

Return previous behavior of having MOH pick up where it was left off. (issue #8672 reported by sinistermidget)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53088 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-01 21:11:28 +00:00
Paul Cadach df64b9a98c Don't play with free()'d pointers
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52808 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-30 08:34:26 +00:00
Steve Murphy be0c0cd6dd this mod from 8593 (dstchannel in cdr is empty when transfer call).
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51716 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-23 20:32:54 +00:00
Joshua Colp 3290b0d37a Merged revisions 51512 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r51512 | file | 2007-01-22 20:41:35 -0500 (Mon, 22 Jan 2007) | 2 lines

Yield before reading from zaptel timing source under Solaris so that other threads get a chance to do things. (issue #7875 reported by bob)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51513 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-23 01:45:04 +00:00
Joshua Colp 2db51f4608 Merged revisions 51145 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r51145 | file | 2007-01-16 12:36:50 -0500 (Tue, 16 Jan 2007) | 2 lines

Return previous behavior. ParkedCalls will be able to do DTMF based transfers again. trunk however will get an option to allow this to be set on/off. (issue #8804 reported by nortex)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51148 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-16 17:39:50 +00:00
Joshua Colp cc242206c6 Only join the snmp thread on an unload if the thread is actually running. (issue #8810 reported by junky)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50674 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-13 03:04:55 +00:00
Jason Parker 9e621e99a5 Save 1 whopping byte of allocated memory!
This looks like it may have been a chicken/egg scenario..

You had to call a cleanup func, because everything was allocated.
Then since you had to call a cleanup func, you were forced to allocate - ie; strdup("").


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49742 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-06 00:24:38 +00:00
Kevin P. Fleming 444adcb477 reduce stack consumption for AMI and AMI/HTTP requests by nearly 20K in most cases
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49676 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-05 22:16:33 +00:00
Kevin P. Fleming 8e900c7db7 use the proper variable type for these unixODBC API calls, eliminating warnings on 64-bit platforms that use the 'new' 64-bit types for ODBC API calls
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48577 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-19 14:57:09 +00:00