Russell Bryant 9bfd82cec2 Merged revisions 88805 via svnmerge from ...

https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r88805 | russell | 2007-11-05 16:07:54 -0600 (Mon, 05 Nov 2007) | 12 lines

After seeing crashes related to channel variables, I went looking around at the
ways that channel variables are handled.  In general, they were not handled in
a thread-safe way.  The channel _must_ be locked when reading or writing from/to
the channel variable list.

What I have done to improve this situation is to make pbx_builtin_setvar_helper()
and friends lock the channel when doing their thing.  Asterisk API calls almost 
all lock the channel for you as necessary, but this family of functions did not.

(closes issue #10923, reported by atis)
(closes issue #11159, reported by 850t)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@88934 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2007-11-06 14:08:54 +00:00

..

db1-ast

clean up assembler and preprocessor files if they are here too

2007-10-29 22:24:44 +00:00

editline

Merged revisions 87567 via svnmerge from

2007-10-30 15:47:19 +00:00

minimime

(closes issue #10692)

2007-09-11 13:10:04 +00:00

stdtime

Merged revisions 85921 via svnmerge from

2007-10-16 19:47:16 +00:00

abstract_jb.c

Do a massive conversion for using the ast_verb() macro

2007-07-26 15:49:18 +00:00

acl.c

Merged revisions 86630 via svnmerge from

2007-10-22 13:36:13 +00:00

adsistub.c

Add a massive set of changes for converting to use the ast_debug() macro.

2007-06-14 19:39:12 +00:00

aescrypt.c

use the OpenSSL AES implementation if it's available (unless configured not to)

2007-05-24 22:07:50 +00:00

aeskey.c

use the OpenSSL AES implementation if it's available (unless configured not to)

2007-05-24 22:07:50 +00:00

aesopt.h

…

aestab.c

use the OpenSSL AES implementation if it's available (unless configured not to)

2007-05-24 22:07:50 +00:00

alaw.c

Merged revisions 80166 via svnmerge from

2007-08-22 14:12:24 +00:00

app.c

Use the same delimited character as the FILTER function in FIELDQTY and CUT.

2007-10-26 00:11:31 +00:00

ast_expr2.c

closes issue #11045 - each file needs to define ASTERISK_FILE_VERSION, if you are going to set MTX_PROFILE in the compiler flags; the problem was that the fixes were getting made to the generated .c file, and erased the next time someone regenerated that file from the corresponding .y or .flex file. Moral of story: keep your eyes open and make mods to the .y (or flex input file) and re-run bison (or flex) as the Makefile directs for that file, and then check in both. Also, res_config_sqlite was kinda missed, and has the same issue.

2007-10-25 16:21:30 +00:00

ast_expr2.fl

Merged revisions 83432 via svnmerge from

2007-09-21 14:40:10 +00:00

ast_expr2.h

Simplify some preprocessor logic by using #elif

2007-10-17 21:16:40 +00:00

ast_expr2.y

closes issue #11045 - each file needs to define ASTERISK_FILE_VERSION, if you are going to set MTX_PROFILE in the compiler flags; the problem was that the fixes were getting made to the generated .c file, and erased the next time someone regenerated that file from the corresponding .y or .flex file. Moral of story: keep your eyes open and make mods to the .y (or flex input file) and re-run bison (or flex) as the Makefile directs for that file, and then check in both. Also, res_config_sqlite was kinda missed, and has the same issue.

2007-10-25 16:21:30 +00:00

ast_expr2f.c

Merged revisions 86880 via svnmerge from

2007-10-23 21:06:15 +00:00

asterisk.c

Switch from AST_CLI (formerly NEW_CLI) to AST_CLI_DEFINE, since the former didn't make much sense

2007-10-22 20:05:18 +00:00

astmm.c

Merged revisions 87373 via svnmerge from

2007-10-29 19:47:52 +00:00

astobj2.c

Switch from AST_CLI (formerly NEW_CLI) to AST_CLI_DEFINE, since the former didn't make much sense

2007-10-22 20:05:18 +00:00

audiohook.c

Fix memory issue that crept up with Russell's testing. It is *not* proper to free the frame we get in ast_write.

2007-09-06 22:34:44 +00:00

autoservice.c

Convert code that checks the _softhangup member of ast_channel directory to use

2007-08-01 15:39:54 +00:00

buildinfo.c

…

callerid.c

Change the fsk filter used in CID and TDD decode to an integer based implementation

2007-08-06 19:52:40 +00:00

cdr.c

Switch from AST_CLI (formerly NEW_CLI) to AST_CLI_DEFINE, since the former didn't make much sense

2007-10-22 20:05:18 +00:00

channel.c

Merged revisions 88826 via svnmerge from

2007-11-05 23:31:00 +00:00

chanvars.c

Issue 9869 - replace malloc and memset with ast_calloc, and other coding guidelines changes

2007-06-06 21:20:11 +00:00

cli.c

Show the channel unique ID in the "show channel concise" output

2007-11-02 21:25:55 +00:00

config.c

Don't re-cache the filename, but check to see if it already exists

2007-11-02 13:17:48 +00:00

cryptostub.c

Clean up adsistub file a bit (just spacing) and change over the crypto sub to use this build_stub macro strategy.

2007-05-20 17:52:00 +00:00

db.c

remove a cygwin-specific function remap that does not work.

2007-11-05 15:15:22 +00:00

devicestate.c

Merge a set of device state improvements from team/russell/events.

2007-08-10 16:24:11 +00:00

dial.c

Bring up to date with poll changes.

2007-08-10 18:37:32 +00:00

dlfcn.c

Issue 9869 - replace malloc and memset with ast_calloc, and other coding guidelines changes

2007-06-06 21:20:11 +00:00

dns.c

Merged revisions 81435 via svnmerge from

2007-09-04 13:11:49 +00:00

dnsmgr.c

Switch from AST_CLI (formerly NEW_CLI) to AST_CLI_DEFINE, since the former didn't make much sense

2007-10-22 20:05:18 +00:00

dsp.c

trivial formatting change

2007-09-20 19:45:00 +00:00

ecdisa.h

…

enum.c

Don't reload a configuration file if nothing has changed.

2007-08-16 21:09:46 +00:00

event.c

Try to clarify the rules on changing ast_event and ast_event_ie

2007-08-29 19:41:16 +00:00

file.c

Switch from AST_CLI (formerly NEW_CLI) to AST_CLI_DEFINE, since the former didn't make much sense

2007-10-22 20:05:18 +00:00

fixedjitterbuf.c

Issue 9869 - replace malloc and memset with ast_calloc, and other coding guidelines changes

2007-06-06 21:20:11 +00:00

fixedjitterbuf.h

…

frame.c

Switch from AST_CLI (formerly NEW_CLI) to AST_CLI_DEFINE, since the former didn't make much sense

2007-10-22 20:05:18 +00:00

fskmodem.c

Change the fsk filter used in CID and TDD decode to an integer based implementation

2007-08-06 19:52:40 +00:00

http.c

Switch from AST_CLI (formerly NEW_CLI) to AST_CLI_DEFINE, since the former didn't make much sense

2007-10-22 20:05:18 +00:00

image.c

Switch from AST_CLI (formerly NEW_CLI) to AST_CLI_DEFINE, since the former didn't make much sense

2007-10-22 20:05:18 +00:00

indications.c

Do a massive conversion for using the ast_verb() macro

2007-07-26 15:49:18 +00:00

io.c

Conversions to ast_debug()

2007-06-24 18:51:41 +00:00

jitterbuf.c

Conversions to ast_debug()

2007-06-24 18:51:41 +00:00

loader.c

merging patches that don't compile is bad... mmkay?

2007-10-22 14:56:05 +00:00

logger.c

This commits the performance mods that give the priority processing engine in the pbx, a 25-30% speed boost. The two updates used, are, first, to merge the ast_exists_extension() and the ast_spawn_extension() where they are called sequentially in a loop in the code, into a slightly upgraded version of ast_spawn_extension(), with a few extra args; and, second, I modified the substitute_variables_helper_full, so it zeroes out the byte after the evaluated string instead of demanding you pre-zero the buffer; I also went thru the code and removed the code that zeroed this buffer before every call to the substitute_variables_helper_full. The first fix provides about a 9% speedup, and the second the rest. These figures come from the 'PIPS' benchmark I describe in blogs, conf. reports, etc.

2007-11-01 22:26:51 +00:00

Makefile

Move the last instance of AST_LIBS to the only place it is used,

2007-11-05 21:27:04 +00:00

manager.c

Switch from AST_CLI (formerly NEW_CLI) to AST_CLI_DEFINE, since the former didn't make much sense

2007-10-22 20:05:18 +00:00

md5.c

…

netsock.c

Issue 9869 - replace malloc and memset with ast_calloc, and other coding guidelines changes

2007-06-06 21:20:11 +00:00

pbx.c

Merged revisions 88805 via svnmerge from

2007-11-06 14:08:54 +00:00

plc.c

…

poll.c

…

privacy.c

…

rtp.c

Drop the RTCP Read too short message to debug. There are some phones out there that send a sort of keep alive packet in the RTCP that trigger this every 5 seconds.

2007-10-29 20:02:31 +00:00

say.c

Merged revisions 88283 via svnmerge from

2007-11-02 16:54:11 +00:00

sched.c

Merged revisions 83432 via svnmerge from

2007-09-21 14:40:10 +00:00

sha1.c

Doxygen cleanups/fixes.

2007-09-05 16:31:39 +00:00

slinfactory.c

Merge audiohooks branch into trunk. This is a new API for developers to listen and manipulate the audio going through a channel.

2007-08-08 19:30:52 +00:00

srv.c

Merged revisions 88719 via svnmerge from

2007-11-05 20:44:05 +00:00

strcompat.c

Merged revisions 68192 via svnmerge from

2007-06-07 19:31:05 +00:00

tdd.c

Change the fsk filter used in CID and TDD decode to an integer based implementation

2007-08-06 19:52:40 +00:00

term.c

Revert commit #86119. Some users intentionally do not want colorized terminals, so this was a misfeature.

2007-11-03 14:19:47 +00:00

threadstorage.c

Switch from AST_CLI (formerly NEW_CLI) to AST_CLI_DEFINE, since the former didn't make much sense

2007-10-22 20:05:18 +00:00

translate.c

Switch from AST_CLI (formerly NEW_CLI) to AST_CLI_DEFINE, since the former didn't make much sense

2007-10-22 20:05:18 +00:00

udptl.c

Switch from AST_CLI (formerly NEW_CLI) to AST_CLI_DEFINE, since the former didn't make much sense

2007-10-22 20:05:18 +00:00

ulaw.c

This change set fixes bug 8126 in trunk. It is implemented via compile time options, activated via the menuselect stuff, which defaults to the old way. non-zero sample data added. Translate tables expressed in microseconds instead of milliseconds, with 5-digit data now instead of 3, giving 2 more digits of precision.

2007-08-20 22:53:48 +00:00

utils.c

Simplify the implementation and the API for stringfields;

2007-11-04 19:44:31 +00:00