Mark Michelson 2ce7eabb24 Fix two problems in ast_str functions found while writing a unit test. ...

1. The documentation for ast_str_set and ast_str_append state that
the max_len parameter may be -1 in order to limit the size of the
ast_str to its current allocated size. The problem was that the max_len
parameter in all cases was a size_t, which is unsigned. Thus a -1 was
interpreted as UINT_MAX instead of -1. Changing the max_len parameter
to be ssize_t fixed this issue.

2. Once issue 1 was fixed, there was an off-by-one error in the case
where we attempted to write a string larger than the current allotted
size to a string when -1 was passed as the max_len parameter. When trying
to write more than the allotted size, the ast_str's __AST_STR_USED was
set to 1 higher than it should have been. Thanks to Tilghman for quickly
spotting the offending line of code.

Oh, and the unit test that I referenced in the top line of this commit
will be added to reviewboard shortly. Sit tight...



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247335 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2010-02-17 21:22:40 +00:00

..

doxygen

Note where empty lines should reside in commit messages.

2010-01-15 23:09:09 +00:00

_private.h

Unit Test Framework API

2009-12-22 16:09:11 +00:00

abstract_jb.h

Expand codec bitfield from 32 bits to 64 bits.

2009-11-04 14:05:12 +00:00

acl.h

Merge code associated with AST-2009-006

2009-09-03 16:31:54 +00:00

adsi.h

A lot of doxygen updates

2007-12-11 14:17:29 +00:00

ael_structs.h

Merged revisions 136726 via svnmerge from

2008-08-08 00:48:35 +00:00

aes_internal.h

use the OpenSSL AES implementation if it's available (unless configured not to)

2007-05-24 22:07:50 +00:00

aes.h

Allow AES to compile, when OpenSSL is not present.

2009-09-26 15:10:28 +00:00

agi.h

Redesigned 'optional API' support.

2009-06-15 16:07:23 +00:00

alaw.h

A lot of doxygen updates

2007-12-11 14:17:29 +00:00

app.h

Change all refererences to 1.6.3 to be 1.8, since that will be the next feature release

2009-12-21 18:51:17 +00:00

ast_expr.h

Merge str_substitution branch.

2009-04-29 18:53:01 +00:00

ast_version.h

Rename version.h to ast_version.h. Next, I will be re-adding version.h as an

2008-02-26 20:02:14 +00:00

astdb.h

A lot of doxygen updates

2007-12-11 14:17:29 +00:00

astmm.h

Adding Tilghman's documentation from asterisk-dev to the actual file.

2010-01-12 07:48:16 +00:00

astobj2.h

fixes astobj2 unlinking of multiple objects when OBJ_MULTIPLE was disabled

2010-02-05 21:21:05 +00:00

astobj.h

Merged revisions 129970 via svnmerge from

2008-07-11 14:22:44 +00:00

astosp.h

1. Re-format the code.

2006-11-15 20:55:17 +00:00

audiohook.h

fixes AUDIOHOOK_INHERIT regression

2010-01-08 19:39:30 +00:00

autochan.h

Convert the ast_channel data structure over to the astobj2 framework.

2009-04-24 14:04:26 +00:00

autoconfig.h.in

Solaris doesn't like outputting a NULL to a %s in format strings.

2010-02-10 16:01:28 +00:00

bridging_features.h

Merge phase 1 support for the new bridging architecture.

2009-03-05 18:18:27 +00:00

bridging_technology.h

Expand codec bitfield from 32 bits to 64 bits.

2009-11-04 14:05:12 +00:00

bridging.h

Expand codec bitfield from 32 bits to 64 bits.

2009-11-04 14:05:12 +00:00

buildinfo.h

try to get this committed before the buildbot complains about a broken tree

2008-10-30 16:53:11 +00:00

calendar.h

Fix handling of notification calls w/ the dialing api

2009-10-13 01:51:46 +00:00

callerid.h

Change all refererences to 1.6.3 to be 1.8, since that will be the next feature release

2009-12-21 18:51:17 +00:00

causes.h

Fix "cancel answered elsewhere" through app_queue with members in chan_local.

2009-01-29 17:08:22 +00:00

cdr.h

Merged revisions 235635 via svnmerge from

2009-12-18 22:51:37 +00:00

cel.h

Change all refererences to 1.6.3 to be 1.8, since that will be the next feature release

2009-12-21 18:51:17 +00:00

channel.h

Merged revisions 237405 via svnmerge from

2010-01-04 18:28:28 +00:00

chanvars.h

Add additional memory debugging to several core APIs, and fix several memory

2008-10-14 22:38:06 +00:00

cli.h

Correct example for CLI autocompletion (generation)

2009-05-23 13:31:56 +00:00

compat.h

Move implementation of closefrom(3) from app.c to strcompat.c

2009-12-06 07:01:06 +00:00

compiler.h

Redesigned 'optional API' support.

2009-06-15 16:07:23 +00:00

config.h

Add Doxygen documentation for API changes from 1.6.0 to 1.6.1

2009-03-09 20:58:17 +00:00

crypto.h

Merged revisions 186320 via svnmerge from

2009-04-03 15:52:50 +00:00

datastore.h

Properly account for memory allocated for channels and datastores

2009-05-05 10:34:19 +00:00

devicestate.h

Merged revisions 205409 via svnmerge from

2009-07-08 22:15:06 +00:00

dial.h

* Fixed timeout logic in the dialing API as setting timeouts

2008-10-31 20:05:46 +00:00

dlinkedlists.h

Add Doxygen documentation for API changes from 1.6.0 to 1.6.1

2009-03-09 20:58:17 +00:00

dns.h

merge new_loader_completion branch, including (at least):

2006-08-21 02:11:39 +00:00

dnsmgr.h

Add Doxygen documentation for API changes from 1.6.0 to 1.6.1

2009-03-09 20:58:17 +00:00

doxyref.h

Change all refererences to 1.6.3 to be 1.8, since that will be the next feature release

2009-12-21 18:51:17 +00:00

dsp.h

Merged revisions 224931 via svnmerge from

2009-10-21 03:09:04 +00:00

dundi.h

incorporates r159808 from branches/1.4:

2008-11-29 17:57:39 +00:00

endian.h

only include this for OpenBSD. At least FreeBSD is borked when including it

2008-10-09 17:48:53 +00:00

enum.h

Add Doxygen documentation for API changes from 1.6.0 to 1.6.1

2009-03-09 20:58:17 +00:00

event_defs.h

Add an API for reporting security events, and a security event logging module.

2009-07-11 19:15:03 +00:00

event.h

Add a test module for the event API, test_event.c.

2010-02-10 23:19:16 +00:00

extconf.h

Const-ify the world (or at least a good part of it)

2009-05-21 21:13:09 +00:00

features.h

Add bridge related dial flags to the bridge app

2009-09-24 20:29:51 +00:00

file.h

Merged revisions 231614 via svnmerge from

2009-11-30 21:31:55 +00:00

frame_defs.h

Expand codec bitfield from 32 bits to 64 bits.

2009-11-04 14:05:12 +00:00

frame.h

Expand codec bitfield from 32 bits to 64 bits.

2009-11-04 14:05:12 +00:00

fskmodem_float.h

Optionally build integer-based routines for FSK tone decoding (but default

2008-07-21 20:59:03 +00:00

fskmodem_int.h

Optionally build integer-based routines for FSK tone decoding (but default

2008-07-21 20:59:03 +00:00

fskmodem.h

(Step 2 of 2)

2008-07-21 21:00:47 +00:00

global_datastores.h

Merged revisions 172517 via svnmerge from

2009-01-30 21:29:12 +00:00

hashtab.h

Add MALLOC_DEBUG to various utility APIs, so that memory leaks can be tracked back to their source.

2009-03-11 00:29:59 +00:00

heap.h

Pass more useful information through to lock tracking when DEBUG_THREADS is on.

2009-03-27 01:35:56 +00:00

http.h

Change all refererences to 1.6.3 to be 1.8, since that will be the next feature release

2009-12-21 18:51:17 +00:00

image.h

Const-ify the world (or at least a good part of it)

2009-05-21 21:13:09 +00:00

indications.h

Fix build issues on Solaris and OpenBSD.

2009-02-21 13:17:47 +00:00

inline_api.h

remove extraneous svn:executable properties

2005-11-29 18:24:39 +00:00

io.h

Merged revisions 182810 via svnmerge from

2009-03-18 02:28:55 +00:00

jabber.h

Add auth_policy option to jabber.conf for auto user registration.

2009-12-16 20:25:27 +00:00

jingle.h

Changed to temporary namespaces to match with latest XEPs. As soon as

2008-05-28 14:10:48 +00:00

linkedlists.h

Merged revisions 226304 via svnmerge from

2009-10-28 18:04:05 +00:00

localtime.h

Add schedule extensions to app_meetme. In addition, the reporter found a

2008-10-01 23:02:25 +00:00

lock.h

Merged revisions 228827 via svnmerge from

2009-11-09 14:37:07 +00:00

logger.h

Change all refererences to 1.6.3 to be 1.8, since that will be the next feature release

2009-12-21 18:51:17 +00:00

manager.h

Oops

2010-02-04 18:47:21 +00:00

md5.h

Start untangling header inclusion in a way that does not affect

2007-11-16 20:04:58 +00:00

mod_format.h

Formats need to be able to represent all 64 codec bits.

2009-12-01 17:48:54 +00:00

module.h

Fixing typos. Replaces "recieved" with "received" and "initilize" with "initialize"

2009-07-27 16:33:50 +00:00

monitor.h

Redesigned 'optional API' support.

2009-06-15 16:07:23 +00:00

musiconhold.h

Merge a bunch of doxygen updates to header files. This includes changes to

2007-07-16 02:51:56 +00:00

netsock.h

fixes an ast_netsock_list memory leak.

2009-10-08 19:35:30 +00:00

network.h

Get default entity ID determination working on Linux again

2008-06-12 17:38:27 +00:00

optional_api.h

Redesigned 'optional API' support.

2009-06-15 16:07:23 +00:00

options.h

Add new option to asterisk.conf (lockconfdir) to protect conf dir during reloads

2010-01-27 18:29:49 +00:00

paths.h

modify http://svn.digium.com/view/asterisk?view=rev&rev=93603

2007-12-20 09:55:05 +00:00

pbx.h

Change api for pbx_builtin_setvar to actually return error code if a function can't be written to.

2010-01-25 21:13:20 +00:00

pktccops.h

Add PacketCable NCS 1.0 support for Docsis/Eurodocsis networks

2009-11-02 22:29:19 +00:00

plc.h

Start untangling header inclusion in a way that does not affect

2007-11-16 20:04:58 +00:00

poll-compat.h

Merged revisions 182810 via svnmerge from

2009-03-18 02:28:55 +00:00

privacy.h

remove extraneous svn:executable properties

2005-11-29 18:24:39 +00:00

pval.h

Merged revisions 162013 via svnmerge from

2008-12-09 17:18:03 +00:00

res_odbc.h

Merge changes from str_substitution that are unrelated to that branch.

2009-04-01 20:13:28 +00:00

rtp_engine.h

Change all refererences to 1.6.3 to be 1.8, since that will be the next feature release

2009-12-21 18:51:17 +00:00

say.h

Fixed some doxygen comments

2009-01-29 19:34:09 +00:00

sched.h

Fix some incorrect documentation of sched_thread functions.

2009-08-28 18:41:23 +00:00

security_events_defs.h

Add an API for reporting security events, and a security event logging module.

2009-07-11 19:15:03 +00:00

security_events.h

Change all refererences to 1.6.3 to be 1.8, since that will be the next feature release

2009-12-21 18:51:17 +00:00

sha1.h

Start untangling header inclusion in a way that does not affect

2007-11-16 20:04:58 +00:00

slin.h

Expand codec bitfield from 32 bits to 64 bits.

2009-11-04 14:05:12 +00:00

slinfactory.h

Expand codec bitfield from 32 bits to 64 bits.

2009-11-04 14:05:12 +00:00

smdi.h

Redesigned 'optional API' support.

2009-06-15 16:07:23 +00:00

speech.h

Const-ify the world (or at least a good part of it)

2009-05-21 21:13:09 +00:00

srv.h

Create iterative method for querying SRV results, and use that for finding AGI servers.

2010-01-19 00:28:49 +00:00

stringfields.h

Change all refererences to 1.6.3 to be 1.8, since that will be the next feature release

2009-12-21 18:51:17 +00:00

strings.h

Fix two problems in ast_str functions found while writing a unit test.

2010-02-17 21:22:40 +00:00

stun.h

Merge in the RTP engine API.

2009-04-02 17:20:52 +00:00

syslog.h

Change all refererences to 1.6.3 to be 1.8, since that will be the next feature release

2009-12-21 18:51:17 +00:00

taskprocessor.h

Const-ify the world (or at least a good part of it)

2009-05-21 21:13:09 +00:00

tcptls.h

SIP TCP/TLS: move client connection setup/write into tcp helper thread, various related locking/memory fixes.

2009-10-22 19:55:51 +00:00

tdd.h

Additional TDD changes (preparing for SIP changes - adding TDD support to SIP)

2007-11-06 19:10:26 +00:00

term.h

Move all the XML documentation API from pbx.c to xmldoc.c.

2008-11-10 13:53:23 +00:00

test.h

Various updates to the unit test API.

2010-02-09 23:32:14 +00:00

threadstorage.h

Merged revisions 236585 via svnmerge from

2009-12-28 15:22:54 +00:00

time.h

Extend max call limit duration from 24.8 days to 292+ million years.

2010-01-18 22:31:25 +00:00

timing.h

Improve timing interface to remember which provider provided a timer

2009-03-27 19:10:32 +00:00

transcap.h

Doxygen updates, formatting.

2007-12-11 22:20:22 +00:00

translate.h

Expand codec bitfield from 32 bits to 64 bits.

2009-11-04 14:05:12 +00:00

udptl.h

fixes crash during T.38 negotiation caused by invalid or missing FaxMaxDatagram field

2010-02-02 22:27:23 +00:00

ulaw.h

Doxygen updates, formatting.

2007-12-11 22:20:22 +00:00

unaligned.h

Revert code in error and include the gcc suggested workaround for the original problem, while gcc investigates.

2009-11-20 21:47:39 +00:00

utils.h

Various updates to the unit test API.

2010-02-09 23:32:14 +00:00

xml.h

Remove trailing whitespaces

2008-11-13 13:08:34 +00:00

xmldoc.h

Implement a new element in AstXML for AMI actions documentation.

2009-05-22 17:52:35 +00:00