Kevin Harwell 30c0af7257 various files - fix some alerts raised by lgtm code analysis ...

This patch fixes several issues reported by the lgtm code analysis tool:

https://lgtm.com/projects/g/asterisk/asterisk

Not all reported issues were addressed in this patch. This patch mostly fixes
confirmed reported errors, potential problematic code points, and a few other
"low hanging" warnings or recommendations found in core supported modules.
These include, but are not limited to the following:

* innapropriate stack allocation in loops
* buffer overflows
* variable declaration "hiding" another variable declaration
* comparisons results that are always the same
* ambiguously signed bit-field members
* missing header guards

Change-Id: Id4a881686605d26c94ab5409bc70fcc21efacc25

2019-11-18 08:30:05 -06:00

..

stdtime

Merge "BuildSystem: Cast any intptr_t explicitly to its proposed type."

2018-03-06 13:17:54 -06:00

.gitignore

…

abstract_jb.c

func_jitterbuffer: Add audio/video sync support.

2019-09-18 15:26:00 -05:00

acl.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

adsi.c

…

alaw.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

alertpipe.c

utils: Wrap socket() and pipe() to reduce syscalls

2018-12-07 09:04:55 -05:00

aoc.c

various modules: json integer overflow

2019-08-01 15:31:23 -06:00

app.c

various files - fix some alerts raised by lgtm code analysis

2019-11-18 08:30:05 -06:00

ast_expr2.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

ast_expr2.fl

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

ast_expr2.h

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

ast_expr2.y

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

ast_expr2f.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

asterisk.c

various files - fix some alerts raised by lgtm code analysis

2019-11-18 08:30:05 -06:00

asterisk.dynamics

…

asterisk.exports.in

stasis: Add statistics gathering in developer mode.

2018-12-12 12:14:44 -05:00

astfd.c

main/astfd: Fix GCC8 format-truncation warning.

2018-10-12 13:21:24 -04:00

astmm.c

astmm.c: Display backtrace with memory show allocations

2019-09-23 06:23:05 -06:00

astobj2_container_private.h

…

astobj2_container.c

core: Add AO2_ALLOC_OPT_NO_REF_DEBUG option.

2019-09-23 12:34:41 -05:00

astobj2_global.c

core: Fix ABI mismatch of ao2_global_obj.

2019-09-24 11:20:21 -05:00

astobj2_hash.c

core: Add AO2_ALLOC_OPT_NO_REF_DEBUG option.

2019-09-23 12:34:41 -05:00

astobj2_private.h

…

astobj2_rbtree.c

core: Add AO2_ALLOC_OPT_NO_REF_DEBUG option.

2019-09-23 12:34:41 -05:00

astobj2.c

Merge "core: Fix ABI mismatch of ao2_global_obj." into 16

2019-09-25 07:41:35 -05:00

audiohook.c

audiohook.c: Substitute silence for unavailable audio frames

2019-08-20 08:43:39 -05:00

autochan.c

autochan/mixmonitor/chanspy: Fix unsafe channel locking and references.

2017-03-15 17:18:55 -06:00

autoservice.c

autoservice: Don't start channel autoservice if the thread is a user interface.

2018-06-19 15:02:52 -05:00

backtrace.c

backtrace.c: Fix casting pointer to/from integral type.

2018-12-19 13:50:51 -05:00

bridge_after.c

stasis/control: Fix possible deadlock with swap channel

2017-09-06 13:00:49 -05:00

bridge_basic.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

bridge_channel.c

bridge_channel.c: Fix Deadlock when using Local channels and fax gateway

2018-06-05 05:37:54 -06:00

bridge_roles.c

bridge_roles: Use a non-locking linked list where appropriate

2018-02-15 14:31:32 -06:00

bridge.c

stasis: Call callbacks when imparting fails

2019-05-02 15:28:21 +00:00

bucket.c

astobj2: Eliminate usage of legacy container allocation macros.

2018-10-19 17:33:02 -04:00

buildinfo.c

…

callerid.c

Replace direct checks of option_debug with DEBUG_ATLEAST macro.

2018-03-07 16:03:01 -06:00

ccss.c

various modules: json integer overflow

2019-08-01 15:31:23 -06:00

cdr.c

cdr / cel: Use event time at event creation instead of processing.

2019-08-07 04:47:12 -06:00

cel.c

cdr / cel: Use event time at event creation instead of processing.

2019-08-07 04:47:12 -06:00

channel_internal_api.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 08:39:39 -06:00

channel.c

various modules: json integer overflow

2019-08-01 15:31:23 -06:00

chanvars.c

core: Remove ABI effects of MALLOC_DEBUG.

2018-03-01 13:13:55 -06:00

cli.c

core: Add some documentation to the malloc_trim code

2018-12-03 17:47:18 -05:00

codec_builtin.c

core: Add H.265/HEVC passthrough support

2019-09-12 11:16:09 +02:00

codec.c

astobj2: Eliminate usage of legacy container allocation macros.

2018-10-19 17:33:02 -04:00

config_options.c

astobj2: Eliminate usage of legacy ao2_container_alloc routine.

2018-11-21 09:56:12 -05:00

config.c

channels: Allow updating variable value

2019-09-12 15:58:49 -05:00

conversions.c

conversions.c: Add conversions for largest max sized integer

2019-05-06 16:26:46 -05:00

core_local.c

various modules: json integer overflow

2019-08-01 15:31:23 -06:00

core_unreal.c

core: Reduce video update queueing.

2017-08-28 11:12:50 -05:00

crypt.c

BuildSystem: Fix build on FreeBSD due to missing crypt.h

2017-06-08 10:42:54 -05:00

cygload.c

…

data_buffer.c

res_rtp_asterisk: Add support for sending NACK requests.

2018-07-18 13:37:03 -05:00

datastore.c

astobj2: Eliminate usage of legacy ao2_container_alloc routine.

2018-11-21 09:56:12 -05:00

db.c

Fix 'statement' typo throughout code.

2018-10-18 12:44:03 -05:00

devicestate.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 08:39:39 -06:00

dial.c

channel: Remove old epoll support and fixed max number of file descriptors.

2017-03-27 19:54:44 +00:00

dns_core.c

dns_core: Create new API ast_dns_resolve_ipv6_and_ipv4

2019-08-22 06:32:54 -06:00

dns_naptr.c

AST-2018-010: Fix length of buffer needed for SRV and NAPTR results

2018-11-14 09:25:06 -05:00

dns_query_set.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

dns_recurring.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

dns_srv.c

AST-2018-010: Fix length of buffer needed for SRV and NAPTR results

2018-11-14 09:25:06 -05:00

dns_system_resolver.c

core: Remove non-critical cleanup from startup aborts.

2018-03-13 13:46:08 -04:00

dns_test.c

…

dns_tlsa.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

dns.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

dnsmgr.c

loader: Process dependencies for built-in modules.

2018-07-26 15:29:39 -04:00

dsp.c

loader: Process dependencies for built-in modules.

2018-07-26 15:29:39 -04:00

ecdisa.h

…

endpoints.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 08:39:39 -06:00

enum.c

loader: Process dependencies for built-in modules.

2018-07-26 15:29:39 -04:00

event.c

various files - fix some alerts raised by lgtm code analysis

2019-11-18 08:30:05 -06:00

features_config.c

astobj2: Eliminate usage of legacy container allocation macros.

2018-10-19 17:33:02 -04:00

features_config.h

loader: Convert reload_classes to built-in modules.

2018-03-14 05:20:12 -04:00

features.c

loader: Process dependencies for built-in modules.

2018-07-26 15:29:39 -04:00

file.c

various files - fix some alerts raised by lgtm code analysis

2019-11-18 08:30:05 -06:00

fixedjitterbuf.c

abstract/fixed/adpative jitter buffer: disallow frame re-inserts

2017-01-17 17:08:53 -06:00

fixedjitterbuf.h

abstract/fixed/adpative jitter buffer: disallow frame re-inserts

2017-01-17 17:08:53 -06:00

format_cache.c

core: Add H.265/HEVC passthrough support

2019-09-12 11:16:09 +02:00

format_cap.c

format_cap: Fix leak on AST_VECTOR_APPEND error.

2017-11-06 16:07:01 -05:00

format_compatibility.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

format.c

astobj2: Eliminate usage of legacy container allocation macros.

2018-10-19 17:33:02 -04:00

frame.c

core/frame: Fix ast_frdup() and ast_frisolate() for empty text frames

2018-10-02 11:25:17 -05:00

framehook.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

fskmodem_float.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

fskmodem_int.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

fskmodem.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

global_datastores.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

hashtab.c

core: Remove ABI effects of MALLOC_DEBUG.

2018-03-01 13:13:55 -06:00

heap.c

core: Remove ABI effects of MALLOC_DEBUG.

2018-03-01 13:13:55 -06:00

http.c

http.c: Support separated HTTP request

2019-02-20 15:28:54 -06:00

image.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

indications.c

various files - fix some alerts raised by lgtm code analysis

2019-11-18 08:30:05 -06:00

io.c

Core: Add support for systemd socket activation.

2017-06-19 13:33:48 -04:00

iostream.c

iostream.c: Fix ast_iostream_gets() needlessly returning failure.

2018-08-30 17:12:00 -05:00

jitterbuf.c

Fix Common Typo's.

2017-12-20 12:40:01 -05:00

json.c

main/json.c: Added app_name, app_data to channel type

2019-04-05 02:33:14 +02:00

libasteriskpj.c

PJPROJECT logging: Fix detection of max supported log level.

2017-01-24 11:25:19 -06:00

libasteriskssl.c

libasteriskssl: Allow OpenSSL 1.0.2 configured with no-deprecated.

2018-05-20 13:55:26 +02:00

libasteriskssl.exports.in

…

loader.c

loader.c: Fix possible SEGV when a module fails to register

2019-07-29 07:38:36 -06:00

lock.c

lock: Replace __ast_mutex_logger with private log_mutex_error.

2018-10-19 11:43:25 -05:00

logger.c

backtrace: Refactor ast_bt_get_symbols so it doesn't crash

2018-11-19 05:48:42 -07:00

Makefile

Build System: Improve ccache matching for different menuselect options.

2018-08-14 12:45:10 -05:00

manager_bridges.c

res/ari/resource_bridges: Add the ability to manipulate the video source

2016-11-14 17:03:09 -05:00

manager_channels.c

Merge "manager_channels: Fix throwing of HangupHandler manager events" into 16

2019-01-23 09:51:38 -06:00

manager_endpoints.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

manager_mwi.c

mwi core: Move core MWI functionality into its own files

2019-04-23 17:39:57 -05:00

manager_system.c

Remove constant conditionals (dead-code).

2017-12-19 09:42:19 -05:00

manager.c

various files - fix some alerts raised by lgtm code analysis

2019-11-18 08:30:05 -06:00

max_forwards.c

…

md5.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

media_cache.c

Fixes for GCC 9

2019-05-10 10:17:27 -06:00

media_index.c

media_index.c: Refactored so it doesn't cache the index

2019-01-28 13:28:22 -06:00

message.c

astobj2: Eliminate usage of legacy ao2_container_alloc routine.

2018-11-21 09:56:12 -05:00

mixmonitor.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

mwi.c

mwi core: Move core MWI functionality into its own files

2019-04-23 17:39:57 -05:00

named_acl.c

astobj2: Eliminate usage of legacy ao2_container_alloc routine.

2018-11-21 09:56:12 -05:00

named_locks.c

core: Use macros to generate ao2_container callbacks where possible.

2017-12-30 13:20:16 -05:00

netsock2.c

netsock2: Add ast_sockaddr_resolve_first_af to netsock2 public API

2018-05-21 11:03:10 -05:00

optional_api.c

optional_api: Refactor to use vector's and standard allocators.

2018-02-12 22:53:35 -05:00

options.c

core: Ensure that el_end is always run when needed.

2018-11-11 08:43:29 -05:00

parking.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 08:39:39 -06:00

pbx_app.c

cli: Enable ast_cli_completion_add on public completion generators.

2018-03-15 07:25:28 -04:00

pbx_builtins.c

core: Remove non-critical cleanup from startup aborts.

2018-03-13 13:46:08 -04:00

pbx_functions.c

Fix some doxygen and curly placement.

2018-06-19 10:46:46 -06:00

pbx_hangup_handler.c

cli: Fix various CLI documentation and completion issues

2017-02-13 11:33:15 -05:00

pbx_ignorepat.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

pbx_include.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

pbx_private.h

pbx: Create pbx_sw.c for management of 'struct ast_sw'.

2016-07-21 13:58:26 -04:00

pbx_sw.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

pbx_switch.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

pbx_timing.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

pbx_variables.c

various files - fix some alerts raised by lgtm code analysis

2019-11-18 08:30:05 -06:00

pbx.c

pbx: deadlock when outgoing dialed channel hangs up too quickly

2019-10-09 16:06:50 -05:00

pickup.c

astobj2: Eliminate usage of legacy container allocation macros.

2018-10-19 17:33:02 -04:00

plc.c

loader: Process dependencies for built-in modules.

2018-07-26 15:29:39 -04:00

poll.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

presencestate.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 08:39:39 -06:00

privacy.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

rtp_engine.c

Merge "func_jitterbuffer: Add audio/video sync support." into 16

2019-09-19 08:10:52 -05:00

say.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

sched.c

sched: Don't allow ast_sched_del to deadlock ast_sched_runq from same thread

2019-07-18 01:22:30 -06:00

sdp_srtp.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

security_events.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 08:39:39 -06:00

sem.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

serializer.c

serializer: move/add asterisk serializer pool functionality

2019-10-07 16:49:39 -05:00

sha1.c

…

sip_api.c

…

slinfactory.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

smoother.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

sorcery.c

sorcery.c: Sorcery enhancements for wizard management

2019-03-18 11:39:31 -06:00

sounds.c

sounds: Sort 'core show sounds' output

2019-02-04 14:40:30 -06:00

srv.c

srv: Fix crash when ast_srv_lookup is used and 0 records are returned.

2017-02-07 12:13:23 -06:00

stasis_bridges.c

app_confbridge: Attended transfer event fixup

2019-06-13 14:06:08 -06:00

stasis_cache_pattern.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 08:39:39 -06:00

stasis_cache.c

various files - fix some alerts raised by lgtm code analysis

2019-11-18 08:30:05 -06:00

stasis_channels.c

various modules: json integer overflow

2019-08-01 15:31:23 -06:00

stasis_endpoints.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 08:39:39 -06:00

stasis_message_router.c

stasis / manager / ari: Better filter messages.

2019-01-17 12:52:08 -06:00

stasis_message.c

stasis: Allow filtering by formatter

2018-12-07 08:58:51 -05:00

stasis_system.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 08:39:39 -06:00

stasis.c

various files - fix some alerts raised by lgtm code analysis

2019-11-18 08:30:05 -06:00

strcompat.c

core: Remove ABI effects of MALLOC_DEBUG.

2018-03-01 13:13:55 -06:00

stream.c

stream: Make the topology a reference counted object.

2018-05-03 16:31:56 +00:00

stringfields.c

stringfields: Remove MALLOC_DEBUG fields from struct ast_string_field_mgr.

2018-03-13 16:24:06 -04:00

strings.c

json.c/strings.c - Add a couple of utility functions

2019-02-19 09:44:08 -06:00

stun.c

STUN/netsock2: Fix some valgrind uninitialized memory findings.

2017-08-10 14:38:12 -05:00

syslog.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

taskprocessor.c

serializer: move/add asterisk serializer pool functionality

2019-10-07 16:49:39 -05:00

tcptls.c

tcptls.c: Add peer hostname and port to some error messages

2019-06-27 15:04:20 -06:00

tdd.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

term.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

test.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 08:39:39 -06:00

threadpool.c

taskprocessor: Enable subsystems and overload by subsystem

2019-02-20 10:46:47 -07:00

threadstorage.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

timing.c

loader: Create ast_module_running_ref.

2018-01-03 17:23:36 -05:00

translate.c

AST-2019-005 - translate: Don't assume all frames will have a src.

2019-09-05 05:28:12 -05:00

udptl.c

main/udptl.c: correctly handle udptl sequence wrap around

2019-07-30 06:48:31 -06:00

ulaw.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

uri.c

…

utils.c

utils: Don't set or clear flags that don't need setting or clearing

2018-12-11 10:08:02 -05:00

uuid.c

uuid: Enable UUID in Solaris 11.

2018-06-23 08:26:19 +02:00

xml.c

xmldoc.c: Fix dump of xml document

2018-07-23 06:47:31 -05:00

xmldoc.c

astobj2: Eliminate usage of legacy ao2_container_alloc routine.

2018-11-21 09:56:12 -05:00