Richard Mudgett e31cb6b248 strings.h: Fix issues with escape string functions. ...

Fixes for issues with the ASTERISK-24934 patch.

* Fixed ast_escape_alloc() and ast_escape_c_alloc() if the s parameter is
an empty string.  If it were an empty string the functions returned NULL
as if there were a memory allocation failure.  This failure caused the AMI
VarSet event to not get posted if the new value was an empty string.

* Fixed dest buffer overwrite potential in ast_escape() and
ast_escape_c().  If the dest buffer size is smaller than the space needed
by the escaped s parameter string then the dest buffer would be written
beyond the end by the nul string terminator.  The num parameter was really
the dest buffer size parameter so I renamed it to size.

* Made nul terminate the dest buffer if the source string parameter s was
an empty string in ast_escape() and ast_escape_c().

* Updated ast_escape() and ast_escape_c() doxygen function description
comments to reflect reality.

* Added some more unit test cases to /main/strings/escape to cover the
empty source string issues.

ASTERISK-25255 #close
Reported by: Richard Mudgett

Change-Id: Id77fc704600ebcce81615c1200296f74de254104

2015-07-15 19:56:32 -05:00

..

editline

main/editline: Add .gitignore.

2015-04-12 13:58:49 -05:00

stdtime

main/stdtime/localtime: Fix warning introduced in r433720

2015-03-30 02:29:10 +00:00

.gitignore

Fixes for OS X

2015-06-02 16:27:51 -05:00

abstract_jb.c

func_jitterbuffer: fix frame leaks.

2014-11-02 07:39:36 +00:00

acl.c

Fix error with mixed address family ACLs.

2014-11-20 16:36:54 +00:00

adsi.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:49:26 +00:00

alaw.c

…

aoc.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

app.c

clang compiler warnings: Fix autological comparisons

2015-04-09 12:56:30 +00:00

ast_expr2.c

…

ast_expr2.fl

…

ast_expr2.h

…

ast_expr2.y

…

ast_expr2f.c

…

asterisk.c

Fix processing of asterisk.conf debug=yes.

2015-05-12 09:37:09 -05:00

asterisk.dynamics

Fix error loading res_monitor.

2014-04-23 15:02:39 +00:00

asterisk.exports.in

…

astfd.c

astfd: Fix buffer overflow in DEBUG_FD_LEAKS.

2015-07-02 05:24:33 -05:00

astmm.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

astobj2_container_private.h

astobj2: Additional refactoring to push impl specific code down into the impls.

2014-06-20 15:27:43 +00:00

astobj2_container.c

Astobj2: Ensure all calls to __adjust_lock pass a valid object.

2015-04-22 20:44:56 -04:00

astobj2_hash.c

Astobj2: Correctly treat hash_fn returning INT_MIN

2015-05-25 02:17:48 -05:00

astobj2_private.h

astobj2: Additional refactoring to push impl specific code down into the impls.

2014-06-20 15:27:43 +00:00

astobj2_rbtree.c

Astobj2: Ensure all calls to __adjust_lock pass a valid object.

2015-04-22 20:44:56 -04:00

astobj2.c

Astobj2: Fix initialization order of refdebug and AO2_DEBUG.

2015-05-01 15:40:45 -04:00

audiohook.c

audiohook.c: Difference in read/write rates caused continuous buffer resets

2015-05-20 16:08:58 -05:00

autochan.c

…

autoservice.c

autoservice: stop thread on graceful shutdown

2014-06-09 03:50:45 +00:00

backtrace.c

…

bridge_after.c

Fix some memory leaks.

2015-01-30 16:47:50 +00:00

bridge_basic.c

features: Fix crash when transferee hangs up during DTMF attended transfer.

2015-05-05 18:17:54 -05:00

bridge_channel.c

bridge.c: Fixed race condition during attended transfer

2015-07-13 12:55:21 -05:00

bridge_roles.c

…

bridge.c

bridge.c: Fixed race condition during attended transfer

2015-07-13 12:55:21 -05:00

bucket.c

A couple minor cleanup tweaks.

2015-03-25 18:37:04 +00:00

buildinfo.c

…

callerid.c

CallerID: Fix parsing regression

2014-10-10 13:01:41 +00:00

ccss.c

Detect potential forwarding loops based on count.

2015-04-17 15:57:10 -05:00

cdr.c

main/cdr: Carry over the disable flag when 'disable all' is specified

2015-06-15 10:34:44 -05:00

cel.c

clang compiler warnings: Fix autological comparisons

2015-04-09 12:56:30 +00:00

channel_internal_api.c

Channel alert pipe: improve diagnostic error return

2015-07-01 16:55:50 -05:00

channel.c

channel: Remove ignore of answer on non-outgoing channels.

2015-06-25 15:16:24 -03:00

chanvars.c

res_phoneprov: Refactor phoneprov to allow pluggable config providers

2014-10-09 17:45:23 +00:00

cli.c

CLI: Cosmetic issue - core show uptime

2015-06-05 02:16:24 -05:00

codec_builtin.c

Various: bugfixes found via chaos

2015-03-17 22:15:09 +00:00

codec.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

config_options.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

config.c

sorcery/realtime: Add a bit of debug and warning messages for bad configs

2015-07-01 16:33:53 -05:00

core_local.c

Fix compile errors caused by r4500 / r4501.

2015-03-26 23:07:15 +00:00

core_unreal.c

AMI: Add missing VarSet events when a channel inherits variables.

2014-10-17 02:41:34 +00:00

crypt.c

…

cygload.c

…

data.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

datastore.c

…

db.c

AMI: Make AMI actions that generate event lists consistent.

2015-01-09 17:54:49 +00:00

devicestate.c

main/devicestate: Prevent duplicate registration of device state providers

2015-07-11 10:24:39 -05:00

dial.c

Detect potential forwarding loops based on count.

2015-04-17 15:57:10 -05:00

dns.c

Clean up files that do not end with newlines

2014-08-21 14:52:06 +00:00

dnsmgr.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

dsp.c

res_pjsip: Add an 'auto' option for DTMF Mode

2015-04-10 17:53:44 +00:00

ecdisa.h

…

endpoints.c

Revert "endpoint/stasis: Eliminate duplicate events on endpoint status change"

2015-05-29 14:52:23 -05:00

enum.c

clang compiler warnings: Fix autological comparisons

2015-04-09 12:56:30 +00:00

event.c

Clang: change previous tautological-compare fixes.

2015-04-23 18:26:55 +02:00

features_config.c

Allow for transferer to retry when dialing an invalid extension.

2014-11-17 16:51:16 +00:00

features.c

Remove unneeded uses of optional_api providers.

2015-05-02 20:25:11 -04:00

file.c

app_playback: Suppress warnings on playback if channel hung up

2015-05-20 18:05:20 -06:00

fixedjitterbuf.c

…

fixedjitterbuf.h

…

format_cache.c

format_cache.c: Add missing slin12 format to ast_format_cache_is_slinear().

2015-04-08 16:23:00 +00:00

format_cap.c

main/format_cap: Parse capabilities generated by ast_format_cap_get_names

2015-07-12 17:54:48 -05:00

format_compatibility.c

chan_iax2: Several media format fixes.

2014-08-07 18:51:16 +00:00

format.c

Format Interfaces: Prevent unload except by shutdown.

2015-05-03 22:08:14 -04:00

frame.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

framehook.c

clang compiler warnings: Fix format specified in framehook

2015-04-06 17:52:13 +00:00

fskmodem_float.c

…

fskmodem_int.c

…

fskmodem.c

…

global_datastores.c

Detect potential forwarding loops based on count.

2015-04-17 15:57:10 -05:00

hashtab.c

Improved and portable ast_log recursion avoidance

2015-03-27 07:09:26 +00:00

heap.c

Fix incorrect usages of ast_realloc().

2013-09-10 18:05:47 +00:00

http.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

image.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

indications.c

clang compiler warnings: Fix autological comparisons

2015-04-09 12:56:30 +00:00

io.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:49:26 +00:00

jitterbuf.c

clang compiler warnings: Fix -Wabsolute-value warnings

2015-03-30 02:44:57 +00:00

json.c

ARI: Fix crash if integer values used in JSON payload 'variables' object.

2015-02-27 18:23:22 +00:00

libasteriskssl.c

tcptls: Avoiding ERR_remove_state in OpenSSL.

2015-05-08 08:34:22 -05:00

libasteriskssl.exports.in

…

loader.c

ARI: Added new functionality to get information on a single module.

2015-07-13 14:27:40 -05:00

lock.c

DEBUG_THREADS: Fix regression and lock tracking initialization problems.

2014-12-12 23:40:50 +00:00

logger.c

Logger: Reset defaults before processing config.

2015-05-20 21:22:34 -05:00

Makefile

Fixes for OS X

2015-06-02 16:27:51 -05:00

manager_bridges.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

manager_channels.c

AMI: Add Linkedid to the standard channel snapshot AMI event headers.

2015-06-25 11:17:09 -05:00

manager_endpoints.c

res_pjsip: Add AMI events for chan_pjsip contact lifecycle changes

2015-05-26 15:32:45 -06:00

manager_mwi.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

manager_system.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

manager.c

main/manager.c: Bugfix sort action_manager by alphabetically

2015-05-13 10:46:20 -05:00

max_forwards.c

Detect potential forwarding loops based on count.

2015-04-17 15:57:10 -05:00

md5.c

…

media_index.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

message.c

Message.c: Clear message channel frames on cleanup

2015-05-13 17:41:16 -05:00

mixmonitor.c

…

named_acl.c

acl: Fix reloading of configuration if configuration file does not exist at startup.

2014-12-20 20:57:19 +00:00

netsock2.c

Audit ast_sockaddr_resolve() usage for memory leaks.

2015-03-17 21:49:30 +00:00

netsock.c

Move eid functions to utils.c, mark netsock.h deprecated

2014-06-24 02:50:15 +00:00

optional_api.c

Logger/CLI/etc.: Fix some aesthetic issues; reduce chatty verbose messages

2014-05-28 22:54:12 +00:00

parking.c

res_pjsip_refer: Fix bugs involving Parking/PJSIP/transfers

2014-05-22 15:52:30 +00:00

pbx.c

main/pbx: Resolve case sensitivity regression in PBX hints

2015-06-26 21:03:40 -05:00

pickup.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

plc.c

…

poll.c

…

presencestate.c

AMI: Escape string values.

2015-06-03 14:03:18 -05:00

privacy.c

…

rtp_engine.c

rtp_engine: Skip useless self-assignment in ast_rtp_engine_unload_format.

2015-07-02 06:18:58 -05:00

say.c

app_voicemail, say: Add support for Japanese Language

2014-06-30 04:00:19 +00:00

sched.c

chan_iax2: Prevent deadlock between hangup and sending lagrq/ping

2015-06-10 12:05:43 -05:00

sdp_srtp.c

main/sdp_srtp.c: allow SDP crypto tag to be up to 9 digits

2015-05-20 09:00:30 -05:00

security_events.c

Clang: change previous tautological-compare fixes.

2015-04-23 18:26:55 +02:00

sem.c

Various fixes for OS X

2015-01-26 14:49:32 +00:00

sha1.c

…

sip_api.c

…

slinfactory.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

smoother.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

sorcery.c

main/sorcery: Provide log messages when a wizard does not support an operation

2015-07-14 19:15:13 -05:00

sounds_index.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

srv.c

…

stasis_bridges.c

core: Don't create snapshots with locks.

2015-03-10 23:09:17 +00:00

stasis_cache_pattern.c

Revert "endpoint/stasis: Eliminate duplicate events on endpoint status change"

2015-05-29 14:52:23 -05:00

stasis_cache.c

main/stasis: Allow subscriptions to use a threadpool for message delivery

2014-12-01 17:57:12 +00:00

stasis_channels.c

AMI: Escape string values.

2015-06-03 14:03:18 -05:00

stasis_endpoints.c

res_pjsip: Add AMI events for chan_pjsip contact lifecycle changes

2015-05-26 15:32:45 -06:00

stasis_message_router.c

res_pjsip: make it unloadable (take 2)

2015-01-27 19:08:44 +00:00

stasis_message.c

Stasis: Allow message types to be blocked

2014-08-06 12:55:28 +00:00

stasis_system.c

Stasis: Allow message types to be blocked

2014-08-06 12:55:28 +00:00

stasis.c

Stasis: Fix unsafe use of stasis_unsubscribe in modules.

2015-05-22 22:58:32 -04:00

strcompat.c

…

strings.c

clang compiler warnings: Fix invalid enum conversion

2015-03-30 02:39:18 +00:00

stun.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

syslog.c

main/syslog: Allow dynamic logs, such as security events, to log to the syslog

2015-01-12 18:01:24 +00:00

taskprocessor.c

taskprocessor.c: Remove extra unref from off-nominal path.

2015-06-10 13:12:09 -05:00

tcptls.c

tcptls: Avoiding ERR_remove_state in OpenSSL.

2015-05-08 08:34:22 -05:00

tdd.c

…

term.c

term: send proper reset sequence when black background is forced

2015-05-03 09:41:15 -05:00

test.c

test.c: Add unit test registration checks for summary and description.

2015-06-24 17:12:19 -05:00

threadpool.c

res_pjsip: Need to use the same serializer for a pjproject SIP transaction.

2015-07-06 12:52:36 -05:00

threadstorage.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

timing.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

translate.c

translate.c: Only select audio codecs to determine the best translation choice.

2015-04-10 16:28:50 +00:00

udptl.c

clang compiler warnings: Fix autological comparisons

2015-04-09 12:56:30 +00:00

ulaw.c

…

uri.c

uri: Quiet warning about type qualifiers ignored on function return type

2014-08-21 14:39:27 +00:00

utils.c

strings.h: Fix issues with escape string functions.

2015-07-15 19:56:32 -05:00

uuid.c

Fix printf problems with high ascii characters after r413586 (1.8).

2014-12-17 09:54:00 +00:00

xml.c

Detect and use xsltCleanupGlobals when available

2013-10-03 18:00:15 +00:00

xmldoc.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00