Refactor upgrade and verify commands.

app/Console/Commands/Correction/FixUnevenAmount.php

@@ -0,0 +1,99 @@
+<?php
+/**
+ * FixUnevenAmount.php
+ * Copyright (c) 2019 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace FireflyIII\Console\Commands\Correction;
+
+use DB;
+use FireflyIII\Models\Transaction;
+use FireflyIII\Models\TransactionJournal;
+use Illuminate\Console\Command;
+use stdClass;
+
+/**
+ * Class FixUnevenAmount
+ */
+class FixUnevenAmount extends Command
+{
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Fix journals with uneven amounts.';
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'firefly-iii:fix-uneven-amount';
+
+    /**
+     * Execute the console command.
+     *
+     * @return int
+     */
+    public function handle(): int
+    {
+
+        $count = 0;
+        // get invalid journals
+        $journals = DB::table('transactions')
+                      ->groupBy('transaction_journal_id')
+                      ->whereNull('deleted_at')
+                      ->get(['transaction_journal_id', DB::raw('SUM(amount) AS the_sum')]);
+        /** @var stdClass $entry */
+        foreach ($journals as $entry) {
+            if (0 !== bccomp((string)$entry->the_sum, '0')) {
+                $this->fixJournal((int)$entry->transaction_journal_id);
+                $count++;
+            }
+        }
+        if (0 === $count) {
+            $this->info('Amount integrity OK!');
+        }
+
+        return 0;
+    }
+
+    /**
+     * @param int $param
+     */
+    private function fixJournal(int $param): void
+    {
+        // one of the transactions is bad.
+        $journal = TransactionJournal::find($param);
+        if (!$journal) {
+            return;
+        }
+        /** @var Transaction $source */
+        $source = $journal->transactions()->where('amount', '<', 0)->first();
+        $amount = bcmul('-1', (string)$source->amount);
+
+        // fix amount of destination:
+        /** @var Transaction $destination */
+        $destination         = $journal->transactions()->where('amount', '>', 0)->first();
+        $destination->amount = $amount;
+        $destination->save();
+
+        $this->line(sprintf('Corrected amount in transaction #%d', $param));
+
+    }
+}