🤖 Auto commit for release 'develop' on 2025-11-03

2025-11-15 06:08:16 +00:00 · 2025-11-03 04:30:12 +01:00
parent 7743d16ea1
commit 2852a36712
26 changed files with 41 additions and 38 deletions
--- a/app/Api/V1/Controllers/Models/Account/ListController.php
+++ b/app/Api/V1/Controllers/Models/Account/ListController.php
@@ -38,7 +38,6 @@ use FireflyIII\Transformers\PiggyBankTransformer;
 use FireflyIII\Transformers\TransactionGroupTransformer;
 use FireflyIII\User;
 use Illuminate\Http\JsonResponse;
-use Illuminate\Http\Request;
 use Illuminate\Pagination\LengthAwarePaginator;
 use Illuminate\Support\Collection;
 use League\Fractal\Pagination\IlluminatePaginatorAdapter;
--- a/app/Api/V1/Controllers/Models/Bill/ListController.php
+++ b/app/Api/V1/Controllers/Models/Bill/ListController.php
@@ -37,7 +37,6 @@ use FireflyIII\Transformers\RuleTransformer;
 use FireflyIII\Transformers\TransactionGroupTransformer;
 use FireflyIII\User;
 use Illuminate\Http\JsonResponse;
-use Illuminate\Http\Request;
 use Illuminate\Pagination\LengthAwarePaginator;
 use League\Fractal\Pagination\IlluminatePaginatorAdapter;
 use League\Fractal\Resource\Collection as FractalCollection;
--- a/app/Api/V1/Controllers/Models/Bill/ShowController.php
+++ b/app/Api/V1/Controllers/Models/Bill/ShowController.php
@@ -27,7 +27,6 @@ namespace FireflyIII\Api\V1\Controllers\Models\Bill;
 use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Api\V1\Requests\DateRangeRequest;
 use FireflyIII\Api\V1\Requests\Generic\PaginationDateRangeRequest;
-use FireflyIII\Api\V1\Requests\PaginationRequest;
 use FireflyIII\Models\Bill;
 use FireflyIII\Repositories\Bill\BillRepositoryInterface;
 use FireflyIII\Support\JsonApi\Enrichments\SubscriptionEnrichment;
--- a/app/Api/V1/Requests/AggregateFormRequest.php
+++ b/app/Api/V1/Requests/AggregateFormRequest.php
@@ -23,7 +23,6 @@ declare(strict_types=1);

 namespace FireflyIII\Api\V1\Requests;

-use FireflyIII\Exceptions\FireflyException;
 use Illuminate\Foundation\Http\FormRequest;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Log;
--- a/app/Api/V1/Requests/Autocomplete/AutocompleteApiRequest.php
+++ b/app/Api/V1/Requests/Autocomplete/AutocompleteApiRequest.php
@@ -27,7 +27,6 @@ use FireflyIII\Api\V1\Requests\AggregateFormRequest;
 use FireflyIII\Api\V1\Requests\DateRequest;
 use FireflyIII\Api\V1\Requests\Generic\ObjectTypeApiRequest;
 use FireflyIII\Api\V1\Requests\Generic\QueryRequest;
-use FireflyIII\Api\V1\Requests\Models\Account\AccountTypesApiRequest;
 use FireflyIII\Api\V1\Requests\PaginationRequest;
 use FireflyIII\Models\Account;
 use Override;
--- a/app/Api/V1/Requests/Generic/ObjectTypeApiRequest.php
+++ b/app/Api/V1/Requests/Generic/ObjectTypeApiRequest.php
@@ -66,6 +66,7 @@ class ObjectTypeApiRequest extends ApiRequest
        if ('' !== $this->required) {
            $rules['types'][] = $this->required;
        }
+
        return $rules;
    }

@@ -78,14 +79,20 @@ class ObjectTypeApiRequest extends ApiRequest
                }
                $type = $this->convertString('types', 'all');
                $this->attributes->set('type', $type);
+
                switch ($this->objectType) {
                    default:
                        $this->attributes->set('types', []);
+
+                        // no break
                    case Account::class:
                        $this->attributes->set('types', $this->mapAccountTypes($type));
+
                        break;
+
                    case Transaction::class:
                        $this->attributes->set('types', $this->mapTransactionTypes($type));
+
                        break;
                }
            }
--- a/app/Api/V1/Requests/Generic/PaginationDateRangeRequest.php
+++ b/app/Api/V1/Requests/Generic/PaginationDateRangeRequest.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types=1);
 /*
 * PaginationDateRangeRequest.php
 * Copyright (c) 2025 james@firefly-iii.org
--- a/app/Factory/CategoryFactory.php
+++ b/app/Factory/CategoryFactory.php
@@ -28,6 +28,7 @@ use FireflyIII\Models\Category;
 use FireflyIII\User;
 use Illuminate\Database\QueryException;
 use Illuminate\Support\Facades\Log;
+
 /**
 * Class CategoryFactory
 */
--- a/app/Factory/PiggyBankFactory.php
+++ b/app/Factory/PiggyBankFactory.php
@@ -38,6 +38,7 @@ use Illuminate\Database\QueryException;
 use Illuminate\Support\Facades\Log;

 use function Safe\json_encode;
+
 /**
 * Class PiggyBankFactory
 */
--- a/app/Handlers/Events/AdminEventHandler.php
+++ b/app/Handlers/Events/AdminEventHandler.php
@@ -38,7 +38,6 @@ use FireflyIII\Notifications\Test\OwnerTestNotificationSlack;
 use Illuminate\Support\Facades\Log;
 use Illuminate\Support\Facades\Notification;

-
 /**
 * Class AdminEventHandler.
 */
--- a/app/Handlers/Events/UserEventHandler.php
+++ b/app/Handlers/Events/UserEventHandler.php
@@ -58,7 +58,6 @@ use Illuminate\Support\Facades\Log;
 use Illuminate\Support\Facades\Mail;
 use Illuminate\Support\Facades\Notification;

-
 /**
 * Class UserEventHandler.
 *
--- a/app/Handlers/Observer/AccountObserver.php
+++ b/app/Handlers/Observer/AccountObserver.php
@@ -36,7 +36,6 @@ use FireflyIII\Support\Http\Api\ExchangeRateConverter;
 use Illuminate\Support\Facades\DB;
 use Illuminate\Support\Facades\Log;

-
 /**
 * Class AccountObserver
 */
--- a/app/Handlers/Observer/BillObserver.php
+++ b/app/Handlers/Observer/BillObserver.php
@@ -30,7 +30,6 @@ use FireflyIII\Support\Facades\Amount;
 use FireflyIII\Support\Http\Api\ExchangeRateConverter;
 use Illuminate\Support\Facades\Log;

-
 /**
 * Class BillObserver
 */
--- a/app/Handlers/Observer/PiggyBankObserver.php
+++ b/app/Handlers/Observer/PiggyBankObserver.php
@@ -30,7 +30,6 @@ use FireflyIII\Repositories\Attachment\AttachmentRepositoryInterface;
 use FireflyIII\Support\Http\Api\ExchangeRateConverter;
 use Illuminate\Support\Facades\Log;

-
 /**
 * Class PiggyBankObserver
 */
--- a/app/Handlers/Observer/WebhookMessageObserver.php
+++ b/app/Handlers/Observer/WebhookMessageObserver.php
@@ -25,6 +25,7 @@ namespace FireflyIII\Handlers\Observer;

 use FireflyIII\Models\WebhookMessage;
 use Illuminate\Support\Facades\Log;
+
 /**
 * Class WebhookMessageObserver
 */
--- a/app/Handlers/Observer/WebhookObserver.php
+++ b/app/Handlers/Observer/WebhookObserver.php
@@ -25,6 +25,7 @@ namespace FireflyIII\Handlers\Observer;

 use FireflyIII\Models\Webhook;
 use Illuminate\Support\Facades\Log;
+
 /**
 * Class WebhookObserver
 */
--- a/app/Helpers/Collector/Extensions/AttachmentCollection.php
+++ b/app/Helpers/Collector/Extensions/AttachmentCollection.php
@@ -30,6 +30,7 @@ use FireflyIII\Models\TransactionJournal;
 use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Database\Eloquent\Builder as EloquentBuilder;
 use Illuminate\Support\Facades\Log;
+
 /**
 * Trait AttachmentCollection
 */
--- a/app/Helpers/Webhook/Sha3SignatureGenerator.php
+++ b/app/Helpers/Webhook/Sha3SignatureGenerator.php
@@ -28,9 +28,9 @@ use Carbon\Carbon;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Models\WebhookMessage;
 use JsonException;
+use Illuminate\Support\Facades\Log;

 use function Safe\json_encode;
-use Illuminate\Support\Facades\Log;

 /**
 * Class Sha3SignatureGenerator
--- a/app/Models/BudgetLimit.php
+++ b/app/Models/BudgetLimit.php
@@ -39,7 +39,7 @@ use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 *
 * @property TransactionCurrency $transactionCurrency
 * @property Carbon              $start_date
- * @property Carbon|null              $end_date
+ * @property null|Carbon         $end_date
 */
 #[ObservedBy([BudgetLimitObserver::class])]
 class BudgetLimit extends Model
--- a/app/Rules/IsAllowedGroupAction.php
+++ b/app/Rules/IsAllowedGroupAction.php
@@ -72,7 +72,6 @@ class IsAllowedGroupAction implements ValidationRule
        $this->validateUserGroup((int)$value, $fail);
    }

-
    private function validateUserGroup(int $userGroupId, Closure $fail): void
    {
        try {
@@ -80,7 +79,8 @@ class IsAllowedGroupAction implements ValidationRule
        } catch (FireflyException $e) {
            Log::error($e->getTraceAsString());
        }
-        die('here we are');
+
+        exit('here we are');
        Log::debug(sprintf('validateUserGroup: %s', static::class));
        if (!auth()->check()) {
            Log::debug('validateUserGroup: user is not logged in, return NULL.');
--- a/app/Support/Http/Api/ValidatesUserGroupTrait.php
+++ b/app/Support/Http/Api/ValidatesUserGroupTrait.php
@@ -25,7 +25,6 @@ declare(strict_types=1);
 namespace FireflyIII\Support\Http\Api;

 use FireflyIII\Enums\UserRoleEnum;
-use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Models\UserGroup;
 use FireflyIII\Repositories\UserGroup\UserGroupRepositoryInterface;
 use FireflyIII\User;
--- a/config/firefly.php
+++ b/config/firefly.php
@@ -78,8 +78,8 @@ return [
        'running_balance_column' => env('USE_RUNNING_BALANCE', false),
        // see cer.php for exchange rates feature flag.
    ],
-    'version'                      => 'develop/2025-11-02',
-    'build_time'                   => 1762056298,
+    'version'                      => 'develop/2025-11-03',
+    'build_time'                   => 1762140500,
    'api_version'                  => '2.1.0', // field is no longer used.
    'db_version'                   => 28, // field is no longer used.

--- a/package-lock.json
+++ b/package-lock.json
@@ -3173,9 +3173,9 @@
            "license": "MIT"
        },
        "node_modules/@types/node": {
-            "version": "24.9.2",
-            "resolved": "https://registry.npmjs.org/@types/node/-/node-24.9.2.tgz",
-            "integrity": "sha512-uWN8YqxXxqFMX2RqGOrumsKeti4LlmIMIyV0lgut4jx7KQBcBiW6vkDtIBvHnHIquwNfJhk8v2OtmO8zXWHfPA==",
+            "version": "24.10.0",
+            "resolved": "https://registry.npmjs.org/@types/node/-/node-24.10.0.tgz",
+            "integrity": "sha512-qzQZRBqkFsYyaSWXuEHc2WR9c0a0CXwiE5FWUvn7ZM+vdy1uZLfCunD38UzhuB7YN/J11ndbDBcTmOdxJo9Q7A==",
            "dev": true,
            "license": "MIT",
            "dependencies": {
@@ -4521,9 +4521,9 @@
            }
        },
        "node_modules/caniuse-lite": {
-            "version": "1.0.30001752",
-            "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001752.tgz",
-            "integrity": "sha512-vKUk7beoukxE47P5gcVNKkDRzXdVofotshHwfR9vmpeFKxmI5PBpgOMC18LUJUA/DvJ70Y7RveasIBraqsyO/g==",
+            "version": "1.0.30001753",
+            "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001753.tgz",
+            "integrity": "sha512-Bj5H35MD/ebaOV4iDLqPEtiliTN29qkGtEHCwawWn4cYm+bPJM2NsaP30vtZcnERClMzp52J4+aw2UNbK4o+zw==",
            "dev": true,
            "funding": [
                {
@@ -5820,9 +5820,9 @@
            }
        },
        "node_modules/envinfo": {
-            "version": "7.19.0",
-            "resolved": "https://registry.npmjs.org/envinfo/-/envinfo-7.19.0.tgz",
-            "integrity": "sha512-DoSM9VyG6O3vqBf+p3Gjgr/Q52HYBBtO3v+4koAxt1MnWr+zEnxE+nke/yXS4lt2P4SYCHQ4V3f1i88LQVOpAw==",
+            "version": "7.20.0",
+            "resolved": "https://registry.npmjs.org/envinfo/-/envinfo-7.20.0.tgz",
+            "integrity": "sha512-+zUomDcLXsVkQ37vUqWBvQwLaLlj8eZPSi61llaEFAVBY5mhcXdaSw1pSJVl4yTYD5g/gEfpNl28YYk4IPvrrg==",
            "dev": true,
            "license": "MIT",
            "bin": {