kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-12-18 12:28:46 +00:00
Code Issues Projects Releases Wiki Activity

Update find methods to return null

Browse Source
This commit is contained in:
James Cole
2018-02-16 15:19:19 +01:00
parent 28b00f6507
commit 33db99ffd3
16 changed files with 142 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
app/Repositories/Budget/BudgetRepository.php
View File

@@ -194,9 +194,9 @@ class BudgetRepository implements BudgetRepositoryInterface
*
* @param string $name
*
* @return Budget
* @return Budget|null
*/
public function findByName(string $name): Budget
public function findByName(string $name): ?Budget
{
$budgets = $this->user->budgets()->get(['budgets.*']);
/** @var Budget $budget */
@@ -206,7 +206,19 @@ class BudgetRepository implements BudgetRepositoryInterface
}
}
return new Budget;
return null;
}
/**
* Find a budget or return NULL
*
* @param int $budgetId
*
* @return Budget|null
*/
public function findNull(int $budgetId): ?Budget
{
return $this->user->budgets()->find($budgetId);
}
/**

14
app/Repositories/Budget/BudgetRepositoryInterface.php
View File

@@ -73,19 +73,29 @@ interface BudgetRepositoryInterface
* Find a budget.
*
* @param int $budgetId
* @deprecated
*
* @return Budget
*/
public function find(int $budgetId): Budget;
/**
* Find a budget or return NULL
*
* @param int $budgetId
*
* @return Budget|null
*/
public function findNull(int $budgetId): ?Budget;
/**
* Find a budget.
*
* @param string $name
*
* @return Budget
* @return Budget|null
*/
public function findByName(string $name): Budget;
public function findByName(string $name): ?Budget;
/**
* This method returns the oldest journal or transaction date known to this budget.