From 34e2595a3deff43462af7d16eb51153f399a5d14 Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 11 Sep 2020 20:29:30 +0200 Subject: [PATCH] Make sure you can't set negative amounts. --- app/Http/Controllers/Budget/AvailableBudgetController.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Http/Controllers/Budget/AvailableBudgetController.php b/app/Http/Controllers/Budget/AvailableBudgetController.php index 94994bfdf3..6c2d9cdd69 100644 --- a/app/Http/Controllers/Budget/AvailableBudgetController.php +++ b/app/Http/Controllers/Budget/AvailableBudgetController.php @@ -185,7 +185,7 @@ class AvailableBudgetController extends Controller return redirect(route('budgets.index', [$start->format('Y-m-d'), $end->format('Y-m-d')])); } - if (0 === bccomp('0', $amount)) { + if (bccomp($amount, '0') <= 0) { session()->flash('error', trans('firefly.invalid_amount')); return redirect(route('budgets.index', [$start->format('Y-m-d'), $end->format('Y-m-d')])); @@ -238,7 +238,7 @@ class AvailableBudgetController extends Controller return redirect(route('budgets.index', [$start->format('Y-m-d'), $end->format('Y-m-d')])); } - if (0 === bccomp('0', $amount)) { + if (bccomp($amount, '0') <= 0) { session()->flash('error', trans('firefly.invalid_amount')); return redirect(route('budgets.index', [$start->format('Y-m-d'), $end->format('Y-m-d')]));