Code cleanup.

This commit is contained in:
James Cole
2014-12-13 21:59:02 +01:00
parent c77b43458e
commit 3cfa3f3b27
67 changed files with 651 additions and 177 deletions

View File

@@ -4,10 +4,18 @@ namespace FireflyIII\Shared\Facade;
use Illuminate\Support\Facades\Facade;
/**
* Class DateKit
*
* @package FireflyIII\Shared\Facade
*/
class DateKit extends Facade
{
/**
* @return string
*/
protected static function getFacadeAccessor()
{
return 'datekit';

View File

@@ -4,10 +4,18 @@ namespace FireflyIII\Shared\Facade;
use Illuminate\Support\Facades\Facade;
/**
* Class FFForm
*
* @package FireflyIII\Shared\Facade
*/
class FFForm extends Facade
{
/**
* @return string
*/
protected static function getFacadeAccessor()
{
return 'ffform';

View File

@@ -4,10 +4,18 @@ namespace FireflyIII\Shared\Facade;
use Illuminate\Support\Facades\Facade;
/**
* Class Filter
*
* @package FireflyIII\Shared\Facade
*/
class Filter extends Facade
{
/**
* @return string
*/
protected static function getFacadeAccessor()
{
return 'filter';

View File

@@ -4,10 +4,18 @@ namespace FireflyIII\Shared\Facade;
use Illuminate\Support\Facades\Facade;
/**
* Class Navigation
*
* @package FireflyIII\Shared\Facade
*/
class Navigation extends Facade
{
/**
* @return string
*/
protected static function getFacadeAccessor()
{
return 'navigation';

View File

@@ -4,10 +4,18 @@ namespace FireflyIII\Shared\Facade;
use Illuminate\Support\Facades\Facade;
/**
* Class Reminders
*
* @package FireflyIII\Shared\Facade
*/
class Reminders extends Facade
{
/**
* @return string
*/
protected static function getFacadeAccessor()
{
return 'reminders';

View File

@@ -4,10 +4,18 @@ namespace FireflyIII\Shared\Facade;
use Illuminate\Support\Facades\Facade;
/**
* Class Steam
*
* @package FireflyIII\Shared\Facade
*/
class Steam extends Facade
{
/**
* @return string
*/
protected static function getFacadeAccessor()
{
return 'steam';

View File

@@ -1,5 +1,6 @@
<?php
namespace FireflyIII\Shared\Mail;
use Swift_RfcComplianceException;
/**
@@ -28,10 +29,11 @@ class Registration implements RegistrationInterface
try {
\Mail::send(
['emails.user.register-html', 'emails.user.register-text'], $data, function ($message) use ($email) {
$message->to($email, $email)->subject('Welcome to Firefly!');
}
$message->to($email, $email)->subject('Welcome to Firefly!');
}
);
} catch(Swift_RfcComplianceException $e) {}
} catch (Swift_RfcComplianceException $e) {
}
}
/**
@@ -49,8 +51,8 @@ class Registration implements RegistrationInterface
$data = ['reset' => $reset];
\Mail::send(
['emails.user.remindme-html', 'emails.user.remindme-text'], $data, function ($message) use ($email) {
$message->to($email, $email)->subject('Forgot your password?');
}
$message->to($email, $email)->subject('Forgot your password?');
}
);
@@ -72,8 +74,8 @@ class Registration implements RegistrationInterface
\Mail::send(
['emails.user.verify-html', 'emails.user.verify-text'], $data, function ($message) use ($email) {
$message->to($email, $email)->subject('Verify your e-mail address.');
}
$message->to($email, $email)->subject('Verify your e-mail address.');
}
);
}

View File

@@ -13,13 +13,10 @@ abstract class SingleTableInheritanceEntity extends \Eloquent
*
* @var bool
*/
protected $isSubclass = false;
/**
* The field that stores the subclass
*
* @var string
*/
// @codingStandardsIgnoreStart
protected $isSubclass = false;
protected $subclassField = null;
// @codingStandardsIgnoreEnd
/**
* @param array $attributes
@@ -77,9 +74,8 @@ abstract class SingleTableInheritanceEntity extends \Eloquent
*
* @return bool
*/
public function save(
array $rules = [], array $customMessages = [], array $options = [], \Closure $beforeSave = null, \Closure $afterSave = null
) {
public function save(array $rules = [], array $customMessages = [], array $options = [], \Closure $beforeSave = null, \Closure $afterSave = null)
{
if ($this->subclassField) {
$this->attributes[$this->subclassField] = get_class($this);
}

View File

@@ -143,6 +143,13 @@ class Date
return $currentEnd;
}
/**
* @param Carbon $date
* @param $repeatFrequency
*
* @return string
* @throws FireflyException
*/
public function periodShow(Carbon $date, $repeatFrequency)
{
switch ($repeatFrequency) {
@@ -216,12 +223,13 @@ class Date
}
/**
* @param Carbon $date
* @param Carbon $theDate
* @param $repeatFreq
* @param int $subtract
*
* @return Carbon
* @throws FireflyException
* @internal param Carbon $date
*/
public function subtractPeriod(Carbon $theDate, $repeatFreq, $subtract = 1)
{

View File

@@ -10,6 +10,13 @@ use Illuminate\Validation\Validator;
*/
class FireflyValidator extends Validator
{
/**
* @param $attribute
* @param $value
* @param $parameters
*
* @return bool
*/
public function validateAlphabasic($attribute, $value, $parameters)
{
$pattern = '/[^[:alnum:]_\-\.\& \(\)\'"]/iu';