From 51b11e5188f4b7852a83f5b63e48dfa34ea79355 Mon Sep 17 00:00:00 2001
From: James Cole <thegrumpydictator@gmail.com>
Date: Thu, 9 Aug 2018 20:46:47 +0200
Subject: [PATCH] Can no longer set a budget to an expense.

---
 app/Services/Internal/Update/JournalUpdateService.php | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/app/Services/Internal/Update/JournalUpdateService.php b/app/Services/Internal/Update/JournalUpdateService.php
index df2162636f..d364514dd3 100644
--- a/app/Services/Internal/Update/JournalUpdateService.php
+++ b/app/Services/Internal/Update/JournalUpdateService.php
@@ -26,6 +26,7 @@ namespace FireflyIII\Services\Internal\Update;
 use FireflyIII\Factory\TransactionFactory;
 use FireflyIII\Models\Transaction;
 use FireflyIII\Models\TransactionJournal;
+use FireflyIII\Models\TransactionType;
 use FireflyIII\Services\Internal\Support\JournalServiceTrait;
 use Illuminate\Support\Collection;
 use Log;
@@ -144,10 +145,11 @@ class JournalUpdateService
         /** @var TransactionUpdateService $service */
         $service = app(TransactionUpdateService::class);
         $service->setUser($journal->user);
-
-        /** @var Transaction $transaction */
-        foreach ($journal->transactions as $transaction) {
-            $service->updateBudget($transaction, $budgetId);
+        if (TransactionType::WITHDRAWAL === $journal->transactionType->type) {
+            /** @var Transaction $transaction */
+            foreach ($journal->transactions as $transaction) {
+                $service->updateBudget($transaction, $budgetId);
+            }
         }
 
         return $journal;