Fix code quality with rector [skip ci]

app/Transformers/AbstractTransformer.php

@@ -24,6 +24,7 @@ declare(strict_types=1);
 
 namespace FireflyIII\Transformers;
 
+use Deprecated;
 use League\Fractal\TransformerAbstract;
 use Symfony\Component\HttpFoundation\ParameterBag;
 
@@ -34,17 +35,13 @@ abstract class AbstractTransformer extends TransformerAbstract
 {
     protected ParameterBag $parameters;
 
-    /**
-     * @deprecated
-     */
+    #[Deprecated]
     final public function getParameters(): ParameterBag
     {
         return $this->parameters;
     }
 
-    /**
-     * @deprecated
-     */
+    #[Deprecated]
     final public function setParameters(ParameterBag $parameters): void
     {
         $this->parameters = $parameters;

app/Transformers/BudgetLimitTransformer.php

@@ -51,10 +51,8 @@ class BudgetLimitTransformer extends AbstractTransformer
 
     /**
      * Include Budget
-     *
-     * @return Item
      */
-    public function includeBudget(BudgetLimit $limit)
+    public function includeBudget(BudgetLimit $limit): Item
     {
         // enrich budget
         $budget     = $limit->budget;

app/Transformers/PiggyBankEventTransformer.php

@@ -36,7 +36,7 @@ use FireflyIII\Support\Facades\Steam;
 class PiggyBankEventTransformer extends AbstractTransformer
 {
     private readonly TransactionCurrency $primaryCurrency;
-    private bool                         $convertToPrimary;
+    private readonly bool                         $convertToPrimary;
 
     /**
      * PiggyBankEventTransformer constructor.

app/Transformers/RecurrenceTransformer.php

@@ -32,11 +32,6 @@ use Illuminate\Support\Facades\Log;
  */
 class RecurrenceTransformer extends AbstractTransformer
 {
-    /**
-     * RecurrenceTransformer constructor.
-     */
-    public function __construct() {}
-
     /**
      * Transform the recurring transaction.
      */

app/Transformers/TransactionGroupTransformer.php

@@ -259,12 +259,7 @@ class TransactionGroupTransformer extends AbstractTransformer
 
             return (string) $array[$key];
         }
-
-        if (null !== $default) {
-            return $default;
-        }
-
-        return null;
+        return $default;
     }
 
     /**
@@ -429,7 +424,7 @@ class TransactionGroupTransformer extends AbstractTransformer
     private function getSourceTransaction(TransactionJournal $journal): Transaction
     {
         $result = $journal->transactions->first(
-            static function (Transaction $transaction) {
+            static function (Transaction $transaction): bool {
                 return (float) $transaction->amount < 0; // lame but it works.
             }
         );
@@ -446,7 +441,7 @@ class TransactionGroupTransformer extends AbstractTransformer
     private function getDestinationTransaction(TransactionJournal $journal): Transaction
     {
         $result = $journal->transactions->first(
-            static function (Transaction $transaction) {
+            static function (Transaction $transaction): bool {
                 return (float) $transaction->amount > 0; // lame but it works
             }
         );

app/Transformers/UserGroupTransformer.php

@@ -36,16 +36,9 @@ use Illuminate\Support\Collection;
  */
 class UserGroupTransformer extends AbstractTransformer
 {
-    private array $inUse;
-    private array $memberships;
-    private array $membershipsVisible;
-
-    public function __construct()
-    {
-        $this->memberships        = [];
-        $this->membershipsVisible = [];
-        $this->inUse              = [];
-    }
+    private array $inUse = [];
+    private array $memberships = [];
+    private array $membershipsVisible = [];
 
     public function collectMetaData(Collection $objects): Collection
     {

app/Transformers/WebhookTransformer.php

@@ -31,11 +31,6 @@ use FireflyIII\Models\Webhook;
  */
 class WebhookTransformer extends AbstractTransformer
 {
-    /**
-     * WebhookTransformer constructor.
-     */
-    public function __construct() {}
-
     /**
      * Transform webhook.
      */