From 7852b8a7852299315a81dfc376c740eb6830d1cf Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 25 Nov 2016 16:26:03 +0100 Subject: [PATCH] Make sure ff does not create accounts when balance is said to be 0. --- app/Http/Controllers/NewUserController.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/Http/Controllers/NewUserController.php b/app/Http/Controllers/NewUserController.php index 870b8ac966..3adfdc2973 100644 --- a/app/Http/Controllers/NewUserController.php +++ b/app/Http/Controllers/NewUserController.php @@ -78,14 +78,16 @@ class NewUserController extends Controller $this->createAssetAccount($request, $repository); // create savings account - if (strlen($request->get('savings_balance')) > 0) { + $savingBalance = strval($request->get('savings_balance')) === '' ? '0' : strval($request->get('savings_balance')); + if (bccomp($savingBalance, '0') !== 0) { $this->createSavingsAccount($request, $repository); $count++; } // create credit card. - if (strlen($request->get('credit_card_limit')) > 0) { + $limit = strval($request->get('credit_card_limit')) === '' ? '0' : strval($request->get('credit_card_limit')); + if (bccomp($limit, '0') !== 0) { $this->storeCreditCard($request, $repository); $count++; }