diff --git a/app/lib/FireflyIII/Database/Account/Account.php b/app/lib/FireflyIII/Database/Account/Account.php index 1faa84c220..9fe77ea498 100644 --- a/app/lib/FireflyIII/Database/Account/Account.php +++ b/app/lib/FireflyIII/Database/Account/Account.php @@ -406,6 +406,8 @@ class Account implements CUDInterface, CommonDatabaseCallsInterface, AccountInte } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * @param $what * * @throws NotImplementedException @@ -445,14 +447,14 @@ class Account implements CUDInterface, CommonDatabaseCallsInterface, AccountInte */ public function firstExpenseAccountOrCreate($name) { - /** @var \FireflyIII\Database\AccountType\AccountType $accountTypeRepository */ - $accountTypeRepository = \App::make('FireflyIII\Database\AccountType\AccountType'); + /** @var \FireflyIII\Database\AccountType\AccountType $typeRepository */ + $typeRepository = \App::make('FireflyIII\Database\AccountType\AccountType'); - $accountType = $accountTypeRepository->findByWhat('expense'); + $accountType = $typeRepository->findByWhat('expense'); // if name is "", find cash account: if (strlen($name) == 0) { - $cashAccountType = $accountTypeRepository->findByWhat('cash'); + $cashAccountType = $typeRepository->findByWhat('cash'); // find or create cash account: return \Account::firstOrCreate( @@ -474,10 +476,10 @@ class Account implements CUDInterface, CommonDatabaseCallsInterface, AccountInte */ public function firstRevenueAccountOrCreate($name) { - /** @var \FireflyIII\Database\AccountType\AccountType $accountTypeRepository */ - $accountTypeRepository = \App::make('FireflyIII\Database\AccountType\AccountType'); + /** @var \FireflyIII\Database\AccountType\AccountType $typeRepository */ + $typeRepository = \App::make('FireflyIII\Database\AccountType\AccountType'); - $accountType = $accountTypeRepository->findByWhat('revenue'); + $accountType = $typeRepository->findByWhat('revenue'); $data = ['user_id' => $this->getUser()->id, 'account_type_id' => $accountType->id, 'name' => $name, 'active' => 1]; diff --git a/app/lib/FireflyIII/Database/AccountType/AccountType.php b/app/lib/FireflyIII/Database/AccountType/AccountType.php index 58f6cebb13..30a9c2bcc6 100644 --- a/app/lib/FireflyIII/Database/AccountType/AccountType.php +++ b/app/lib/FireflyIII/Database/AccountType/AccountType.php @@ -19,6 +19,7 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface /** * @param Eloquent $model + * @SuppressWarnings(PHPMD.UnusedFormalParameter) * * @return bool * @throws NotImplementedException @@ -30,6 +31,7 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface /** * @param array $data + * @SuppressWarnings(PHPMD.UnusedFormalParameter) * * @return \Eloquent * @throws NotImplementedException @@ -42,6 +44,7 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface /** * @param Eloquent $model * @param array $data + * @SuppressWarnings(PHPMD.UnusedFormalParameter) * * @return bool * @throws NotImplementedException @@ -52,6 +55,8 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * Validates an array. Returns an array containing MessageBags * errors/warnings/successes. * @@ -66,6 +71,8 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * Returns an object with id $id. * * @param int $objectId @@ -88,30 +95,22 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface */ public function findByWhat($what) { - switch ($what) { - case 'expense': - return \AccountType::whereType('Expense account')->first(); - break; - case 'asset': - return \AccountType::whereType('Asset account')->first(); - break; - case 'revenue': - return \AccountType::whereType('Revenue account')->first(); - break; - case 'cash': - return \AccountType::whereType('Cash account')->first(); - break; - case 'initial': - return \AccountType::whereType('Initial balance account')->first(); - break; - default: - throw new FireflyException('Cannot find account type described as "' . e($what) . '".'); - break; - + $typeMap = [ + 'expense' => 'Expense account', + 'asset' => 'Asset account', + 'revenue' => 'Revenue account', + 'cash' => 'Cash account', + 'initial' => 'Initial balance account', + ]; + if (isset($typeMap[$what])) { + return \AccountType::whereType($typeMap[$what])->first(); } + throw new FireflyException('Cannot find account type described as "' . e($what) . '".'); } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * Returns all objects. * * @return Collection @@ -123,6 +122,8 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * @param array $ids * * @return Collection diff --git a/app/lib/FireflyIII/Database/Bill/Bill.php b/app/lib/FireflyIII/Database/Bill/Bill.php index 9c9683b7cf..e987d4abc7 100644 --- a/app/lib/FireflyIII/Database/Bill/Bill.php +++ b/app/lib/FireflyIII/Database/Bill/Bill.php @@ -133,6 +133,8 @@ class Bill implements CUDInterface, CommonDatabaseCallsInterface, BillInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * Returns an object with id $id. * * @param int $objectId @@ -146,6 +148,8 @@ class Bill implements CUDInterface, CommonDatabaseCallsInterface, BillInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * Finds an account type using one of the "$what"'s: expense, asset, revenue, opening, etc. * * @param $what @@ -169,6 +173,7 @@ class Bill implements CUDInterface, CommonDatabaseCallsInterface, BillInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) * @param array $ids * * @return Collection @@ -205,15 +210,14 @@ class Bill implements CUDInterface, CommonDatabaseCallsInterface, BillInterface } /** + * @SuppressWarnings("CyclomaticComplexity") // It's exactly 5. So I don't mind. + * * @param \Bill $bill * * @return Carbon|null */ public function nextExpectedMatch(\Bill $bill) { - /* - * The date Firefly tries to find. If this stays null, it's "unknown". - */ $finalDate = null; if ($bill->active == 0) { return $finalDate; @@ -225,10 +229,6 @@ class Bill implements CUDInterface, CommonDatabaseCallsInterface, BillInterface */ $today = \DateKit::addPeriod(new Carbon, $bill->repeat_freq, 0); - /* - * FF3 loops from the $start of the bill, and to make sure - * $skip works, it adds one (for modulo). - */ $skip = $bill->skip + 1; $start = \DateKit::startOfPeriod(new Carbon, $bill->repeat_freq); /* diff --git a/app/lib/FireflyIII/Database/Budget/Budget.php b/app/lib/FireflyIII/Database/Budget/Budget.php index aaf6eabe3c..f437879e87 100644 --- a/app/lib/FireflyIII/Database/Budget/Budget.php +++ b/app/lib/FireflyIII/Database/Budget/Budget.php @@ -175,6 +175,8 @@ class Budget implements CUDInterface, CommonDatabaseCallsInterface, BudgetInterf } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * Finds an account type using one of the "$what"'s: expense, asset, revenue, opening, etc. * * @param $what @@ -200,6 +202,8 @@ class Budget implements CUDInterface, CommonDatabaseCallsInterface, BudgetInterf } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * @param array $ids * * @return Collection diff --git a/app/lib/FireflyIII/Database/Category/Category.php b/app/lib/FireflyIII/Database/Category/Category.php index 14d8b64da3..a4a8dc0137 100644 --- a/app/lib/FireflyIII/Database/Category/Category.php +++ b/app/lib/FireflyIII/Database/Category/Category.php @@ -99,6 +99,8 @@ class Category implements CUDInterface, CommonDatabaseCallsInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * Returns an object with id $id. * * @param int $objectId @@ -112,6 +114,8 @@ class Category implements CUDInterface, CommonDatabaseCallsInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * Finds an account type using one of the "$what"'s: expense, asset, revenue, opening, etc. * * @param $what @@ -125,6 +129,8 @@ class Category implements CUDInterface, CommonDatabaseCallsInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * Returns all objects. * * @return Collection @@ -135,6 +141,8 @@ class Category implements CUDInterface, CommonDatabaseCallsInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * @param array $ids * * @return Collection diff --git a/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php b/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php index 5a878e37f4..1d5fa492aa 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php +++ b/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php @@ -58,6 +58,8 @@ class PiggyBankShared } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * Finds an account type using one of the "$what"'s: expense, asset, revenue, opening, etc. * * @param $what @@ -123,6 +125,8 @@ class PiggyBankShared /** + * @SuppressWarnings("CyclomaticComplexity") // It's exactly 5. So I don't mind. + * * @param Eloquent $model * @param array $data * diff --git a/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php b/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php index 171b4c7a88..bf22ca509c 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php +++ b/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php @@ -17,6 +17,8 @@ class RepeatedExpense extends PiggyBankShared implements CUDInterface, CommonDat { /** + * @SuppressWarnings("CyclomaticComplexity") // It's exactly 5. So I don't mind. + * * Based on the piggy bank, the reminder-setting and * other variables this method tries to divide the piggy bank into equal parts. Each is * accommodated by a reminder (if everything goes to plan). diff --git a/app/lib/FireflyIII/Database/Transaction/Transaction.php b/app/lib/FireflyIII/Database/Transaction/Transaction.php index a92f110d2e..6880999fb7 100644 --- a/app/lib/FireflyIII/Database/Transaction/Transaction.php +++ b/app/lib/FireflyIII/Database/Transaction/Transaction.php @@ -22,6 +22,7 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface /** * @param Eloquent $model + * @SuppressWarnings(PHPMD.UnusedFormalParameter) * * @return bool * @throws NotImplementedException @@ -59,6 +60,8 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * @param Eloquent $model * @param array $data * @@ -92,6 +95,8 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * Returns an object with id $id. * * @param int $objectId @@ -105,6 +110,8 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * Finds an account type using one of the "$what"'s: expense, asset, revenue, opening, etc. * * @param $what @@ -129,6 +136,8 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * @param array $ids * * @return Collection diff --git a/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php b/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php index 55b7c5f502..fc72379da4 100644 --- a/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php +++ b/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php @@ -89,6 +89,8 @@ class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabas } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * Returns an object with id $id. * * @param int $objectId @@ -102,6 +104,8 @@ class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabas } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * Finds an account type using one of the "$what"'s: expense, asset, revenue, opening, etc. * * @param $what @@ -125,6 +129,8 @@ class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabas } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * @param array $objectIds * @throws NotImplementedException * diff --git a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php index 60f74c1415..10015a1afb 100644 --- a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php +++ b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php @@ -210,6 +210,8 @@ class TransactionJournal implements TransactionJournalInterface, CUDInterface, C } /** + * @SuppressWarnings("CyclomaticComplexity") // It's exactly 5. So I don't mind. + * * @param array $data * * @return array @@ -321,6 +323,8 @@ class TransactionJournal implements TransactionJournalInterface, CUDInterface, C } /** + * @SuppressWarnings("CamelCase") // I'm fine with this. + * * @param array $model * * @return MessageBag @@ -340,6 +344,8 @@ class TransactionJournal implements TransactionJournalInterface, CUDInterface, C } /** + * @SuppressWarnings("CamelCase") // I'm fine with this. + * * @param array $model * * @return MessageBag @@ -358,6 +364,8 @@ class TransactionJournal implements TransactionJournalInterface, CUDInterface, C } /** + * @SuppressWarnings("CamelCase") // I'm fine with this. + * * @param array $model * * @return MessageBag @@ -412,6 +420,8 @@ class TransactionJournal implements TransactionJournalInterface, CUDInterface, C } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * Finds an account type using one of the "$what"'s: expense, asset, revenue, opening, etc. * * @param $what diff --git a/app/lib/FireflyIII/Database/TransactionType/TransactionType.php b/app/lib/FireflyIII/Database/TransactionType/TransactionType.php index 2159e5d62a..ca5b678587 100644 --- a/app/lib/FireflyIII/Database/TransactionType/TransactionType.php +++ b/app/lib/FireflyIII/Database/TransactionType/TransactionType.php @@ -20,6 +20,8 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface { /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * @param Eloquent $model * * @return bool @@ -31,6 +33,8 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * @param array $data * * @return \Eloquent @@ -42,6 +46,8 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * @param Eloquent $model * @param array $data * @@ -54,6 +60,8 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * Validates an array. Returns an array containing MessageBags * errors/warnings/successes. * @@ -68,6 +76,8 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * Returns an object with id $id. * * @param int $objectId @@ -104,6 +114,8 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * Returns all objects. * * @return Collection @@ -115,6 +127,8 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * @param array $ids * * @return Collection diff --git a/app/lib/FireflyIII/Event/Piggybank.php b/app/lib/FireflyIII/Event/Piggybank.php index 5c1960a170..645f48432b 100644 --- a/app/lib/FireflyIII/Event/Piggybank.php +++ b/app/lib/FireflyIII/Event/Piggybank.php @@ -34,6 +34,8 @@ class PiggyBank } /** + * @SuppressWarnings("CyclomaticComplexity") // It's exactly 5. So I don't mind. + * * @param \TransactionJournal $journal * * @throws \FireflyIII\Exception\FireflyException @@ -109,6 +111,8 @@ class PiggyBank */ /** + * @SuppressWarnings("CyclomaticComplexity") // It's exactly 5. So I don't mind. + * * @param \TransactionJournal $journal * @param int $piggyBankId */ diff --git a/app/lib/FireflyIII/Helper/TransactionJournal/Helper.php b/app/lib/FireflyIII/Helper/TransactionJournal/Helper.php index f2f9b0f313..90ef11060d 100644 --- a/app/lib/FireflyIII/Helper/TransactionJournal/Helper.php +++ b/app/lib/FireflyIII/Helper/TransactionJournal/Helper.php @@ -81,14 +81,5 @@ class Helper implements HelperInterface } - /** - * @param $what - * - * @return int - */ - public function getTransactionTypeIdByWhat($what) - { - - } } diff --git a/app/lib/FireflyIII/Helper/TransactionJournal/HelperInterface.php b/app/lib/FireflyIII/Helper/TransactionJournal/HelperInterface.php index f49046a42a..06bcac0de7 100644 --- a/app/lib/FireflyIII/Helper/TransactionJournal/HelperInterface.php +++ b/app/lib/FireflyIII/Helper/TransactionJournal/HelperInterface.php @@ -22,13 +22,6 @@ interface HelperInterface */ public function getAssetAccount($what, Collection $transactions); - /** - * @param $what - * - * @return int - */ - public function getTransactionTypeIdByWhat($what); - /** * @return Collection */ diff --git a/app/lib/FireflyIII/Report/Report.php b/app/lib/FireflyIII/Report/Report.php index 748b2f5f49..91a3caae95 100644 --- a/app/lib/FireflyIII/Report/Report.php +++ b/app/lib/FireflyIII/Report/Report.php @@ -227,6 +227,8 @@ class Report implements ReportInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * @param Carbon $date * @param bool $shared * @@ -354,6 +356,8 @@ class Report implements ReportInterface } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * @param Carbon $start * @param Carbon $end * @param int $limit diff --git a/app/lib/FireflyIII/Search/Search.php b/app/lib/FireflyIII/Search/Search.php index 859d83b7b4..4a5d429634 100644 --- a/app/lib/FireflyIII/Search/Search.php +++ b/app/lib/FireflyIII/Search/Search.php @@ -80,6 +80,8 @@ class Search } /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * @param array $words * * @return Collection diff --git a/app/lib/FireflyIII/Shared/Toolkit/Reminders.php b/app/lib/FireflyIII/Shared/Toolkit/Reminders.php index fe3b40ed9b..11b75259e1 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Reminders.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Reminders.php @@ -15,6 +15,8 @@ class Reminders { /** + * @SuppressWarnings("CyclomaticComplexity") // It's exactly 5. So I don't mind. + * * @param \Reminder $reminder * * @return int @@ -62,6 +64,9 @@ class Reminders return $reminders; } + /** + * @SuppressWarnings("CyclomaticComplexity") // It's exactly 5. So I don't mind. + */ public function updateReminders() { /** @var Collection $set */ diff --git a/app/lib/FireflyIII/Shared/Validation/FireflyValidator.php b/app/lib/FireflyIII/Shared/Validation/FireflyValidator.php index 544174a1c5..33795d563b 100644 --- a/app/lib/FireflyIII/Shared/Validation/FireflyValidator.php +++ b/app/lib/FireflyIII/Shared/Validation/FireflyValidator.php @@ -11,6 +11,8 @@ use Illuminate\Validation\Validator; class FireflyValidator extends Validator { /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * * @param $attribute * @param $value * @param $parameters diff --git a/app/models/Bill.php b/app/models/Bill.php index 00d7d2c1e4..bc5500ebe2 100644 --- a/app/models/Bill.php +++ b/app/models/Bill.php @@ -1,5 +1,4 @@