kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2026-07-27 16:07:45 -07:00
Code Issues Projects Releases Wiki Activity

Various phpstan fixes.

Browse Source
This commit is contained in:
James Cole
2023-11-04 06:52:40 +01:00
parent 633d84449a
commit dc45131f73
20 changed files with 39 additions and 150 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Controllers/Transaction/ConvertController.php
-3
View File
@@ -33,7 +33,6 @@ use FireflyIII\Models\TransactionGroup;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\Models\TransactionType;
use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
use FireflyIII\Services\Internal\Update\JournalUpdateService;
use FireflyIII\Support\Http\Controllers\ModelInformation;
use FireflyIII\Transformers\TransactionGroupTransformer;
@@ -54,7 +53,6 @@ class ConvertController extends Controller
use ModelInformation;
private AccountRepositoryInterface $accountRepository;
private JournalRepositoryInterface $repository;
/**
* ConvertController constructor.
@@ -68,7 +66,6 @@ class ConvertController extends Controller
// some useful repositories:
$this->middleware(
function ($request, $next) {
$this->repository = app(JournalRepositoryInterface::class);
$this->accountRepository = app(AccountRepositoryInterface::class);
app('view')->share('title', (string)trans('firefly.transactions'));
app('view')->share('mainTitleIcon', 'fa-exchange');
app/Http/Controllers/Transaction/MassController.php
+3 -1
View File
@@ -39,6 +39,7 @@ use FireflyIII\Services\Internal\Update\JournalUpdateService;
use Illuminate\Contracts\Foundation\Application;
use Illuminate\Http\RedirectResponse;
use Illuminate\Routing\Redirector;
use Illuminate\Support\Facades\Log;
use Illuminate\View\View as IlluminateView;
use InvalidArgumentException;
@@ -251,7 +252,8 @@ class MassController extends Controller
try {
$carbon = Carbon::parse($value[$journalId]);
} catch (InvalidArgumentException $e) {
$e->getMessage();
Log::warning(sprintf('Could not parse "%s" but dont mind',$value[$journalId]));
Log::warning($e->getMessage());
return null;
}
app/Http/Controllers/Transaction/ShowController.php
+1 -1
View File
@@ -84,7 +84,7 @@ class ShowController extends Controller
*/
public function show(Request $request, TransactionGroup $transactionGroup)
{
/** @var TransactionJournal $first */
/** @var TransactionJournal|null $first */
$first = $transactionGroup->transactionJournals()->first(['transaction_journals.*']);
$splits = $transactionGroup->transactionJournals()->count();