Code clean up.

This commit is contained in:
James Cole
2017-11-15 12:25:49 +01:00
parent 57dcdfa0c4
commit ffca858b8d
476 changed files with 2055 additions and 4181 deletions

View File

@@ -18,7 +18,6 @@
* You should have received a copy of the GNU General Public License
* along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
*/
declare(strict_types=1);
namespace FireflyIII\TransactionRules\Triggers;
@@ -27,13 +26,10 @@ use FireflyIII\Models\TransactionJournal;
use Log;
/**
* Class AmountMore
*
* @package FireflyIII\TransactionRules\Triggers
* Class AmountMore.
*/
final class AmountMore extends AbstractTrigger implements TriggerInterface
{
/**
* A trigger is said to "match anything", or match any given transaction,
* when the trigger value is very vague or has no restrictions. Easy examples
@@ -52,9 +48,9 @@ final class AmountMore extends AbstractTrigger implements TriggerInterface
*/
public static function willMatchEverything($value = null)
{
if (!is_null($value)) {
$res = bccomp('0', strval($value)) === 0;
if ($res === true) {
if (null !== $value) {
$res = 0 === bccomp('0', strval($value));
if (true === $res) {
Log::error(sprintf('Cannot use %s with a value equal to 0.', self::class));
}
@@ -76,7 +72,7 @@ final class AmountMore extends AbstractTrigger implements TriggerInterface
$amount = $journal->destination_amount ?? $journal->amountPositive();
$compare = $this->triggerValue;
$result = bccomp($amount, $compare);
if ($result === 1) {
if (1 === $result) {
Log::debug(sprintf('RuleTrigger AmountMore for journal #%d: %d is more than %d, so return true', $journal->id, $amount, $compare));
return true;