Commit Graph

167 Commits

Author SHA1 Message Date
James Cole 12675dd950 Refactor phpstan errors. 2023-10-29 17:41:14 +01:00
James Cole 9a17a11b37 Remove references to static class. 2023-10-29 06:36:37 +01:00
James Cole 78153c2aa4 Update meta files for new release. 2023-10-28 17:17:09 +02:00
James Cole 0133a7c5db Code cleanup 2023-10-28 15:03:33 +02:00
James Cole 1d138eed8d Refactor currency repository. 2023-10-28 06:58:33 +02:00
James Cole 32a36bbb12 Restore missing methods and fix silly bugs. 2023-10-24 18:32:24 +02:00
James Cole c3398d4d51 Fix refactor for field. 2023-10-22 08:05:28 +02:00
James Cole 80237d8bc3 Refactor methods that request the old currency preference. 2023-10-22 07:55:36 +02:00
James Cole 3dcb35710b chore: reformat code. 2023-06-21 12:34:58 +02:00
James Cole 1b52147a05 chore: code cleanup. 2023-05-29 13:56:55 +02:00
James Cole 141a828947 Improved contrast for dark mode 2023-03-25 11:33:42 +01:00
James Cole e6dc881f56 Clean up comments 2023-02-22 18:03:31 +01:00
James Cole 927d607b1a Remove code coverage ignore instructions 2023-02-12 07:15:06 +01:00
James Cole 6cfdc58cb1 Various PSR12 code cleanup 2022-12-29 19:42:26 +01:00
James Cole cae0b1798a Merge branch 'develop' into 5.8-dev 2022-12-27 21:13:42 +01:00
James Cole 5e654786be Remove floats. 2022-12-27 21:13:18 +01:00
James Cole 75ce777090 Fix https://github.com/firefly-iii/firefly-iii/issues/6743 2022-12-27 20:00:18 +01:00
James Cole db478711ed Merge branch 'develop' into 5.8-dev
# Conflicts:
#	app/Api/V1/Controllers/Chart/AccountController.php
#	app/Api/V1/Controllers/Insight/Expense/AccountController.php
#	app/Api/V1/Controllers/Insight/Expense/BillController.php
#	app/Api/V1/Controllers/Insight/Expense/BudgetController.php
#	app/Api/V1/Controllers/Insight/Expense/CategoryController.php
#	app/Api/V1/Controllers/Insight/Expense/PeriodController.php
#	app/Console/Commands/Upgrade/MigrateToGroups.php
#	app/Http/Controllers/Account/IndexController.php
#	app/Http/Controllers/Budget/AvailableBudgetController.php
#	app/Http/Controllers/Budget/BudgetLimitController.php
#	app/Http/Controllers/Budget/EditController.php
#	app/Http/Controllers/Chart/AccountController.php
#	app/Http/Controllers/Json/FrontpageController.php
#	app/Http/Controllers/PiggyBank/EditController.php
2022-12-24 06:15:26 +01:00
James Cole c47980a737 Remove many references to (float) 2022-12-24 05:06:39 +01:00
James Cole f52675068b Use PSR-12 code style 2022-10-30 14:24:37 +01:00
James Cole 914dc8596b remove old inspections 2022-10-30 12:12:35 +01:00
James Cole 20ab457222 Various new stuff 2022-07-21 16:41:28 +02:00
James Cole 123693096c Reformat various code. 2022-03-29 15:10:05 +02:00
James Cole d04efb8325 Reformat various code. 2022-03-29 15:00:29 +02:00
James Cole 4003cea759 Code reordering and reformatting. I should really start employing style CI. 2021-09-18 10:26:12 +02:00
James Cole e829d79589 Various code cleanup. 2021-09-18 10:21:29 +02:00
James Cole 3f1bd6b3f1 Currency code expansion. 2021-05-13 05:52:06 +02:00
James Cole f12744ad8c Various code cleanup. 2021-04-07 07:28:43 +02:00
James Cole 38d0f0427f Various code cleanup. 2021-04-06 17:00:16 +02:00
James Cole 206845575c Code cleanup 2021-03-21 09:15:40 +01:00
James Cole 7118abe28d Fix some tests for account API 2021-03-13 12:01:01 +01:00
James Cole 013ebbf039 Initial effort to make code 8.0 compatible. 2020-12-17 06:31:23 +01:00
James Cole aa3e467a3e Add message so exception isn't empty. 2020-10-26 16:22:20 +01:00
James Cole 4e51f0abc4 Clean up some code. 2020-10-13 06:35:33 +02:00
James Cole 6671c6d45c Create some new test code. 2020-10-04 10:56:10 +02:00
James Cole d49743031f Add windows locale support #3519 2020-07-27 07:13:39 +02:00
James Cole 7017d33b87 Small code improv #3578 2020-07-27 07:08:29 +02:00
James Cole c5489a7c55 Restore locale info from localeconv #3578 2020-07-27 07:05:41 +02:00
James Cole fe66be673a Some extra code for #3578 2020-07-26 17:35:13 +02:00
James Cole 0bb59f5505 Yoda style and dump unused method. 2020-07-19 20:08:50 +02:00
James Cole 6881d4479e Remove round(). 2020-07-19 20:07:58 +02:00
Hosh Sadiq 14dd185717 Use php-intl to format currencies
Currently the php function `number_format` is used to format currencies.
This is problematic as we have to figure out different things for
different currencies ourselves. These formats are determined based on
the libc's locale functions.

The issue arises where an OS doesn't have the proper locales installed,
or, in some cases, it's not supported (see below on multiple issues).

This addresses this issue by using the php-intl extensions to format the
numbers based on the locale. The extension is already a requirement in
`composer.json`. The solution does not rely on `LC_MONETARY` from the
underlying libc (which in Alpine Linux's case, which uses musl, is not
supported as of yet).

List of issues that are related and would potentially be fixed using
this PR:

- #2298
- #2946
- #3070
- #3306
- #3519
2020-07-19 18:34:39 +01:00
James Cole cd65d4d4c5 Call correct timezone. 2020-07-17 18:51:35 +02:00
James Cole c398aa2b69 Add support for British English and allow the user to set a locale. 2020-04-19 06:51:40 +02:00
James Cole 144bc29eb3 Fix issue with budgets. 2020-03-31 07:03:37 +02:00
James Cole 5445752588 Update some phpdocs, courtesy of Psalm. 2020-03-25 07:03:23 +01:00
James Cole 46382b0d21 Simplify method. 2020-03-16 19:45:23 +01:00
James Cole 4982f6f919 Cleanup method 2020-03-15 18:12:36 +01:00
James Cole 4958f6e4a6 Update email address. 2020-02-16 13:56:52 +01:00
James Cole 7cdfbc48a9 Fix #3070 2020-02-01 06:32:28 +01:00