mirror of
				https://github.com/firefly-iii/firefly-iii.git
				synced 2025-10-31 10:47:00 +00:00 
			
		
		
		
	Compare commits
	
		
			655 Commits
		
	
	
		
			develop-20
			...
			develop-20
		
	
	| Author | SHA1 | Date | |
|---|---|---|---|
|  | ed265f68ba | ||
|  | d2e9b64bf5 | ||
|  | 3811aff206 | ||
|  | 762d898fee | ||
|  | 5e6034fc86 | ||
|  | 9da10459d6 | ||
|  | ff80cedd6b | ||
|  | b213148ae8 | ||
|  | c8646e20cb | ||
|  | 76a41fec50 | ||
|  | 0e705bd038 | ||
|  | f33ffb98ff | ||
|  | faa0d59340 | ||
|  | 5af0219884 | ||
|  | dafd99f155 | ||
|  | 3560f0388c | ||
|  | b2954658d8 | ||
|  | 44581d9983 | ||
|  | 02dcfeb227 | ||
|  | d8bafb349d | ||
|  | 889598a4c8 | ||
|  | 7e37d10016 | ||
|  | ebaebb09d1 | ||
|  | 531a3a4b6c | ||
|  | b3e313821b | ||
|  | 51958af422 | ||
|  | e3b21ccdba | ||
|  | 31bb208835 | ||
|  | 8c97e805a2 | ||
|  | ac8a43bb37 | ||
|  | 2df4b40a28 | ||
|  | e06736c254 | ||
|  | ec367e94ce | ||
|  | 1515dea9fa | ||
|  | adedf9c17d | ||
|  | 0b52fb84f1 | ||
|  | 16e742ae73 | ||
|  | 1b4471dfae | ||
|  | ae152ce0a4 | ||
|  | 2aa023f140 | ||
|  | 6e2e4c6f08 | ||
|  | 1c8c038735 | ||
|  | 4d339a6da8 | ||
|  | b7edd4407a | ||
|  | a679a1e94a | ||
|  | 180451d32f | ||
|  | 7396f22bca | ||
|  | 058019aa84 | ||
|  | 695f83d1d8 | ||
|  | ac4dfb3baf | ||
|  | 427001b223 | ||
|  | 3117d8b30d | ||
|  | d19dd2a8b2 | ||
|  | de3dcc3fc2 | ||
|  | 077f3e095b | ||
|  | ad3b0bb320 | ||
|  | 8538741341 | ||
|  | a0aef5d579 | ||
|  | fdd93427aa | ||
|  | ac3f6557de | ||
|  | b0a909150c | ||
|  | 913f163fe4 | ||
|  | 3126b07b33 | ||
|  | 08ca90cf75 | ||
|  | 540ac2a277 | ||
|  | ed80bed066 | ||
|  | 41d2541c6a | ||
|  | 5dedf63498 | ||
|  | 09bc4f41d2 | ||
|  | cebf0b5c57 | ||
|  | 1632a57e3e | ||
|  | 744c4be7d1 | ||
|  | bd99ef3eff | ||
|  | 8a86f13a5d | ||
|  | 7418b2f0ee | ||
|  | a0e9de9312 | ||
|  | 7e23a6f5e8 | ||
|  | 44589f8744 | ||
|  | d24531030f | ||
|  | 25bdab1346 | ||
|  | 41af1c863a | ||
|  | 76b3b18cfb | ||
|  | e6fb2958a9 | ||
|  | 15b75b322f | ||
|  | 86149d1032 | ||
|  | ded142cd9e | ||
|  | 7923eb9ec9 | ||
|  | 132553c108 | ||
|  | c2269fc9a4 | ||
|  | aed30d1499 | ||
|  | 84a1a876e1 | ||
|  | dc675707f9 | ||
|  | d5667c7ef6 | ||
|  | cba1213dd1 | ||
|  | 7219c90957 | ||
|  | af13bd991e | ||
|  | 48e548eb52 | ||
|  | 1a19e27f0e | ||
|  | 0cbd22426d | ||
|  | d5e52e99e0 | ||
|  | f52978e71f | ||
|  | 3a3358124d | ||
|  | 929808c633 | ||
|  | a78df574f3 | ||
|  | 875cad16b6 | ||
|  | 7bc30192ca | ||
|  | a1a8968e98 | ||
|  | 6abb74a038 | ||
|  | 2d7d05e985 | ||
|  | d426e09474 | ||
|  | 72d55cb953 | ||
|  | 73ad865581 | ||
|  | fefb52beb7 | ||
|  | abd503543b | ||
|  | e3eb550581 | ||
|  | 46b780758e | ||
|  | b2c3ee9779 | ||
|  | dca899bcee | ||
|  | 9667b8a948 | ||
|  | 661f225fe7 | ||
|  | 4c6fe0c8de | ||
|  | 78f457950e | ||
|  | d831cc8df2 | ||
|  | 7056406afc | ||
|  | c85cfcf3e6 | ||
|  | db06d06789 | ||
|  | a28b990cd1 | ||
|  | dab4bfa7a6 | ||
|  | 6575236f2b | ||
|  | ad582c8806 | ||
|  | 452e9cb953 | ||
|  | a64f137b39 | ||
|  | c067d6aab0 | ||
|  | 119b9920a6 | ||
|  | 99ed54fce8 | ||
|  | 2ea57cdd38 | ||
|  | bb94bdfdaf | ||
|  | 4de8398cc2 | ||
|  | e6e8cd5d8a | ||
|  | 0b200309ba | ||
|  | a184548912 | ||
|  | c987191212 | ||
|  | 7009b444d9 | ||
|  | 06551d5367 | ||
|  | a20622ac0c | ||
|  | ca38117fca | ||
|  | 9478f78d4f | ||
|  | 5c2397bbae | ||
|  | 92fefef816 | ||
|  | d3ced65524 | ||
|  | 29eb748831 | ||
|  | 76df3d5f33 | ||
|  | 252076ec1f | ||
|  | bbec28591f | ||
|  | 075a360ba6 | ||
|  | 477524a8ae | ||
|  | dfe055732d | ||
|  | 78b611a18d | ||
|  | 367bdf65e6 | ||
|  | 3fc9caa31a | ||
|  | 95a41fcab7 | ||
|  | 58b409fc00 | ||
|  | 3eaaac09ad | ||
|  | bcb672920c | ||
|  | 79b91e25c2 | ||
|  | 7170931464 | ||
|  | c1b5a1a13e | ||
|  | a6265ce8ab | ||
|  | 90109917df | ||
|  | 0acd54c2b7 | ||
|  | c96226b9b4 | ||
|  | 6d143f1624 | ||
|  | 93324d1154 | ||
|  | a39f0e1891 | ||
|  | 822f609a22 | ||
|  | cd7ddd1c61 | ||
|  | 0b63ba26bb | ||
|  | 94d70cdb62 | ||
|  | acb3831c8b | ||
|  | c9d9ecede4 | ||
|  | 4eb5873353 | ||
|  | 7ca39fdb21 | ||
|  | b8d1d7a8c0 | ||
|  | 1af79eab30 | ||
|  | 03be2704ce | ||
|  | 34baea66a7 | ||
|  | 0638d109d0 | ||
|  | 561e228a2d | ||
|  | cb5d856769 | ||
|  | 04fe5d1fc4 | ||
|  | 45e9d4f8de | ||
|  | 73fdbb6202 | ||
|  | e49dbefddd | ||
|  | fc5143337a | ||
|  | 4b3eb6dace | ||
|  | c741b2a819 | ||
|  | cebfaa32bf | ||
|  | d356d39d43 | ||
|  | 7d9f22d3f4 | ||
|  | c6c8f282e2 | ||
|  | 6a64420721 | ||
|  | fcde4e2488 | ||
|  | aa5c4c20e9 | ||
|  | 794e31e487 | ||
|  | 16bf186312 | ||
|  | 45c722e786 | ||
|  | 36d9e5c3fe | ||
|  | 8d614de67f | ||
|  | d17da670ab | ||
|  | 5bf4df9ad8 | ||
|  | 07db6b59ce | ||
|  | e16f1cf4ee | ||
|  | 4c80d929ca | ||
|  | 16364d9859 | ||
|  | c24f6acb2c | ||
|  | 4bd19e0627 | ||
|  | 69d839997a | ||
|  | c02c027f4f | ||
|  | b14606625e | ||
|  | 222d7b56c7 | ||
|  | b7f7bf42b2 | ||
|  | 0cbd64d31a | ||
|  | 60bdae47c4 | ||
|  | ca4b38d905 | ||
|  | 3674465f53 | ||
|  | b951d4130c | ||
|  | 7992b810fd | ||
|  | c1c0afa40b | ||
|  | 56c9026299 | ||
|  | 021ddfc36b | ||
|  | 5bd72f6428 | ||
|  | feabfe54f0 | ||
|  | 565409b486 | ||
|  | f57366da5f | ||
|  | 064217ccb0 | ||
|  | fa3ccbda33 | ||
|  | f43aadf02d | ||
|  | 3b8a4d3e9b | ||
|  | 3d410556ef | ||
|  | f15ca1d0a1 | ||
|  | 7002463c54 | ||
|  | 649f876437 | ||
|  | 3cfd178cbd | ||
|  | cefbaafa19 | ||
|  | a8c88800c4 | ||
|  | 9d1a127200 | ||
|  | 3fdde2d1c8 | ||
|  | cdc0b8dd2c | ||
|  | 1a1e06e6e8 | ||
|  | 6d39b8468c | ||
|  | bdee3947b2 | ||
|  | 2317037655 | ||
|  | dcea6b757b | ||
|  | bd7fe92818 | ||
|  | 850e47d8db | ||
|  | 96fe62400f | ||
|  | 5d07fcdcb6 | ||
|  | fd5d2d57a8 | ||
|  | 8e7d42201f | ||
|  | f26bd3cb31 | ||
|  | 36915cdace | ||
|  | 8a5cecd2a0 | ||
|  | 78da1b22bb | ||
|  | 6d970a9794 | ||
|  | 8bb7739f05 | ||
|  | 7788bb4b33 | ||
|  | 2ecb4bb3b7 | ||
|  | 4a783d3c3c | ||
|  | e16645ae87 | ||
|  | 9d3189be7e | ||
|  | 07fca78293 | ||
|  | 82080501c7 | ||
|  | d93d6bfc66 | ||
|  | a41326ef94 | ||
|  | 90b77845c3 | ||
|  | 57af80d820 | ||
|  | fc4d5a1dfd | ||
|  | 8ab9ab8d21 | ||
|  | 75674b5793 | ||
|  | a7d6f26051 | ||
|  | eb540ce148 | ||
|  | a3077fe43b | ||
|  | 63bb84d375 | ||
|  | e5f5aa628e | ||
|  | c54f84dc8e | ||
|  | c2e562623c | ||
|  | c8d5e8a9dc | ||
|  | 963f017be3 | ||
|  | 0e0eeb736f | ||
|  | e8d9b8fa49 | ||
|  | c166b9242e | ||
|  | 8ff8efced2 | ||
|  | 0b4fb9a806 | ||
|  | ba9fef9410 | ||
|  | f7d94d17cd | ||
|  | 1fea9c6817 | ||
|  | a88c8bedbe | ||
|  | fbf3468053 | ||
|  | 2a3ba9799e | ||
|  | d121aad28f | ||
|  | dc808fa807 | ||
|  | a1be6ff62b | ||
|  | 20dc5b0256 | ||
|  | edd54e23c5 | ||
|  | 1238df8784 | ||
|  | b8c62652b0 | ||
|  | 54b2d02f63 | ||
|  | 47faf89a5c | ||
|  | b7fb5a3854 | ||
|  | a384b4202a | ||
|  | 99ecac0ce4 | ||
|  | 6102982456 | ||
|  | b88e981b4b | ||
|  | 827263b03e | ||
|  | d44e74d334 | ||
|  | 911f46c590 | ||
|  | 7d42c4ee5d | ||
|  | ea89f6177f | ||
|  | 74291b3870 | ||
|  | 2c4f2082fe | ||
|  | d8d58cc29b | ||
|  | 85b17e4035 | ||
|  | 83de5667b3 | ||
|  | 5fffe873c6 | ||
|  | 78c09c82d6 | ||
|  | 704abc315d | ||
|  | 86b4965458 | ||
|  | d2dc0c2bf0 | ||
|  | 9f4894bbb5 | ||
|  | 76a8675a34 | ||
|  | 6988301da1 | ||
|  | 109cd37211 | ||
|  | 284ff4d1b0 | ||
|  | bc0ab7af99 | ||
|  | a17bc7258f | ||
|  | 87911c2438 | ||
|  | 746f1fd300 | ||
|  | 9e5faf919f | ||
|  | cc6cbe6605 | ||
|  | dc6d708897 | ||
|  | 6189d24b98 | ||
|  | f6e28dc88f | ||
|  | 75ea035630 | ||
|  | 4cdb14301d | ||
|  | 9f95221ba3 | ||
|  | e3a67be412 | ||
|  | 5749b642ce | ||
|  | baff7c67f9 | ||
|  | ccc005942f | ||
|  | 5b83c33039 | ||
|  | cc32578c5f | ||
|  | 80f410835b | ||
|  | b537a3145d | ||
|  | bfa1fcbaf8 | ||
|  | 56243907c4 | ||
|  | 5928dd72e6 | ||
|  | c6bf0ff1cd | ||
|  | 19d1cf192b | ||
|  | 37d7dc7e3e | ||
|  | 95a3a194b8 | ||
|  | 3542387188 | ||
|  | da1b002a64 | ||
|  | 46daee28e7 | ||
|  | 9ade5635d4 | ||
|  | e14e80f33c | ||
|  | 0c824e21c8 | ||
|  | fab1c68569 | ||
|  | c1534657f2 | ||
|  | 39841de680 | ||
|  | 43a720b62b | ||
|  | 5ec54de29e | ||
|  | 397e37f344 | ||
|  | b6f84c2b99 | ||
|  | 843f86fc66 | ||
|  | 0e8e364074 | ||
|  | bbccbef578 | ||
|  | ee11a8e3a0 | ||
|  | e8618047bd | ||
|  | f104b76f73 | ||
|  | cb701d8506 | ||
|  | 70a334c56e | ||
|  | e6b2db1e29 | ||
|  | e8dffa0052 | ||
|  | c4f0512f39 | ||
|  | 3268019d0c | ||
|  | a0ef6a1fc8 | ||
|  | 99d0098b20 | ||
|  | a7a54c042c | ||
|  | c44e48a793 | ||
|  | 53b501ca73 | ||
|  | 322f70bcca | ||
|  | 35559c077b | ||
|  | 590ffe7c76 | ||
|  | 8a2d8f148e | ||
|  | 4f0e15e07d | ||
|  | 7463861e0c | ||
|  | 1e70fa28be | ||
|  | 26c6ca470b | ||
|  | 5e54034e0e | ||
|  | 25873ef734 | ||
|  | 1092b04b22 | ||
|  | 01ce74dd72 | ||
|  | 41430d8386 | ||
|  | 01eb19169c | ||
|  | cfaa7d7c68 | ||
|  | 14d3312a10 | ||
|  | 87be478dd8 | ||
|  | 0b6877a20e | ||
|  | 7186f0ef60 | ||
|  | 538933691e | ||
|  | 46c49ddbd8 | ||
|  | bcfb134b6e | ||
|  | 57981f1cf9 | ||
|  | 0310186fb7 | ||
|  | 4dcb38290e | ||
|  | 2f5c37048b | ||
|  | 370c8b16ae | ||
|  | af0555592a | ||
|  | 9c07ddaed6 | ||
|  | bb7355a566 | ||
|  | 1d48347f8c | ||
|  | 060b76ca9c | ||
|  | 2b2b9b6f7a | ||
|  | f3dd05a0c0 | ||
|  | 47a91aa273 | ||
|  | 41bc236603 | ||
|  | 65349451ea | ||
|  | e77b6a55a4 | ||
|  | 2379bcff11 | ||
|  | 7133156fa1 | ||
|  | a59176689d | ||
|  | bc2d8f3dfb | ||
|  | ddf89a9d5a | ||
|  | 7daaba17f6 | ||
|  | 9cb5b1384f | ||
|  | 7d13263482 | ||
|  | d9ff252915 | ||
|  | 51ba550251 | ||
|  | fd21c467ad | ||
|  | 9aa90650b4 | ||
|  | d892257e8b | ||
|  | db0dbcfcf1 | ||
|  | f591996f04 | ||
|  | b08d385586 | ||
|  | 20ef22f67e | ||
|  | c888baf542 | ||
|  | 8b0af3f666 | ||
|  | 7043e1e7c0 | ||
|  | c5854eba23 | ||
|  | ddf1a8cebb | ||
|  | 7dcaf167e9 | ||
|  | b359d51d3a | ||
|  | 3913fa5086 | ||
|  | ab2772abe0 | ||
|  | bc7875b17b | ||
|  | 4938fa9990 | ||
|  | 84df2c80ee | ||
|  | dc17060754 | ||
|  | e2fa81dddc | ||
|  | 182dfc95fe | ||
|  | c8979b6c33 | ||
|  | ab872e8912 | ||
|  | d36b94fabf | ||
|  | e3d4ceaecb | ||
|  | e3a6e5b788 | ||
|  | 57235c0e00 | ||
|  | 2298c3ddaf | ||
|  | 7224f1be6f | ||
|  | 1bd3019c16 | ||
|  | f0fa21dead | ||
|  | 845eaed8d7 | ||
|  | b3649cd4d0 | ||
|  | 55f14c587b | ||
|  | 441a8a8408 | ||
|  | 060c9648f1 | ||
|  | 7680c8733f | ||
|  | 5a0af5c93b | ||
|  | f4b066add1 | ||
|  | 9ecb414b02 | ||
|  | ad4f908c24 | ||
|  | 025f739442 | ||
|  | 6df7354c48 | ||
|  | 3f77c845ca | ||
|  | d4771f7a5c | ||
|  | ec4e2bfa4f | ||
|  | dfdbfae4b5 | ||
|  | 349d38b956 | ||
|  | 2267aa3ac4 | ||
|  | 2323aa454e | ||
|  | 8b3317b665 | ||
|  | 15f893c343 | ||
|  | 309b3e765e | ||
|  | d3fad06e00 | ||
|  | 834f24c99c | ||
|  | 35291e1298 | ||
|  | ac4e9dcbc5 | ||
|  | d57806f2ba | ||
|  | 3b005c317d | ||
|  | e91903fed2 | ||
|  | fee2002b0f | ||
|  | f12e502eb8 | ||
|  | 24e62b1cee | ||
|  | f559ec73e0 | ||
|  | 530b501fcf | ||
|  | d5ea78025e | ||
|  | 3413b9b5b5 | ||
|  | 0b45c1aa76 | ||
|  | 5718d1690a | ||
|  | 67b16cc070 | ||
|  | 5746ac3247 | ||
|  | 8a2c520b11 | ||
|  | f46c14df8c | ||
|  | 009fbba491 | ||
|  | 53d84347c2 | ||
|  | 1961487055 | ||
|  | c9ce5df74b | ||
|  | 1371b6773e | ||
|  | b9f1baf150 | ||
|  | 66b322e844 | ||
|  | 487b65b669 | ||
|  | 9078781d61 | ||
|  | 1ec830521a | ||
|  | c4bf2aae7d | ||
|  | 69ca88d9f8 | ||
|  | b38b7b2534 | ||
|  | f19bfc3b4b | ||
|  | d22f9c09d7 | ||
|  | fc2da9eb42 | ||
|  | f2c9e20aef | ||
|  | 16b8ca2746 | ||
|  | 46ea074821 | ||
|  | d2c89781e2 | ||
|  | e54d711891 | ||
|  | 84d3ad4764 | ||
|  | b908951a2d | ||
|  | 8b87deea58 | ||
|  | 0d7325b3dc | ||
|  | a3fd99a498 | ||
|  | 0ff405d1e0 | ||
|  | 46a60af966 | ||
|  | 591c9e3b39 | ||
|  | c30461b20b | ||
|  | 2c3f86d9bc | ||
|  | 34349e4475 | ||
|  | 6acd5be5dc | ||
|  | 55a2b4e789 | ||
|  | f41397eb43 | ||
|  | 41fc1e8f82 | ||
|  | bee219ebf7 | ||
|  | 438f602961 | ||
|  | 429e72e681 | ||
|  | 7a134781f2 | ||
|  | b572c1dcd3 | ||
|  | 95593f847b | ||
|  | b82fcbd97b | ||
|  | daddee7806 | ||
|  | 930a08ec90 | ||
|  | fd2edf3b23 | ||
|  | 0597255c08 | ||
|  | 955ab38a85 | ||
|  | 1311a0db8b | ||
|  | 0ce9ee6a6c | ||
|  | 3a339382d4 | ||
|  | a5b15bbc16 | ||
|  | fbf89fd514 | ||
|  | b3223feba2 | ||
|  | 88a9bc379e | ||
|  | b442b91b7c | ||
|  | 9fadbbe087 | ||
|  | 1ef7239276 | ||
|  | ea573e9434 | ||
|  | 34fa24e4a8 | ||
|  | a1be4a4d8a | ||
|  | b8e8af1e2a | ||
|  | c13a3fb30c | ||
|  | cb8fa4e1f4 | ||
|  | bf7f4f9887 | ||
|  | af48548e81 | ||
|  | 90d58ec8fa | ||
|  | e92dd7f464 | ||
|  | 3bdf9eeed2 | ||
|  | 558ac7b0da | ||
|  | 9d0488ffbc | ||
|  | d7fa8b283e | ||
|  | a0097bd613 | ||
|  | ffc2156e5f | ||
|  | e0a89bb5fe | ||
|  | 647179cd3c | ||
|  | 5106ccdbd7 | ||
|  | 7103098fe7 | ||
|  | f8072f0bfc | ||
|  | 96ac3a95c8 | ||
|  | cd713dc40f | ||
|  | d9fba39d80 | ||
|  | 2564470197 | ||
|  | 9222c82af0 | ||
|  | 243f283bfd | ||
|  | 5b60aaecc0 | ||
|  | 20a4caec60 | ||
|  | 99cc096b71 | ||
|  | 5626d1c56d | ||
|  | 68c9c4ec3c | ||
|  | f9d4a43e05 | ||
|  | 92e7f344e0 | ||
|  | 89ce2838d5 | ||
|  | 356b217692 | ||
|  | 950e39b753 | ||
|  | 8f14979717 | ||
|  | aa2afd162e | ||
|  | fe33352ec1 | ||
|  | 65c5249815 | ||
|  | b1afaea1aa | ||
|  | 997dc3814b | ||
|  | b37b5b86d4 | ||
|  | b13a4e1016 | ||
|  | 7897ebc4d5 | ||
|  | ac17b82d85 | ||
|  | 1b1712d998 | ||
|  | a2c0d9f7d0 | ||
|  | 5b68b25c85 | ||
|  | d3a215b575 | ||
|  | 5c352a0d3e | ||
|  | fded058ea6 | ||
|  | 99f041b114 | ||
|  | 283b594995 | ||
|  | 723aa65e7a | ||
|  | 64d315ad51 | ||
|  | d0844356cb | ||
|  | ba8d65835a | ||
|  | fa3343f437 | ||
|  | c5b8a951d2 | ||
|  | 20b1fc05cb | ||
|  | ab441d7d0c | ||
|  | b621d14bdf | ||
|  | 94730e998b | ||
|  | 23c2f76e52 | ||
|  | 40196d48b2 | ||
|  | ef3c2eb701 | ||
|  | 4f994a2795 | ||
|  | 807e575dac | ||
|  | 04b1465eb7 | ||
|  | 6f79ab2a70 | ||
|  | c1469f016e | ||
|  | 373ec934df | ||
|  | abd34ba1dc | ||
|  | 89b7596caf | ||
|  | 3543548ba0 | ||
|  | a932965908 | ||
|  | 9056126328 | ||
|  | 0e85a5123d | ||
|  | d3f19db42d | ||
|  | 9894d16d26 | ||
|  | 0b069bcb58 | ||
|  | 36d54c3fac | ||
|  | 530e48f16e | 
| @@ -22,6 +22,9 @@ | ||||
|  | ||||
| SCRIPT_DIR="$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )" | ||||
|  | ||||
| echo "Running PHP CS Fixer" | ||||
| $SCRIPT_DIR/phpcs.sh | ||||
| echo "Running PHPStan" | ||||
| $SCRIPT_DIR/phpstan.sh | ||||
| echo "Running PHPMD" | ||||
| $SCRIPT_DIR/phpmd.sh | ||||
|   | ||||
| @@ -19,6 +19,8 @@ | ||||
|  * along with this program.  If not, see <https://www.gnu.org/licenses/>. | ||||
|  */ | ||||
| 
 | ||||
| use PhpCsFixer\Runner\Parallel\ParallelConfigFactory; | ||||
| 
 | ||||
| $current = __DIR__; | ||||
| 
 | ||||
| $paths = [ | ||||
| @@ -35,28 +37,33 @@ $finder = PhpCsFixer\Finder::create() | ||||
| 
 | ||||
| 
 | ||||
| $config = new PhpCsFixer\Config(); | ||||
| return $config->setRules([ | ||||
|                              'no_unused_imports'             => true, | ||||
|                              '@PhpCsFixer'                   => true, | ||||
| $config->setParallelConfig(ParallelConfigFactory::detect()); | ||||
| return $config->setRules( | ||||
|     [ | ||||
|         // rule sets
 | ||||
|         '@PHP83Migration'               => true, | ||||
|         '@PhpCsFixer'                   => true, | ||||
|         '@PhpCsFixer:risky'             => true, | ||||
|         '@PSR12'                        => true, | ||||
|         '@PSR12:risky'                  => true, | ||||
|         'declare_strict_types'          => true, | ||||
|         'strict_param'                  => true, | ||||
|                              'comment_to_phpdoc'             => false, // breaks phpstan lines in combination with PHPStorm.
 | ||||
|                              'array_syntax'                  => ['syntax' => 'short'], | ||||
|         'no_unused_imports'             => true, | ||||
|         'single_space_around_construct' => true, | ||||
|         'statement_indentation'         => true, | ||||
|         'void_return'                   => true, | ||||
| 
 | ||||
|         // disabled rules
 | ||||
|         'native_function_invocation'    => false, // annoying
 | ||||
|         'php_unit_data_provider_name'   => false, // bloody annoying long test names
 | ||||
|         'static_lambda'                 => false, // breaks the Response macro for API's.
 | ||||
|         'phpdoc_summary'                => false, // annoying.
 | ||||
|                              'single_space_around_construct' => [ | ||||
|                                  'constructs_followed_by_a_single_space' => [ | ||||
|                                      'protected', | ||||
|                                  ], | ||||
|                              ], | ||||
|                              'statement_indentation'         => true, | ||||
|         'comment_to_phpdoc'             => false, // breaks phpstan lines in combination with PHPStorm.
 | ||||
|         'type_declaration_spaces'       => false, | ||||
|         'cast_spaces'                   => false, | ||||
| 
 | ||||
|         // complex rules
 | ||||
|         'array_syntax'                  => ['syntax' => 'short'], | ||||
|         'binary_operator_spaces'        => [ | ||||
|             'default'   => 'at_least_single_space', | ||||
|             'operators' => [ | ||||
| @@ -65,6 +72,5 @@ return $config->setRules([ | ||||
|                 '??=' => 'align_single_space_minimal_by_scope', | ||||
|             ], | ||||
|         ], | ||||
|                              'void_return'                   => true, | ||||
|     ]) | ||||
|               ->setFinder($finder); | ||||
|   | ||||
							
								
								
									
										1055
									
								
								.ci/php-cs-fixer/composer.lock
									
									
									
										generated
									
									
									
								
							
							
						
						
									
										1055
									
								
								.ci/php-cs-fixer/composer.lock
									
									
									
										generated
									
									
									
								
							
										
											
												File diff suppressed because it is too large
												Load Diff
											
										
									
								
							
							
								
								
									
										19
									
								
								.ci/phpcs.sh
									
									
									
									
									
								
							
							
						
						
									
										19
									
								
								.ci/phpcs.sh
									
									
									
									
									
								
							| @@ -20,23 +20,8 @@ | ||||
| # along with this program.  If not, see <https://www.gnu.org/licenses/>. | ||||
| # | ||||
|  | ||||
| # Install composer packages | ||||
| #composer install --no-scripts --no-ansi | ||||
|  | ||||
| SCRIPT_DIR="$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )" | ||||
|  | ||||
| # enable test .env file. | ||||
| # cp .ci/.env.ci .env | ||||
|  | ||||
| OUTPUT_FORMAT=txt | ||||
| EXTRA_PARAMS="" | ||||
|  | ||||
| if [[ $GITHUB_ACTIONS = "true" ]] | ||||
| then | ||||
|     OUTPUT_FORMAT=txt | ||||
|     EXTRA_PARAMS="" | ||||
| fi | ||||
|  | ||||
| # clean up php code | ||||
| cd $SCRIPT_DIR/php-cs-fixer | ||||
| composer update --quiet | ||||
| @@ -44,8 +29,8 @@ rm -f .php-cs-fixer.cache | ||||
| PHP_CS_FIXER_IGNORE_ENV=true | ||||
| ./vendor/bin/php-cs-fixer fix \ | ||||
|     --config $SCRIPT_DIR/php-cs-fixer/.php-cs-fixer.php \ | ||||
|     --format=$OUTPUT_FORMAT \ | ||||
|     --allow-risky=yes $EXTRA_PARAMS | ||||
|     --format=txt \ | ||||
|     --allow-risky=yes | ||||
|  | ||||
| EXIT_CODE=$? | ||||
|  | ||||
|   | ||||
							
								
								
									
										106
									
								
								.ci/phpmd/composer.lock
									
									
									
										generated
									
									
									
								
							
							
						
						
									
										106
									
								
								.ci/phpmd/composer.lock
									
									
									
										generated
									
									
									
								
							| @@ -9,16 +9,16 @@ | ||||
|     "packages-dev": [ | ||||
|         { | ||||
|             "name": "composer/pcre", | ||||
|             "version": "3.1.1", | ||||
|             "version": "3.1.3", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/composer/pcre.git", | ||||
|                 "reference": "00104306927c7a0919b4ced2aaa6782c1e61a3c9" | ||||
|                 "reference": "5b16e25a5355f1f3afdfc2f954a0a80aec4826a8" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/composer/pcre/zipball/00104306927c7a0919b4ced2aaa6782c1e61a3c9", | ||||
|                 "reference": "00104306927c7a0919b4ced2aaa6782c1e61a3c9", | ||||
|                 "url": "https://api.github.com/repos/composer/pcre/zipball/5b16e25a5355f1f3afdfc2f954a0a80aec4826a8", | ||||
|                 "reference": "5b16e25a5355f1f3afdfc2f954a0a80aec4826a8", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
| @@ -60,7 +60,7 @@ | ||||
|             ], | ||||
|             "support": { | ||||
|                 "issues": "https://github.com/composer/pcre/issues", | ||||
|                 "source": "https://github.com/composer/pcre/tree/3.1.1" | ||||
|                 "source": "https://github.com/composer/pcre/tree/3.1.3" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -76,20 +76,20 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2023-10-11T07:11:09+00:00" | ||||
|             "time": "2024-03-19T10:26:25+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "composer/xdebug-handler", | ||||
|             "version": "3.0.3", | ||||
|             "version": "3.0.4", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/composer/xdebug-handler.git", | ||||
|                 "reference": "ced299686f41dce890debac69273b47ffe98a40c" | ||||
|                 "reference": "4f988f8fdf580d53bdb2d1278fe93d1ed5462255" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/composer/xdebug-handler/zipball/ced299686f41dce890debac69273b47ffe98a40c", | ||||
|                 "reference": "ced299686f41dce890debac69273b47ffe98a40c", | ||||
|                 "url": "https://api.github.com/repos/composer/xdebug-handler/zipball/4f988f8fdf580d53bdb2d1278fe93d1ed5462255", | ||||
|                 "reference": "4f988f8fdf580d53bdb2d1278fe93d1ed5462255", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
| @@ -100,7 +100,7 @@ | ||||
|             "require-dev": { | ||||
|                 "phpstan/phpstan": "^1.0", | ||||
|                 "phpstan/phpstan-strict-rules": "^1.1", | ||||
|                 "symfony/phpunit-bridge": "^6.0" | ||||
|                 "phpunit/phpunit": "^8.5 || ^9.6 || ^10.5" | ||||
|             }, | ||||
|             "type": "library", | ||||
|             "autoload": { | ||||
| @@ -124,9 +124,9 @@ | ||||
|                 "performance" | ||||
|             ], | ||||
|             "support": { | ||||
|                 "irc": "irc://irc.freenode.org/composer", | ||||
|                 "irc": "ircs://irc.libera.chat:6697/composer", | ||||
|                 "issues": "https://github.com/composer/xdebug-handler/issues", | ||||
|                 "source": "https://github.com/composer/xdebug-handler/tree/3.0.3" | ||||
|                 "source": "https://github.com/composer/xdebug-handler/tree/3.0.4" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -142,7 +142,7 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2022-02-25T21:32:43+00:00" | ||||
|             "time": "2024-03-26T18:29:49+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "pdepend/pdepend", | ||||
| @@ -395,16 +395,16 @@ | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/config", | ||||
|             "version": "v7.0.0", | ||||
|             "version": "v7.0.4", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/config.git", | ||||
|                 "reference": "8789646600f4e7e451dde9e1dc81cfa429f3857a" | ||||
|                 "reference": "44deeba7233f08f383185ffa37dace3b3bc87364" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/symfony/config/zipball/8789646600f4e7e451dde9e1dc81cfa429f3857a", | ||||
|                 "reference": "8789646600f4e7e451dde9e1dc81cfa429f3857a", | ||||
|                 "url": "https://api.github.com/repos/symfony/config/zipball/44deeba7233f08f383185ffa37dace3b3bc87364", | ||||
|                 "reference": "44deeba7233f08f383185ffa37dace3b3bc87364", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
| @@ -450,7 +450,7 @@ | ||||
|             "description": "Helps you find, load, combine, autofill and validate configuration values of any kind", | ||||
|             "homepage": "https://symfony.com", | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/config/tree/v7.0.0" | ||||
|                 "source": "https://github.com/symfony/config/tree/v7.0.4" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -466,20 +466,20 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2023-11-09T08:30:23+00:00" | ||||
|             "time": "2024-02-26T07:52:39+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/dependency-injection", | ||||
|             "version": "v7.0.2", | ||||
|             "version": "v7.0.4", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/dependency-injection.git", | ||||
|                 "reference": "bd25ef7c937b9da12510bdc4f1c66728f19620e3" | ||||
|                 "reference": "47f37af245df8457ea63409fc242b3cc825ce5eb" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/symfony/dependency-injection/zipball/bd25ef7c937b9da12510bdc4f1c66728f19620e3", | ||||
|                 "reference": "bd25ef7c937b9da12510bdc4f1c66728f19620e3", | ||||
|                 "url": "https://api.github.com/repos/symfony/dependency-injection/zipball/47f37af245df8457ea63409fc242b3cc825ce5eb", | ||||
|                 "reference": "47f37af245df8457ea63409fc242b3cc825ce5eb", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
| @@ -530,7 +530,7 @@ | ||||
|             "description": "Allows you to standardize and centralize the way objects are constructed in your application", | ||||
|             "homepage": "https://symfony.com", | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/dependency-injection/tree/v7.0.2" | ||||
|                 "source": "https://github.com/symfony/dependency-injection/tree/v7.0.4" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -546,7 +546,7 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2023-12-28T19:18:20+00:00" | ||||
|             "time": "2024-02-22T20:27:20+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/deprecation-contracts", | ||||
| @@ -617,16 +617,16 @@ | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/filesystem", | ||||
|             "version": "v7.0.0", | ||||
|             "version": "v7.0.3", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/filesystem.git", | ||||
|                 "reference": "7da8ea2362a283771478c5f7729cfcb43a76b8b7" | ||||
|                 "reference": "2890e3a825bc0c0558526c04499c13f83e1b6b12" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/symfony/filesystem/zipball/7da8ea2362a283771478c5f7729cfcb43a76b8b7", | ||||
|                 "reference": "7da8ea2362a283771478c5f7729cfcb43a76b8b7", | ||||
|                 "url": "https://api.github.com/repos/symfony/filesystem/zipball/2890e3a825bc0c0558526c04499c13f83e1b6b12", | ||||
|                 "reference": "2890e3a825bc0c0558526c04499c13f83e1b6b12", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
| @@ -660,7 +660,7 @@ | ||||
|             "description": "Provides basic utilities for the filesystem", | ||||
|             "homepage": "https://symfony.com", | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/filesystem/tree/v7.0.0" | ||||
|                 "source": "https://github.com/symfony/filesystem/tree/v7.0.3" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -676,20 +676,20 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2023-07-27T06:33:22+00:00" | ||||
|             "time": "2024-01-23T15:02:46+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/polyfill-ctype", | ||||
|             "version": "v1.28.0", | ||||
|             "version": "v1.29.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/polyfill-ctype.git", | ||||
|                 "reference": "ea208ce43cbb04af6867b4fdddb1bdbf84cc28cb" | ||||
|                 "reference": "ef4d7e442ca910c4764bce785146269b30cb5fc4" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/symfony/polyfill-ctype/zipball/ea208ce43cbb04af6867b4fdddb1bdbf84cc28cb", | ||||
|                 "reference": "ea208ce43cbb04af6867b4fdddb1bdbf84cc28cb", | ||||
|                 "url": "https://api.github.com/repos/symfony/polyfill-ctype/zipball/ef4d7e442ca910c4764bce785146269b30cb5fc4", | ||||
|                 "reference": "ef4d7e442ca910c4764bce785146269b30cb5fc4", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
| @@ -703,9 +703,6 @@ | ||||
|             }, | ||||
|             "type": "library", | ||||
|             "extra": { | ||||
|                 "branch-alias": { | ||||
|                     "dev-main": "1.28-dev" | ||||
|                 }, | ||||
|                 "thanks": { | ||||
|                     "name": "symfony/polyfill", | ||||
|                     "url": "https://github.com/symfony/polyfill" | ||||
| @@ -742,7 +739,7 @@ | ||||
|                 "portable" | ||||
|             ], | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/polyfill-ctype/tree/v1.28.0" | ||||
|                 "source": "https://github.com/symfony/polyfill-ctype/tree/v1.29.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -758,20 +755,20 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2023-01-26T09:26:14+00:00" | ||||
|             "time": "2024-01-29T20:11:03+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/polyfill-mbstring", | ||||
|             "version": "v1.28.0", | ||||
|             "version": "v1.29.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/polyfill-mbstring.git", | ||||
|                 "reference": "42292d99c55abe617799667f454222c54c60e229" | ||||
|                 "reference": "9773676c8a1bb1f8d4340a62efe641cf76eda7ec" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/symfony/polyfill-mbstring/zipball/42292d99c55abe617799667f454222c54c60e229", | ||||
|                 "reference": "42292d99c55abe617799667f454222c54c60e229", | ||||
|                 "url": "https://api.github.com/repos/symfony/polyfill-mbstring/zipball/9773676c8a1bb1f8d4340a62efe641cf76eda7ec", | ||||
|                 "reference": "9773676c8a1bb1f8d4340a62efe641cf76eda7ec", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
| @@ -785,9 +782,6 @@ | ||||
|             }, | ||||
|             "type": "library", | ||||
|             "extra": { | ||||
|                 "branch-alias": { | ||||
|                     "dev-main": "1.28-dev" | ||||
|                 }, | ||||
|                 "thanks": { | ||||
|                     "name": "symfony/polyfill", | ||||
|                     "url": "https://github.com/symfony/polyfill" | ||||
| @@ -825,7 +819,7 @@ | ||||
|                 "shim" | ||||
|             ], | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/polyfill-mbstring/tree/v1.28.0" | ||||
|                 "source": "https://github.com/symfony/polyfill-mbstring/tree/v1.29.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -841,7 +835,7 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2023-07-28T09:04:16+00:00" | ||||
|             "time": "2024-01-29T20:11:03+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/service-contracts", | ||||
| @@ -927,16 +921,16 @@ | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/var-exporter", | ||||
|             "version": "v7.0.2", | ||||
|             "version": "v7.0.4", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/var-exporter.git", | ||||
|                 "reference": "345c62fefe92243c3a06fc0cc65f2ec1a47e0764" | ||||
|                 "reference": "dfb0acb6803eb714f05d97dd4c5abe6d5fa9fe41" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/symfony/var-exporter/zipball/345c62fefe92243c3a06fc0cc65f2ec1a47e0764", | ||||
|                 "reference": "345c62fefe92243c3a06fc0cc65f2ec1a47e0764", | ||||
|                 "url": "https://api.github.com/repos/symfony/var-exporter/zipball/dfb0acb6803eb714f05d97dd4c5abe6d5fa9fe41", | ||||
|                 "reference": "dfb0acb6803eb714f05d97dd4c5abe6d5fa9fe41", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
| @@ -981,7 +975,7 @@ | ||||
|                 "serialize" | ||||
|             ], | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/var-exporter/tree/v7.0.2" | ||||
|                 "source": "https://github.com/symfony/var-exporter/tree/v7.0.4" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -997,7 +991,7 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2023-12-27T08:42:13+00:00" | ||||
|             "time": "2024-02-26T10:35:24+00:00" | ||||
|         } | ||||
|     ], | ||||
|     "aliases": [], | ||||
|   | ||||
| @@ -19,9 +19,9 @@ | ||||
|   ~ along with this program.  If not, see <https://www.gnu.org/licenses/>. | ||||
|   --> | ||||
|  | ||||
| <ruleset name="pcsg-generated-ruleset" | ||||
| <ruleset xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||||
|          name="pcsg-generated-ruleset" | ||||
|          xmlns="http://pmd.sf.net/ruleset/1.0.0" | ||||
|          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||||
|          xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 http://pmd.sf.net/ruleset_xml_schema.xsd" | ||||
|          xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd"> | ||||
|     <description>Firefly III ruleset.</description> | ||||
|   | ||||
| @@ -1,9 +1,10 @@ | ||||
| parameters: | ||||
|   scanFiles: | ||||
|     - ../_ide_helper_models.php | ||||
|   universalObjectCratesClasses: | ||||
|     - Illuminate\Database\Eloquent\Model | ||||
|   # TODO: slowly remove these parameters and fix the issues found. | ||||
|   reportUnmatchedIgnoredErrors: false | ||||
|   checkGenericClassInNonGenericObjectType: false  # remove this rule when all other issues are solved. | ||||
|   ignoreErrors: | ||||
|   # TODO: slowly remove these exceptions and fix the issues found. | ||||
|     - '#Dynamic call to static method#' # all the Laravel ORM things depend on this. | ||||
| @@ -11,6 +12,7 @@ parameters: | ||||
|     - '#with no value type specified in iterable type array#' # remove this rule when all other issues are solved. | ||||
|     - '#has no value type specified in iterable type array#' # remove this rule when all other issues are solved. | ||||
|     - '#is not allowed to extend#' | ||||
|     - '#does not specify its types#' | ||||
|     - '#switch is forbidden to use#' | ||||
|     - '#is neither abstract nor final#' | ||||
|     - '#on left side of \?\?\= always exists and is not nullable#' | ||||
|   | ||||
							
								
								
									
										45
									
								
								.env.example
									
									
									
									
									
								
							
							
						
						
									
										45
									
								
								.env.example
									
									
									
									
									
								
							| @@ -1,6 +1,6 @@ | ||||
| # You can leave this on "local". If you change it to production most console commands will ask for extra confirmation. | ||||
| # Never set it to "testing". | ||||
| APP_ENV=local | ||||
| APP_ENV=production | ||||
|  | ||||
| # Set to true if you want to see debug information in error screens. | ||||
| APP_DEBUG=false | ||||
| @@ -111,7 +111,10 @@ PGSQL_SSL_CERT=null | ||||
| PGSQL_SSL_KEY=null | ||||
| PGSQL_SSL_CRL_FILE=null | ||||
|  | ||||
| # more PostgreSQL settings | ||||
| # For postgresql 15 and up, setting this to public will no longer work as expected, becasuse the | ||||
| # 'public' schema is without grants. This can be worked around by having a super user grant those | ||||
| # necessary privileges, but in security conscious setups that's not viable. | ||||
| # You will need to set this to the schema you want to use. | ||||
| PGSQL_SCHEMA=public | ||||
|  | ||||
| # If you're looking for performance improvements, you could install memcached or redis | ||||
| @@ -184,6 +187,11 @@ SEND_REPORT_JOURNALS=true | ||||
| # Since this involves an external service, it's optional and disabled by default. | ||||
| ENABLE_EXTERNAL_MAP=false | ||||
|  | ||||
| # | ||||
| # Enable or disable exchange rate conversion. This function isn't used yet by Firefly III | ||||
| # | ||||
| ENABLE_EXCHANGE_RATES=false | ||||
|  | ||||
| # Set this value to true if you want Firefly III to download currency exchange rates | ||||
| # from the internet. These rates are hosted by the creator of Firefly III inside | ||||
| # an Azure Storage Container. | ||||
| @@ -291,27 +299,6 @@ DKR_BUILD_LOCALE=false | ||||
| # Won't significantly speed up things. | ||||
| DKR_CHECK_SQLITE=true | ||||
|  | ||||
| # Run database creation and migration commands. Disable this only if you're 100% sure the DB exists | ||||
| # and is up to date. | ||||
| DKR_RUN_MIGRATION=true | ||||
|  | ||||
| # Run database upgrade commands. Disable this only when you're 100% sure your DB is up-to-date | ||||
| # with the latest fixes (outside of migrations!) | ||||
| DKR_RUN_UPGRADE=true | ||||
|  | ||||
| # Verify database integrity. Includes all data checks and verifications. | ||||
| # Disabling this makes Firefly III assume your DB is intact. | ||||
| DKR_RUN_VERIFY=true | ||||
|  | ||||
| # Run database reporting commands. When disabled, Firefly III won't go over your data to report current state. | ||||
| # Disabling this should have no impact on data integrity or safety but it won't warn you of possible issues. | ||||
| DKR_RUN_REPORT=true | ||||
|  | ||||
| # Generate OAuth2 keys. | ||||
| # When disabled, Firefly III won't attempt to generate OAuth2 Passport keys. This won't be an issue, IFF (if and only if) | ||||
| # you had previously generated keys already and they're stored in your database for restoration. | ||||
| DKR_RUN_PASSPORT_INSTALL=true | ||||
|  | ||||
| # Leave the following configuration vars as is. | ||||
| # Unless you like to tinker and know what you're doing. | ||||
| APP_NAME=FireflyIII | ||||
| @@ -332,15 +319,7 @@ DEMO_PASSWORD= | ||||
| FIREFLY_III_LAYOUT=v1 | ||||
|  | ||||
| # | ||||
| # If you have trouble configuring your Firefly III installation, DON'T BOTHER setting this variable. | ||||
| # It won't work. It doesn't do ANYTHING. Don't believe the lies you read online. I'm not joking. | ||||
| # This configuration value WILL NOT HELP. | ||||
| # | ||||
| # Notable exception to this rule is Synology, which, according to some users, will use APP_URL to rewrite stuff. | ||||
| # | ||||
| # This variable is ONLY used in some of the emails Firefly III sends around. Nowhere else. | ||||
| # So when configuring anything WEB related this variable doesn't do anything. Nothing | ||||
| # | ||||
| # If you're stuck I understand you get desperate but look SOMEWHERE ELSE. | ||||
| # Please make sure this URL matches the external URL of your Firefly III installation. | ||||
| # It is used to validate specific requests and to generate URLs in emails. | ||||
| # | ||||
| APP_URL=http://localhost | ||||
|   | ||||
							
								
								
									
										2
									
								
								.github/CODEOWNERS
									
									
									
									
										vendored
									
									
										Normal file
									
								
							
							
						
						
									
										2
									
								
								.github/CODEOWNERS
									
									
									
									
										vendored
									
									
										Normal file
									
								
							| @@ -0,0 +1,2 @@ | ||||
| # code owners for this Firefly III related repository | ||||
| * @JC5 @SDx3 | ||||
							
								
								
									
										3
									
								
								.github/dependabot.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										3
									
								
								.github/dependabot.yml
									
									
									
									
										vendored
									
									
								
							| @@ -4,6 +4,7 @@ updates: | ||||
|   # Check for updates to GitHub Actions every week | ||||
|   - package-ecosystem: "github-actions" | ||||
|     directory: "/" | ||||
|     labels: [] | ||||
|     schedule: | ||||
|       interval: "weekly" | ||||
|  | ||||
| @@ -11,6 +12,7 @@ updates: | ||||
|   - package-ecosystem: "composer" | ||||
|     directory: "/" # Location of package manifests | ||||
|     target-branch: develop | ||||
|     labels: [] | ||||
|     versioning-strategy: increase | ||||
|     schedule: | ||||
|       interval: "weekly" | ||||
| @@ -18,6 +20,7 @@ updates: | ||||
|   # yarn / JS updates | ||||
|   - package-ecosystem: "npm" | ||||
|     directory: "/" | ||||
|     labels: [] | ||||
|     target-branch: develop | ||||
|     versioning-strategy: increase | ||||
|     schedule: | ||||
|   | ||||
							
								
								
									
										4
									
								
								.github/funding.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										4
									
								
								.github/funding.yml
									
									
									
									
										vendored
									
									
								
							| @@ -1,4 +1,6 @@ | ||||
| # These are supported funding model platforms | ||||
| # Firefly III sponsor options | ||||
|  | ||||
| github: jc5 | ||||
| patreon: JC5 | ||||
| ko_fi: jamesc5 | ||||
| liberapay: JC5 | ||||
|   | ||||
							
								
								
									
										17
									
								
								.github/pull_request_template.md
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										17
									
								
								.github/pull_request_template.md
									
									
									
									
										vendored
									
									
								
							| @@ -1,13 +1,20 @@ | ||||
| <!-- | ||||
| Before you create a new PR, please consider: | ||||
| Thank you for submitting new code to Firefly III, or any of the related projects. Please read the following rules carefully. | ||||
| 
 | ||||
| 1) Pull requests for the MAIN branch will be closed. | ||||
| 2) DO NOT include translations in your PR. Only English US sentences. | ||||
| - Please do not submit solutions for problems that are not already reported in an issue. | ||||
| - Unfortunately, Firefly III can't be your learning experience. If you're new to all of this, please open an issue first. | ||||
| - Please do not open PRs to "discuss" possible solutions or to "get feedback" on your code. I simply don't have time for that. | ||||
| - Pull requests for the MAIN branch will be closed. | ||||
| - DO NOT include translated strings in your PR. | ||||
| - PRs (or parts thereof) that only fix issues inside code comments will not be accepted. | ||||
| 
 | ||||
| If it feels necessary to open an issue first, please do so, before you open a PR. | ||||
| 
 | ||||
| See also: https://docs.firefly-iii.org/explanation/support/#contributing-code | ||||
| 
 | ||||
| Thanks. | ||||
| --> | ||||
|      | ||||
| Fixes issue # (if relevant) | ||||
| This PR fixes issue # (if relevant). | ||||
| 
 | ||||
| Changes in this pull request: | ||||
| 
 | ||||
|   | ||||
							
								
								
									
										58
									
								
								.github/stale.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										58
									
								
								.github/stale.yml
									
									
									
									
										vendored
									
									
								
							| @@ -1,58 +0,0 @@ | ||||
| # Configuration for probot-stale - https://github.com/probot/stale | ||||
|  | ||||
| # Number of days of inactivity before an Issue or Pull Request becomes stale | ||||
| daysUntilStale: 14 | ||||
|  | ||||
| # Number of days of inactivity before a stale Issue or Pull Request is closed. | ||||
| # Set to false to disable. If disabled, issues still need to be closed manually, but will remain marked as stale. | ||||
| daysUntilClose: 14 | ||||
|  | ||||
| # Issues or Pull Requests with these labels will never be considered stale. Set to `[]` to disable | ||||
| # - "[Status] Maybe Later" | ||||
| exemptLabels: | ||||
|   - enhancement | ||||
|   - feature | ||||
|   - bug | ||||
|   - announcement | ||||
|   - "layout-v3" | ||||
|  | ||||
| # Set to true to ignore issues in a project (defaults to false) | ||||
| exemptProjects: false | ||||
|  | ||||
| # Set to true to ignore issues in a milestone (defaults to false) | ||||
| exemptMilestones: false | ||||
|  | ||||
| # Label to use when marking as stale | ||||
| staleLabel: stale | ||||
|  | ||||
| # Comment to post when marking as stale. Set to `false` to disable | ||||
| markComment: > | ||||
|   This issue has been automatically marked as stale because it has not had | ||||
|   recent activity. It will be closed if no further activity occurs. Thank you | ||||
|   for your contributions. | ||||
|  | ||||
| # Comment to post when removing the stale label. | ||||
| # unmarkComment: > | ||||
| #   Your comment here. | ||||
|  | ||||
| # Comment to post when closing a stale Issue or Pull Request. | ||||
| # closeComment: > | ||||
| #   Your comment here. | ||||
|  | ||||
| # Limit the number of actions per hour, from 1-30. Default is 30 | ||||
| limitPerRun: 30 | ||||
|  | ||||
| # Limit to only `issues` or `pulls` | ||||
| # only: issues | ||||
|  | ||||
| # Optionally, specify configuration settings that are specific to just 'issues' or 'pulls': | ||||
| # pulls: | ||||
| #   daysUntilStale: 30 | ||||
| #   markComment: > | ||||
| #     This pull request has been automatically marked as stale because it has not had | ||||
| #     recent activity. It will be closed if no further activity occurs. Thank you | ||||
| #     for your contributions. | ||||
|  | ||||
| # issues: | ||||
| #   exemptLabels: | ||||
| #     - confirmed | ||||
							
								
								
									
										9
									
								
								.github/workflows/cleanup.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										9
									
								
								.github/workflows/cleanup.yml
									
									
									
									
										vendored
									
									
								
							| @@ -2,9 +2,12 @@ | ||||
|  | ||||
| name: "Chore - Prune old builds" | ||||
|  | ||||
| permissions: | ||||
|   actions: write | ||||
|  | ||||
| on: | ||||
|   schedule: | ||||
|     - cron: '0 0 * * *' | ||||
|     - cron: '0 1 * * *' | ||||
|   workflow_dispatch: | ||||
| jobs: | ||||
|   prune: | ||||
| @@ -14,7 +17,7 @@ jobs: | ||||
|       - name: Prune cancelled/skipped runs | ||||
|         uses: actions/github-script@v7 | ||||
|         with: | ||||
|           github-token: ${{ secrets.GH_ACTIONS_PERSONAL_ACCESS_TOKEN }} | ||||
|           github-token: ${{ secrets.GITHUB_TOKEN }} | ||||
|           script: | | ||||
|             const cancelled = await github.rest.actions.listWorkflowRunsForRepo({ | ||||
|               owner: context.repo.owner, | ||||
| @@ -44,7 +47,7 @@ jobs: | ||||
|       - name: Prune runs older than 3 days | ||||
|         uses: actions/github-script@v7 | ||||
|         with: | ||||
|           github-token: ${{ secrets.GH_ACTIONS_PERSONAL_ACCESS_TOKEN }} | ||||
|           github-token: ${{ secrets.GITHUB_TOKEN }} | ||||
|           script: | | ||||
|             const days_to_expiration = 3; | ||||
|             const ms_in_day = 86400000; | ||||
|   | ||||
							
								
								
									
										2
									
								
								.github/workflows/close-duplicates.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										2
									
								
								.github/workflows/close-duplicates.yml
									
									
									
									
										vendored
									
									
								
							| @@ -13,7 +13,7 @@ jobs: | ||||
|   close_duplicates: | ||||
|     runs-on: ubuntu-latest | ||||
|     steps: | ||||
|       - uses: github/command@v1.1.0 | ||||
|       - uses: github/command@v1.2.1 | ||||
|         id: command | ||||
|         with: | ||||
|           allowed_contexts: "issue" | ||||
|   | ||||
							
								
								
									
										20
									
								
								.github/workflows/lock.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										20
									
								
								.github/workflows/lock.yml
									
									
									
									
										vendored
									
									
								
							| @@ -3,17 +3,27 @@ name: 'Issues - Lock old issues' | ||||
| on: | ||||
|   workflow_dispatch: | ||||
|   schedule: | ||||
|     - cron: '0 0 * * *' | ||||
|     - cron: '0 2 * * *' | ||||
|  | ||||
| concurrency: | ||||
|   group: lock-threads | ||||
|  | ||||
| permissions: | ||||
|   issues: write | ||||
|   pull-requests: write | ||||
|   discussions: write | ||||
|  | ||||
| jobs: | ||||
|   lock: | ||||
|     permissions: | ||||
|       issues: write | ||||
|       pull-requests: write | ||||
|       discussions: write | ||||
|     runs-on: ubuntu-latest | ||||
|     steps: | ||||
|       - uses: JC5/lock-threads@main | ||||
|       - uses: dessant/lock-threads@v5 | ||||
|         with: | ||||
|           github-token: ${{ github.token }} | ||||
|           issue-inactive-days: 7 | ||||
|           pr-inactive-days: 7 | ||||
|           issue-inactive-days: 21 | ||||
|           pr-inactive-days: 21 | ||||
|           discussion-inactive-days: 21 | ||||
|           log-output: true | ||||
|   | ||||
							
								
								
									
										205
									
								
								.github/workflows/release.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										205
									
								
								.github/workflows/release.yml
									
									
									
									
										vendored
									
									
								
							| @@ -4,11 +4,11 @@ on: | ||||
|   workflow_dispatch: | ||||
|     inputs: | ||||
|       version: | ||||
|         description: 'Version to release' | ||||
|         description: 'Release "v1.2.3" or "develop"' | ||||
|         required: true | ||||
|         default: 'develop' | ||||
|   schedule: | ||||
|     - cron:  '15 0 * * MON,THU' | ||||
|     - cron: '0 3 * * MON' | ||||
|  | ||||
| jobs: | ||||
|   build: | ||||
| @@ -39,7 +39,7 @@ jobs: | ||||
|           php-version: '8.3' | ||||
|           extensions: mbstring, intl, zip, bcmath | ||||
|       - name: crowdin action | ||||
|         uses: crowdin/github-action@v1 | ||||
|         uses: crowdin/github-action@v2 | ||||
|         with: | ||||
|           upload_sources: true | ||||
|           download_translations: true | ||||
| @@ -51,89 +51,140 @@ jobs: | ||||
|           CROWDIN_TOKEN: ${{ secrets.CROWDIN_TOKEN }} | ||||
|       - name: Cleanup translations | ||||
|         id: cleanup-transactions | ||||
|         uses: JC5/firefly-iii-dev@v29 | ||||
|         uses: JC5/firefly-iii-dev@main | ||||
|         with: | ||||
|           action: 'ff3:crowdin-warning' | ||||
|           output: '' | ||||
|         env: | ||||
|           FIREFLY_III_ROOT: /github/workspace | ||||
|           GH_TOKEN: ${{ secrets.GH_TOKEN }} | ||||
|           GH_TOKEN: '' | ||||
|       - name: Cleanup changelog | ||||
|         id: cleanup-changelog | ||||
|         uses: JC5/firefly-iii-dev@v29 | ||||
|         uses: JC5/firefly-iii-dev@main | ||||
|         with: | ||||
|           action: 'ff3:changelog' | ||||
|           output: '' | ||||
|         env: | ||||
|           FIREFLY_III_ROOT: /github/workspace | ||||
|           GH_TOKEN: ${{ secrets.GH_TOKEN }} | ||||
|           GH_TOKEN: ${{ secrets.CHANGELOG_TOKEN }} | ||||
|       - name: "Create THANKS.md" | ||||
|         id: thank-you | ||||
|         uses: JC5/firefly-iii-dev@main | ||||
|         with: | ||||
|           action: 'ff3:thank-you' | ||||
|           output: '' | ||||
|         env: | ||||
|           FIREFLY_III_ROOT: /github/workspace | ||||
|           GH_TOKEN: '' | ||||
|       - name: Extract changelog | ||||
|         id: extract-changelog | ||||
|         uses: JC5/firefly-iii-dev@v29 | ||||
|         uses: JC5/firefly-iii-dev@main | ||||
|         with: | ||||
|           action: 'ff3:extract-changelog' | ||||
|           output: 'output' | ||||
|         env: | ||||
|           FIREFLY_III_ROOT: /github/workspace | ||||
|           GH_TOKEN: ${{ secrets.GH_TOKEN }} | ||||
|           GH_TOKEN: "" | ||||
|       - name: Replace version | ||||
|         id: replace-version | ||||
|         uses: JC5/firefly-iii-dev@main | ||||
|         with: | ||||
|           action: 'ff3:version' | ||||
|           output: '' | ||||
|         env: | ||||
|           FIREFLY_III_ROOT: /github/workspace | ||||
|           GH_TOKEN: "" | ||||
|           FF_III_VERSION: ${{ github.event_name == 'schedule' && 'develop' || github.event.inputs.version }} | ||||
|       - name: Generate JSON v1 | ||||
|         id: json-v1 | ||||
|         uses: JC5/firefly-iii-dev@v29 | ||||
|         uses: JC5/firefly-iii-dev@main | ||||
|         with: | ||||
|           action: 'ff3:json-translations v1' | ||||
|           output: '' | ||||
|         env: | ||||
|           FIREFLY_III_ROOT: /github/workspace | ||||
|           GH_TOKEN: ${{ secrets.GH_TOKEN }} | ||||
|           GH_TOKEN: '' | ||||
|       - name: Generate JSON v2 | ||||
|         id: json-v2 | ||||
|         uses: JC5/firefly-iii-dev@v29 | ||||
|         uses: JC5/firefly-iii-dev@main | ||||
|         with: | ||||
|           action: 'ff3:json-translations v2' | ||||
|           output: '' | ||||
|         env: | ||||
|           FIREFLY_III_ROOT: /github/workspace | ||||
|           GH_TOKEN: ${{ secrets.GH_TOKEN }} | ||||
|           GH_TOKEN: '' | ||||
|       - name: Code cleanup | ||||
|         id: code-cleanup | ||||
|         uses: JC5/firefly-iii-dev@v29 | ||||
|         uses: JC5/firefly-iii-dev@main | ||||
|         with: | ||||
|           action: 'ff3:code' | ||||
|           output: '' | ||||
|         env: | ||||
|           FIREFLY_III_ROOT: /github/workspace | ||||
|           GH_TOKEN: ${{ secrets.GH_TOKEN }} | ||||
|       - name: Build new JS | ||||
|           GH_TOKEN: '' | ||||
|       - name: Build JS | ||||
|         run: | | ||||
|           npm upgrade | ||||
|           npm run build | ||||
|       - name: Build old JS | ||||
|         id: old-js | ||||
|         uses: JC5/firefly-iii-dev@v29 | ||||
|         with: | ||||
|           action: 'ff3:old-js' | ||||
|           output: '' | ||||
|         env: | ||||
|           FIREFLY_III_ROOT: /github/workspace | ||||
|           GH_TOKEN: ${{ secrets.GH_TOKEN }} | ||||
|           npm install | ||||
|           npm run prod  --workspace=v1 | ||||
|           npm run build --workspace=v2 | ||||
|           npm update | ||||
|       - name: Run CI | ||||
|         run: | | ||||
|           rm -rf vendor composer.lock | ||||
|           composer validate --strict | ||||
|           composer update --no-dev --no-scripts --no-plugins -q | ||||
|           sudo chown -R runner:docker resources/lang | ||||
|           .ci/phpcs.sh | ||||
|       - name: Import GPG key | ||||
|         uses: crazy-max/ghaction-import-gpg@v6 | ||||
|         with: | ||||
|           gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }} | ||||
|           passphrase: ${{ secrets.PASSPHRASE }} | ||||
|       - name: Release | ||||
|         run: | | ||||
|           # do some configuration | ||||
|           sudo timedatectl set-timezone Europe/Amsterdam | ||||
|           git config user.name github-actions | ||||
|           git config user.email 41898282+github-actions[bot]@users.noreply.github.com | ||||
|           git config advice.addIgnoredFile false | ||||
|  | ||||
|           # set some variables | ||||
|           releaseName=$version | ||||
|           originalName=$version | ||||
|           zipName=FireflyIII-$version.zip | ||||
|           tarName=FireflyIII-$version.tar.gz | ||||
|  | ||||
|           # update composer (again) | ||||
|           composer update --no-dev --no-scripts --no-plugins | ||||
|           composer dump-autoload | ||||
|  | ||||
|           # if this is a develop build, slightly different variable names. | ||||
|           if [[ "develop" == "$version" ]]; then | ||||
|             [[ -z $(git status --untracked-files=normal --porcelain) ]] && echo "this branch is clean, no need to push..." && exit 0; | ||||
|             releaseName=$version-$(date +'%Y%m%d') | ||||
|             originalName=$releaseName | ||||
|             zipName=FireflyIII-develop.zip | ||||
|             tarName=FireflyIII-develop.tar.gz | ||||
|           fi | ||||
|  | ||||
|           # in both cases, if the release or tag already exists, add ".1" until it no longer exists. | ||||
|           tagFound=true | ||||
|           tagCount=1 | ||||
|           while [ "$tagFound" = true ] | ||||
|           do | ||||
|             if [ $(git tag -l "$releaseName") ]; then | ||||
|               echo "Tag $releaseName exists already." | ||||
|               releaseName="$originalName"."$tagCount" | ||||
|               echo "Tag for release is now $releaseName" | ||||
|               tagCount=$((tagCount+1)) | ||||
|             else | ||||
|              echo "Tag $releaseName does not exist, can continue" | ||||
|              tagFound=false | ||||
|             fi | ||||
|           done | ||||
|           echo "Will use tag and release name $releaseName." | ||||
|  | ||||
|           # add all content, except output.txt (this contains the changelog and/or the download instructions) | ||||
|           echo 'Add all and reset output.txt' | ||||
|           git add -A | ||||
|           if test -f "output.txt"; then | ||||
|             git reset output.txt | ||||
| @@ -141,19 +192,101 @@ jobs: | ||||
|           git commit -m "Auto commit for release '$version' on $(date +'%Y-%m-%d')" || true | ||||
|           git push | ||||
|  | ||||
|           # zip and tar everything | ||||
|           echo 'Zip and tar...' | ||||
|           zip -rq $zipName . -x "*.git*" "*.ci*" "*.github*" "*node_modules*" "*output.txt*" | ||||
|           touch $tarName | ||||
|           tar --exclude=$tarName --exclude=$zipName --exclude='./.git' --exclude='./.ci' --exclude='./.github' --exclude='./node_modules' --exclude='./output.txt' -czf $tarName . | ||||
|  | ||||
|           # add sha256 sum | ||||
|           echo 'Sha sum ...' | ||||
|           sha256sum -b $zipName > $zipName.sha256 | ||||
|           sha256sum -b $tarName > $tarName.sha256 | ||||
|  | ||||
|           # add signatures: | ||||
|           gpg --armor --detach-sign $zipName | ||||
|           gpg --armor --detach-sign $tarName | ||||
|  | ||||
|           # create a development (nightly) release: | ||||
|           if [[ "develop" == "$version" ]]; then | ||||
|             echo 'Develop release.' | ||||
|             # add text to output.txt (instructions) | ||||
|             rm output.txt | ||||
|             echo "Bi-weekly development release of Firefly III with the latest fixes, translations and features. Docker users can find this release under the \`develop\` tag." >> output.txt | ||||
|             echo "" >> output.txt | ||||
|             echo "This release was created on **$(date +'%Y-%m-%d')** and may contain unexpected bugs. Data loss is rare but is not impossible. The releases are signed, and you can verify them using the [Firefly III releases PGP key](https://docs.firefly-iii.org/explanation/more-information/signatures/)." >> output.txt | ||||
|             echo "" >> output.txt | ||||
|             echo "* Please read the installation instructions for [Docker](https://docs.firefly-iii.org/how-to/firefly-iii/installation/docker/), [Portainer](https://docs.firefly-iii.org/how-to/firefly-iii/installation/portainer/), [Kubernetes](https://docs.firefly-iii.org/how-to/firefly-iii/installation/kubernetes/) or [self-managed servers](https://docs.firefly-iii.org/how-to/firefly-iii/installation/self-managed/)" >> output.txt | ||||
|             echo "* Or read the upgrade instructions for [Docker](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/docker/), [Kubernetes](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/kubernetes/) or [self-managed servers](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/self-managed/)" >> output.txt | ||||
|             echo "" >> output.txt | ||||
|             echo ":warning: Please be careful with this pre-release, as it may not work as expected." >> output.txt | ||||
|  | ||||
|             # create the release: | ||||
|             echo "Create nightly release." | ||||
|             git tag -a $version-$(date +'%Y%m%d') -m "Nightly development release '$version' on $(date +'%Y-%m-%d')" | ||||
|             git push origin $version-$(date +'%Y%m%d') | ||||
|             gh release create $version-$(date +'%Y%m%d') -p --verify-tag \ | ||||
|             git tag -a $releaseName -m "Nightly development release '$version' on $(date +'%Y-%m-%d')" | ||||
|             git push origin $releaseName | ||||
|             gh release create $releaseName -p --verify-tag \ | ||||
|               -t "Development release for $(date +'%Y-%m-%d')" \ | ||||
|               -n "Bi-weekly development release of Firefly III with the latest fixes, translations and features. This release was created on **$(date +'%Y-%m-%d')** and may contain bugs. Use at your own risk. Docker users can find this release under the `develop` tag." | ||||
|               -F output.txt | ||||
|  | ||||
|             # add zip file to release. | ||||
|             gh release upload $releaseName $zipName | ||||
|             gh release upload $releaseName $tarName | ||||
|  | ||||
|             # add sha256 sum to release | ||||
|             gh release upload $releaseName $zipName.sha256 | ||||
|             gh release upload $releaseName $tarName.sha256 | ||||
|  | ||||
|             # add signatures to release | ||||
|             gh release upload $releaseName $zipName.asc | ||||
|             gh release upload $releaseName $tarName.asc | ||||
|  | ||||
|             # get current HEAD and add as file to the release | ||||
|             HEAD=$(git rev-parse HEAD) | ||||
|             echo $HEAD > HEAD.txt | ||||
|             gh release upload $releaseName HEAD.txt | ||||
|           else | ||||
|             echo 'MAIN (real) release' | ||||
|             sudo chown -R runner:docker output.txt | ||||
|             # add text to output.txt (more instructions) | ||||
|             echo '' >> output.txt | ||||
|             echo '### Instructions' >> output.txt | ||||
|             echo '' >> output.txt | ||||
|             echo "* Installation instructions for [Docker](https://docs.firefly-iii.org/how-to/firefly-iii/installation/docker/), [Portainer](https://docs.firefly-iii.org/how-to/firefly-iii/installation/portainer/), [Kubernetes](https://docs.firefly-iii.org/how-to/firefly-iii/installation/kubernetes/) or [self-managed servers](https://docs.firefly-iii.org/how-to/firefly-iii/installation/self-managed/)" >> output.txt | ||||
|             echo "* Or read the upgrade instructions for [Docker](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/docker/), [Kubernetes](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/kubernetes/) or [self-managed servers](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/self-managed/)" >> output.txt | ||||
|             echo "* The releases are signed, and you can verify them using the [Firefly III releases PGP key](https://docs.firefly-iii.org/explanation/more-information/signatures/)." >> output.txt | ||||
|  | ||||
|             echo "Create default release." | ||||
|             git tag -a $version -m "Here be changelog" | ||||
|             git push origin $version | ||||
|             gh release create $version -F output.txt -t "$version" --verify-tag | ||||
|             rm -f output.txt | ||||
|             git tag -a $releaseName -m "Here be changelog" | ||||
|             git push origin $releaseName | ||||
|             gh release create $releaseName -F output.txt -t "$releaseName" --verify-tag | ||||
|  | ||||
|             # add archive files to release | ||||
|             gh release upload $releaseName $zipName | ||||
|             gh release upload $releaseName $tarName | ||||
|  | ||||
|             # add sha256 sums to release | ||||
|             gh release upload $releaseName $zipName.sha256 | ||||
|             gh release upload $releaseName $tarName.sha256 | ||||
|  | ||||
|             # add signatures to release | ||||
|             gh release upload $releaseName $zipName.asc | ||||
|             gh release upload $releaseName $tarName.asc | ||||
|  | ||||
|             # get current HEAD and add as file to the release | ||||
|             HEAD=$(git rev-parse HEAD) | ||||
|             echo $HEAD > HEAD.txt | ||||
|             gh release upload $releaseName HEAD.txt | ||||
|  | ||||
|             # remove all temporary files | ||||
|             rm output.txt | ||||
|             rm HEAD.txt | ||||
|             rm $zipName | ||||
|             rm $zipName.sha256 | ||||
|             rm $tarName | ||||
|             rm $tarName.sha256 | ||||
|  | ||||
|             # merge main back into develop | ||||
|             git checkout develop | ||||
|             git merge main | ||||
|             git push | ||||
|   | ||||
							
								
								
									
										9
									
								
								.github/workflows/sonarcloud.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										9
									
								
								.github/workflows/sonarcloud.yml
									
									
									
									
										vendored
									
									
								
							| @@ -45,15 +45,6 @@ jobs: | ||||
|       - name: Install Composer dependencies | ||||
|         run: composer install --prefer-dist --no-interaction --no-progress --no-scripts | ||||
|  | ||||
|       - name: PHPStan | ||||
|         run: .ci/phpstan.sh | ||||
|  | ||||
|       - name: PHPMD | ||||
|         run: .ci/phpmd.sh | ||||
|  | ||||
|       - name: PHP CS Fixer | ||||
|         run: .ci/phpcs.sh | ||||
|  | ||||
|       - name: "Create database file" | ||||
|         run: touch storage/database/database.sqlite | ||||
|  | ||||
|   | ||||
							
								
								
									
										6
									
								
								.github/workflows/stale.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										6
									
								
								.github/workflows/stale.yml
									
									
									
									
										vendored
									
									
								
							| @@ -1,7 +1,7 @@ | ||||
| name: "Issues - Mark and close stale issues" | ||||
| on: | ||||
|   schedule: | ||||
|     - cron: "30 1 * * *" | ||||
|     - cron: "0 4 * * *" | ||||
|   workflow_dispatch: | ||||
|  | ||||
| permissions: | ||||
| @@ -17,7 +17,7 @@ jobs: | ||||
|       - uses: actions/stale@v9 | ||||
|         with: | ||||
|           repo-token: ${{ secrets.GITHUB_TOKEN }} | ||||
|           stale-issue-message: > | ||||
|           stale-issue-message: | | ||||
|             Hi there! | ||||
|  | ||||
|             This is an automatic reply. `Share and enjoy` | ||||
| @@ -25,7 +25,7 @@ jobs: | ||||
|             This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. | ||||
|  | ||||
|             Thank you for your contributions. | ||||
|           stale-pr-message: > | ||||
|           stale-pr-message: | | ||||
|             Hi there! | ||||
|  | ||||
|             This is an automatic reply. `Share and enjoy` | ||||
|   | ||||
							
								
								
									
										11
									
								
								.gitignore
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										11
									
								
								.gitignore
									
									
									
									
										vendored
									
									
								
							| @@ -7,3 +7,14 @@ yarn-error.log | ||||
| .env | ||||
| /.ci/php-cs-fixer/vendor | ||||
| coverage.xml | ||||
|  | ||||
| # ignore generated files. | ||||
| public/build | ||||
|  | ||||
| # ignore v1 build files | ||||
| resources/assets/v1/node_modules | ||||
| resources/assets/v1/build | ||||
|  | ||||
| # ignore v2 build files | ||||
| resources/assets/v2/node_modules | ||||
| resources/assets/v2/build | ||||
|   | ||||
							
								
								
									
										195
									
								
								THANKS.md
									
									
									
									
									
										Executable file
									
								
							
							
						
						
									
										195
									
								
								THANKS.md
									
									
									
									
									
										Executable file
									
								
							| @@ -0,0 +1,195 @@ | ||||
| # Thank you! :tada: :heart: :tada: | ||||
| 
 | ||||
| Over time, many people have contributed to Firefly III. Their efforts are not always visible, but always remembered and appreciated. | ||||
| Please find below all the people who contributed to the Firefly III code. Their names are mentioned in the year of their first contribution. | ||||
| 
 | ||||
| ## 2024 | ||||
| - withbest | ||||
| - Steve Wasiura | ||||
| - imlonghao | ||||
| - Rahman Yusuf | ||||
| - Michael Thomas | ||||
| - WardenJakx | ||||
| - kuilin | ||||
| - Stevie Robinson | ||||
| - luzpaz | ||||
| - Lemuel Roberto Bonifácio | ||||
| - maureenferreira | ||||
| 
 | ||||
| ## 2023 | ||||
| - tieu1991 | ||||
| - Maxco10 | ||||
| - zqye | ||||
| - Mateus Pereira | ||||
| - josephbadow | ||||
| - Christian Desktop | ||||
| - Edgars | ||||
| - Hannah K | ||||
| - noxonad | ||||
| - Kaijia Feng | ||||
| - Marc Ordinas i Llopis | ||||
| - Kuba Turek | ||||
| - Julien Stébenne | ||||
| 
 | ||||
| ## 2022 | ||||
| - Johannes Zellner | ||||
| - Janne Heß | ||||
| - charlesteets | ||||
| - Nathan PERIER | ||||
| - Jan Willhaus | ||||
| - canoine | ||||
| - Rick Cuddy | ||||
| - James | ||||
| - Hugo Meyronneinc | ||||
| - naveen | ||||
| - neilnaveen | ||||
| - naveensrinivasan | ||||
| - Federico Micelli | ||||
| - George Hahn | ||||
| 
 | ||||
| ## 2021 | ||||
| - StillLoading | ||||
| - Igor Rzegocki | ||||
| - Lorenzo Breda | ||||
| - Hosh | ||||
| - Flightkick | ||||
| - alex6480 | ||||
| - VREEdom | ||||
| - Hamza FADIL | ||||
| - Kasper Læssø Sørensen | ||||
| - Alex | ||||
| - Jeroen De Meerleer | ||||
| - Ruben van Erk | ||||
| - Fabian Zimmermann | ||||
| - Mirko Berger | ||||
| - KaihatsuOnline | ||||
| - MihataBG | ||||
| 
 | ||||
| ## 2020 | ||||
| - Hannes Körber | ||||
| - Julien Cassagne | ||||
| - bu4ak | ||||
| - Viktor Yakovlev | ||||
| - Oliver Kaufmann | ||||
| - Arvind Chembarpu | ||||
| - GrayStrider | ||||
| - psychowood | ||||
| - Hosh Sadiq | ||||
| - emansih | ||||
| - Aniruddha Maru | ||||
| - johnny | ||||
| - sephrat | ||||
| - bpatath | ||||
| - Florian Dupret | ||||
| - Maxim Kurbatov | ||||
| - Lucas Guima | ||||
| - Sandro | ||||
| - Ruben Verhoef | ||||
| - Daniel Idzerda | ||||
| - Calum Smith | ||||
| - Agraphie | ||||
| - Tomer Shvueli | ||||
| - Tomer S | ||||
| 
 | ||||
| ## 2019 | ||||
| - Pascal Jungblut | ||||
| - Justyn Shull | ||||
| - Timendum | ||||
| - Nicolas Lœuillet | ||||
| - Dominic Guhl | ||||
| - Melroy van den Berg | ||||
| - Henning Stein | ||||
| - Jan Klepek | ||||
| - Jonathan | ||||
| - Geoffrey “Frogeye” Preud'homme | ||||
| - Michael Fix | ||||
| - Juraj Mlich | ||||
| - Eddybrando Vásquez | ||||
| - hulloanson | ||||
| - Will Rouesnel | ||||
| - lastlink | ||||
| - Mr. Funk | ||||
| - Simon Taddiken | ||||
| - Joris | ||||
| - Bastiaan Nijkamp | ||||
| 
 | ||||
| ## 2018 | ||||
| - a1ex4 | ||||
| - Daniel Quah | ||||
| - Marco Lourenço | ||||
| - Dennis Enderink | ||||
| - Luca Bognolo | ||||
| - Mike Conway | ||||
| - Ben | ||||
| - Mathieu Post | ||||
| - George Hertz | ||||
| - HamuZ HamuZ | ||||
| - David Meiseles | ||||
| - Erik Gelderblom | ||||
| - Luca Vallerini | ||||
| - Clemens Wijnekus | ||||
| - Jacob Weisz | ||||
| - Mateusz Gozdek | ||||
| - anmol26s | ||||
| - Kevin Hellemun | ||||
| - Shashank M Chakravarthy | ||||
| - Nico Schreiner | ||||
| - Paul Sohier | ||||
| - Brenden Conte | ||||
| - Ben Yanke | ||||
| - Andrew Prokhorenkov | ||||
| - devlearner | ||||
| - Kelvin | ||||
| - J'informatique | ||||
| 
 | ||||
| ## 2017 | ||||
| - Victor Mosin | ||||
| - Justin | ||||
| - Hugo van Duijn | ||||
| - Lukas Winkler | ||||
| - Marcin Szymanski | ||||
| - Jens Kat | ||||
| - koziolek | ||||
| - jleeong | ||||
| - Simon Hanna | ||||
| - richard & xeli.eu | ||||
| - Sergey Besedin | ||||
| - Welbert Serra | ||||
| - Joris de Vries | ||||
| - Patrick Kostjens | ||||
| - Enrico Lamperti | ||||
| - Christian Musa | ||||
| - Enno Lohmeier | ||||
| 
 | ||||
| ## 2016 | ||||
| - Sander | ||||
| - Toon Schoenmakers | ||||
| - Telyn | ||||
| - Sander Kleykens | ||||
| - Tom van der Werf | ||||
| - Matthew Peck | ||||
| - Sander Mulders | ||||
| - Bonno Nachtegaal-Karels | ||||
| - Niek Haarman | ||||
| - Edwin | ||||
| - Thijs Alkemade | ||||
| - zjean | ||||
| - Graham Miller | ||||
| - Robert Horlings | ||||
| - leander091 | ||||
| 
 | ||||
| ## 2015 | ||||
| - Antonio Spinelli | ||||
| - Colin O'Dell | ||||
| - RonaldvanMeer | ||||
| - Richard Ebbers | ||||
| - Balazs Varkonyi | ||||
| - Niek van der Kooy | ||||
| - Ilya Kil | ||||
| 
 | ||||
| ## 2014 | ||||
| - Stewart Malik | ||||
| - Graham Campbell | ||||
| 
 | ||||
| 
 | ||||
| Thank you for all your support! | ||||
| @@ -83,17 +83,17 @@ class AccountController extends Controller | ||||
|         // user's preferences
 | ||||
|         $defaultSet = $this->repository->getAccountsByType([AccountType::ASSET])->pluck('id')->toArray(); | ||||
| 
 | ||||
|         /** @var Preference $frontPage */ | ||||
|         $frontPage  = app('preferences')->get('frontPageAccounts', $defaultSet); | ||||
|         /** @var Preference $frontpage */ | ||||
|         $frontpage  = app('preferences')->get('frontpageAccounts', $defaultSet); | ||||
|         $default    = app('amount')->getDefaultCurrency(); | ||||
| 
 | ||||
|         if (!(is_array($frontPage->data) && count($frontPage->data) > 0)) { | ||||
|             $frontPage->data = $defaultSet; | ||||
|             $frontPage->save(); | ||||
|         if (!(is_array($frontpage->data) && count($frontpage->data) > 0)) { | ||||
|             $frontpage->data = $defaultSet; | ||||
|             $frontpage->save(); | ||||
|         } | ||||
| 
 | ||||
|         // get accounts:
 | ||||
|         $accounts   = $this->repository->getAccountsById($frontPage->data); | ||||
|         $accounts   = $this->repository->getAccountsById($frontpage->data); | ||||
|         $chartData  = []; | ||||
| 
 | ||||
|         /** @var Account $account */ | ||||
|   | ||||
| @@ -76,38 +76,6 @@ abstract class Controller extends BaseController | ||||
|         ); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Method to help build URL's. | ||||
|      */ | ||||
|     final protected function buildParams(): string | ||||
|     { | ||||
|         $return = '?'; | ||||
|         $params = []; | ||||
|         foreach ($this->parameters as $key => $value) { | ||||
|             if ('page' === $key) { | ||||
|                 continue; | ||||
|             } | ||||
|             if ($value instanceof Carbon) { | ||||
|                 $params[$key] = $value->format('Y-m-d'); | ||||
| 
 | ||||
|                 continue; | ||||
|             } | ||||
|             $params[$key] = $value; | ||||
|         } | ||||
| 
 | ||||
|         return $return.http_build_query($params); | ||||
|     } | ||||
| 
 | ||||
|     final protected function getManager(): Manager | ||||
|     { | ||||
|         // create some objects:
 | ||||
|         $manager = new Manager(); | ||||
|         $baseUrl = request()->getSchemeAndHttpHost().'/api/v1'; | ||||
|         $manager->setSerializer(new JsonApiSerializer($baseUrl)); | ||||
| 
 | ||||
|         return $manager; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Method to grab all parameters from the URL. | ||||
|      */ | ||||
| @@ -216,4 +184,36 @@ abstract class Controller extends BaseController | ||||
| 
 | ||||
|         return $bag; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Method to help build URL's. | ||||
|      */ | ||||
|     final protected function buildParams(): string | ||||
|     { | ||||
|         $return = '?'; | ||||
|         $params = []; | ||||
|         foreach ($this->parameters as $key => $value) { | ||||
|             if ('page' === $key) { | ||||
|                 continue; | ||||
|             } | ||||
|             if ($value instanceof Carbon) { | ||||
|                 $params[$key] = $value->format('Y-m-d'); | ||||
| 
 | ||||
|                 continue; | ||||
|             } | ||||
|             $params[$key] = $value; | ||||
|         } | ||||
| 
 | ||||
|         return $return.http_build_query($params); | ||||
|     } | ||||
| 
 | ||||
|     final protected function getManager(): Manager | ||||
|     { | ||||
|         // create some objects:
 | ||||
|         $manager = new Manager(); | ||||
|         $baseUrl = request()->getSchemeAndHttpHost().'/api/v1'; | ||||
|         $manager->setSerializer(new JsonApiSerializer($baseUrl)); | ||||
| 
 | ||||
|         return $manager; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -68,7 +68,7 @@ class DestroyController extends Controller | ||||
|         $allExceptAssets = [AccountType::BENEFICIARY, AccountType::CASH, AccountType::CREDITCARD, AccountType::DEFAULT, AccountType::EXPENSE, AccountType::IMPORT, AccountType::INITIAL_BALANCE, AccountType::LIABILITY_CREDIT, AccountType::RECONCILIATION, AccountType::REVENUE]; | ||||
|         $all             = [AccountType::ASSET, AccountType::BENEFICIARY, AccountType::CASH, AccountType::CREDITCARD, AccountType::DEBT, AccountType::DEFAULT, AccountType::EXPENSE, AccountType::IMPORT, AccountType::INITIAL_BALANCE, AccountType::LIABILITY_CREDIT, AccountType::LOAN, AccountType::MORTGAGE, AccountType::RECONCILIATION]; | ||||
|         $liabilities     = [AccountType::DEBT, AccountType::LOAN, AccountType::MORTGAGE, AccountType::CREDITCARD]; | ||||
|         $transactions    = [TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::TRANSFER, TransactionType::RECONCILIATION, TransactionType::OPENING_BALANCE]; | ||||
|         $transactions    = [TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::TRANSFER, TransactionType::RECONCILIATION]; | ||||
| 
 | ||||
|         match ($objects) { | ||||
|             'budgets'                => $this->destroyBudgets(), | ||||
|   | ||||
| @@ -68,6 +68,32 @@ class ExportController extends Controller | ||||
|         return $this->returnExport('accounts'); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * @throws FireflyException | ||||
|      */ | ||||
|     private function returnExport(string $key): LaravelResponse | ||||
|     { | ||||
|         $date     = date('Y-m-d-H-i-s'); | ||||
|         $fileName = sprintf('%s-export-%s.csv', $date, $key); | ||||
|         $data     = $this->exporter->export(); | ||||
| 
 | ||||
|         /** @var LaravelResponse $response */ | ||||
|         $response = response($data[$key]); | ||||
|         $response | ||||
|             ->header('Content-Description', 'File Transfer') | ||||
|             ->header('Content-Type', 'application/octet-stream') | ||||
|             ->header('Content-Disposition', 'attachment; filename='.$fileName) | ||||
|             ->header('Content-Transfer-Encoding', 'binary') | ||||
|             ->header('Connection', 'Keep-Alive') | ||||
|             ->header('Expires', '0') | ||||
|             ->header('Cache-Control', 'must-revalidate, post-check=0, pre-check=0') | ||||
|             ->header('Pragma', 'public') | ||||
|             ->header('Content-Length', (string)strlen($data[$key])) | ||||
|         ; | ||||
| 
 | ||||
|         return $response; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * This endpoint is documented at: | ||||
|      * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportBills
 | ||||
| @@ -189,30 +215,4 @@ class ExportController extends Controller | ||||
| 
 | ||||
|         return $this->returnExport('transactions'); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * @throws FireflyException | ||||
|      */ | ||||
|     private function returnExport(string $key): LaravelResponse | ||||
|     { | ||||
|         $date     = date('Y-m-d-H-i-s'); | ||||
|         $fileName = sprintf('%s-export-%s.csv', $date, $key); | ||||
|         $data     = $this->exporter->export(); | ||||
| 
 | ||||
|         /** @var LaravelResponse $response */ | ||||
|         $response = response($data[$key]); | ||||
|         $response | ||||
|             ->header('Content-Description', 'File Transfer') | ||||
|             ->header('Content-Type', 'application/octet-stream') | ||||
|             ->header('Content-Disposition', 'attachment; filename='.$fileName) | ||||
|             ->header('Content-Transfer-Encoding', 'binary') | ||||
|             ->header('Connection', 'Keep-Alive') | ||||
|             ->header('Expires', '0') | ||||
|             ->header('Cache-Control', 'must-revalidate, post-check=0, pre-check=0') | ||||
|             ->header('Pragma', 'public') | ||||
|             ->header('Content-Length', (string) strlen($data[$key])) | ||||
|         ; | ||||
| 
 | ||||
|         return $response; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -1,8 +1,7 @@ | ||||
| <?php | ||||
| 
 | ||||
| /** | ||||
|  * auth.php | ||||
|  * Copyright (c) 2019 james@firefly-iii.org | ||||
| /* | ||||
|  * ExpressionController.php | ||||
|  * Copyright (c) 2024 Michael Thomas | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
| @@ -20,20 +19,29 @@ | ||||
|  * along with this program.  If not, see <https://www.gnu.org/licenses/>. | ||||
|  */ | ||||
| 
 | ||||
| /* | ||||
|  * PLEASE DO NOT EDIT THIS FILE DIRECTLY. | ||||
|  * YOUR CHANGES WILL BE OVERWRITTEN! | ||||
|  * YOUR PR WITH CHANGES TO THIS FILE WILL BE REJECTED! | ||||
|  * | ||||
|  * GO TO CROWDIN TO FIX OR CHANGE TRANSLATIONS! | ||||
|  * | ||||
|  * https://crowdin.com/project/firefly-iii | ||||
|  * | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| 
 | ||||
| return [ | ||||
|     'failed'   => 'Въведените удостоверителни данни не съвпадат с нашите записи.', | ||||
|     'throttle' => 'Твърде много опити за влизане. Опитайте се пак след :seconds секунди.', | ||||
| ]; | ||||
| namespace FireflyIII\Api\V1\Controllers\Models\Rule; | ||||
| 
 | ||||
| use FireflyIII\Api\V1\Controllers\Controller; | ||||
| use FireflyIII\Api\V1\Requests\Models\Rule\ValidateExpressionRequest; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| 
 | ||||
| /** | ||||
|  * Class ExpressionController | ||||
|  */ | ||||
| class ExpressionController extends Controller | ||||
| { | ||||
|     /** | ||||
|      * This endpoint is documented at: | ||||
|      * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/rules/validateExpression
 | ||||
|      * | ||||
|      * @SuppressWarnings(PHPMD.UnusedFormalParameter) | ||||
|      */ | ||||
|     public function validateExpression(ValidateExpressionRequest $request): JsonResponse | ||||
|     { | ||||
|         return response()->json([ | ||||
|             'valid' => true, | ||||
|         ]); | ||||
|     } | ||||
| } | ||||
| @@ -147,7 +147,7 @@ class TriggerController extends Controller | ||||
|             // add a range:
 | ||||
|             $ruleEngine->addOperator(['type' => 'date_before', 'value' => $parameters['end']->format('Y-m-d')]); | ||||
|         } | ||||
|         if (array_key_exists('accounts', $parameters) && '' !== $parameters['accounts']) { | ||||
|         if (array_key_exists('accounts', $parameters) && is_array($parameters['accounts']) && count($parameters['accounts']) > 0) { | ||||
|             $ruleEngine->addOperator(['type' => 'account_id', 'value' => implode(',', $parameters['accounts'])]); | ||||
|         } | ||||
| 
 | ||||
|   | ||||
| @@ -69,9 +69,15 @@ class UpdateController extends Controller | ||||
|      */ | ||||
|     public function update(UpdateRequest $request, TransactionGroup $transactionGroup): JsonResponse | ||||
|     { | ||||
|         app('log')->debug('Now in update routine for transaction group!'); | ||||
|         app('log')->debug('Now in update routine for transaction group'); | ||||
|         $data             = $request->getAll(); | ||||
| 
 | ||||
|         // Fixes 8750.
 | ||||
|         $transactions     = $data['transactions'] ?? []; | ||||
|         foreach ($transactions as $index => $info) { | ||||
|             unset($data['transactions'][$index]['type']); | ||||
|         } | ||||
| 
 | ||||
|         $transactionGroup = $this->groupRepository->update($transactionGroup, $data); | ||||
|         $manager          = $this->getManager(); | ||||
| 
 | ||||
|   | ||||
| @@ -34,6 +34,7 @@ use FireflyIII\Support\Http\Api\TransactionFilter; | ||||
| use FireflyIII\Transformers\CurrencyTransformer; | ||||
| use FireflyIII\User; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use League\Fractal\Resource\Item; | ||||
| 
 | ||||
| /** | ||||
| @@ -164,6 +165,7 @@ class UpdateController extends Controller | ||||
|     public function update(UpdateRequest $request, TransactionCurrency $currency): JsonResponse | ||||
|     { | ||||
|         $data        = $request->getAll(); | ||||
|         Log::debug(__METHOD__, $data); | ||||
| 
 | ||||
|         /** @var User $user */ | ||||
|         $user        = auth()->user(); | ||||
| @@ -173,6 +175,11 @@ class UpdateController extends Controller | ||||
|         if (array_key_exists('enabled', $data) && false === $data['enabled'] && 1 === count($set) && $set->first()->id === $currency->id) { | ||||
|             return response()->json([], 409); | ||||
|         } | ||||
|         // second safety catch on currency disable.
 | ||||
|         if (array_key_exists('enabled', $data) && false === $data['enabled'] && $this->repository->currencyInUse($currency)) { | ||||
|             return response()->json([], 409); | ||||
|         } | ||||
| 
 | ||||
|         $currency    = $this->repository->update($currency, $data); | ||||
| 
 | ||||
|         app('preferences')->mark(); | ||||
|   | ||||
| @@ -118,23 +118,6 @@ class BasicController extends Controller | ||||
|         return response()->json($return); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Check if date is outside session range. | ||||
|      */ | ||||
|     protected function notInDateRange(Carbon $date, Carbon $start, Carbon $end): bool // Validate a preference
 | ||||
|     { | ||||
|         $result = false; | ||||
|         if ($start->greaterThanOrEqualTo($date) && $end->greaterThanOrEqualTo($date)) { | ||||
|             $result = true; | ||||
|         } | ||||
|         // start and end in the past? use $end
 | ||||
|         if ($start->lessThanOrEqualTo($date) && $end->lessThanOrEqualTo($date)) { | ||||
|             $result = true; | ||||
|         } | ||||
| 
 | ||||
|         return $result; | ||||
|     } | ||||
| 
 | ||||
|     private function getBalanceInformation(Carbon $start, Carbon $end): array | ||||
|     { | ||||
|         // prep some arrays:
 | ||||
| @@ -298,7 +281,7 @@ class BasicController extends Controller | ||||
|             $spentInCurrency = $row['sum']; | ||||
|             $leftToSpend     = bcadd($amount, $spentInCurrency); | ||||
| 
 | ||||
|             $days            = $today->diffInDays($end) + 1; | ||||
|             $days            = (int)$today->diffInDays($end, true) + 1; | ||||
|             $perDay          = '0'; | ||||
|             if (0 !== $days && bccomp($leftToSpend, '0') > -1) { | ||||
|                 $perDay = bcdiv($leftToSpend, (string)$days); | ||||
| @@ -380,4 +363,21 @@ class BasicController extends Controller | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Check if date is outside session range. | ||||
|      */ | ||||
|     protected function notInDateRange(Carbon $date, Carbon $start, Carbon $end): bool // Validate a preference
 | ||||
|     { | ||||
|         $result = false; | ||||
|         if ($start->greaterThanOrEqualTo($date) && $end->greaterThanOrEqualTo($date)) { | ||||
|             $result = true; | ||||
|         } | ||||
|         // start and end in the past? use $end
 | ||||
|         if ($start->lessThanOrEqualTo($date) && $end->lessThanOrEqualTo($date)) { | ||||
|             $result = true; | ||||
|         } | ||||
| 
 | ||||
|         return $result; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -88,6 +88,35 @@ class ConfigurationController extends Controller | ||||
|         return response()->json($return); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Get all config values. | ||||
|      */ | ||||
|     private function getDynamicConfiguration(): array | ||||
|     { | ||||
|         $isDemoSite  = app('fireflyconfig')->get('is_demo_site'); | ||||
|         $updateCheck = app('fireflyconfig')->get('permission_update_check'); | ||||
|         $lastCheck   = app('fireflyconfig')->get('last_update_check'); | ||||
|         $singleUser  = app('fireflyconfig')->get('single_user_mode'); | ||||
| 
 | ||||
|         return [ | ||||
|             'is_demo_site'            => $isDemoSite?->data, | ||||
|             'permission_update_check' => null === $updateCheck ? null : (int)$updateCheck->data, | ||||
|             'last_update_check'       => null === $lastCheck ? null : (int)$lastCheck->data, | ||||
|             'single_user_mode'        => $singleUser?->data, | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     private function getStaticConfiguration(): array | ||||
|     { | ||||
|         $list   = EitherConfigKey::$static; | ||||
|         $return = []; | ||||
|         foreach ($list as $key) { | ||||
|             $return[$key] = config($key); | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * This endpoint is documented at: | ||||
|      * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/configuration/getSingleConfiguration
 | ||||
| @@ -145,33 +174,4 @@ class ConfigurationController extends Controller | ||||
| 
 | ||||
|         return response()->json(['data' => $data])->header('Content-Type', self::CONTENT_TYPE); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Get all config values. | ||||
|      */ | ||||
|     private function getDynamicConfiguration(): array | ||||
|     { | ||||
|         $isDemoSite  = app('fireflyconfig')->get('is_demo_site'); | ||||
|         $updateCheck = app('fireflyconfig')->get('permission_update_check'); | ||||
|         $lastCheck   = app('fireflyconfig')->get('last_update_check'); | ||||
|         $singleUser  = app('fireflyconfig')->get('single_user_mode'); | ||||
| 
 | ||||
|         return [ | ||||
|             'is_demo_site'            => $isDemoSite?->data, | ||||
|             'permission_update_check' => null === $updateCheck ? null : (int)$updateCheck->data, | ||||
|             'last_update_check'       => null === $lastCheck ? null : (int)$lastCheck->data, | ||||
|             'single_user_mode'        => $singleUser?->data, | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     private function getStaticConfiguration(): array | ||||
|     { | ||||
|         $list   = EitherConfigKey::$static; | ||||
|         $return = []; | ||||
|         foreach ($list as $key) { | ||||
|             $return[$key] = config($key); | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -32,6 +32,7 @@ use FireflyIII\Models\Preference; | ||||
| use FireflyIII\Transformers\PreferenceTransformer; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Pagination\LengthAwarePaginator; | ||||
| use Illuminate\Support\Collection; | ||||
| use League\Fractal\Pagination\IlluminatePaginatorAdapter; | ||||
| use League\Fractal\Resource\Collection as FractalCollection; | ||||
| use League\Fractal\Resource\Item; | ||||
| @@ -84,6 +85,10 @@ class PreferencesController extends Controller | ||||
|     { | ||||
|         $manager     = $this->getManager(); | ||||
| 
 | ||||
|         if ('currencyPreference' === $preference->name) { | ||||
|             throw new FireflyException('Please use api/v1/currencies/default instead.'); | ||||
|         } | ||||
| 
 | ||||
|         /** @var PreferenceTransformer $transformer */ | ||||
|         $transformer = app(PreferenceTransformer::class); | ||||
|         $transformer->setParameters($this->parameters); | ||||
| @@ -93,6 +98,34 @@ class PreferencesController extends Controller | ||||
|         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * TODO This endpoint is not documented. | ||||
|      * | ||||
|      * Return a single preference by name. | ||||
|      * | ||||
|      * @param Collection<int, Preference> $collection | ||||
|      */ | ||||
|     public function showList(Collection $collection): JsonResponse | ||||
|     { | ||||
|         $manager     = $this->getManager(); | ||||
|         $count       = $collection->count(); | ||||
|         $pageSize    = $this->parameters->get('limit'); | ||||
|         $preferences = $collection->slice(($this->parameters->get('page') - 1) * $pageSize, $pageSize); | ||||
| 
 | ||||
|         // make paginator:
 | ||||
|         $paginator   = new LengthAwarePaginator($preferences, $count, $pageSize, $this->parameters->get('page')); | ||||
|         $paginator->setPath(route('api.v1.preferences.show-list').$this->buildParams()); | ||||
| 
 | ||||
|         /** @var PreferenceTransformer $transformer */ | ||||
|         $transformer = app(PreferenceTransformer::class); | ||||
|         $transformer->setParameters($this->parameters); | ||||
| 
 | ||||
|         $resource    = new FractalCollection($preferences, $transformer, self::RESOURCE_KEY); | ||||
|         $resource->setPaginator(new IlluminatePaginatorAdapter($paginator)); | ||||
| 
 | ||||
|         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * This endpoint is documented at: | ||||
|      * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/preferences/storePreference
 | ||||
| @@ -103,6 +136,11 @@ class PreferencesController extends Controller | ||||
|     { | ||||
|         $manager     = $this->getManager(); | ||||
|         $data        = $request->getAll(); | ||||
| 
 | ||||
|         if ('currencyPreference' === $data['name']) { | ||||
|             throw new FireflyException('Please use api/v1/currencies/default instead.'); | ||||
|         } | ||||
| 
 | ||||
|         $pref        = app('preferences')->set($data['name'], $data['data']); | ||||
| 
 | ||||
|         /** @var PreferenceTransformer $transformer */ | ||||
| @@ -122,6 +160,10 @@ class PreferencesController extends Controller | ||||
|      */ | ||||
|     public function update(PreferenceUpdateRequest $request, Preference $preference): JsonResponse | ||||
|     { | ||||
|         if ('currencyPreference' === $preference->name) { | ||||
|             throw new FireflyException('Please use api/v1/currencies/default instead.'); | ||||
|         } | ||||
| 
 | ||||
|         $manager     = $this->getManager(); | ||||
|         $data        = $request->getAll(); | ||||
|         $pref        = app('preferences')->set($preference->name, $data['data']); | ||||
|   | ||||
| @@ -46,7 +46,7 @@ class DateRequest extends FormRequest | ||||
|     { | ||||
|         $start = $this->getCarbonDate('start'); | ||||
|         $end   = $this->getCarbonDate('end'); | ||||
|         if($start->diffInYears($end) > 5) { | ||||
|         if ($start->diffInYears($end, true) > 5) { | ||||
|             throw new FireflyException('Date range out of range.'); | ||||
|         } | ||||
| 
 | ||||
|   | ||||
| @@ -78,6 +78,25 @@ class GenericRequest extends FormRequest | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     private function parseAccounts(): void | ||||
|     { | ||||
|         if (0 !== $this->accounts->count()) { | ||||
|             return; | ||||
|         } | ||||
|         $repository = app(AccountRepositoryInterface::class); | ||||
|         $repository->setUser(auth()->user()); | ||||
|         $array      = $this->get('accounts'); | ||||
|         if (is_array($array)) { | ||||
|             foreach ($array as $accountId) { | ||||
|                 $accountId = (int)$accountId; | ||||
|                 $account   = $repository->find($accountId); | ||||
|                 if (null !== $account) { | ||||
|                     $this->accounts->push($account); | ||||
|                 } | ||||
|             } | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     public function getBills(): Collection | ||||
|     { | ||||
|         $this->parseBills(); | ||||
| @@ -85,6 +104,25 @@ class GenericRequest extends FormRequest | ||||
|         return $this->bills; | ||||
|     } | ||||
| 
 | ||||
|     private function parseBills(): void | ||||
|     { | ||||
|         if (0 !== $this->bills->count()) { | ||||
|             return; | ||||
|         } | ||||
|         $repository = app(BillRepositoryInterface::class); | ||||
|         $repository->setUser(auth()->user()); | ||||
|         $array      = $this->get('bills'); | ||||
|         if (is_array($array)) { | ||||
|             foreach ($array as $billId) { | ||||
|                 $billId = (int)$billId; | ||||
|                 $bill   = $repository->find($billId); | ||||
|                 if (null !== $bill) { | ||||
|                     $this->bills->push($bill); | ||||
|                 } | ||||
|             } | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     public function getBudgets(): Collection | ||||
|     { | ||||
|         $this->parseBudgets(); | ||||
| @@ -92,6 +130,25 @@ class GenericRequest extends FormRequest | ||||
|         return $this->budgets; | ||||
|     } | ||||
| 
 | ||||
|     private function parseBudgets(): void | ||||
|     { | ||||
|         if (0 !== $this->budgets->count()) { | ||||
|             return; | ||||
|         } | ||||
|         $repository = app(BudgetRepositoryInterface::class); | ||||
|         $repository->setUser(auth()->user()); | ||||
|         $array      = $this->get('budgets'); | ||||
|         if (is_array($array)) { | ||||
|             foreach ($array as $budgetId) { | ||||
|                 $budgetId = (int)$budgetId; | ||||
|                 $budget   = $repository->find($budgetId); | ||||
|                 if (null !== $budget) { | ||||
|                     $this->budgets->push($budget); | ||||
|                 } | ||||
|             } | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     public function getCategories(): Collection | ||||
|     { | ||||
|         $this->parseCategories(); | ||||
| @@ -99,6 +156,25 @@ class GenericRequest extends FormRequest | ||||
|         return $this->categories; | ||||
|     } | ||||
| 
 | ||||
|     private function parseCategories(): void | ||||
|     { | ||||
|         if (0 !== $this->categories->count()) { | ||||
|             return; | ||||
|         } | ||||
|         $repository = app(CategoryRepositoryInterface::class); | ||||
|         $repository->setUser(auth()->user()); | ||||
|         $array      = $this->get('categories'); | ||||
|         if (is_array($array)) { | ||||
|             foreach ($array as $categoryId) { | ||||
|                 $categoryId = (int)$categoryId; | ||||
|                 $category   = $repository->find($categoryId); | ||||
|                 if (null !== $category) { | ||||
|                     $this->categories->push($category); | ||||
|                 } | ||||
|             } | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     public function getEnd(): Carbon | ||||
|     { | ||||
|         $date = $this->getCarbonDate('end'); | ||||
| @@ -154,100 +230,6 @@ class GenericRequest extends FormRequest | ||||
|         return $this->tags; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * The rules that the incoming request must be matched against. | ||||
|      */ | ||||
|     public function rules(): array | ||||
|     { | ||||
|         // this is cheating, but it works to initialize the collections.
 | ||||
|         $this->accounts   = new Collection(); | ||||
|         $this->budgets    = new Collection(); | ||||
|         $this->categories = new Collection(); | ||||
|         $this->bills      = new Collection(); | ||||
|         $this->tags       = new Collection(); | ||||
| 
 | ||||
|         return [ | ||||
|             'start' => 'required|date', | ||||
|             'end'   => 'required|date|after_or_equal:start', | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     private function parseAccounts(): void | ||||
|     { | ||||
|         if (0 !== $this->accounts->count()) { | ||||
|             return; | ||||
|         } | ||||
|         $repository = app(AccountRepositoryInterface::class); | ||||
|         $repository->setUser(auth()->user()); | ||||
|         $array      = $this->get('accounts'); | ||||
|         if (is_array($array)) { | ||||
|             foreach ($array as $accountId) { | ||||
|                 $accountId = (int)$accountId; | ||||
|                 $account   = $repository->find($accountId); | ||||
|                 if (null !== $account) { | ||||
|                     $this->accounts->push($account); | ||||
|                 } | ||||
|             } | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     private function parseBills(): void | ||||
|     { | ||||
|         if (0 !== $this->bills->count()) { | ||||
|             return; | ||||
|         } | ||||
|         $repository = app(BillRepositoryInterface::class); | ||||
|         $repository->setUser(auth()->user()); | ||||
|         $array      = $this->get('bills'); | ||||
|         if (is_array($array)) { | ||||
|             foreach ($array as $billId) { | ||||
|                 $billId = (int)$billId; | ||||
|                 $bill   = $repository->find($billId); | ||||
|                 if (null !== $bill) { | ||||
|                     $this->bills->push($bill); | ||||
|                 } | ||||
|             } | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     private function parseBudgets(): void | ||||
|     { | ||||
|         if (0 !== $this->budgets->count()) { | ||||
|             return; | ||||
|         } | ||||
|         $repository = app(BudgetRepositoryInterface::class); | ||||
|         $repository->setUser(auth()->user()); | ||||
|         $array      = $this->get('budgets'); | ||||
|         if (is_array($array)) { | ||||
|             foreach ($array as $budgetId) { | ||||
|                 $budgetId = (int)$budgetId; | ||||
|                 $budget   = $repository->find($budgetId); | ||||
|                 if (null !== $budget) { | ||||
|                     $this->budgets->push($budget); | ||||
|                 } | ||||
|             } | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     private function parseCategories(): void | ||||
|     { | ||||
|         if (0 !== $this->categories->count()) { | ||||
|             return; | ||||
|         } | ||||
|         $repository = app(CategoryRepositoryInterface::class); | ||||
|         $repository->setUser(auth()->user()); | ||||
|         $array      = $this->get('categories'); | ||||
|         if (is_array($array)) { | ||||
|             foreach ($array as $categoryId) { | ||||
|                 $categoryId = (int)$categoryId; | ||||
|                 $category   = $repository->find($categoryId); | ||||
|                 if (null !== $category) { | ||||
|                     $this->categories->push($category); | ||||
|                 } | ||||
|             } | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     private function parseTags(): void | ||||
|     { | ||||
|         if (0 !== $this->tags->count()) { | ||||
| @@ -266,4 +248,22 @@ class GenericRequest extends FormRequest | ||||
|             } | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * The rules that the incoming request must be matched against. | ||||
|      */ | ||||
|     public function rules(): array | ||||
|     { | ||||
|         // this is cheating, but it works to initialize the collections.
 | ||||
|         $this->accounts   = new Collection(); | ||||
|         $this->budgets    = new Collection(); | ||||
|         $this->categories = new Collection(); | ||||
|         $this->bills      = new Collection(); | ||||
|         $this->tags       = new Collection(); | ||||
| 
 | ||||
|         return [ | ||||
|             'start' => 'required|date', | ||||
|             'end'   => 'required|date|after_or_equal:start', | ||||
|         ]; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -63,7 +63,7 @@ class StoreRequest extends FormRequest | ||||
|             'order'                   => $this->convertInteger('order'), | ||||
|             'currency_code'           => $this->convertString('currency_code'), | ||||
|             'virtual_balance'         => $this->convertString('virtual_balance'), | ||||
|             'iban'                    => $this->convertString('iban'), | ||||
|             'iban'                    => $this->convertIban('iban'), | ||||
|             'BIC'                     => $this->convertString('bic'), | ||||
|             'account_number'          => $this->convertString('account_number'), | ||||
|             'account_role'            => $this->convertString('account_role'), | ||||
|   | ||||
| @@ -51,7 +51,7 @@ class UpdateRequest extends FormRequest | ||||
|             'include_net_worth'       => ['include_net_worth', 'boolean'], | ||||
|             'account_type_name'       => ['type', 'convertString'], | ||||
|             'virtual_balance'         => ['virtual_balance', 'convertString'], | ||||
|             'iban'                    => ['iban', 'convertString'], | ||||
|             'iban'                    => ['iban', 'convertIban'], | ||||
|             'BIC'                     => ['bic', 'convertString'], | ||||
|             'account_number'          => ['account_number', 'convertString'], | ||||
|             'account_role'            => ['account_role', 'convertString'], | ||||
|   | ||||
| @@ -58,7 +58,7 @@ class StoreRequest extends FormRequest | ||||
|         $models = config('firefly.valid_attachment_models'); | ||||
|         $models = array_map( | ||||
|             static function (string $className) { | ||||
|                 return str_replace('FireflyIII\\Models\\', '', $className); | ||||
|                 return str_replace('FireflyIII\Models\\', '', $className); | ||||
|             }, | ||||
|             $models | ||||
|         ); | ||||
|   | ||||
| @@ -60,7 +60,7 @@ class UpdateRequest extends FormRequest | ||||
|         $models = config('firefly.valid_attachment_models'); | ||||
|         $models = array_map( | ||||
|             static function (string $className) { | ||||
|                 return str_replace('FireflyIII\\Models\\', '', $className); | ||||
|                 return str_replace('FireflyIII\Models\\', '', $className); | ||||
|             }, | ||||
|             $models | ||||
|         ); | ||||
|   | ||||
| @@ -73,6 +73,65 @@ class StoreRequest extends FormRequest | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Returns the transaction data as it is found in the submitted data. It's a complex method according to code | ||||
|      * standards but it just has a lot of ??-statements because of the fields that may or may not exist. | ||||
|      */ | ||||
|     private function getTransactionData(): array | ||||
|     { | ||||
|         $return       = []; | ||||
| 
 | ||||
|         // transaction data:
 | ||||
|         /** @var null|array $transactions */ | ||||
|         $transactions = $this->get('transactions'); | ||||
|         if (null === $transactions) { | ||||
|             return []; | ||||
|         } | ||||
| 
 | ||||
|         /** @var array $transaction */ | ||||
|         foreach ($transactions as $transaction) { | ||||
|             $return[] = $this->getSingleTransactionData($transaction); | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Returns the repetition data as it is found in the submitted data. | ||||
|      */ | ||||
|     private function getRepetitionData(): array | ||||
|     { | ||||
|         $return      = []; | ||||
| 
 | ||||
|         // repetition data:
 | ||||
|         /** @var null|array $repetitions */ | ||||
|         $repetitions = $this->get('repetitions'); | ||||
|         if (null === $repetitions) { | ||||
|             return []; | ||||
|         } | ||||
| 
 | ||||
|         /** @var array $repetition */ | ||||
|         foreach ($repetitions as $repetition) { | ||||
|             $current  = []; | ||||
|             if (array_key_exists('type', $repetition)) { | ||||
|                 $current['type'] = $repetition['type']; | ||||
|             } | ||||
|             if (array_key_exists('moment', $repetition)) { | ||||
|                 $current['moment'] = $repetition['moment']; | ||||
|             } | ||||
|             if (array_key_exists('skip', $repetition)) { | ||||
|                 $current['skip'] = (int)$repetition['skip']; | ||||
|             } | ||||
|             if (array_key_exists('weekend', $repetition)) { | ||||
|                 $current['weekend'] = (int)$repetition['weekend']; | ||||
|             } | ||||
| 
 | ||||
|             $return[] = $current; | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * The rules that the incoming request must be matched against. | ||||
|      */ | ||||
| @@ -136,63 +195,4 @@ class StoreRequest extends FormRequest | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Returns the transaction data as it is found in the submitted data. It's a complex method according to code | ||||
|      * standards but it just has a lot of ??-statements because of the fields that may or may not exist. | ||||
|      */ | ||||
|     private function getTransactionData(): array | ||||
|     { | ||||
|         $return       = []; | ||||
| 
 | ||||
|         // transaction data:
 | ||||
|         /** @var null|array $transactions */ | ||||
|         $transactions = $this->get('transactions'); | ||||
|         if (null === $transactions) { | ||||
|             return []; | ||||
|         } | ||||
| 
 | ||||
|         /** @var array $transaction */ | ||||
|         foreach ($transactions as $transaction) { | ||||
|             $return[] = $this->getSingleTransactionData($transaction); | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Returns the repetition data as it is found in the submitted data. | ||||
|      */ | ||||
|     private function getRepetitionData(): array | ||||
|     { | ||||
|         $return      = []; | ||||
| 
 | ||||
|         // repetition data:
 | ||||
|         /** @var null|array $repetitions */ | ||||
|         $repetitions = $this->get('repetitions'); | ||||
|         if (null === $repetitions) { | ||||
|             return []; | ||||
|         } | ||||
| 
 | ||||
|         /** @var array $repetition */ | ||||
|         foreach ($repetitions as $repetition) { | ||||
|             $current  = []; | ||||
|             if (array_key_exists('type', $repetition)) { | ||||
|                 $current['type'] = $repetition['type']; | ||||
|             } | ||||
|             if (array_key_exists('moment', $repetition)) { | ||||
|                 $current['moment'] = $repetition['moment']; | ||||
|             } | ||||
|             if (array_key_exists('skip', $repetition)) { | ||||
|                 $current['skip'] = (int)$repetition['skip']; | ||||
|             } | ||||
|             if (array_key_exists('weekend', $repetition)) { | ||||
|                 $current['weekend'] = (int)$repetition['weekend']; | ||||
|             } | ||||
| 
 | ||||
|             $return[] = $current; | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -78,6 +78,70 @@ class UpdateRequest extends FormRequest | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Returns the repetition data as it is found in the submitted data. | ||||
|      */ | ||||
|     private function getRepetitionData(): ?array | ||||
|     { | ||||
|         $return      = []; | ||||
| 
 | ||||
|         // repetition data:
 | ||||
|         /** @var null|array $repetitions */ | ||||
|         $repetitions = $this->get('repetitions'); | ||||
|         if (null === $repetitions) { | ||||
|             return null; | ||||
|         } | ||||
| 
 | ||||
|         /** @var array $repetition */ | ||||
|         foreach ($repetitions as $repetition) { | ||||
|             $current  = []; | ||||
|             if (array_key_exists('type', $repetition)) { | ||||
|                 $current['type'] = $repetition['type']; | ||||
|             } | ||||
| 
 | ||||
|             if (array_key_exists('moment', $repetition)) { | ||||
|                 $current['moment'] = (string)$repetition['moment']; | ||||
|             } | ||||
| 
 | ||||
|             if (array_key_exists('skip', $repetition)) { | ||||
|                 $current['skip'] = (int)$repetition['skip']; | ||||
|             } | ||||
| 
 | ||||
|             if (array_key_exists('weekend', $repetition)) { | ||||
|                 $current['weekend'] = (int)$repetition['weekend']; | ||||
|             } | ||||
|             $return[] = $current; | ||||
|         } | ||||
|         if (0 === count($return)) { | ||||
|             return null; | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Returns the transaction data as it is found in the submitted data. It's a complex method according to code | ||||
|      * standards but it just has a lot of ??-statements because of the fields that may or may not exist. | ||||
|      */ | ||||
|     private function getTransactionData(): array | ||||
|     { | ||||
|         $return       = []; | ||||
| 
 | ||||
|         // transaction data:
 | ||||
|         /** @var null|array $transactions */ | ||||
|         $transactions = $this->get('transactions'); | ||||
|         if (null === $transactions) { | ||||
|             return []; | ||||
|         } | ||||
| 
 | ||||
|         /** @var array $transaction */ | ||||
|         foreach ($transactions as $transaction) { | ||||
|             $return[] = $this->getSingleTransactionData($transaction); | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * The rules that the incoming request must be matched against. | ||||
|      */ | ||||
| @@ -146,68 +210,4 @@ class UpdateRequest extends FormRequest | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Returns the repetition data as it is found in the submitted data. | ||||
|      */ | ||||
|     private function getRepetitionData(): ?array | ||||
|     { | ||||
|         $return      = []; | ||||
| 
 | ||||
|         // repetition data:
 | ||||
|         /** @var null|array $repetitions */ | ||||
|         $repetitions = $this->get('repetitions'); | ||||
|         if (null === $repetitions) { | ||||
|             return null; | ||||
|         } | ||||
| 
 | ||||
|         /** @var array $repetition */ | ||||
|         foreach ($repetitions as $repetition) { | ||||
|             $current  = []; | ||||
|             if (array_key_exists('type', $repetition)) { | ||||
|                 $current['type'] = $repetition['type']; | ||||
|             } | ||||
| 
 | ||||
|             if (array_key_exists('moment', $repetition)) { | ||||
|                 $current['moment'] = (string) $repetition['moment']; | ||||
|             } | ||||
| 
 | ||||
|             if (array_key_exists('skip', $repetition)) { | ||||
|                 $current['skip'] = (int) $repetition['skip']; | ||||
|             } | ||||
| 
 | ||||
|             if (array_key_exists('weekend', $repetition)) { | ||||
|                 $current['weekend'] = (int) $repetition['weekend']; | ||||
|             } | ||||
|             $return[] = $current; | ||||
|         } | ||||
|         if (0 === count($return)) { | ||||
|             return null; | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Returns the transaction data as it is found in the submitted data. It's a complex method according to code | ||||
|      * standards but it just has a lot of ??-statements because of the fields that may or may not exist. | ||||
|      */ | ||||
|     private function getTransactionData(): array | ||||
|     { | ||||
|         $return       = []; | ||||
| 
 | ||||
|         // transaction data:
 | ||||
|         /** @var null|array $transactions */ | ||||
|         $transactions = $this->get('transactions'); | ||||
|         if (null === $transactions) { | ||||
|             return []; | ||||
|         } | ||||
| 
 | ||||
|         /** @var array $transaction */ | ||||
|         foreach ($transactions as $transaction) { | ||||
|             $return[] = $this->getSingleTransactionData($transaction); | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| namespace FireflyIII\Api\V1\Requests\Models\Rule; | ||||
| 
 | ||||
| use FireflyIII\Rules\IsBoolean; | ||||
| use FireflyIII\Rules\IsValidActionExpression; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use FireflyIII\Support\Request\GetRuleConfiguration; | ||||
| @@ -57,13 +58,49 @@ class StoreRequest extends FormRequest | ||||
|             'active'           => ['active', 'boolean'], | ||||
|         ]; | ||||
|         $data             = $this->getAllData($fields); | ||||
| 
 | ||||
|         $data['triggers'] = $this->getRuleTriggers(); | ||||
|         $data['actions']  = $this->getRuleActions(); | ||||
| 
 | ||||
|         return $data; | ||||
|     } | ||||
| 
 | ||||
|     private function getRuleTriggers(): array | ||||
|     { | ||||
|         $triggers = $this->get('triggers'); | ||||
|         $return   = []; | ||||
|         if (is_array($triggers)) { | ||||
|             foreach ($triggers as $trigger) { | ||||
|                 $return[] = [ | ||||
|                     'type'            => $trigger['type'] ?? '', | ||||
|                     'value'           => $trigger['value'] ?? null, | ||||
|                     'prohibited'      => $this->convertBoolean((string)($trigger['prohibited'] ?? 'false')), | ||||
|                     'active'          => $this->convertBoolean((string)($trigger['active'] ?? 'true')), | ||||
|                     'stop_processing' => $this->convertBoolean((string)($trigger['stop_processing'] ?? 'false')), | ||||
|                 ]; | ||||
|             } | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     private function getRuleActions(): array | ||||
|     { | ||||
|         $actions = $this->get('actions'); | ||||
|         $return  = []; | ||||
|         if (is_array($actions)) { | ||||
|             foreach ($actions as $action) { | ||||
|                 $return[] = [ | ||||
|                     'type'            => $action['type'], | ||||
|                     'value'           => $action['value'], | ||||
|                     'active'          => $this->convertBoolean((string)($action['active'] ?? 'true')), | ||||
|                     'stop_processing' => $this->convertBoolean((string)($action['stop_processing'] ?? 'false')), | ||||
|                 ]; | ||||
|             } | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * The rules that the incoming request must be matched against. | ||||
|      */ | ||||
| @@ -87,7 +124,7 @@ class StoreRequest extends FormRequest | ||||
|             'triggers.*.stop_processing' => [new IsBoolean()], | ||||
|             'triggers.*.active'          => [new IsBoolean()], | ||||
|             'actions.*.type'             => 'required|in:'.implode(',', $validActions), | ||||
|             'actions.*.value'            => 'required_if:actions.*.type,'.$contextActions.'|ruleActionValue', | ||||
|             'actions.*.value'            => [sprintf('required_if:actions.*.type,%s', $contextActions), new IsValidActionExpression(), 'ruleActionValue'], | ||||
|             'actions.*.stop_processing'  => [new IsBoolean()], | ||||
|             'actions.*.active'           => [new IsBoolean()], | ||||
|             'strict'                     => [new IsBoolean()], | ||||
| @@ -197,40 +234,4 @@ class StoreRequest extends FormRequest | ||||
|             $validator->errors()->add(sprintf('actions.%d.active', $inactiveIndex), (string)trans('validation.at_least_one_active_action')); | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     private function getRuleTriggers(): array | ||||
|     { | ||||
|         $triggers = $this->get('triggers'); | ||||
|         $return   = []; | ||||
|         if (is_array($triggers)) { | ||||
|             foreach ($triggers as $trigger) { | ||||
|                 $return[] = [ | ||||
|                     'type'            => $trigger['type'], | ||||
|                     'value'           => $trigger['value'], | ||||
|                     'active'          => $this->convertBoolean((string)($trigger['active'] ?? 'true')), | ||||
|                     'stop_processing' => $this->convertBoolean((string)($trigger['stop_processing'] ?? 'false')), | ||||
|                 ]; | ||||
|             } | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     private function getRuleActions(): array | ||||
|     { | ||||
|         $actions = $this->get('actions'); | ||||
|         $return  = []; | ||||
|         if (is_array($actions)) { | ||||
|             foreach ($actions as $action) { | ||||
|                 $return[] = [ | ||||
|                     'type'            => $action['type'], | ||||
|                     'value'           => $action['value'], | ||||
|                     'active'          => $this->convertBoolean((string)($action['active'] ?? 'true')), | ||||
|                     'stop_processing' => $this->convertBoolean((string)($action['stop_processing'] ?? 'false')), | ||||
|                 ]; | ||||
|             } | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -47,16 +47,6 @@ class TestRequest extends FormRequest | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'start'      => 'date', | ||||
|             'end'        => 'date|after_or_equal:start', | ||||
|             'accounts'   => '', | ||||
|             'accounts.*' => 'required|exists:accounts,id|belongsToUser:accounts', | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     private function getPage(): int | ||||
|     { | ||||
|         return 0 === (int)$this->query('page') ? 1 : (int)$this->query('page'); | ||||
| @@ -69,16 +59,22 @@ class TestRequest extends FormRequest | ||||
|             return null; | ||||
|         } | ||||
|         $value = (string)$value; | ||||
|         $result = null === $this->query($field) ? null : Carbon::createFromFormat('Y-m-d', substr($value, 0, 10)); | ||||
|         if (false === $result) { | ||||
|             return null; | ||||
|         } | ||||
| 
 | ||||
|         return $result; | ||||
|         return null === $this->query($field) ? null : Carbon::createFromFormat('Y-m-d', substr($value, 0, 10)); | ||||
|     } | ||||
| 
 | ||||
|     private function getAccounts(): array | ||||
|     { | ||||
|         return $this->get('accounts'); | ||||
|     } | ||||
| 
 | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'start'      => 'date', | ||||
|             'end'        => 'date|after_or_equal:start', | ||||
|             'accounts'   => '', | ||||
|             'accounts.*' => 'required|exists:accounts,id|belongsToUser:accounts', | ||||
|         ]; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -46,6 +46,22 @@ class TriggerRequest extends FormRequest | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     private function getDate(string $field): ?Carbon | ||||
|     { | ||||
|         $value = $this->query($field); | ||||
|         if (is_array($value)) { | ||||
|             return null; | ||||
|         } | ||||
|         $value = (string)$value; | ||||
| 
 | ||||
|         return null === $this->query($field) ? null : Carbon::createFromFormat('Y-m-d', substr($value, 0, 10)); | ||||
|     } | ||||
| 
 | ||||
|     private function getAccounts(): array | ||||
|     { | ||||
|         return $this->get('accounts') ?? []; | ||||
|     } | ||||
| 
 | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
| @@ -55,24 +71,4 @@ class TriggerRequest extends FormRequest | ||||
|             'accounts.*' => 'exists:accounts,id|belongsToUser:accounts', | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     private function getDate(string $field): ?Carbon | ||||
|     { | ||||
|         $value  = $this->query($field); | ||||
|         if (is_array($value)) { | ||||
|             return null; | ||||
|         } | ||||
|         $value  = (string)$value; | ||||
|         $result = null === $this->query($field) ? null : Carbon::createFromFormat('Y-m-d', substr($value, 0, 10)); | ||||
|         if (false === $result) { | ||||
|             return null; | ||||
|         } | ||||
| 
 | ||||
|         return $result; | ||||
|     } | ||||
| 
 | ||||
|     private function getAccounts(): array | ||||
|     { | ||||
|         return $this->get('accounts') ?? []; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -25,6 +25,7 @@ namespace FireflyIII\Api\V1\Requests\Models\Rule; | ||||
| 
 | ||||
| use FireflyIII\Models\Rule; | ||||
| use FireflyIII\Rules\IsBoolean; | ||||
| use FireflyIII\Rules\IsValidActionExpression; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use FireflyIII\Support\Request\GetRuleConfiguration; | ||||
| @@ -70,6 +71,52 @@ class UpdateRequest extends FormRequest | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     private function getRuleTriggers(): ?array | ||||
|     { | ||||
|         if (!$this->has('triggers')) { | ||||
|             return null; | ||||
|         } | ||||
|         $triggers = $this->get('triggers'); | ||||
|         $return   = []; | ||||
|         if (is_array($triggers)) { | ||||
|             foreach ($triggers as $trigger) { | ||||
|                 $active         = array_key_exists('active', $trigger) ? $trigger['active'] : true; | ||||
|                 $prohibited     = array_key_exists('prohibited', $trigger) ? $trigger['prohibited'] : false; | ||||
|                 $stopProcessing = array_key_exists('stop_processing', $trigger) ? $trigger['stop_processing'] : false; | ||||
|                 $return[]       = [ | ||||
|                     'type'            => $trigger['type'], | ||||
|                     'value'           => $trigger['value'], | ||||
|                     'prohibited'      => $prohibited, | ||||
|                     'active'          => $active, | ||||
|                     'stop_processing' => $stopProcessing, | ||||
|                 ]; | ||||
|             } | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     private function getRuleActions(): ?array | ||||
|     { | ||||
|         if (!$this->has('actions')) { | ||||
|             return null; | ||||
|         } | ||||
|         $actions = $this->get('actions'); | ||||
|         $return  = []; | ||||
|         if (is_array($actions)) { | ||||
|             foreach ($actions as $action) { | ||||
|                 $return[] = [ | ||||
|                     'type'            => $action['type'], | ||||
|                     'value'           => $action['value'], | ||||
|                     'active'          => $this->convertBoolean((string)($action['active'] ?? 'false')), | ||||
|                     'stop_processing' => $this->convertBoolean((string)($action['stop_processing'] ?? 'false')), | ||||
|                 ]; | ||||
|             } | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * The rules that the incoming request must be matched against. | ||||
|      */ | ||||
| @@ -96,7 +143,7 @@ class UpdateRequest extends FormRequest | ||||
|             'triggers.*.stop_processing' => [new IsBoolean()], | ||||
|             'triggers.*.active'          => [new IsBoolean()], | ||||
|             'actions.*.type'             => 'required|in:'.implode(',', $validActions), | ||||
|             'actions.*.value'            => 'required_if:actions.*.type,'.$contextActions.'|ruleActionValue', | ||||
|             'actions.*.value'            => [sprintf('required_if:actions.*.type,%s', $contextActions), new IsValidActionExpression(), 'ruleActionValue'], | ||||
|             'actions.*.stop_processing'  => [new IsBoolean()], | ||||
|             'actions.*.active'           => [new IsBoolean()], | ||||
|             'strict'                     => [new IsBoolean()], | ||||
| @@ -204,48 +251,4 @@ class UpdateRequest extends FormRequest | ||||
|             $validator->errors()->add(sprintf('actions.%d.active', $inactiveIndex), (string)trans('validation.at_least_one_active_action')); | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     private function getRuleTriggers(): ?array | ||||
|     { | ||||
|         if (!$this->has('triggers')) { | ||||
|             return null; | ||||
|         } | ||||
|         $triggers = $this->get('triggers'); | ||||
|         $return   = []; | ||||
|         if (is_array($triggers)) { | ||||
|             foreach ($triggers as $trigger) { | ||||
|                 $active         = array_key_exists('active', $trigger) ? $trigger['active'] : true; | ||||
|                 $stopProcessing = array_key_exists('stop_processing', $trigger) ? $trigger['stop_processing'] : false; | ||||
|                 $return[]       = [ | ||||
|                     'type'            => $trigger['type'], | ||||
|                     'value'           => $trigger['value'], | ||||
|                     'active'          => $active, | ||||
|                     'stop_processing' => $stopProcessing, | ||||
|                 ]; | ||||
|             } | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     private function getRuleActions(): ?array | ||||
|     { | ||||
|         if (!$this->has('actions')) { | ||||
|             return null; | ||||
|         } | ||||
|         $actions = $this->get('actions'); | ||||
|         $return  = []; | ||||
|         if (is_array($actions)) { | ||||
|             foreach ($actions as $action) { | ||||
|                 $return[] = [ | ||||
|                     'type'            => $action['type'], | ||||
|                     'value'           => $action['value'], | ||||
|                     'active'          => $this->convertBoolean((string)($action['active'] ?? 'false')), | ||||
|                     'stop_processing' => $this->convertBoolean((string)($action['stop_processing'] ?? 'false')), | ||||
|                 ]; | ||||
|             } | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -1,8 +1,8 @@ | ||||
| <?php | ||||
| 
 | ||||
| /** | ||||
|  * auth.php | ||||
|  * Copyright (c) 2019 james@firefly-iii.org | ||||
|  * ValidateExpressionRequest.php | ||||
|  * Copyright (c) 2024 Michael Thomas | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
| @@ -20,20 +20,23 @@ | ||||
|  * along with this program.  If not, see <https://www.gnu.org/licenses/>. | ||||
|  */ | ||||
| 
 | ||||
| /* | ||||
|  * PLEASE DO NOT EDIT THIS FILE DIRECTLY. | ||||
|  * YOUR CHANGES WILL BE OVERWRITTEN! | ||||
|  * YOUR PR WITH CHANGES TO THIS FILE WILL BE REJECTED! | ||||
|  * | ||||
|  * GO TO CROWDIN TO FIX OR CHANGE TRANSLATIONS! | ||||
|  * | ||||
|  * https://crowdin.com/project/firefly-iii | ||||
|  * | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| 
 | ||||
| return [ | ||||
|     'failed'   => 'These credentials do not match our records.', | ||||
|     'throttle' => 'Too many login attempts. Please try again in :seconds seconds.', | ||||
| ]; | ||||
| namespace FireflyIII\Api\V1\Requests\Models\Rule; | ||||
| 
 | ||||
| use FireflyIII\Rules\IsValidActionExpression; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| 
 | ||||
| /** | ||||
|  * Class ValidateExpressionRequest | ||||
|  */ | ||||
| class ValidateExpressionRequest extends FormRequest | ||||
| { | ||||
|     use ChecksLogin; | ||||
| 
 | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return ['expression' => ['required', new IsValidActionExpression()]]; | ||||
|     } | ||||
| } | ||||
| @@ -46,6 +46,22 @@ class TestRequest extends FormRequest | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     private function getDate(string $field): ?Carbon | ||||
|     { | ||||
|         $value = $this->query($field); | ||||
|         if (is_array($value)) { | ||||
|             return null; | ||||
|         } | ||||
|         $value = (string)$value; | ||||
| 
 | ||||
|         return null === $this->query($field) ? null : Carbon::createFromFormat('Y-m-d', substr($value, 0, 10)); | ||||
|     } | ||||
| 
 | ||||
|     private function getAccounts(): array | ||||
|     { | ||||
|         return $this->get('accounts'); | ||||
|     } | ||||
| 
 | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
| @@ -55,24 +71,4 @@ class TestRequest extends FormRequest | ||||
|             'accounts.*' => 'exists:accounts,id|belongsToUser:accounts', | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     private function getDate(string $field): ?Carbon | ||||
|     { | ||||
|         $value  = $this->query($field); | ||||
|         if (is_array($value)) { | ||||
|             return null; | ||||
|         } | ||||
|         $value  = (string)$value; | ||||
|         $result = null === $this->query($field) ? null : Carbon::createFromFormat('Y-m-d', substr($value, 0, 10)); | ||||
|         if (false === $result) { | ||||
|             return null; | ||||
|         } | ||||
| 
 | ||||
|         return $result; | ||||
|     } | ||||
| 
 | ||||
|     private function getAccounts(): array | ||||
|     { | ||||
|         return $this->get('accounts'); | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -46,14 +46,6 @@ class TriggerRequest extends FormRequest | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'start' => 'date', | ||||
|             'end'   => 'date|after_or_equal:start', | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     private function getDate(string $field): ?Carbon | ||||
|     { | ||||
|         $value = $this->query($field); | ||||
| @@ -61,16 +53,24 @@ class TriggerRequest extends FormRequest | ||||
|             return null; | ||||
|         } | ||||
|         $value = (string)$value; | ||||
|         $result = null === $this->query($field) ? null : Carbon::createFromFormat('Y-m-d', substr($value, 0, 10)); | ||||
|         if (false === $result) { | ||||
|             return null; | ||||
|         } | ||||
| 
 | ||||
|         return $result; | ||||
|         return null === $this->query($field) ? null : Carbon::createFromFormat('Y-m-d', substr($value, 0, 10)); | ||||
|     } | ||||
| 
 | ||||
|     private function getAccounts(): array | ||||
|     { | ||||
|         if (null === $this->get('accounts')) { | ||||
|             return []; | ||||
|         } | ||||
| 
 | ||||
|         return $this->get('accounts'); | ||||
|     } | ||||
| 
 | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'start' => 'date', | ||||
|             'end'   => 'date|after_or_equal:start', | ||||
|         ]; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -69,6 +69,101 @@ class StoreRequest extends FormRequest | ||||
|         // TODO include location and ability to process it.
 | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Get transaction data. | ||||
|      */ | ||||
|     private function getTransactionData(): array | ||||
|     { | ||||
|         $return = []; | ||||
| 
 | ||||
|         /** | ||||
|          * @var array $transaction | ||||
|          */ | ||||
|         foreach ($this->get('transactions') as $transaction) { | ||||
|             $object   = new NullArrayObject($transaction); | ||||
|             $return[] = [ | ||||
|                 'type'                  => $this->clearString($object['type']), | ||||
|                 'date'                  => $this->dateFromValue($object['date']), | ||||
|                 'order'                 => $this->integerFromValue((string)$object['order']), | ||||
| 
 | ||||
|                 'currency_id'           => $this->integerFromValue((string)$object['currency_id']), | ||||
|                 'currency_code'         => $this->clearString((string)$object['currency_code']), | ||||
| 
 | ||||
|                 // foreign currency info:
 | ||||
|                 'foreign_currency_id'   => $this->integerFromValue((string)$object['foreign_currency_id']), | ||||
|                 'foreign_currency_code' => $this->clearString((string)$object['foreign_currency_code']), | ||||
| 
 | ||||
|                 // amount and foreign amount. Cannot be 0.
 | ||||
|                 'amount'                => $this->clearString((string)$object['amount']), | ||||
|                 'foreign_amount'        => $this->clearString((string)$object['foreign_amount']), | ||||
| 
 | ||||
|                 // description.
 | ||||
|                 'description'           => $this->clearString($object['description']), | ||||
| 
 | ||||
|                 // source of transaction. If everything is null, assume cash account.
 | ||||
|                 'source_id'             => $this->integerFromValue((string)$object['source_id']), | ||||
|                 'source_name'           => $this->clearString((string)$object['source_name']), | ||||
|                 'source_iban'           => $this->clearIban((string)$object['source_iban']), | ||||
|                 'source_number'         => $this->clearString((string)$object['source_number']), | ||||
|                 'source_bic'            => $this->clearString((string)$object['source_bic']), | ||||
| 
 | ||||
|                 // destination of transaction. If everything is null, assume cash account.
 | ||||
|                 'destination_id'        => $this->integerFromValue((string)$object['destination_id']), | ||||
|                 'destination_name'      => $this->clearString((string)$object['destination_name']), | ||||
|                 'destination_iban'      => $this->clearIban((string)$object['destination_iban']), | ||||
|                 'destination_number'    => $this->clearString((string)$object['destination_number']), | ||||
|                 'destination_bic'       => $this->clearString((string)$object['destination_bic']), | ||||
| 
 | ||||
|                 // budget info
 | ||||
|                 'budget_id'             => $this->integerFromValue((string)$object['budget_id']), | ||||
|                 'budget_name'           => $this->clearString((string)$object['budget_name']), | ||||
| 
 | ||||
|                 // category info
 | ||||
|                 'category_id'           => $this->integerFromValue((string)$object['category_id']), | ||||
|                 'category_name'         => $this->clearString((string)$object['category_name']), | ||||
| 
 | ||||
|                 // journal bill reference. Optional. Will only work for withdrawals
 | ||||
|                 'bill_id'               => $this->integerFromValue((string)$object['bill_id']), | ||||
|                 'bill_name'             => $this->clearString((string)$object['bill_name']), | ||||
| 
 | ||||
|                 // piggy bank reference. Optional. Will only work for transfers
 | ||||
|                 'piggy_bank_id'         => $this->integerFromValue((string)$object['piggy_bank_id']), | ||||
|                 'piggy_bank_name'       => $this->clearString((string)$object['piggy_bank_name']), | ||||
| 
 | ||||
|                 // some other interesting properties
 | ||||
|                 'reconciled'            => $this->convertBoolean((string)$object['reconciled']), | ||||
|                 'notes'                 => $this->clearStringKeepNewlines((string)$object['notes']), | ||||
|                 'tags'                  => $this->arrayFromValue($object['tags']), | ||||
| 
 | ||||
|                 // all custom fields:
 | ||||
|                 'internal_reference'    => $this->clearString((string)$object['internal_reference']), | ||||
|                 'external_id'           => $this->clearString((string)$object['external_id']), | ||||
|                 'original_source'       => sprintf('ff3-v%s|api-v%s', config('firefly.version'), config('firefly.api_version')), | ||||
|                 'recurrence_id'         => $this->integerFromValue($object['recurrence_id']), | ||||
|                 'bunq_payment_id'       => $this->clearString((string)$object['bunq_payment_id']), | ||||
|                 'external_url'          => $this->clearString((string)$object['external_url']), | ||||
| 
 | ||||
|                 'sepa_cc'               => $this->clearString((string)$object['sepa_cc']), | ||||
|                 'sepa_ct_op'            => $this->clearString((string)$object['sepa_ct_op']), | ||||
|                 'sepa_ct_id'            => $this->clearString((string)$object['sepa_ct_id']), | ||||
|                 'sepa_db'               => $this->clearString((string)$object['sepa_db']), | ||||
|                 'sepa_country'          => $this->clearString((string)$object['sepa_country']), | ||||
|                 'sepa_ep'               => $this->clearString((string)$object['sepa_ep']), | ||||
|                 'sepa_ci'               => $this->clearString((string)$object['sepa_ci']), | ||||
|                 'sepa_batch_id'         => $this->clearString((string)$object['sepa_batch_id']), | ||||
|                 // custom date fields. Must be Carbon objects. Presence is optional.
 | ||||
|                 'interest_date'         => $this->dateFromValue($object['interest_date']), | ||||
|                 'book_date'             => $this->dateFromValue($object['book_date']), | ||||
|                 'process_date'          => $this->dateFromValue($object['process_date']), | ||||
|                 'due_date'              => $this->dateFromValue($object['due_date']), | ||||
|                 'payment_date'          => $this->dateFromValue($object['payment_date']), | ||||
|                 'invoice_date'          => $this->dateFromValue($object['invoice_date']), | ||||
|             ]; | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * The rules that the incoming request must be matched against. | ||||
|      */ | ||||
| @@ -196,99 +291,4 @@ class StoreRequest extends FormRequest | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Get transaction data. | ||||
|      */ | ||||
|     private function getTransactionData(): array | ||||
|     { | ||||
|         $return = []; | ||||
| 
 | ||||
|         /** | ||||
|          * @var array $transaction | ||||
|          */ | ||||
|         foreach ($this->get('transactions') as $transaction) { | ||||
|             $object   = new NullArrayObject($transaction); | ||||
|             $return[] = [ | ||||
|                 'type'                  => $this->clearString($object['type']), | ||||
|                 'date'                  => $this->dateFromValue($object['date']), | ||||
|                 'order'                 => $this->integerFromValue((string)$object['order']), | ||||
| 
 | ||||
|                 'currency_id'           => $this->integerFromValue((string)$object['currency_id']), | ||||
|                 'currency_code'         => $this->clearString((string)$object['currency_code']), | ||||
| 
 | ||||
|                 // foreign currency info:
 | ||||
|                 'foreign_currency_id'   => $this->integerFromValue((string)$object['foreign_currency_id']), | ||||
|                 'foreign_currency_code' => $this->clearString((string)$object['foreign_currency_code']), | ||||
| 
 | ||||
|                 // amount and foreign amount. Cannot be 0.
 | ||||
|                 'amount'                => $this->clearString((string)$object['amount']), | ||||
|                 'foreign_amount'        => $this->clearString((string)$object['foreign_amount']), | ||||
| 
 | ||||
|                 // description.
 | ||||
|                 'description'           => $this->clearString($object['description']), | ||||
| 
 | ||||
|                 // source of transaction. If everything is null, assume cash account.
 | ||||
|                 'source_id'             => $this->integerFromValue((string)$object['source_id']), | ||||
|                 'source_name'           => $this->clearString((string)$object['source_name']), | ||||
|                 'source_iban'           => $this->clearString((string)$object['source_iban']), | ||||
|                 'source_number'         => $this->clearString((string)$object['source_number']), | ||||
|                 'source_bic'            => $this->clearString((string)$object['source_bic']), | ||||
| 
 | ||||
|                 // destination of transaction. If everything is null, assume cash account.
 | ||||
|                 'destination_id'        => $this->integerFromValue((string)$object['destination_id']), | ||||
|                 'destination_name'      => $this->clearString((string)$object['destination_name']), | ||||
|                 'destination_iban'      => $this->clearString((string)$object['destination_iban']), | ||||
|                 'destination_number'    => $this->clearString((string)$object['destination_number']), | ||||
|                 'destination_bic'       => $this->clearString((string)$object['destination_bic']), | ||||
| 
 | ||||
|                 // budget info
 | ||||
|                 'budget_id'             => $this->integerFromValue((string)$object['budget_id']), | ||||
|                 'budget_name'           => $this->clearString((string)$object['budget_name']), | ||||
| 
 | ||||
|                 // category info
 | ||||
|                 'category_id'           => $this->integerFromValue((string)$object['category_id']), | ||||
|                 'category_name'         => $this->clearString((string)$object['category_name']), | ||||
| 
 | ||||
|                 // journal bill reference. Optional. Will only work for withdrawals
 | ||||
|                 'bill_id'               => $this->integerFromValue((string)$object['bill_id']), | ||||
|                 'bill_name'             => $this->clearString((string)$object['bill_name']), | ||||
| 
 | ||||
|                 // piggy bank reference. Optional. Will only work for transfers
 | ||||
|                 'piggy_bank_id'         => $this->integerFromValue((string)$object['piggy_bank_id']), | ||||
|                 'piggy_bank_name'       => $this->clearString((string)$object['piggy_bank_name']), | ||||
| 
 | ||||
|                 // some other interesting properties
 | ||||
|                 'reconciled'            => $this->convertBoolean((string)$object['reconciled']), | ||||
|                 'notes'                 => $this->clearStringKeepNewlines((string)$object['notes']), | ||||
|                 'tags'                  => $this->arrayFromValue($object['tags']), | ||||
| 
 | ||||
|                 // all custom fields:
 | ||||
|                 'internal_reference'    => $this->clearString((string)$object['internal_reference']), | ||||
|                 'external_id'           => $this->clearString((string)$object['external_id']), | ||||
|                 'original_source'       => sprintf('ff3-v%s|api-v%s', config('firefly.version'), config('firefly.api_version')), | ||||
|                 'recurrence_id'         => $this->integerFromValue($object['recurrence_id']), | ||||
|                 'bunq_payment_id'       => $this->clearString((string)$object['bunq_payment_id']), | ||||
|                 'external_url'          => $this->clearString((string)$object['external_url']), | ||||
| 
 | ||||
|                 'sepa_cc'               => $this->clearString((string)$object['sepa_cc']), | ||||
|                 'sepa_ct_op'            => $this->clearString((string)$object['sepa_ct_op']), | ||||
|                 'sepa_ct_id'            => $this->clearString((string)$object['sepa_ct_id']), | ||||
|                 'sepa_db'               => $this->clearString((string)$object['sepa_db']), | ||||
|                 'sepa_country'          => $this->clearString((string)$object['sepa_country']), | ||||
|                 'sepa_ep'               => $this->clearString((string)$object['sepa_ep']), | ||||
|                 'sepa_ci'               => $this->clearString((string)$object['sepa_ci']), | ||||
|                 'sepa_batch_id'         => $this->clearString((string)$object['sepa_batch_id']), | ||||
|                 // custom date fields. Must be Carbon objects. Presence is optional.
 | ||||
|                 'interest_date'         => $this->dateFromValue($object['interest_date']), | ||||
|                 'book_date'             => $this->dateFromValue($object['book_date']), | ||||
|                 'process_date'          => $this->dateFromValue($object['process_date']), | ||||
|                 'due_date'              => $this->dateFromValue($object['due_date']), | ||||
|                 'payment_date'          => $this->dateFromValue($object['payment_date']), | ||||
|                 'invoice_date'          => $this->dateFromValue($object['invoice_date']), | ||||
|             ]; | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -90,127 +90,6 @@ class UpdateRequest extends FormRequest | ||||
|         return $data; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * The rules that the incoming request must be matched against. | ||||
|      */ | ||||
|     public function rules(): array | ||||
|     { | ||||
|         app('log')->debug(sprintf('Now in %s', __METHOD__)); | ||||
|         $validProtocols = config('firefly.valid_url_protocols'); | ||||
| 
 | ||||
|         return [ | ||||
|             // basic fields for group:
 | ||||
|             'group_title'                            => 'min:1|max:1000|nullable', | ||||
|             'apply_rules'                            => [new IsBoolean()], | ||||
| 
 | ||||
|             // transaction rules (in array for splits):
 | ||||
|             'transactions.*.type'                    => 'in:withdrawal,deposit,transfer,opening-balance,reconciliation', | ||||
|             'transactions.*.date'                    => [new IsDateOrTime()], | ||||
|             'transactions.*.order'                   => 'numeric|min:0', | ||||
| 
 | ||||
|             // group id:
 | ||||
|             'transactions.*.transaction_journal_id'  => ['nullable', 'numeric', new BelongsUser()], | ||||
| 
 | ||||
|             // currency info
 | ||||
|             'transactions.*.currency_id'             => 'numeric|exists:transaction_currencies,id|nullable', | ||||
|             'transactions.*.currency_code'           => 'min:3|max:51|exists:transaction_currencies,code|nullable', | ||||
|             'transactions.*.foreign_currency_id'     => 'nullable|numeric|exists:transaction_currencies,id', | ||||
|             'transactions.*.foreign_currency_code'   => 'nullable|min:3|max:51|exists:transaction_currencies,code', | ||||
| 
 | ||||
|             // amount
 | ||||
|             'transactions.*.amount'                  => [new IsValidPositiveAmount()], | ||||
|             'transactions.*.foreign_amount'          => ['nullable', new IsValidZeroOrMoreAmount()], | ||||
| 
 | ||||
|             // description
 | ||||
|             'transactions.*.description'             => 'nullable|min:1|max:1000', | ||||
| 
 | ||||
|             // source of transaction
 | ||||
|             'transactions.*.source_id'               => ['numeric', 'nullable', new BelongsUser()], | ||||
|             'transactions.*.source_name'             => 'min:1|max:255|nullable', | ||||
| 
 | ||||
|             // destination of transaction
 | ||||
|             'transactions.*.destination_id'          => ['numeric', 'nullable', new BelongsUser()], | ||||
|             'transactions.*.destination_name'        => 'min:1|max:255|nullable', | ||||
| 
 | ||||
|             // budget, category, bill and piggy
 | ||||
|             'transactions.*.budget_id'               => ['mustExist:budgets,id', new BelongsUser(), 'nullable'], | ||||
|             'transactions.*.budget_name'             => ['min:1', 'max:255', 'nullable', new BelongsUser()], | ||||
|             'transactions.*.category_id'             => ['mustExist:categories,id', new BelongsUser(), 'nullable'], | ||||
|             'transactions.*.category_name'           => 'min:1|max:255|nullable', | ||||
|             'transactions.*.bill_id'                 => ['numeric', 'nullable', 'mustExist:bills,id', new BelongsUser()], | ||||
|             'transactions.*.bill_name'               => ['min:1', 'max:255', 'nullable', new BelongsUser()], | ||||
| 
 | ||||
|             // other interesting fields
 | ||||
|             'transactions.*.reconciled'              => [new IsBoolean()], | ||||
|             'transactions.*.notes'                   => 'min:1|max:32768|nullable', | ||||
|             'transactions.*.tags'                    => 'min:0|max:255|nullable', | ||||
|             'transactions.*.tags.*'                  => 'min:0|max:255', | ||||
| 
 | ||||
|             // meta info fields
 | ||||
|             'transactions.*.internal_reference'      => 'min:1|max:255|nullable', | ||||
|             'transactions.*.external_id'             => 'min:1|max:255|nullable', | ||||
|             'transactions.*.recurrence_id'           => 'min:1|max:255|nullable', | ||||
|             'transactions.*.bunq_payment_id'         => 'min:1|max:255|nullable', | ||||
|             'transactions.*.external_url'            => sprintf('min:1|max:255|nullable|url:%s', $validProtocols), | ||||
| 
 | ||||
|             // SEPA fields:
 | ||||
|             'transactions.*.sepa_cc'                 => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_ct_op'              => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_ct_id'              => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_db'                 => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_country'            => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_ep'                 => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_ci'                 => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_batch_id'           => 'min:1|max:255|nullable', | ||||
| 
 | ||||
|             // dates
 | ||||
|             'transactions.*.interest_date'           => 'date|nullable', | ||||
|             'transactions.*.book_date'               => 'date|nullable', | ||||
|             'transactions.*.process_date'            => 'date|nullable', | ||||
|             'transactions.*.due_date'                => 'date|nullable', | ||||
|             'transactions.*.payment_date'            => 'date|nullable', | ||||
|             'transactions.*.invoice_date'            => 'date|nullable', | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Configure the validator instance. | ||||
|      */ | ||||
|     public function withValidator(Validator $validator): void | ||||
|     { | ||||
|         app('log')->debug('Now in withValidator'); | ||||
| 
 | ||||
|         /** @var TransactionGroup $transactionGroup */ | ||||
|         $transactionGroup = $this->route()->parameter('transactionGroup'); | ||||
|         $validator->after( | ||||
|             function (Validator $validator) use ($transactionGroup): void { | ||||
|                 // if more than one, verify that there are journal ID's present.
 | ||||
|                 $this->validateJournalIds($validator, $transactionGroup); | ||||
| 
 | ||||
|                 // all transaction types must be equal:
 | ||||
|                 $this->validateTransactionTypesForUpdate($validator); | ||||
| 
 | ||||
|                 // user wants to update a reconciled transaction.
 | ||||
|                 // source, destination, amount + foreign_amount cannot be changed
 | ||||
|                 // and must be omitted from the request.
 | ||||
|                 $this->preventUpdateReconciled($validator, $transactionGroup); | ||||
| 
 | ||||
|                 // validate source/destination is equal, depending on the transaction journal type.
 | ||||
|                 $this->validateEqualAccountsForUpdate($validator, $transactionGroup); | ||||
| 
 | ||||
|                 // see method:
 | ||||
|                 // $this->preventNoAccountInfo($validator, );
 | ||||
| 
 | ||||
|                 // validate that the currency fits the source and/or destination account.
 | ||||
|                 // validate all account info
 | ||||
|                 $this->validateAccountInformationUpdate($validator, $transactionGroup); | ||||
|             } | ||||
|         ); | ||||
|         if($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Get transaction data. | ||||
|      * | ||||
| @@ -362,4 +241,125 @@ class UpdateRequest extends FormRequest | ||||
| 
 | ||||
|         return $current; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * The rules that the incoming request must be matched against. | ||||
|      */ | ||||
|     public function rules(): array | ||||
|     { | ||||
|         app('log')->debug(sprintf('Now in %s', __METHOD__)); | ||||
|         $validProtocols = config('firefly.valid_url_protocols'); | ||||
| 
 | ||||
|         return [ | ||||
|             // basic fields for group:
 | ||||
|             'group_title'                           => 'min:1|max:1000|nullable', | ||||
|             'apply_rules'                           => [new IsBoolean()], | ||||
| 
 | ||||
|             // transaction rules (in array for splits):
 | ||||
|             'transactions.*.type'                   => 'in:withdrawal,deposit,transfer,opening-balance,reconciliation', | ||||
|             'transactions.*.date'                   => [new IsDateOrTime()], | ||||
|             'transactions.*.order'                  => 'numeric|min:0', | ||||
| 
 | ||||
|             // group id:
 | ||||
|             'transactions.*.transaction_journal_id' => ['nullable', 'numeric', new BelongsUser()], | ||||
| 
 | ||||
|             // currency info
 | ||||
|             'transactions.*.currency_id'            => 'numeric|exists:transaction_currencies,id|nullable', | ||||
|             'transactions.*.currency_code'          => 'min:3|max:51|exists:transaction_currencies,code|nullable', | ||||
|             'transactions.*.foreign_currency_id'    => 'nullable|numeric|exists:transaction_currencies,id', | ||||
|             'transactions.*.foreign_currency_code'  => 'nullable|min:3|max:51|exists:transaction_currencies,code', | ||||
| 
 | ||||
|             // amount
 | ||||
|             'transactions.*.amount'                 => [new IsValidPositiveAmount()], | ||||
|             'transactions.*.foreign_amount'         => ['nullable', new IsValidZeroOrMoreAmount()], | ||||
| 
 | ||||
|             // description
 | ||||
|             'transactions.*.description'            => 'nullable|min:1|max:1000', | ||||
| 
 | ||||
|             // source of transaction
 | ||||
|             'transactions.*.source_id'              => ['numeric', 'nullable', new BelongsUser()], | ||||
|             'transactions.*.source_name'            => 'min:1|max:255|nullable', | ||||
| 
 | ||||
|             // destination of transaction
 | ||||
|             'transactions.*.destination_id'         => ['numeric', 'nullable', new BelongsUser()], | ||||
|             'transactions.*.destination_name'       => 'min:1|max:255|nullable', | ||||
| 
 | ||||
|             // budget, category, bill and piggy
 | ||||
|             'transactions.*.budget_id'              => ['mustExist:budgets,id', new BelongsUser(), 'nullable'], | ||||
|             'transactions.*.budget_name'            => ['min:1', 'max:255', 'nullable', new BelongsUser()], | ||||
|             'transactions.*.category_id'            => ['mustExist:categories,id', new BelongsUser(), 'nullable'], | ||||
|             'transactions.*.category_name'          => 'min:1|max:255|nullable', | ||||
|             'transactions.*.bill_id'                => ['numeric', 'nullable', 'mustExist:bills,id', new BelongsUser()], | ||||
|             'transactions.*.bill_name'              => ['min:1', 'max:255', 'nullable', new BelongsUser()], | ||||
| 
 | ||||
|             // other interesting fields
 | ||||
|             'transactions.*.reconciled'             => [new IsBoolean()], | ||||
|             'transactions.*.notes'                  => 'min:1|max:32768|nullable', | ||||
|             'transactions.*.tags'                   => 'min:0|max:255|nullable', | ||||
|             'transactions.*.tags.*'                 => 'min:0|max:255', | ||||
| 
 | ||||
|             // meta info fields
 | ||||
|             'transactions.*.internal_reference'     => 'min:1|max:255|nullable', | ||||
|             'transactions.*.external_id'            => 'min:1|max:255|nullable', | ||||
|             'transactions.*.recurrence_id'          => 'min:1|max:255|nullable', | ||||
|             'transactions.*.bunq_payment_id'        => 'min:1|max:255|nullable', | ||||
|             'transactions.*.external_url'           => sprintf('min:1|max:255|nullable|url:%s', $validProtocols), | ||||
| 
 | ||||
|             // SEPA fields:
 | ||||
|             'transactions.*.sepa_cc'                => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_ct_op'             => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_ct_id'             => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_db'                => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_country'           => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_ep'                => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_ci'                => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_batch_id'          => 'min:1|max:255|nullable', | ||||
| 
 | ||||
|             // dates
 | ||||
|             'transactions.*.interest_date'          => 'date|nullable', | ||||
|             'transactions.*.book_date'              => 'date|nullable', | ||||
|             'transactions.*.process_date'           => 'date|nullable', | ||||
|             'transactions.*.due_date'               => 'date|nullable', | ||||
|             'transactions.*.payment_date'           => 'date|nullable', | ||||
|             'transactions.*.invoice_date'           => 'date|nullable', | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Configure the validator instance. | ||||
|      */ | ||||
|     public function withValidator(Validator $validator): void | ||||
|     { | ||||
|         app('log')->debug('Now in withValidator'); | ||||
| 
 | ||||
|         /** @var TransactionGroup $transactionGroup */ | ||||
|         $transactionGroup = $this->route()->parameter('transactionGroup'); | ||||
|         $validator->after( | ||||
|             function (Validator $validator) use ($transactionGroup): void { | ||||
|                 // if more than one, verify that there are journal ID's present.
 | ||||
|                 $this->validateJournalIds($validator, $transactionGroup); | ||||
| 
 | ||||
|                 // all transaction types must be equal:
 | ||||
|                 $this->validateTransactionTypesForUpdate($validator); | ||||
| 
 | ||||
|                 // user wants to update a reconciled transaction.
 | ||||
|                 // source, destination, amount + foreign_amount cannot be changed
 | ||||
|                 // and must be omitted from the request.
 | ||||
|                 $this->preventUpdateReconciled($validator, $transactionGroup); | ||||
| 
 | ||||
|                 // validate source/destination is equal, depending on the transaction journal type.
 | ||||
|                 $this->validateEqualAccountsForUpdate($validator, $transactionGroup); | ||||
| 
 | ||||
|                 // see method:
 | ||||
|                 // $this->preventNoAccountInfo($validator, );
 | ||||
| 
 | ||||
|                 // validate that the currency fits the source and/or destination account.
 | ||||
|                 // validate all account info
 | ||||
|                 $this->validateAccountInformationUpdate($validator, $transactionGroup); | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -28,22 +28,21 @@ use FireflyIII\Api\V2\Controllers\Controller; | ||||
| use FireflyIII\Api\V2\Request\Autocomplete\AutocompleteRequest; | ||||
| use FireflyIII\Exceptions\FireflyException; | ||||
| use FireflyIII\Models\Account; | ||||
| use FireflyIII\Models\AccountType; | ||||
| use FireflyIII\Repositories\Account\AccountRepositoryInterface; | ||||
| use FireflyIII\Repositories\UserGroups\Account\AccountRepositoryInterface as AdminAccountRepositoryInterface; | ||||
| use FireflyIII\Support\Http\Api\AccountFilter; | ||||
| use FireflyIII\Models\AccountBalance; | ||||
| use FireflyIII\Models\TransactionCurrency; | ||||
| use FireflyIII\Repositories\UserGroups\Account\AccountRepositoryInterface; | ||||
| use FireflyIII\Support\Http\Api\ExchangeRateConverter; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| 
 | ||||
| /** | ||||
|  * Class AccountController | ||||
|  */ | ||||
| class AccountController extends Controller | ||||
| { | ||||
|     use AccountFilter; | ||||
| 
 | ||||
|     private AdminAccountRepositoryInterface $adminRepository; | ||||
|     private array                           $balanceTypes; | ||||
|     private AccountRepositoryInterface $repository; | ||||
|     private TransactionCurrency        $default; | ||||
|     private ExchangeRateConverter      $converter; | ||||
| 
 | ||||
|     /** | ||||
|      * AccountController constructor. | ||||
| @@ -53,83 +52,88 @@ class AccountController extends Controller | ||||
|         parent::__construct(); | ||||
|         $this->middleware( | ||||
|             function ($request, $next) { | ||||
|                 $this->repository      = app(AccountRepositoryInterface::class); | ||||
|                 $this->adminRepository = app(AdminAccountRepositoryInterface::class); | ||||
| 
 | ||||
|                 $userGroup        = $this->validateUserGroup($request); | ||||
|                 if (null !== $userGroup) { | ||||
|                     $this->adminRepository->setUserGroup($userGroup); | ||||
|                 } | ||||
|                 $this->repository = app(AccountRepositoryInterface::class); | ||||
|                 $this->repository->setUserGroup($userGroup); | ||||
|                 $this->default    = app('amount')->getDefaultCurrency(); | ||||
|                 $this->converter  = app(ExchangeRateConverter::class); | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
|         ); | ||||
|         $this->balanceTypes = [AccountType::ASSET, AccountType::LOAN, AccountType::DEBT, AccountType::MORTGAGE]; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Documentation for this endpoint: | ||||
|      * TODO list of checks | ||||
|      * 1. use dates from ParameterBag | ||||
|      * 2. Request validates dates | ||||
|      * 3. Request includes user_group_id | ||||
|      * 4. Endpoint is documented. | ||||
|      * 5. Collector uses user_group_id | ||||
|      * | ||||
|      * @throws FireflyException | ||||
|      * @throws FireflyException | ||||
|      * Documentation: https://api-docs.firefly-iii.org/?urls.primaryName=2.1.0%20(v2)#/autocomplete/getAccountsAC
 | ||||
|      */ | ||||
|     public function accounts(AutocompleteRequest $request): JsonResponse | ||||
|     { | ||||
|         $data            = $request->getData(); | ||||
|         $types           = $data['types']; | ||||
|         $query           = $data['query']; | ||||
|         $date            = $this->parameters->get('date') ?? today(config('app.timezone')); | ||||
|         $result          = $this->adminRepository->searchAccount((string)$query, $types, $data['limit']); | ||||
|         $defaultCurrency = app('amount')->getDefaultCurrency(); | ||||
|         $groupedResult   = []; | ||||
|         $allItems        = []; | ||||
|         $queryParameters = $request->getParameters(); | ||||
|         $result          = $this->repository->searchAccount($queryParameters['query'], $queryParameters['account_types'], $queryParameters['size']); | ||||
|         $return          = []; | ||||
| 
 | ||||
|         /** @var Account $account */ | ||||
|         foreach ($result as $account) { | ||||
|             $nameWithBalance = $account->name; | ||||
|             $currency        = $this->repository->getAccountCurrency($account) ?? $defaultCurrency; | ||||
| 
 | ||||
|             if (in_array($account->accountType->type, $this->balanceTypes, true)) { | ||||
|                 $balance         = app('steam')->balance($account, $date); | ||||
|                 $nameWithBalance = sprintf('%s (%s)', $account->name, app('amount')->formatAnything($currency, $balance, false)); | ||||
|             $return[] = $this->parseAccount($account); | ||||
|         } | ||||
|             $type            = (string)trans(sprintf('firefly.%s', $account->accountType->type)); | ||||
|             $groupedResult[$type] ??= [ | ||||
|                 'group ' => $type, | ||||
|                 'items'  => [], | ||||
|             ]; | ||||
|             $allItems[]      = [ | ||||
| 
 | ||||
|         return response()->json($return); | ||||
|     } | ||||
| 
 | ||||
|     private function parseAccount(Account $account): array | ||||
|     { | ||||
|         $currency = $this->repository->getAccountCurrency($account); | ||||
| 
 | ||||
|         return [ | ||||
|             'id'    => (string) $account->id, | ||||
|                 'value'                   => (string)$account->id, | ||||
|                 'name'                    => $account->name, | ||||
|                 'name_with_balance'       => $nameWithBalance, | ||||
|                 'label'                   => $nameWithBalance, | ||||
|             'title' => $account->name, | ||||
|             'meta'  => [ | ||||
|                 'type'                    => $account->accountType->type, | ||||
|                 'currency_id'             => null === $currency ? null : (string) $currency->id, | ||||
|                 'currency_code'           => $currency?->code, | ||||
|                 'currency_symbol'         => $currency?->symbol, | ||||
|                 'currency_decimal_places' => $currency?->decimal_places, | ||||
|                 'account_balances'        => $this->getAccountBalances($account), | ||||
|             ], | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     private function getAccountBalances(Account $account): array | ||||
|     { | ||||
|         $return   = []; | ||||
|         $balances = $this->repository->getAccountBalances($account); | ||||
| 
 | ||||
|         /** @var AccountBalance $balance */ | ||||
|         foreach ($balances as $balance) { | ||||
|             try { | ||||
|                 $return[] = $this->parseAccountBalance($balance); | ||||
|             } catch (FireflyException $e) { | ||||
|                 Log::error(sprintf('Could not parse convert account balance: %s', $e->getMessage())); | ||||
|             } | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * @throws FireflyException | ||||
|      */ | ||||
|     private function parseAccountBalance(AccountBalance $balance): array | ||||
|     { | ||||
|         $currency = $balance->transactionCurrency; | ||||
| 
 | ||||
|         return [ | ||||
|             'title'                          => $balance->title, | ||||
|             'native_amount'                  => $this->converter->convert($currency, $this->default, today(), $balance->balance), | ||||
|             'amount'                         => app('steam')->bcround($balance->balance, $currency->decimal_places), | ||||
|             'currency_id'                    => (string) $currency->id, | ||||
|                 'currency_name'           => $currency->name, | ||||
|             'currency_code'                  => $currency->code, | ||||
|             'currency_symbol'                => $currency->symbol, | ||||
|             'currency_decimal_places'        => $currency->decimal_places, | ||||
|             'native_currency_id'             => (string) $this->default->id, | ||||
|             'native_currency_code'           => $this->default->code, | ||||
|             'native_currency_symbol'         => $this->default->symbol, | ||||
|             'native_currency_decimal_places' => $this->default->decimal_places, | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|         usort( | ||||
|             $allItems, | ||||
|             static function (array $left, array $right): int { | ||||
|                 $order    = [AccountType::ASSET, AccountType::REVENUE, AccountType::EXPENSE]; | ||||
|                 $posLeft  = (int)array_search($left['type'], $order, true); | ||||
|                 $posRight = (int)array_search($right['type'], $order, true); | ||||
| 
 | ||||
|                 return $posLeft - $posRight; | ||||
|             } | ||||
|         ); | ||||
| 
 | ||||
|         return response()->json($allItems); | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -45,11 +45,7 @@ class CategoryController extends Controller | ||||
|         $this->middleware( | ||||
|             function ($request, $next) { | ||||
|                 $this->repository = app(CategoryRepositoryInterface::class); | ||||
| 
 | ||||
|                 $userGroup        = $this->validateUserGroup($request); | ||||
|                 if (null !== $userGroup) { | ||||
|                     $this->repository->setUserGroup($userGroup); | ||||
|                 } | ||||
|                 $this->repository->setUserGroup($this->validateUserGroup($request)); | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
| @@ -57,23 +53,18 @@ class CategoryController extends Controller | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      *  Documentation for this endpoint: | ||||
|      *  TODO list of checks | ||||
|      *  1. use dates from ParameterBag | ||||
|      *  2. Request validates dates | ||||
|      *  3. Request includes user_group_id | ||||
|      *  4. Endpoint is documented. | ||||
|      *  5. Collector uses user_group_id | ||||
|      * Documentation: https://api-docs.firefly-iii.org/?urls.primaryName=2.1.0%20(v2)#/autocomplete/getCategoriesAC
 | ||||
|      */ | ||||
|     public function categories(AutocompleteRequest $request): JsonResponse | ||||
|     { | ||||
|         $data     = $request->getData(); | ||||
|         $result   = $this->repository->searchCategory($data['query'], $this->parameters->get('limit')); | ||||
|         $queryParameters = $request->getParameters(); | ||||
|         $result          = $this->repository->searchCategory($queryParameters['query'], $queryParameters['size']); | ||||
|         $filtered        = $result->map( | ||||
|             static function (Category $item) { | ||||
|                 return [ | ||||
|                     'id'    => (string)$item->id, | ||||
|                     'name' => $item->name, | ||||
|                     'title' => $item->name, | ||||
|                     'meta'  => [], | ||||
|                 ]; | ||||
|             } | ||||
|         ); | ||||
|   | ||||
| @@ -45,11 +45,7 @@ class TagController extends Controller | ||||
|         $this->middleware( | ||||
|             function ($request, $next) { | ||||
|                 $this->repository = app(TagRepositoryInterface::class); | ||||
| 
 | ||||
|                 $userGroup        = $this->validateUserGroup($request); | ||||
|                 if (null !== $userGroup) { | ||||
|                     $this->repository->setUserGroup($userGroup); | ||||
|                 } | ||||
|                 $this->repository->setUserGroup($this->validateUserGroup($request)); | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
| @@ -57,25 +53,20 @@ class TagController extends Controller | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      *  Documentation for this endpoint: | ||||
|      *  TODO list of checks | ||||
|      *  1. use dates from ParameterBag | ||||
|      *  2. Request validates dates | ||||
|      *  3. Request includes user_group_id | ||||
|      *  4. Endpoint is documented. | ||||
|      *  5. Collector uses user_group_id | ||||
|      * Documentation: https://api-docs.firefly-iii.org/?urls.primaryName=2.1.0%20(v2)#/autocomplete/getTagsAC
 | ||||
|      */ | ||||
|     public function tags(AutocompleteRequest $request): JsonResponse | ||||
|     { | ||||
|         $data     = $request->getData(); | ||||
|         $result   = $this->repository->searchTag($data['query'], $data['limit']); | ||||
|         $queryParameters = $request->getParameters(); | ||||
|         $result          = $this->repository->searchTag($queryParameters['query'], $queryParameters['size']); | ||||
|         $filtered        = $result->map( | ||||
|             static function (Tag $item) { | ||||
|                 return [ | ||||
|                     'id'    => (string) $item->id, | ||||
|                     'name'    => $item->tag, | ||||
|                     'title' => $item->tag, | ||||
|                     'value' => (string) $item->id, | ||||
|                     'label' => $item->tag, | ||||
|                     'meta'  => [], | ||||
|                 ]; | ||||
|             } | ||||
|         ); | ||||
|   | ||||
| @@ -45,11 +45,7 @@ class TransactionController extends Controller | ||||
|         $this->middleware( | ||||
|             function ($request, $next) { | ||||
|                 $this->repository = app(JournalRepositoryInterface::class); | ||||
| 
 | ||||
|                 $userGroup        = $this->validateUserGroup($request); | ||||
|                 if (null !== $userGroup) { | ||||
|                     $this->repository->setUserGroup($userGroup); | ||||
|                 } | ||||
|                 $this->repository->setUserGroup($this->validateUserGroup($request)); | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
| @@ -57,18 +53,12 @@ class TransactionController extends Controller | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      *  Documentation for this endpoint: | ||||
|      *  TODO list of checks | ||||
|      *  1. use dates from ParameterBag | ||||
|      *  2. Request validates dates | ||||
|      *  3. Request includes user_group_id | ||||
|      *  4. Endpoint is documented. | ||||
|      *  5. Collector uses user_group_id | ||||
|      * Documentation: https://api-docs.firefly-iii.org/?urls.primaryName=2.1.0%20(v2)#/autocomplete/getTransactionsAC
 | ||||
|      */ | ||||
|     public function transactionDescriptions(AutocompleteRequest $request): JsonResponse | ||||
|     { | ||||
|         $data     = $request->getData(); | ||||
|         $result   = $this->repository->searchJournalDescriptions($data['query'], $data['limit']); | ||||
|         $queryParameters = $request->getParameters(); | ||||
|         $result          = $this->repository->searchJournalDescriptions($queryParameters['query'], $queryParameters['size']); | ||||
| 
 | ||||
|         // limit and unique
 | ||||
|         $filtered        = $result->unique('description'); | ||||
| @@ -78,9 +68,10 @@ class TransactionController extends Controller | ||||
|         foreach ($filtered as $journal) { | ||||
|             $array[] = [ | ||||
|                 'id'    => (string) $journal->id, | ||||
|                 'title' => $journal->description, | ||||
|                 'meta'  => [ | ||||
|                     'transaction_group_id' => (string) $journal->transaction_group_id, | ||||
|                 'name'                 => $journal->description, | ||||
|                 'description'          => $journal->description, | ||||
|                 ], | ||||
|             ]; | ||||
|         } | ||||
| 
 | ||||
|   | ||||
| @@ -24,18 +24,17 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V2\Controllers\Chart; | ||||
| 
 | ||||
| use Carbon\Carbon; | ||||
| use FireflyIII\Api\V2\Controllers\Controller; | ||||
| use FireflyIII\Api\V2\Request\Chart\DashboardChartRequest; | ||||
| use FireflyIII\Api\V2\Request\Chart\ChartRequest; | ||||
| use FireflyIII\Exceptions\FireflyException; | ||||
| use FireflyIII\Models\Account; | ||||
| use FireflyIII\Models\AccountType; | ||||
| use FireflyIII\Models\TransactionCurrency; | ||||
| use FireflyIII\Repositories\UserGroups\Account\AccountRepositoryInterface; | ||||
| use FireflyIII\Support\Chart\ChartData; | ||||
| use FireflyIII\Support\Http\Api\CleansChartData; | ||||
| use FireflyIII\Support\Http\Api\CollectsAccountsFromFilter; | ||||
| use FireflyIII\Support\Http\Api\ValidatesUserGroupTrait; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Support\Collection; | ||||
| 
 | ||||
| /** | ||||
|  * Class AccountController | ||||
| @@ -43,9 +42,12 @@ use Illuminate\Support\Collection; | ||||
| class AccountController extends Controller | ||||
| { | ||||
|     use CleansChartData; | ||||
|     use CollectsAccountsFromFilter; | ||||
|     use ValidatesUserGroupTrait; | ||||
| 
 | ||||
|     private AccountRepositoryInterface $repository; | ||||
|     private ChartData                  $chartData; | ||||
|     private TransactionCurrency        $default; | ||||
| 
 | ||||
|     public function __construct() | ||||
|     { | ||||
| @@ -53,10 +55,9 @@ class AccountController extends Controller | ||||
|         $this->middleware( | ||||
|             function ($request, $next) { | ||||
|                 $this->repository = app(AccountRepositoryInterface::class); | ||||
|                 $userGroup        = $this->validateUserGroup($request); | ||||
|                 if (null !== $userGroup) { | ||||
|                     $this->repository->setUserGroup($userGroup); | ||||
|                 } | ||||
|                 $this->repository->setUserGroup($this->validateUserGroup($request)); | ||||
|                 $this->chartData  = new ChartData(); | ||||
|                 $this->default    = app('amount')->getDefaultCurrency(); | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
| @@ -64,69 +65,40 @@ class AccountController extends Controller | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * This endpoint is documented at | ||||
|      * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v2)#/charts/getChartAccountOverview
 | ||||
|      * | ||||
|      * The native currency is the preferred currency on the page /currencies. | ||||
|      * | ||||
|      * If a transaction has foreign currency = native currency, the foreign amount will be used, no conversion | ||||
|      * will take place. | ||||
|      * | ||||
|      * TODO validate and set user_group_id from request | ||||
|      * TODO fix documentation | ||||
|      * | ||||
|      * @throws FireflyException | ||||
|      * | ||||
|      * @SuppressWarnings(PHPMD.UnusedFormalParameter) | ||||
|      */ | ||||
|     public function dashboard(DashboardChartRequest $request): JsonResponse | ||||
|     public function dashboard(ChartRequest $request): JsonResponse | ||||
|     { | ||||
|         /** @var Carbon $start */ | ||||
|         $start     = $this->parameters->get('start'); | ||||
|         $queryParameters = $request->getParameters(); | ||||
|         $accounts        = $this->getAccountList($queryParameters); | ||||
| 
 | ||||
|         /** @var Carbon $end */ | ||||
|         $end       = $this->parameters->get('end'); | ||||
|         $end->endOfDay(); | ||||
| 
 | ||||
|         /** @var TransactionCurrency $default */ | ||||
|         $default   = app('amount')->getDefaultCurrency(); | ||||
|         $params    = $request->getAll(); | ||||
| 
 | ||||
|         /** @var Collection $accounts */ | ||||
|         $accounts  = $params['accounts']; | ||||
|         $chartData = []; | ||||
| 
 | ||||
|         // user's preferences
 | ||||
|         if (0 === $accounts->count()) { | ||||
|             $defaultSet = $this->repository->getAccountsByType([AccountType::ASSET, AccountType::DEFAULT])->pluck('id')->toArray(); | ||||
|             $frontPage  = app('preferences')->get('frontPageAccounts', $defaultSet); | ||||
| 
 | ||||
|             if (!(is_array($frontPage->data) && count($frontPage->data) > 0)) { | ||||
|                 $frontPage->data = $defaultSet; | ||||
|                 $frontPage->save(); | ||||
|             } | ||||
| 
 | ||||
|             $accounts   = $this->repository->getAccountsById($frontPage->data); | ||||
|         } | ||||
| 
 | ||||
|         // both options are overruled by "preselected"
 | ||||
|         if ('all' === $params['preselected']) { | ||||
|             $accounts = $this->repository->getAccountsByType([AccountType::ASSET, AccountType::DEFAULT, AccountType::LOAN, AccountType::DEBT, AccountType::MORTGAGE]); | ||||
|         } | ||||
|         if ('assets' === $params['preselected']) { | ||||
|             $accounts = $this->repository->getAccountsByType([AccountType::ASSET, AccountType::DEFAULT]); | ||||
|         } | ||||
|         if ('liabilities' === $params['preselected']) { | ||||
|             $accounts = $this->repository->getAccountsByType([AccountType::LOAN, AccountType::DEBT, AccountType::MORTGAGE]); | ||||
|         } | ||||
|         // move date to end of day
 | ||||
|         $queryParameters['start']->startOfDay(); | ||||
|         $queryParameters['end']->endOfDay(); | ||||
| 
 | ||||
|         // loop each account, and collect info:
 | ||||
|         /** @var Account $account */ | ||||
|         foreach ($accounts as $account) { | ||||
|             $this->renderAccountData($queryParameters, $account); | ||||
|         } | ||||
| 
 | ||||
|         return response()->json($this->chartData->render()); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * @throws FireflyException | ||||
|      */ | ||||
|     private function renderAccountData(array $params, Account $account): void | ||||
|     { | ||||
|         $currency          = $this->repository->getAccountCurrency($account); | ||||
|         if (null === $currency) { | ||||
|                 $currency = $default; | ||||
|             $currency = $this->default; | ||||
|         } | ||||
|         $currentSet        = [ | ||||
|             'label'                          => $account->name, | ||||
| 
 | ||||
|             // the currency that belongs to the account.
 | ||||
|             'currency_id'                    => (string) $currency->id, | ||||
|             'currency_code'                  => $currency->code, | ||||
| @@ -134,23 +106,24 @@ class AccountController extends Controller | ||||
|             'currency_decimal_places'        => $currency->decimal_places, | ||||
| 
 | ||||
|             // the default currency of the user (could be the same!)
 | ||||
|                 'native_currency_id'               => (string)$default->id, | ||||
|                 'native_currency_code'             => $default->code, | ||||
|                 'native_currency_symbol'           => $default->symbol, | ||||
|                 'native_currency_decimal_places'   => $default->decimal_places, | ||||
|                 'start'                            => $start->toAtomString(), | ||||
|                 'end'                              => $end->toAtomString(), | ||||
|             'native_currency_id'             => (string) $this->default->id, | ||||
|             'native_currency_code'           => $this->default->code, | ||||
|             'native_currency_symbol'         => $this->default->symbol, | ||||
|             'native_currency_decimal_places' => $this->default->decimal_places, | ||||
|             'date'                           => $params['start']->toAtomString(), | ||||
|             'start'                          => $params['start']->toAtomString(), | ||||
|             'end'                            => $params['end']->toAtomString(), | ||||
|             'period'                         => '1D', | ||||
|             'entries'                        => [], | ||||
|             'native_entries'                 => [], | ||||
|         ]; | ||||
|             $currentStart      = clone $start; | ||||
|             $range             = app('steam')->balanceInRange($account, $start, clone $end, $currency); | ||||
|             $rangeConverted    = app('steam')->balanceInRangeConverted($account, $start, clone $end, $default); | ||||
|         $currentStart      = clone $params['start']; | ||||
|         $range             = app('steam')->balanceInRange($account, $params['start'], clone $params['end'], $currency); | ||||
|         $rangeConverted    = app('steam')->balanceInRangeConverted($account, $params['start'], clone $params['end'], $this->default); | ||||
| 
 | ||||
|         $previous          = array_values($range)[0]; | ||||
|         $previousConverted = array_values($rangeConverted)[0]; | ||||
|             while ($currentStart <= $end) { | ||||
|         while ($currentStart <= $params['end']) { | ||||
|             $format                               = $currentStart->format('Y-m-d'); | ||||
|             $label                                = $currentStart->toAtomString(); | ||||
|             $balance                              = array_key_exists($format, $range) ? $range[$format] : $previous; | ||||
| @@ -162,9 +135,6 @@ class AccountController extends Controller | ||||
|             $currentSet['entries'][$label]        = $balance; | ||||
|             $currentSet['native_entries'][$label] = $balanceConverted; | ||||
|         } | ||||
|             $chartData[]       = $currentSet; | ||||
|         } | ||||
| 
 | ||||
|         return response()->json($this->clean($chartData)); | ||||
|         $this->chartData->add($currentSet); | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -24,17 +24,18 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V2\Controllers\Chart; | ||||
| 
 | ||||
| use Carbon\Carbon; | ||||
| use FireflyIII\Api\V2\Controllers\Controller; | ||||
| use FireflyIII\Api\V2\Request\Chart\BalanceChartRequest; | ||||
| use FireflyIII\Api\V2\Request\Chart\ChartRequest; | ||||
| use FireflyIII\Exceptions\FireflyException; | ||||
| use FireflyIII\Helpers\Collector\GroupCollectorInterface; | ||||
| use FireflyIII\Models\TransactionCurrency; | ||||
| use FireflyIII\Models\TransactionType; | ||||
| use FireflyIII\Repositories\UserGroups\Account\AccountRepositoryInterface; | ||||
| use FireflyIII\Support\Chart\ChartData; | ||||
| use FireflyIII\Support\Http\Api\AccountBalanceGrouped; | ||||
| use FireflyIII\Support\Http\Api\CleansChartData; | ||||
| use FireflyIII\Support\Http\Api\CollectsAccountsFromFilter; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Support\Collection; | ||||
| 
 | ||||
| /** | ||||
|  * Class BalanceController | ||||
| @@ -42,6 +43,30 @@ use Illuminate\Support\Collection; | ||||
| class BalanceController extends Controller | ||||
| { | ||||
|     use CleansChartData; | ||||
|     use CollectsAccountsFromFilter; | ||||
| 
 | ||||
|     private AccountRepositoryInterface $repository; | ||||
|     private GroupCollectorInterface    $collector; | ||||
|     private ChartData                  $chartData; | ||||
|     // private TransactionCurrency        $default;
 | ||||
| 
 | ||||
|     public function __construct() | ||||
|     { | ||||
|         parent::__construct(); | ||||
|         $this->middleware( | ||||
|             function ($request, $next) { | ||||
|                 $this->repository = app(AccountRepositoryInterface::class); | ||||
|                 $this->collector  = app(GroupCollectorInterface::class); | ||||
|                 $userGroup        = $this->validateUserGroup($request); | ||||
|                 $this->repository->setUserGroup($userGroup); | ||||
|                 $this->collector->setUserGroup($userGroup); | ||||
|                 $this->chartData  = new ChartData(); | ||||
|                 // $this->default    = app('amount')->getDefaultCurrency();
 | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
|         ); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * The code is practically a duplicate of ReportController::operations. | ||||
| @@ -52,50 +77,43 @@ class BalanceController extends Controller | ||||
|      * If the transaction being processed is already in native currency OR if the | ||||
|      * foreign amount is in the native currency, the amount will not be converted. | ||||
|      * | ||||
|      * TODO validate and set user_group_id | ||||
|      * TODO collector set group, not user | ||||
|      * | ||||
|      * @throws FireflyException | ||||
|      */ | ||||
|     public function balance(BalanceChartRequest $request): JsonResponse | ||||
|     public function balance(ChartRequest $request): JsonResponse | ||||
|     { | ||||
|         $params         = $request->getAll(); | ||||
|         $queryParameters = $request->getParameters(); | ||||
|         $accounts        = $this->getAccountList($queryParameters); | ||||
| 
 | ||||
|         /** @var Carbon $start */ | ||||
|         $start          = $this->parameters->get('start'); | ||||
| 
 | ||||
|         /** @var Carbon $end */ | ||||
|         $end            = $this->parameters->get('end'); | ||||
|         $end->endOfDay(); | ||||
| 
 | ||||
|         /** @var Collection $accounts */ | ||||
|         $accounts       = $params['accounts']; | ||||
| 
 | ||||
|         /** @var string $preferredRange */ | ||||
|         $preferredRange = $params['period']; | ||||
|         // move date to end of day
 | ||||
|         $queryParameters['start']->startOfDay(); | ||||
|         $queryParameters['end']->endOfDay(); | ||||
| 
 | ||||
|         // prepare for currency conversion and data collection:
 | ||||
|         /** @var TransactionCurrency $default */ | ||||
|         $default         = app('amount')->getDefaultCurrency(); | ||||
| 
 | ||||
|         // get journals for entire period:
 | ||||
|         /** @var GroupCollectorInterface $collector */ | ||||
|         $collector      = app(GroupCollectorInterface::class); | ||||
|         $collector->setRange($start, $end)->withAccountInformation(); | ||||
|         $collector->setXorAccounts($accounts); | ||||
|         $collector->setTypes([TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::RECONCILIATION, TransactionType::TRANSFER]); | ||||
|         $journals       = $collector->getExtractedJournals(); | ||||
| 
 | ||||
|         $this->collector->setRange($queryParameters['start'], $queryParameters['end']) | ||||
|             ->withAccountInformation() | ||||
|             ->setXorAccounts($accounts) | ||||
|             ->setTypes([TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::RECONCILIATION, TransactionType::TRANSFER]) | ||||
|         ; | ||||
|         $journals        = $this->collector->getExtractedJournals(); | ||||
| 
 | ||||
|         $object          = new AccountBalanceGrouped(); | ||||
|         $object->setPreferredRange($preferredRange); | ||||
|         $object->setPreferredRange($queryParameters['period']); | ||||
|         $object->setDefault($default); | ||||
|         $object->setAccounts($accounts); | ||||
|         $object->setJournals($journals); | ||||
|         $object->setStart($start); | ||||
|         $object->setEnd($end); | ||||
|         $object->setStart($queryParameters['start']); | ||||
|         $object->setEnd($queryParameters['end']); | ||||
|         $object->groupByCurrencyAndPeriod(); | ||||
|         $chartData      = $object->convertToChartData(); | ||||
|         $data            = $object->convertToChartData(); | ||||
|         foreach ($data as $entry) { | ||||
|             $this->chartData->add($entry); | ||||
|         } | ||||
| 
 | ||||
|         return response()->json($this->clean($chartData)); | ||||
|         return response()->json($this->chartData->render()); | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -64,12 +64,9 @@ class BudgetController extends Controller | ||||
|                 $this->blRepository  = app(BudgetLimitRepositoryInterface::class); | ||||
|                 $this->opsRepository = app(OperationsRepositoryInterface::class); | ||||
|                 $this->currency      = app('amount')->getDefaultCurrency(); | ||||
| 
 | ||||
|                 $userGroup           = $this->validateUserGroup($request); | ||||
|                 if (null !== $userGroup) { | ||||
|                 $this->repository->setUserGroup($userGroup); | ||||
|                 $this->opsRepository->setUserGroup($userGroup); | ||||
|                 } | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
|   | ||||
| @@ -57,10 +57,7 @@ class CategoryController extends Controller | ||||
|             function ($request, $next) { | ||||
|                 $this->accountRepos  = app(AccountRepositoryInterface::class); | ||||
|                 $this->currencyRepos = app(CurrencyRepositoryInterface::class); | ||||
|                 $userGroup           = $this->validateUserGroup($request); | ||||
|                 if (null !== $userGroup) { | ||||
|                     $this->accountRepos->setUserGroup($userGroup); | ||||
|                 } | ||||
|                 $this->accountRepos->setUserGroup($this->validateUserGroup($request)); | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
|   | ||||
| @@ -27,6 +27,7 @@ namespace FireflyIII\Api\V2\Controllers; | ||||
| use Carbon\Carbon; | ||||
| use Carbon\Exceptions\InvalidDateException; | ||||
| use Carbon\Exceptions\InvalidFormatException; | ||||
| use FireflyIII\Enums\UserRoleEnum; | ||||
| use FireflyIII\Support\Http\Api\ValidatesUserGroupTrait; | ||||
| use FireflyIII\Transformers\V2\AbstractTransformer; | ||||
| use Illuminate\Database\Eloquent\Model; | ||||
| @@ -55,6 +56,7 @@ class Controller extends BaseController | ||||
| 
 | ||||
|     protected const string CONTENT_TYPE = 'application/vnd.api+json'; | ||||
|     protected ParameterBag $parameters; | ||||
|     protected array $acceptedRoles      = [UserRoleEnum::READ_ONLY]; | ||||
| 
 | ||||
|     public function __construct() | ||||
|     { | ||||
| @@ -67,43 +69,6 @@ class Controller extends BaseController | ||||
|         ); | ||||
|     } | ||||
| 
 | ||||
|     final protected function jsonApiList(string $key, LengthAwarePaginator $paginator, AbstractTransformer $transformer): array | ||||
|     { | ||||
|         $manager  = new Manager(); | ||||
|         $baseUrl  = request()->getSchemeAndHttpHost().'/api/v2'; | ||||
|         $manager->setSerializer(new JsonApiSerializer($baseUrl)); | ||||
| 
 | ||||
|         $objects  = $paginator->getCollection(); | ||||
| 
 | ||||
|         // the transformer, at this point, needs to collect information that ALL items in the collection
 | ||||
|         // require, like meta-data and stuff like that, and save it for later.
 | ||||
|         $transformer->collectMetaData($objects); | ||||
| 
 | ||||
|         $resource = new FractalCollection($objects, $transformer, $key); | ||||
|         $resource->setPaginator(new IlluminatePaginatorAdapter($paginator)); | ||||
| 
 | ||||
|         return $manager->createData($resource)->toArray(); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Returns a JSON API object and returns it. | ||||
|      * | ||||
|      * @param array<int, mixed>|Model $object | ||||
|      */ | ||||
|     final protected function jsonApiObject(string $key, array|Model $object, AbstractTransformer $transformer): array | ||||
|     { | ||||
|         // create some objects:
 | ||||
|         $manager  = new Manager(); | ||||
|         $baseUrl  = request()->getSchemeAndHttpHost().'/api/v2'; | ||||
|         $manager->setSerializer(new JsonApiSerializer($baseUrl)); | ||||
| 
 | ||||
|         $transformer->collectMetaData(new Collection([$object])); | ||||
| 
 | ||||
|         $resource = new Item($object, $transformer, $key); | ||||
| 
 | ||||
|         return $manager->createData($resource)->toArray(); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * TODO duplicate from V1 controller | ||||
|      * Method to grab all parameters from the URL. | ||||
| @@ -157,6 +122,9 @@ class Controller extends BaseController | ||||
|                     $obj = null; | ||||
|                 } | ||||
|             } | ||||
|             if (null !== $date && 'end' === $field) { | ||||
|                 $obj->endOfDay(); | ||||
|             } | ||||
|             $bag->set($field, $obj); | ||||
|         } | ||||
| 
 | ||||
| @@ -184,4 +152,45 @@ class Controller extends BaseController | ||||
| 
 | ||||
|         return $bag; | ||||
|     } | ||||
| 
 | ||||
|     final protected function jsonApiList(string $key, LengthAwarePaginator $paginator, AbstractTransformer $transformer): array | ||||
|     { | ||||
|         $manager  = new Manager(); | ||||
|         $baseUrl  = request()->getSchemeAndHttpHost().'/api/v2'; | ||||
| 
 | ||||
|         // TODO add stuff to path?
 | ||||
| 
 | ||||
|         $manager->setSerializer(new JsonApiSerializer($baseUrl)); | ||||
| 
 | ||||
|         $objects  = $paginator->getCollection(); | ||||
| 
 | ||||
|         // the transformer, at this point, needs to collect information that ALL items in the collection
 | ||||
|         // require, like meta-data and stuff like that, and save it for later.
 | ||||
|         $objects  = $transformer->collectMetaData($objects); | ||||
|         $paginator->setCollection($objects); | ||||
| 
 | ||||
|         $resource = new FractalCollection($objects, $transformer, $key); | ||||
|         $resource->setPaginator(new IlluminatePaginatorAdapter($paginator)); | ||||
| 
 | ||||
|         return $manager->createData($resource)->toArray(); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Returns a JSON API object and returns it. | ||||
|      * | ||||
|      * @param array<int, mixed>|Model $object | ||||
|      */ | ||||
|     final protected function jsonApiObject(string $key, array|Model $object, AbstractTransformer $transformer): array | ||||
|     { | ||||
|         // create some objects:
 | ||||
|         $manager  = new Manager(); | ||||
|         $baseUrl  = request()->getSchemeAndHttpHost().'/api/v2'; | ||||
|         $manager->setSerializer(new JsonApiSerializer($baseUrl)); | ||||
| 
 | ||||
|         $transformer->collectMetaData(new Collection([$object])); | ||||
| 
 | ||||
|         $resource = new Item($object, $transformer, $key); | ||||
| 
 | ||||
|         return $manager->createData($resource)->toArray(); | ||||
|     } | ||||
| } | ||||
|   | ||||
							
								
								
									
										111
									
								
								app/Api/V2/Controllers/JsonApi/AccountController.php
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										111
									
								
								app/Api/V2/Controllers/JsonApi/AccountController.php
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,111 @@ | ||||
| <?php | ||||
| /* | ||||
|  * AccountController.php | ||||
|  * Copyright (c) 2024 james@firefly-iii.org. | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
|  * This program is free software: you can redistribute it and/or modify | ||||
|  * it under the terms of the GNU Affero General Public License as | ||||
|  * published by the Free Software Foundation, either version 3 of the | ||||
|  * License, or (at your option) any later version. | ||||
|  * | ||||
|  * This program is distributed in the hope that it will be useful, | ||||
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see https://www.gnu.org/licenses/. | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V2\Controllers\JsonApi; | ||||
| 
 | ||||
| use FireflyIII\Http\Controllers\Controller; | ||||
| use FireflyIII\JsonApi\V2\Accounts\AccountCollectionQuery; | ||||
| use FireflyIII\JsonApi\V2\Accounts\AccountSchema; | ||||
| use FireflyIII\JsonApi\V2\Accounts\AccountSingleQuery; | ||||
| use FireflyIII\Models\Account; | ||||
| use Illuminate\Contracts\Support\Responsable; | ||||
| use Illuminate\Http\Response; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use LaravelJsonApi\Core\Responses\DataResponse; | ||||
| use LaravelJsonApi\Laravel\Http\Controllers\Actions; | ||||
| 
 | ||||
| /** | ||||
|  * Class AccountController | ||||
|  * | ||||
|  * This class handles api/v2 requests for accounts. | ||||
|  * Most stuff is default stuff. | ||||
|  */ | ||||
| class AccountController extends Controller | ||||
| { | ||||
|     use Actions\AttachRelationship; | ||||
|     use Actions\Destroy; | ||||
|     use Actions\DetachRelationship; | ||||
| 
 | ||||
|     use Actions\FetchMany; | ||||
|     // use Actions\FetchOne;
 | ||||
|     use Actions\FetchRelated; | ||||
|     use Actions\FetchRelationship; | ||||
|     use Actions\Store; | ||||
|     use Actions\Update; | ||||
|     use Actions\UpdateRelationship; | ||||
| 
 | ||||
|     /** | ||||
|      * Fetch zero to many JSON API resources. | ||||
|      * | ||||
|      * @return Responsable|Response | ||||
|      */ | ||||
|     public function index(AccountSchema $schema, AccountCollectionQuery $request) | ||||
|     { | ||||
|         Log::debug(__METHOD__); | ||||
|         $models = $schema | ||||
|             ->repository() | ||||
|             ->queryAll() | ||||
|             ->withRequest($request) | ||||
|             ->get() | ||||
|         ; | ||||
| 
 | ||||
|         // do something custom...
 | ||||
| 
 | ||||
|         return new DataResponse($models); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Fetch zero to one JSON API resource by id. | ||||
|      * | ||||
|      * @return Responsable|Response | ||||
|      */ | ||||
|     public function show(AccountSchema $schema, AccountSingleQuery $request, Account $account) | ||||
|     { | ||||
|         Log::debug(__METHOD__); | ||||
|         $model = $schema->repository() | ||||
|             ->queryOne($account) | ||||
|             ->withRequest($request) | ||||
|             ->first() | ||||
|         ; | ||||
|         Log::debug(sprintf('%s again!', __METHOD__)); | ||||
| 
 | ||||
|         // do something custom...
 | ||||
| 
 | ||||
|         return new DataResponse($model); | ||||
|     } | ||||
| 
 | ||||
|     //    public function readAccountBalances(AnonymousQuery $query, AccountBalanceSchema $schema, Account $account): Responsable
 | ||||
|     //    {
 | ||||
|     //        $schema = JsonApi::server()->schemas()->schemaFor('account-balances');
 | ||||
|     //
 | ||||
|     //        $models = $schema
 | ||||
|     //            ->repository()
 | ||||
|     //            ->queryAll()
 | ||||
|     //            ->withRequest($query)
 | ||||
|     //            ->withAccount($account)
 | ||||
|     //            ->get()
 | ||||
|     //        ;
 | ||||
|     //
 | ||||
|     //        return DataResponse::make($models);
 | ||||
|     //    }
 | ||||
| } | ||||
							
								
								
									
										97
									
								
								app/Api/V2/Controllers/Model/Account/IndexController.php
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										97
									
								
								app/Api/V2/Controllers/Model/Account/IndexController.php
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,97 @@ | ||||
| <?php | ||||
| /* | ||||
|  * IndexController.php | ||||
|  * Copyright (c) 2024 james@firefly-iii.org. | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
|  * This program is free software: you can redistribute it and/or modify | ||||
|  * it under the terms of the GNU Affero General Public License as | ||||
|  * published by the Free Software Foundation, either version 3 of the | ||||
|  * License, or (at your option) any later version. | ||||
|  * | ||||
|  * This program is distributed in the hope that it will be useful, | ||||
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see https://www.gnu.org/licenses/. | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V2\Controllers\Model\Account; | ||||
| 
 | ||||
| use FireflyIII\Api\V2\Controllers\Controller; | ||||
| use FireflyIII\Api\V2\Request\Model\Account\IndexRequest; | ||||
| use FireflyIII\Enums\UserRoleEnum; | ||||
| use FireflyIII\Repositories\UserGroups\Account\AccountRepositoryInterface; | ||||
| use FireflyIII\Transformers\V2\AccountTransformer; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Pagination\LengthAwarePaginator; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| 
 | ||||
| class IndexController extends Controller | ||||
| { | ||||
|     public const string RESOURCE_KEY                  = 'accounts'; | ||||
| 
 | ||||
|     private AccountRepositoryInterface $repository; | ||||
|     protected array                    $acceptedRoles = [UserRoleEnum::READ_ONLY, UserRoleEnum::MANAGE_TRANSACTIONS]; | ||||
| 
 | ||||
|     /** | ||||
|      * AccountController constructor. | ||||
|      */ | ||||
|     public function __construct() | ||||
|     { | ||||
|         parent::__construct(); | ||||
|         $this->middleware( | ||||
|             function ($request, $next) { | ||||
|                 $this->repository = app(AccountRepositoryInterface::class); | ||||
|                 // new way of user group validation
 | ||||
|                 $userGroup        = $this->validateUserGroup($request); | ||||
|                 $this->repository->setUserGroup($userGroup); | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
|         ); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * TODO the sort instructions need proper repeatable documentation. | ||||
|      * TODO see autocomplete/account controller for list. | ||||
|      */ | ||||
|     public function index(IndexRequest $request): JsonResponse | ||||
|     { | ||||
|         $this->repository->resetAccountOrder(); | ||||
|         $types             = $request->getAccountTypes(); | ||||
|         $sorting           = $request->getSortInstructions('accounts'); | ||||
|         $filters           = $request->getFilterInstructions('accounts'); | ||||
|         $accounts          = $this->repository->getAccountsByType($types, $sorting, $filters); | ||||
|         $pageSize          = $this->parameters->get('limit'); | ||||
|         $count             = $accounts->count(); | ||||
| 
 | ||||
|         // depending on the sort parameters, this list must not be split, because the
 | ||||
|         // order is calculated in the account transformer and by that time it's too late.
 | ||||
|         $first             = array_key_first($sorting); | ||||
|         $disablePagination = in_array($first, ['last_activity', 'balance', 'balance_difference'], true); | ||||
|         Log::debug(sprintf('Will disable pagination in account index v2? %s', var_export($disablePagination, true))); | ||||
|         if (!$disablePagination) { | ||||
|             $accounts = $accounts->slice(($this->parameters->get('page') - 1) * $pageSize, $pageSize); | ||||
|         } | ||||
|         $paginator         = new LengthAwarePaginator($accounts, $count, $pageSize, $this->parameters->get('page')); | ||||
|         $transformer       = new AccountTransformer(); | ||||
| 
 | ||||
|         $this->parameters->set('disablePagination', $disablePagination); | ||||
|         $this->parameters->set('pageSize', $pageSize); | ||||
|         $this->parameters->set('sort', $sorting); | ||||
| 
 | ||||
|         $this->parameters->set('filters', $filters); | ||||
|         $transformer->setParameters($this->parameters); // give params to transformer
 | ||||
| 
 | ||||
|         return response() | ||||
|             ->json($this->jsonApiList('accounts', $paginator, $transformer)) | ||||
|             ->header('Content-Type', self::CONTENT_TYPE) | ||||
|         ; | ||||
|     } | ||||
| } | ||||
| @@ -25,7 +25,9 @@ declare(strict_types=1); | ||||
| namespace FireflyIII\Api\V2\Controllers\Model\Account; | ||||
| 
 | ||||
| use FireflyIII\Api\V2\Controllers\Controller; | ||||
| use FireflyIII\Enums\UserRoleEnum; | ||||
| use FireflyIII\Models\Account; | ||||
| use FireflyIII\Repositories\UserGroups\Account\AccountRepositoryInterface; | ||||
| use FireflyIII\Transformers\V2\AccountTransformer; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| 
 | ||||
| @@ -36,6 +38,29 @@ use Illuminate\Http\JsonResponse; | ||||
|  */ | ||||
| class ShowController extends Controller | ||||
| { | ||||
|     public const string RESOURCE_KEY                  = 'accounts'; | ||||
| 
 | ||||
|     private AccountRepositoryInterface $repository; | ||||
|     protected array                    $acceptedRoles = [UserRoleEnum::READ_ONLY, UserRoleEnum::MANAGE_TRANSACTIONS]; | ||||
| 
 | ||||
|     /** | ||||
|      * AccountController constructor. | ||||
|      */ | ||||
|     public function __construct() | ||||
|     { | ||||
|         parent::__construct(); | ||||
|         $this->middleware( | ||||
|             function ($request, $next) { | ||||
|                 $this->repository = app(AccountRepositoryInterface::class); | ||||
|                 // new way of user group validation
 | ||||
|                 $userGroup        = $this->validateUserGroup($request); | ||||
|                 $this->repository->setUserGroup($userGroup); | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
|         ); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * TODO this endpoint is not yet reachable. | ||||
|      */ | ||||
|   | ||||
							
								
								
									
										75
									
								
								app/Api/V2/Controllers/Model/Account/UpdateController.php
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										75
									
								
								app/Api/V2/Controllers/Model/Account/UpdateController.php
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,75 @@ | ||||
| <?php | ||||
| /* | ||||
|  * UpdateController.php | ||||
|  * Copyright (c) 2024 james@firefly-iii.org. | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
|  * This program is free software: you can redistribute it and/or modify | ||||
|  * it under the terms of the GNU Affero General Public License as | ||||
|  * published by the Free Software Foundation, either version 3 of the | ||||
|  * License, or (at your option) any later version. | ||||
|  * | ||||
|  * This program is distributed in the hope that it will be useful, | ||||
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see https://www.gnu.org/licenses/. | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V2\Controllers\Model\Account; | ||||
| 
 | ||||
| use FireflyIII\Api\V2\Controllers\Controller; | ||||
| use FireflyIII\Api\V2\Request\Model\Account\UpdateRequest; | ||||
| use FireflyIII\Models\Account; | ||||
| use FireflyIII\Repositories\UserGroups\Account\AccountRepositoryInterface; | ||||
| use FireflyIII\Transformers\V2\AccountTransformer; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| 
 | ||||
| class UpdateController extends Controller | ||||
| { | ||||
|     public const string RESOURCE_KEY = 'accounts'; | ||||
| 
 | ||||
|     private AccountRepositoryInterface $repository; | ||||
| 
 | ||||
|     /** | ||||
|      * AccountController constructor. | ||||
|      */ | ||||
|     public function __construct() | ||||
|     { | ||||
|         parent::__construct(); | ||||
|         $this->middleware( | ||||
|             function ($request, $next) { | ||||
|                 $this->repository = app(AccountRepositoryInterface::class); | ||||
|                 $this->repository->setUserGroup($this->validateUserGroup($request)); | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
|         ); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * TODO this endpoint is not yet reachable. | ||||
|      */ | ||||
|     public function update(UpdateRequest $request, Account $account): JsonResponse | ||||
|     { | ||||
|         app('log')->debug(sprintf('Now in %s', __METHOD__)); | ||||
|         $data         = $request->getUpdateData(); | ||||
|         $data['type'] = config('firefly.shortNamesByFullName.'.$account->accountType->type); | ||||
|         $account      = $this->repository->update($account, $data); | ||||
|         $account->refresh(); | ||||
|         app('preferences')->mark(); | ||||
| 
 | ||||
|         $transformer  = new AccountTransformer(); | ||||
|         $transformer->setParameters($this->parameters); | ||||
| 
 | ||||
|         return response() | ||||
|             ->api($this->jsonApiObject('accounts', $account, $transformer)) | ||||
|             ->header('Content-Type', self::CONTENT_TYPE) | ||||
|         ; | ||||
|     } | ||||
| } | ||||
| @@ -46,12 +46,7 @@ class IndexController extends Controller | ||||
|         $this->middleware( | ||||
|             function ($request, $next) { | ||||
|                 $this->repository = app(BillRepositoryInterface::class); | ||||
| 
 | ||||
|                 // new way of user group validation
 | ||||
|                 $userGroup        = $this->validateUserGroup($request); | ||||
|                 if (null !== $userGroup) { | ||||
|                     $this->repository->setUserGroup($userGroup); | ||||
|                 } | ||||
|                 $this->repository->setUserGroup($this->validateUserGroup($request)); | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
|   | ||||
| @@ -46,12 +46,7 @@ class ShowController extends Controller | ||||
|         $this->middleware( | ||||
|             function ($request, $next) { | ||||
|                 $this->repository = app(BillRepositoryInterface::class); | ||||
| 
 | ||||
|                 // new way of user group validation
 | ||||
|                 $userGroup        = $this->validateUserGroup($request); | ||||
|                 if (null !== $userGroup) { | ||||
|                     $this->repository->setUserGroup($userGroup); | ||||
|                 } | ||||
|                 $this->repository->setUserGroup($this->validateUserGroup($request)); | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
|   | ||||
| @@ -45,11 +45,7 @@ class SumController extends Controller | ||||
|         $this->middleware( | ||||
|             function ($request, $next) { | ||||
|                 $this->repository = app(BillRepositoryInterface::class); | ||||
| 
 | ||||
|                 $userGroup        = $this->validateUserGroup($request); | ||||
|                 if (null !== $userGroup) { | ||||
|                     $this->repository->setUserGroup($userGroup); | ||||
|                 } | ||||
|                 $this->repository->setUserGroup($this->validateUserGroup($request)); | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
|   | ||||
| @@ -51,20 +51,6 @@ class ShowController extends Controller | ||||
|         ); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Show a budget. | ||||
|      */ | ||||
|     public function show(Budget $budget): JsonResponse | ||||
|     { | ||||
|         $transformer = new BudgetTransformer(); | ||||
|         $transformer->setParameters($this->parameters); | ||||
| 
 | ||||
|         return response() | ||||
|             ->api($this->jsonApiObject('budgets', $budget, $transformer)) | ||||
|             ->header('Content-Type', self::CONTENT_TYPE) | ||||
|         ; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * 2023-10-29 removed the cerSum reference, not sure where this is used atm | ||||
|      * so removed from api.php. Also applies to "spent" method. | ||||
| @@ -80,6 +66,20 @@ class ShowController extends Controller | ||||
|         return response()->json($result); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Show a budget. | ||||
|      */ | ||||
|     public function show(Budget $budget): JsonResponse | ||||
|     { | ||||
|         $transformer = new BudgetTransformer(); | ||||
|         $transformer->setParameters($this->parameters); | ||||
| 
 | ||||
|         return response() | ||||
|             ->api($this->jsonApiObject('budgets', $budget, $transformer)) | ||||
|             ->header('Content-Type', self::CONTENT_TYPE) | ||||
|         ; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * This endpoint is documented at: | ||||
|      * TODO add URL | ||||
|   | ||||
| @@ -46,11 +46,7 @@ class IndexController extends Controller | ||||
|         $this->middleware( | ||||
|             function ($request, $next) { | ||||
|                 $this->repository = app(PiggyBankRepositoryInterface::class); | ||||
| 
 | ||||
|                 $userGroup        = $this->validateUserGroup($request); | ||||
|                 if (null !== $userGroup) { | ||||
|                     $this->repository->setUserGroup($userGroup); | ||||
|                 } | ||||
|                 $this->repository->setUserGroup($this->validateUserGroup($request)); | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
|   | ||||
| @@ -77,13 +77,11 @@ class BasicController extends Controller | ||||
|                 $this->opsRepository     = app(OperationsRepositoryInterface::class); | ||||
| 
 | ||||
|                 $userGroup               = $this->validateUserGroup($request); | ||||
|                 if (null !== $userGroup) { | ||||
|                 $this->abRepository->setUserGroup($userGroup); | ||||
|                 $this->accountRepository->setUserGroup($userGroup); | ||||
|                 $this->billRepository->setUserGroup($userGroup); | ||||
|                 $this->budgetRepository->setUserGroup($userGroup); | ||||
|                 $this->opsRepository->setUserGroup($userGroup); | ||||
|                 } | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
| @@ -114,23 +112,6 @@ class BasicController extends Controller | ||||
|         return response()->json($total); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Check if date is outside session range. | ||||
|      */ | ||||
|     protected function notInDateRange(Carbon $date, Carbon $start, Carbon $end): bool // Validate a preference
 | ||||
|     { | ||||
|         $result = false; | ||||
|         if ($start->greaterThanOrEqualTo($date) && $end->greaterThanOrEqualTo($date)) { | ||||
|             $result = true; | ||||
|         } | ||||
|         // start and end in the past? use $end
 | ||||
|         if ($start->lessThanOrEqualTo($date) && $end->lessThanOrEqualTo($date)) { | ||||
|             $result = true; | ||||
|         } | ||||
| 
 | ||||
|         return $result; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * @throws FireflyException | ||||
|      */ | ||||
| @@ -315,7 +296,7 @@ class BasicController extends Controller | ||||
|             app('log')->debug(sprintf('Amount left is %s', $left)); | ||||
| 
 | ||||
|             // how much left per day?
 | ||||
|             $days                    = $today->diffInDays($end) + 1; | ||||
|             $days                    = (int)$today->diffInDays($end, true) + 1; | ||||
|             $perDay                  = '0'; | ||||
|             $perDayNative            = '0'; | ||||
|             if (0 !== $days && bccomp($left, '0') > -1) { | ||||
| @@ -411,4 +392,21 @@ class BasicController extends Controller | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Check if date is outside session range. | ||||
|      */ | ||||
|     protected function notInDateRange(Carbon $date, Carbon $start, Carbon $end): bool // Validate a preference
 | ||||
|     { | ||||
|         $result = false; | ||||
|         if ($start->greaterThanOrEqualTo($date) && $end->greaterThanOrEqualTo($date)) { | ||||
|             $result = true; | ||||
|         } | ||||
|         // start and end in the past? use $end
 | ||||
|         if ($start->lessThanOrEqualTo($date) && $end->lessThanOrEqualTo($date)) { | ||||
|             $result = true; | ||||
|         } | ||||
| 
 | ||||
|         return $result; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -52,10 +52,8 @@ class NetWorthController extends Controller | ||||
|                 $this->repository = app(AccountRepositoryInterface::class); | ||||
|                 // new way of user group validation
 | ||||
|                 $userGroup        = $this->validateUserGroup($request); | ||||
|                 if (null !== $userGroup) { | ||||
|                 $this->netWorth->setUserGroup($userGroup); | ||||
|                 $this->repository->setUserGroup($userGroup); | ||||
|                 } | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| namespace FireflyIII\Api\V2\Controllers\Transaction\List; | ||||
| 
 | ||||
| use FireflyIII\Api\V2\Controllers\Controller; | ||||
| use FireflyIII\Api\V2\Request\Model\Transaction\InfiniteListRequest; | ||||
| use FireflyIII\Api\V2\Request\Model\Transaction\ListRequest; | ||||
| use FireflyIII\Helpers\Collector\GroupCollectorInterface; | ||||
| use FireflyIII\Transformers\V2\TransactionGroupTransformer; | ||||
| @@ -34,6 +35,47 @@ use Illuminate\Http\JsonResponse; | ||||
|  */ | ||||
| class TransactionController extends Controller | ||||
| { | ||||
|     public function infiniteList(InfiniteListRequest $request): JsonResponse | ||||
|     { | ||||
|         // get sort instructions
 | ||||
|         $instructions = $request->getSortInstructions('transactions'); | ||||
| 
 | ||||
|         // collect transactions:
 | ||||
|         /** @var GroupCollectorInterface $collector */ | ||||
|         $collector    = app(GroupCollectorInterface::class); | ||||
|         $collector->setUserGroup(auth()->user()->userGroup) | ||||
|             ->withAPIInformation() | ||||
|             ->setStartRow($request->getStartRow()) | ||||
|             ->setEndRow($request->getEndRow()) | ||||
|             ->setTypes($request->getTransactionTypes()) | ||||
|             ->setSorting($instructions) | ||||
|         ; | ||||
| 
 | ||||
|         $start        = $this->parameters->get('start'); | ||||
|         $end          = $this->parameters->get('end'); | ||||
|         if (null !== $start) { | ||||
|             $collector->setStart($start); | ||||
|         } | ||||
|         if (null !== $end) { | ||||
|             $collector->setEnd($end); | ||||
|         } | ||||
| 
 | ||||
|         $paginator    = $collector->getPaginatedGroups(); | ||||
|         $params       = $request->buildParams(); | ||||
|         $paginator->setPath( | ||||
|             sprintf( | ||||
|                 '%s?%s', | ||||
|                 route('api.v2.infinite.transactions.list'), | ||||
|                 $params | ||||
|             ) | ||||
|         ); | ||||
| 
 | ||||
|         return response() | ||||
|             ->json($this->jsonApiList('transactions', $paginator, new TransactionGroupTransformer())) | ||||
|             ->header('Content-Type', self::CONTENT_TYPE) | ||||
|         ; | ||||
|     } | ||||
| 
 | ||||
|     public function list(ListRequest $request): JsonResponse | ||||
|     { | ||||
|         // collect transactions:
 | ||||
| @@ -59,9 +101,6 @@ class TransactionController extends Controller | ||||
|             $collector->setEnd($end); | ||||
|         } | ||||
| 
 | ||||
|         //        $collector->dumpQuery();
 | ||||
|         //        exit;
 | ||||
| 
 | ||||
|         $paginator = $collector->getPaginatedGroups(); | ||||
|         $params    = $request->buildParams($pageSize); | ||||
|         $paginator->setPath( | ||||
|   | ||||
							
								
								
									
										73
									
								
								app/Api/V2/Controllers/UserGroup/IndexController.php
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										73
									
								
								app/Api/V2/Controllers/UserGroup/IndexController.php
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,73 @@ | ||||
| <?php | ||||
| /* | ||||
|  * IndexController.php | ||||
|  * Copyright (c) 2024 james@firefly-iii.org. | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
|  * This program is free software: you can redistribute it and/or modify | ||||
|  * it under the terms of the GNU Affero General Public License as | ||||
|  * published by the Free Software Foundation, either version 3 of the | ||||
|  * License, or (at your option) any later version. | ||||
|  * | ||||
|  * This program is distributed in the hope that it will be useful, | ||||
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see https://www.gnu.org/licenses/. | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V2\Controllers\UserGroup; | ||||
| 
 | ||||
| use FireflyIII\Api\V2\Controllers\Controller; | ||||
| use FireflyIII\Api\V2\Request\Model\Account\IndexRequest; | ||||
| use FireflyIII\Repositories\UserGroup\UserGroupRepositoryInterface; | ||||
| use FireflyIII\Transformers\V2\UserGroupTransformer; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Pagination\LengthAwarePaginator; | ||||
| 
 | ||||
| class IndexController extends Controller | ||||
| { | ||||
|     public const string RESOURCE_KEY = 'user_groups'; | ||||
| 
 | ||||
|     private UserGroupRepositoryInterface $repository; | ||||
| 
 | ||||
|     /** | ||||
|      * AccountController constructor. | ||||
|      */ | ||||
|     public function __construct() | ||||
|     { | ||||
|         parent::__construct(); | ||||
|         $this->middleware( | ||||
|             function ($request, $next) { | ||||
|                 $this->repository = app(UserGroupRepositoryInterface::class); | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
|         ); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * TODO see autocomplete/accountcontroller for list. | ||||
|      */ | ||||
|     public function index(IndexRequest $request): JsonResponse | ||||
|     { | ||||
|         $administrations = $this->repository->get(); | ||||
|         $pageSize        = $this->parameters->get('limit'); | ||||
|         $count           = $administrations->count(); | ||||
|         $administrations = $administrations->slice(($this->parameters->get('page') - 1) * $pageSize, $pageSize); | ||||
|         $paginator       = new LengthAwarePaginator($administrations, $count, $pageSize, $this->parameters->get('page')); | ||||
|         $transformer     = new UserGroupTransformer(); | ||||
| 
 | ||||
|         $transformer->setParameters($this->parameters); // give params to transformer
 | ||||
| 
 | ||||
|         return response() | ||||
|             ->json($this->jsonApiList(self::RESOURCE_KEY, $paginator, $transformer)) | ||||
|             ->header('Content-Type', self::CONTENT_TYPE) | ||||
|         ; | ||||
|     } | ||||
| } | ||||
| @@ -79,4 +79,12 @@ class UpdateController extends Controller | ||||
|             ->header('Content-Type', self::CONTENT_TYPE) | ||||
|         ; | ||||
|     } | ||||
| 
 | ||||
|     public function useUserGroup(UserGroup $userGroup): JsonResponse | ||||
|     { | ||||
|         // group validation is already in place, so can just update the user.
 | ||||
|         $this->repository->useUserGroup($userGroup); | ||||
| 
 | ||||
|         return response()->json([], 204); | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -23,47 +23,68 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V2\Request\Autocomplete; | ||||
| 
 | ||||
| use FireflyIII\Enums\UserRoleEnum; | ||||
| use FireflyIII\Models\AccountType; | ||||
| use FireflyIII\JsonApi\Rules\IsValidFilter; | ||||
| use FireflyIII\JsonApi\Rules\IsValidPage; | ||||
| use FireflyIII\Support\Http\Api\AccountFilter; | ||||
| use FireflyIII\Support\Http\Api\ParsesQueryFilters; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use LaravelJsonApi\Core\Query\QueryParameters; | ||||
| use LaravelJsonApi\Validation\Rule as JsonApiRule; | ||||
| 
 | ||||
| /** | ||||
|  * Class AutocompleteRequest | ||||
|  */ | ||||
| class AutocompleteRequest extends FormRequest | ||||
| { | ||||
|     use AccountFilter; | ||||
|     use ChecksLogin; | ||||
|     use ConvertsDataTypes; | ||||
|     use ParsesQueryFilters; | ||||
| 
 | ||||
|     protected array $acceptedRoles = [UserRoleEnum::MANAGE_TRANSACTIONS]; | ||||
| 
 | ||||
|     public function getData(): array | ||||
|     /** | ||||
|      * Loops over all possible query parameters (these are shared over ALL auto complete requests) | ||||
|      * and returns a validated array of parameters. | ||||
|      * | ||||
|      * The advantage is a single class. But you may also submit "account types" to an endpoint that doesn't use these. | ||||
|      */ | ||||
|     public function getParameters(): array | ||||
|     { | ||||
|         $types = $this->convertString('types'); | ||||
|         $array = []; | ||||
|         if ('' !== $types) { | ||||
|             $array = explode(',', $types); | ||||
|         } | ||||
|         $limit = $this->convertInteger('limit'); | ||||
|         $limit = 0 === $limit ? 10 : $limit; | ||||
| 
 | ||||
|         // remove 'initial balance' and another from allowed types. its internal
 | ||||
|         $array = array_diff($array, [AccountType::INITIAL_BALANCE, AccountType::RECONCILIATION]); | ||||
|         $queryParameters = QueryParameters::cast($this->all()); | ||||
| 
 | ||||
|         return [ | ||||
|             'types' => $array, | ||||
|             'query' => $this->convertString('query'), | ||||
|             'date'  => $this->getCarbonDate('date'), | ||||
|             'limit' => $limit, | ||||
|             'date'          => $this->dateOrToday($queryParameters, 'date'), | ||||
|             'query'         => $this->arrayOfStrings($queryParameters, 'query'), | ||||
|             'size'          => $this->integerFromQueryParams($queryParameters, 'size', 50), | ||||
|             'account_types' => $this->getAccountTypeParameter($this->arrayOfStrings($queryParameters, 'account_types')), | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'limit' => 'min:0|max:1337', | ||||
|             'fields'  => JsonApiRule::notSupported(), | ||||
|             'filter'  => ['nullable', 'array', new IsValidFilter(['query', 'date', 'account_types'])], | ||||
|             'include' => JsonApiRule::notSupported(), | ||||
|             'page'    => ['nullable', 'array', new IsValidPage(['size'])], | ||||
|             'sort'    => JsonApiRule::notSupported(), | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     private function getAccountTypeParameter(mixed $types): array | ||||
|     { | ||||
|         if (is_string($types) && str_contains($types, ',')) { | ||||
|             $types = explode(',', $types); | ||||
|         } | ||||
|         if (!is_iterable($types)) { | ||||
|             $types = [$types]; | ||||
|         } | ||||
|         $return = []; | ||||
|         foreach ($types as $type) { | ||||
|             $return = array_merge($return, $this->mapAccountTypes($type)); | ||||
|         } | ||||
| 
 | ||||
|         return array_unique($return); | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V2\Request\Chart; | ||||
| 
 | ||||
| use FireflyIII\Enums\UserRoleEnum; | ||||
| use FireflyIII\Support\Http\Api\ValidatesUserGroupTrait; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| @@ -39,6 +40,7 @@ class BalanceChartRequest extends FormRequest | ||||
|     use ChecksLogin; | ||||
|     use ConvertsDataTypes; | ||||
|     use ValidatesUserGroupTrait; | ||||
|     protected array                    $acceptedRoles = [UserRoleEnum::READ_ONLY]; | ||||
| 
 | ||||
|     /** | ||||
|      * Get all data from the request. | ||||
|   | ||||
							
								
								
									
										118
									
								
								app/Api/V2/Request/Chart/ChartRequest.php
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										118
									
								
								app/Api/V2/Request/Chart/ChartRequest.php
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,118 @@ | ||||
| <?php | ||||
| /* | ||||
|  * DashboardChartRequest.php | ||||
|  * Copyright (c) 2023 james@firefly-iii.org | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
|  * This program is free software: you can redistribute it and/or modify | ||||
|  * it under the terms of the GNU Affero General Public License as | ||||
|  * published by the Free Software Foundation, either version 3 of the | ||||
|  * License, or (at your option) any later version. | ||||
|  * | ||||
|  * This program is distributed in the hope that it will be useful, | ||||
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see <https://www.gnu.org/licenses/>. | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V2\Request\Chart; | ||||
| 
 | ||||
| use FireflyIII\Enums\UserRoleEnum; | ||||
| use FireflyIII\JsonApi\Rules\IsValidFilter; | ||||
| use FireflyIII\Rules\IsFilterValueIn; | ||||
| use FireflyIII\Support\Http\Api\ParsesQueryFilters; | ||||
| use FireflyIII\Support\Http\Api\ValidatesUserGroupTrait; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Validation\Validator; | ||||
| use LaravelJsonApi\Core\Query\QueryParameters; | ||||
| use LaravelJsonApi\Validation\Rule as JsonApiRule; | ||||
| 
 | ||||
| /** | ||||
|  * Class ChartRequest | ||||
|  */ | ||||
| class ChartRequest extends FormRequest | ||||
| { | ||||
|     use ChecksLogin; | ||||
|     use ConvertsDataTypes; | ||||
|     use ParsesQueryFilters; | ||||
|     use ValidatesUserGroupTrait; | ||||
| 
 | ||||
|     protected array $acceptedRoles = [UserRoleEnum::READ_ONLY]; | ||||
| 
 | ||||
|     public function getParameters(): array | ||||
|     { | ||||
|         $queryParameters = QueryParameters::cast($this->all()); | ||||
| 
 | ||||
|         return [ | ||||
|             'start'       => $this->dateOrToday($queryParameters, 'start'), | ||||
|             'end'         => $this->dateOrToday($queryParameters, 'end'), | ||||
|             'preselected' => $this->stringFromQueryParams($queryParameters, 'preselected', 'empty'), | ||||
|             'period'      => $this->stringFromQueryParams($queryParameters, 'period', '1M'), | ||||
|             'accounts'    => $this->arrayOfStrings($queryParameters, 'accounts'), | ||||
|             // preselected heeft maar een paar toegestane waardes, dat moet ook goed gaan.
 | ||||
|             //            'query'         => $this->arrayOfStrings($queryParameters, 'query'),
 | ||||
|             //            'size'          => $this->integerFromQueryParams($queryParameters,'size', 50),
 | ||||
|             //            'account_types' => $this->getAccountTypeParameter($this->arrayOfStrings($queryParameters, 'account_types')),
 | ||||
|         ]; | ||||
|         // collect accounts based on this list?
 | ||||
|     } | ||||
| 
 | ||||
|     //        return [
 | ||||
|     //            'accounts'    => $this->getAccountList(),
 | ||||
|     //            'preselected' => $this->convertString('preselected'),
 | ||||
|     //        ];
 | ||||
|     //    }
 | ||||
| 
 | ||||
|     /** | ||||
|      * The rules that the incoming request must be matched against. | ||||
|      */ | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'fields'  => JsonApiRule::notSupported(), | ||||
|             'filter'  => ['nullable', 'array', | ||||
|                 new IsValidFilter(['start', 'end', 'preselected', 'accounts']), | ||||
|                 new IsFilterValueIn('preselected', config('firefly.preselected_accounts')), | ||||
|             ], | ||||
|             'include' => JsonApiRule::notSupported(), | ||||
|             'page'    => JsonApiRule::notSupported(), | ||||
|             'sort'    => JsonApiRule::notSupported(), | ||||
|         ]; | ||||
| 
 | ||||
|         //        return [
 | ||||
|         //            'start'       => 'required|date|after:1900-01-01|before:2099-12-31',
 | ||||
|         //            'end'         => 'required|date|after_or_equal:start|before:2099-12-31|after:1900-01-01',
 | ||||
|         //            'preselected' => sprintf('in:%s', implode(',', config('firefly.preselected_accounts'))),
 | ||||
|         //            'accounts.*'  => 'exists:accounts,id',
 | ||||
|         //        ];
 | ||||
|     } | ||||
| 
 | ||||
|     public function withValidator(Validator $validator): void | ||||
|     { | ||||
|         $validator->after( | ||||
|             static function (Validator $validator): void { | ||||
|                 // validate transaction query data.
 | ||||
|                 $data = $validator->getData(); | ||||
|                 if (!array_key_exists('accounts', $data)) { | ||||
|                     // $validator->errors()->add('accounts', trans('validation.filled', ['attribute' => 'accounts']));
 | ||||
|                     return; | ||||
|                 } | ||||
|                 if (!is_array($data['accounts'])) { | ||||
|                     $validator->errors()->add('accounts', trans('validation.filled', ['attribute' => 'accounts'])); | ||||
|                 } | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| } | ||||
| @@ -23,6 +23,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V2\Request\Chart; | ||||
| 
 | ||||
| use FireflyIII\Enums\UserRoleEnum; | ||||
| use FireflyIII\Support\Http\Api\ValidatesUserGroupTrait; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| @@ -39,6 +40,8 @@ class DashboardChartRequest extends FormRequest | ||||
|     use ConvertsDataTypes; | ||||
|     use ValidatesUserGroupTrait; | ||||
| 
 | ||||
|     protected array $acceptedRoles = [UserRoleEnum::READ_ONLY]; | ||||
| 
 | ||||
|     /** | ||||
|      * Get all data from the request. | ||||
|      */ | ||||
|   | ||||
							
								
								
									
										70
									
								
								app/Api/V2/Request/Model/Account/IndexRequest.php
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										70
									
								
								app/Api/V2/Request/Model/Account/IndexRequest.php
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,70 @@ | ||||
| <?php | ||||
| /* | ||||
|  * IndexRequest.php | ||||
|  * Copyright (c) 2024 james@firefly-iii.org. | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
|  * This program is free software: you can redistribute it and/or modify | ||||
|  * it under the terms of the GNU Affero General Public License as | ||||
|  * published by the Free Software Foundation, either version 3 of the | ||||
|  * License, or (at your option) any later version. | ||||
|  * | ||||
|  * This program is distributed in the hope that it will be useful, | ||||
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see https://www.gnu.org/licenses/. | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V2\Request\Model\Account; | ||||
| 
 | ||||
| use Carbon\Carbon; | ||||
| use FireflyIII\Support\Http\Api\AccountFilter; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use FireflyIII\Support\Request\GetFilterInstructions; | ||||
| use FireflyIII\Support\Request\GetSortInstructions; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| 
 | ||||
| /** | ||||
|  * Class IndexRequest | ||||
|  * | ||||
|  * Lots of code stolen from the SingleDateRequest. | ||||
|  */ | ||||
| class IndexRequest extends FormRequest | ||||
| { | ||||
|     use AccountFilter; | ||||
|     use ChecksLogin; | ||||
|     use ConvertsDataTypes; | ||||
|     use GetFilterInstructions; | ||||
|     use GetSortInstructions; | ||||
| 
 | ||||
|     public function getAccountTypes(): array | ||||
|     { | ||||
|         $type = (string) $this->get('type', 'default'); | ||||
| 
 | ||||
|         return $this->mapAccountTypes($type); | ||||
|     } | ||||
| 
 | ||||
|     public function getDate(): Carbon | ||||
|     { | ||||
|         return $this->getCarbonDate('date'); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * The rules that the incoming request must be matched against. | ||||
|      */ | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'date'  => 'date|after:1900-01-01|before:2099-12-31', | ||||
|             'start' => 'date|after:1900-01-01|before:2099-12-31|before:end|required_with:end', | ||||
|             'end'   => 'date|after:1900-01-01|before:2099-12-31|after:start|required_with:start', | ||||
|         ]; | ||||
|     } | ||||
| } | ||||
							
								
								
									
										116
									
								
								app/Api/V2/Request/Model/Account/UpdateRequest.php
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										116
									
								
								app/Api/V2/Request/Model/Account/UpdateRequest.php
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,116 @@ | ||||
| <?php | ||||
| /* | ||||
|  * UpdateRequest.php | ||||
|  * Copyright (c) 2024 james@firefly-iii.org. | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
|  * This program is free software: you can redistribute it and/or modify | ||||
|  * it under the terms of the GNU Affero General Public License as | ||||
|  * published by the Free Software Foundation, either version 3 of the | ||||
|  * License, or (at your option) any later version. | ||||
|  * | ||||
|  * This program is distributed in the hope that it will be useful, | ||||
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see https://www.gnu.org/licenses/. | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V2\Request\Model\Account; | ||||
| 
 | ||||
| use FireflyIII\Models\Account; | ||||
| use FireflyIII\Models\Location; | ||||
| use FireflyIII\Rules\IsBoolean; | ||||
| use FireflyIII\Rules\UniqueAccountNumber; | ||||
| use FireflyIII\Rules\UniqueIban; | ||||
| use FireflyIII\Support\Request\AppendsLocationData; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| 
 | ||||
| class UpdateRequest extends FormRequest | ||||
| { | ||||
|     use AppendsLocationData; | ||||
|     use ChecksLogin; | ||||
|     use ConvertsDataTypes; | ||||
| 
 | ||||
|     /** | ||||
|      * TODO is a duplicate of the v1 update thing. | ||||
|      */ | ||||
|     public function getUpdateData(): array | ||||
|     { | ||||
|         $fields = [ | ||||
|             'name'                    => ['name', 'convertString'], | ||||
|             'active'                  => ['active', 'boolean'], | ||||
|             'include_net_worth'       => ['include_net_worth', 'boolean'], | ||||
|             'account_type_name'       => ['type', 'convertString'], | ||||
|             'virtual_balance'         => ['virtual_balance', 'convertString'], | ||||
|             'iban'                    => ['iban', 'convertString'], | ||||
|             'BIC'                     => ['bic', 'convertString'], | ||||
|             'account_number'          => ['account_number', 'convertString'], | ||||
|             'account_role'            => ['account_role', 'convertString'], | ||||
|             'liability_type'          => ['liability_type', 'convertString'], | ||||
|             'opening_balance'         => ['opening_balance', 'convertString'], | ||||
|             'opening_balance_date'    => ['opening_balance_date', 'convertDateTime'], | ||||
|             'cc_type'                 => ['credit_card_type', 'convertString'], | ||||
|             'cc_monthly_payment_date' => ['monthly_payment_date', 'convertDateTime'], | ||||
|             'notes'                   => ['notes', 'stringWithNewlines'], | ||||
|             'interest'                => ['interest', 'convertString'], | ||||
|             'interest_period'         => ['interest_period', 'convertString'], | ||||
|             'order'                   => ['order', 'convertInteger'], | ||||
|             'currency_id'             => ['currency_id', 'convertInteger'], | ||||
|             'currency_code'           => ['currency_code', 'convertString'], | ||||
|             'liability_direction'     => ['liability_direction', 'convertString'], | ||||
|             'liability_amount'        => ['liability_amount', 'convertString'], | ||||
|             'liability_start_date'    => ['liability_start_date', 'date'], | ||||
|         ]; | ||||
|         $data   = $this->getAllData($fields); | ||||
| 
 | ||||
|         return $this->appendLocationData($data, null); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * TODO is a duplicate of the v1 UpdateRequest method. | ||||
|      * | ||||
|      * The rules that the incoming request must be matched against. | ||||
|      */ | ||||
|     public function rules(): array | ||||
|     { | ||||
|         /** @var Account $account */ | ||||
|         $account        = $this->route()->parameter('account'); | ||||
|         $accountRoles   = implode(',', config('firefly.accountRoles')); | ||||
|         $types          = implode(',', array_keys(config('firefly.subTitlesByIdentifier'))); | ||||
|         $ccPaymentTypes = implode(',', array_keys(config('firefly.ccTypes'))); | ||||
| 
 | ||||
|         $rules          = [ | ||||
|             'name'                 => sprintf('min:1|max:1024|uniqueAccountForUser:%d', $account->id), | ||||
|             'type'                 => sprintf('in:%s', $types), | ||||
|             'iban'                 => ['iban', 'nullable', new UniqueIban($account, $this->convertString('type'))], | ||||
|             'bic'                  => 'bic|nullable', | ||||
|             'account_number'       => ['min:1', 'max:255', 'nullable', new UniqueAccountNumber($account, $this->convertString('type'))], | ||||
|             'opening_balance'      => 'numeric|required_with:opening_balance_date|nullable', | ||||
|             'opening_balance_date' => 'date|required_with:opening_balance|nullable', | ||||
|             'virtual_balance'      => 'numeric|nullable', | ||||
|             'order'                => 'numeric|nullable', | ||||
|             'currency_id'          => 'numeric|exists:transaction_currencies,id', | ||||
|             'currency_code'        => 'min:3|max:51|exists:transaction_currencies,code', | ||||
|             'active'               => [new IsBoolean()], | ||||
|             'include_net_worth'    => [new IsBoolean()], | ||||
|             'account_role'         => sprintf('in:%s|nullable|required_if:type,asset', $accountRoles), | ||||
|             'credit_card_type'     => sprintf('in:%s|nullable|required_if:account_role,ccAsset', $ccPaymentTypes), | ||||
|             'monthly_payment_date' => 'date|nullable|required_if:account_role,ccAsset|required_if:credit_card_type,monthlyFull', | ||||
|             'liability_type'       => 'required_if:type,liability|in:loan,debt,mortgage', | ||||
|             'liability_direction'  => 'required_if:type,liability|in:credit,debit', | ||||
|             'interest'             => 'required_if:type,liability|min:0|max:100|numeric', | ||||
|             'interest_period'      => 'required_if:type,liability|in:daily,monthly,yearly', | ||||
|             'notes'                => 'min:0|max:32768', | ||||
|         ]; | ||||
| 
 | ||||
|         return Location::requestRules($rules); | ||||
|     } | ||||
| } | ||||
							
								
								
									
										118
									
								
								app/Api/V2/Request/Model/Transaction/InfiniteListRequest.php
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										118
									
								
								app/Api/V2/Request/Model/Transaction/InfiniteListRequest.php
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,118 @@ | ||||
| <?php | ||||
| 
 | ||||
| /* | ||||
|  * ListRequest.php | ||||
|  * Copyright (c) 2023 james@firefly-iii.org | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
|  * This program is free software: you can redistribute it and/or modify | ||||
|  * it under the terms of the GNU Affero General Public License as | ||||
|  * published by the Free Software Foundation, either version 3 of the | ||||
|  * License, or (at your option) any later version. | ||||
|  * | ||||
|  * This program is distributed in the hope that it will be useful, | ||||
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see <https://www.gnu.org/licenses/>. | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V2\Request\Model\Transaction; | ||||
| 
 | ||||
| use Carbon\Carbon; | ||||
| use FireflyIII\Support\Http\Api\AccountFilter; | ||||
| use FireflyIII\Support\Http\Api\TransactionFilter; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use FireflyIII\Support\Request\GetSortInstructions; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| 
 | ||||
| /** | ||||
|  * Class InfiniteListRequest | ||||
|  * Used specifically to list transactions. | ||||
|  */ | ||||
| class InfiniteListRequest extends FormRequest | ||||
| { | ||||
|     use AccountFilter; | ||||
|     use ChecksLogin; | ||||
|     use ConvertsDataTypes; | ||||
|     use GetSortInstructions; | ||||
|     use TransactionFilter; | ||||
| 
 | ||||
|     public function buildParams(): string | ||||
|     { | ||||
|         $array = [ | ||||
|             'start_row' => $this->getStartRow(), | ||||
|             'end_row'   => $this->getEndRow(), | ||||
|         ]; | ||||
| 
 | ||||
|         $start = $this->getStartDate(); | ||||
|         $end   = $this->getEndDate(); | ||||
|         if (null !== $start && null !== $end) { | ||||
|             $array['start'] = $start->format('Y-m-d'); | ||||
|             $array['end']   = $end->format('Y-m-d'); | ||||
|         } | ||||
| 
 | ||||
|         return http_build_query($array); | ||||
|     } | ||||
| 
 | ||||
|     public function getStartRow(): int | ||||
|     { | ||||
|         $startRow = $this->convertInteger('start_row'); | ||||
| 
 | ||||
|         return $startRow < 0 || $startRow > 4294967296 ? 0 : $startRow; | ||||
|     } | ||||
| 
 | ||||
|     public function getEndRow(): int | ||||
|     { | ||||
|         $endRow = $this->convertInteger('end_row'); | ||||
| 
 | ||||
|         return $endRow <= 0 || $endRow > 4294967296 ? 100 : $endRow; | ||||
|     } | ||||
| 
 | ||||
|     public function getStartDate(): ?Carbon | ||||
|     { | ||||
|         return $this->getCarbonDate('start'); | ||||
|     } | ||||
| 
 | ||||
|     public function getEndDate(): ?Carbon | ||||
|     { | ||||
|         return $this->getCarbonDate('end'); | ||||
|     } | ||||
| 
 | ||||
|     public function getAccountTypes(): array | ||||
|     { | ||||
|         $type = (string)$this->get('type', 'default'); | ||||
| 
 | ||||
|         return $this->mapAccountTypes($type); | ||||
|     } | ||||
| 
 | ||||
|     public function getPage(): int | ||||
|     { | ||||
|         $page = $this->convertInteger('page'); | ||||
| 
 | ||||
|         return 0 === $page || $page > 65536 ? 1 : $page; | ||||
|     } | ||||
| 
 | ||||
|     public function getTransactionTypes(): array | ||||
|     { | ||||
|         $type = (string)$this->get('type', 'default'); | ||||
| 
 | ||||
|         return $this->mapTransactionTypes($type); | ||||
|     } | ||||
| 
 | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'start'     => 'date', | ||||
|             'end'       => 'date|after:start', | ||||
|             'start_row' => 'integer|min:0|max:4294967296', | ||||
|             'end_row'   => 'integer|min:0|max:4294967296|gt:start_row', | ||||
|         ]; | ||||
|     } | ||||
| } | ||||
| @@ -78,6 +78,103 @@ class StoreRequest extends FormRequest | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Get transaction data. | ||||
|      */ | ||||
|     private function getTransactionData(): array | ||||
|     { | ||||
|         $return = []; | ||||
| 
 | ||||
|         /** | ||||
|          * @var array $transaction | ||||
|          */ | ||||
|         foreach ($this->get('transactions') as $transaction) { | ||||
|             $object   = new NullArrayObject($transaction); | ||||
|             $result   = [ | ||||
|                 'type'                  => $this->clearString($object['type']), | ||||
|                 'date'                  => $this->dateFromValue($object['date']), | ||||
|                 'order'                 => $this->integerFromValue((string)$object['order']), | ||||
| 
 | ||||
|                 'currency_id'           => $this->integerFromValue((string)$object['currency_id']), | ||||
|                 'currency_code'         => $this->clearString((string)$object['currency_code']), | ||||
| 
 | ||||
|                 // foreign currency info:
 | ||||
|                 'foreign_currency_id'   => $this->integerFromValue((string)$object['foreign_currency_id']), | ||||
|                 'foreign_currency_code' => $this->clearString((string)$object['foreign_currency_code']), | ||||
| 
 | ||||
|                 // amount and foreign amount. Cannot be 0.
 | ||||
|                 'amount'                => $this->clearString((string)$object['amount']), | ||||
|                 'foreign_amount'        => $this->clearString((string)$object['foreign_amount']), | ||||
| 
 | ||||
|                 // description.
 | ||||
|                 'description'           => $this->clearString($object['description']), | ||||
| 
 | ||||
|                 // source of transaction. If everything is null, assume cash account.
 | ||||
|                 'source_id'             => $this->integerFromValue((string)$object['source_id']), | ||||
|                 'source_name'           => $this->clearString((string)$object['source_name']), | ||||
|                 'source_iban'           => $this->clearString((string)$object['source_iban']), | ||||
|                 'source_number'         => $this->clearString((string)$object['source_number']), | ||||
|                 'source_bic'            => $this->clearString((string)$object['source_bic']), | ||||
| 
 | ||||
|                 // destination of transaction. If everything is null, assume cash account.
 | ||||
|                 'destination_id'        => $this->integerFromValue((string)$object['destination_id']), | ||||
|                 'destination_name'      => $this->clearString((string)$object['destination_name']), | ||||
|                 'destination_iban'      => $this->clearString((string)$object['destination_iban']), | ||||
|                 'destination_number'    => $this->clearString((string)$object['destination_number']), | ||||
|                 'destination_bic'       => $this->clearString((string)$object['destination_bic']), | ||||
| 
 | ||||
|                 // budget info
 | ||||
|                 'budget_id'             => $this->integerFromValue((string)$object['budget_id']), | ||||
|                 'budget_name'           => $this->clearString((string)$object['budget_name']), | ||||
| 
 | ||||
|                 // category info
 | ||||
|                 'category_id'           => $this->integerFromValue((string)$object['category_id']), | ||||
|                 'category_name'         => $this->clearString((string)$object['category_name']), | ||||
| 
 | ||||
|                 // journal bill reference. Optional. Will only work for withdrawals
 | ||||
|                 'bill_id'               => $this->integerFromValue((string)$object['bill_id']), | ||||
|                 'bill_name'             => $this->clearString((string)$object['bill_name']), | ||||
| 
 | ||||
|                 // piggy bank reference. Optional. Will only work for transfers
 | ||||
|                 'piggy_bank_id'         => $this->integerFromValue((string)$object['piggy_bank_id']), | ||||
|                 'piggy_bank_name'       => $this->clearString((string)$object['piggy_bank_name']), | ||||
| 
 | ||||
|                 // some other interesting properties
 | ||||
|                 'reconciled'            => $this->convertBoolean((string)$object['reconciled']), | ||||
|                 'notes'                 => $this->clearStringKeepNewlines((string)$object['notes']), | ||||
|                 'tags'                  => $this->arrayFromValue($object['tags']), | ||||
| 
 | ||||
|                 // all custom fields:
 | ||||
|                 'internal_reference'    => $this->clearString((string)$object['internal_reference']), | ||||
|                 'external_id'           => $this->clearString((string)$object['external_id']), | ||||
|                 'original_source'       => sprintf('ff3-v%s|api-v%s', config('firefly.version'), config('firefly.api_version')), | ||||
|                 'recurrence_id'         => $this->integerFromValue($object['recurrence_id']), | ||||
|                 'bunq_payment_id'       => $this->clearString((string)$object['bunq_payment_id']), | ||||
|                 'external_url'          => $this->clearString((string)$object['external_url']), | ||||
| 
 | ||||
|                 'sepa_cc'               => $this->clearString((string)$object['sepa_cc']), | ||||
|                 'sepa_ct_op'            => $this->clearString((string)$object['sepa_ct_op']), | ||||
|                 'sepa_ct_id'            => $this->clearString((string)$object['sepa_ct_id']), | ||||
|                 'sepa_db'               => $this->clearString((string)$object['sepa_db']), | ||||
|                 'sepa_country'          => $this->clearString((string)$object['sepa_country']), | ||||
|                 'sepa_ep'               => $this->clearString((string)$object['sepa_ep']), | ||||
|                 'sepa_ci'               => $this->clearString((string)$object['sepa_ci']), | ||||
|                 'sepa_batch_id'         => $this->clearString((string)$object['sepa_batch_id']), | ||||
|                 // custom date fields. Must be Carbon objects. Presence is optional.
 | ||||
|                 'interest_date'         => $this->dateFromValue($object['interest_date']), | ||||
|                 'book_date'             => $this->dateFromValue($object['book_date']), | ||||
|                 'process_date'          => $this->dateFromValue($object['process_date']), | ||||
|                 'due_date'              => $this->dateFromValue($object['due_date']), | ||||
|                 'payment_date'          => $this->dateFromValue($object['payment_date']), | ||||
|                 'invoice_date'          => $this->dateFromValue($object['invoice_date']), | ||||
|             ]; | ||||
|             $result   = $this->addFromromTransactionStore($transaction, $result); | ||||
|             $return[] = $result; | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * The rules that the incoming request must be matched against. | ||||
|      */ | ||||
| @@ -216,101 +313,4 @@ class StoreRequest extends FormRequest | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Get transaction data. | ||||
|      */ | ||||
|     private function getTransactionData(): array | ||||
|     { | ||||
|         $return = []; | ||||
| 
 | ||||
|         /** | ||||
|          * @var array $transaction | ||||
|          */ | ||||
|         foreach ($this->get('transactions') as $transaction) { | ||||
|             $object   = new NullArrayObject($transaction); | ||||
|             $result   = [ | ||||
|                 'type'                  => $this->clearString($object['type']), | ||||
|                 'date'                  => $this->dateFromValue($object['date']), | ||||
|                 'order'                 => $this->integerFromValue((string)$object['order']), | ||||
| 
 | ||||
|                 'currency_id'           => $this->integerFromValue((string)$object['currency_id']), | ||||
|                 'currency_code'         => $this->clearString((string)$object['currency_code']), | ||||
| 
 | ||||
|                 // foreign currency info:
 | ||||
|                 'foreign_currency_id'   => $this->integerFromValue((string)$object['foreign_currency_id']), | ||||
|                 'foreign_currency_code' => $this->clearString((string)$object['foreign_currency_code']), | ||||
| 
 | ||||
|                 // amount and foreign amount. Cannot be 0.
 | ||||
|                 'amount'                => $this->clearString((string)$object['amount']), | ||||
|                 'foreign_amount'        => $this->clearString((string)$object['foreign_amount']), | ||||
| 
 | ||||
|                 // description.
 | ||||
|                 'description'           => $this->clearString($object['description']), | ||||
| 
 | ||||
|                 // source of transaction. If everything is null, assume cash account.
 | ||||
|                 'source_id'             => $this->integerFromValue((string)$object['source_id']), | ||||
|                 'source_name'           => $this->clearString((string)$object['source_name']), | ||||
|                 'source_iban'           => $this->clearString((string)$object['source_iban']), | ||||
|                 'source_number'         => $this->clearString((string)$object['source_number']), | ||||
|                 'source_bic'            => $this->clearString((string)$object['source_bic']), | ||||
| 
 | ||||
|                 // destination of transaction. If everything is null, assume cash account.
 | ||||
|                 'destination_id'        => $this->integerFromValue((string)$object['destination_id']), | ||||
|                 'destination_name'      => $this->clearString((string)$object['destination_name']), | ||||
|                 'destination_iban'      => $this->clearString((string)$object['destination_iban']), | ||||
|                 'destination_number'    => $this->clearString((string)$object['destination_number']), | ||||
|                 'destination_bic'       => $this->clearString((string)$object['destination_bic']), | ||||
| 
 | ||||
|                 // budget info
 | ||||
|                 'budget_id'             => $this->integerFromValue((string)$object['budget_id']), | ||||
|                 'budget_name'           => $this->clearString((string)$object['budget_name']), | ||||
| 
 | ||||
|                 // category info
 | ||||
|                 'category_id'           => $this->integerFromValue((string)$object['category_id']), | ||||
|                 'category_name'         => $this->clearString((string)$object['category_name']), | ||||
| 
 | ||||
|                 // journal bill reference. Optional. Will only work for withdrawals
 | ||||
|                 'bill_id'               => $this->integerFromValue((string)$object['bill_id']), | ||||
|                 'bill_name'             => $this->clearString((string)$object['bill_name']), | ||||
| 
 | ||||
|                 // piggy bank reference. Optional. Will only work for transfers
 | ||||
|                 'piggy_bank_id'         => $this->integerFromValue((string)$object['piggy_bank_id']), | ||||
|                 'piggy_bank_name'       => $this->clearString((string)$object['piggy_bank_name']), | ||||
| 
 | ||||
|                 // some other interesting properties
 | ||||
|                 'reconciled'            => $this->convertBoolean((string)$object['reconciled']), | ||||
|                 'notes'                 => $this->clearStringKeepNewlines((string)$object['notes']), | ||||
|                 'tags'                  => $this->arrayFromValue($object['tags']), | ||||
| 
 | ||||
|                 // all custom fields:
 | ||||
|                 'internal_reference'    => $this->clearString((string)$object['internal_reference']), | ||||
|                 'external_id'           => $this->clearString((string)$object['external_id']), | ||||
|                 'original_source'       => sprintf('ff3-v%s|api-v%s', config('firefly.version'), config('firefly.api_version')), | ||||
|                 'recurrence_id'         => $this->integerFromValue($object['recurrence_id']), | ||||
|                 'bunq_payment_id'       => $this->clearString((string)$object['bunq_payment_id']), | ||||
|                 'external_url'          => $this->clearString((string)$object['external_url']), | ||||
| 
 | ||||
|                 'sepa_cc'               => $this->clearString((string)$object['sepa_cc']), | ||||
|                 'sepa_ct_op'            => $this->clearString((string)$object['sepa_ct_op']), | ||||
|                 'sepa_ct_id'            => $this->clearString((string)$object['sepa_ct_id']), | ||||
|                 'sepa_db'               => $this->clearString((string)$object['sepa_db']), | ||||
|                 'sepa_country'          => $this->clearString((string)$object['sepa_country']), | ||||
|                 'sepa_ep'               => $this->clearString((string)$object['sepa_ep']), | ||||
|                 'sepa_ci'               => $this->clearString((string)$object['sepa_ci']), | ||||
|                 'sepa_batch_id'         => $this->clearString((string)$object['sepa_batch_id']), | ||||
|                 // custom date fields. Must be Carbon objects. Presence is optional.
 | ||||
|                 'interest_date'         => $this->dateFromValue($object['interest_date']), | ||||
|                 'book_date'             => $this->dateFromValue($object['book_date']), | ||||
|                 'process_date'          => $this->dateFromValue($object['process_date']), | ||||
|                 'due_date'              => $this->dateFromValue($object['due_date']), | ||||
|                 'payment_date'          => $this->dateFromValue($object['payment_date']), | ||||
|                 'invoice_date'          => $this->dateFromValue($object['invoice_date']), | ||||
|             ]; | ||||
|             $result   = $this->addFromromTransactionStore($transaction, $result); | ||||
|             $return[] = $result; | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -91,127 +91,6 @@ class UpdateRequest extends Request | ||||
|         return $data; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * The rules that the incoming request must be matched against. | ||||
|      */ | ||||
|     public function rules(): array | ||||
|     { | ||||
|         app('log')->debug(sprintf('Now in %s', __METHOD__)); | ||||
|         $validProtocols = config('firefly.valid_url_protocols'); | ||||
| 
 | ||||
|         return [ | ||||
|             // basic fields for group:
 | ||||
|             'group_title'                            => 'min:1|max:1000|nullable', | ||||
|             'apply_rules'                            => [new IsBoolean()], | ||||
| 
 | ||||
|             // transaction rules (in array for splits):
 | ||||
|             'transactions.*.type'                    => 'in:withdrawal,deposit,transfer,opening-balance,reconciliation', | ||||
|             'transactions.*.date'                    => [new IsDateOrTime()], | ||||
|             'transactions.*.order'                   => 'numeric|min:0', | ||||
| 
 | ||||
|             // group id:
 | ||||
|             'transactions.*.transaction_journal_id'  => ['nullable', 'numeric', new BelongsUser()], | ||||
| 
 | ||||
|             // currency info
 | ||||
|             'transactions.*.currency_id'             => 'numeric|exists:transaction_currencies,id|nullable', | ||||
|             'transactions.*.currency_code'           => 'min:3|max:51|exists:transaction_currencies,code|nullable', | ||||
|             'transactions.*.foreign_currency_id'     => 'nullable|numeric|exists:transaction_currencies,id', | ||||
|             'transactions.*.foreign_currency_code'   => 'nullable|min:3|max:51|exists:transaction_currencies,code', | ||||
| 
 | ||||
|             // amount
 | ||||
|             'transactions.*.amount'                  => ['nullable', new IsValidPositiveAmount()], | ||||
|             'transactions.*.foreign_amount'          => ['nullable', new IsValidZeroOrMoreAmount()], | ||||
| 
 | ||||
|             // description
 | ||||
|             'transactions.*.description'             => 'nullable|min:1|max:1000', | ||||
| 
 | ||||
|             // source of transaction
 | ||||
|             'transactions.*.source_id'               => ['numeric', 'nullable', new BelongsUser()], | ||||
|             'transactions.*.source_name'             => 'min:1|max:255|nullable', | ||||
| 
 | ||||
|             // destination of transaction
 | ||||
|             'transactions.*.destination_id'          => ['numeric', 'nullable', new BelongsUser()], | ||||
|             'transactions.*.destination_name'        => 'min:1|max:255|nullable', | ||||
| 
 | ||||
|             // budget, category, bill and piggy
 | ||||
|             'transactions.*.budget_id'               => ['mustExist:budgets,id', new BelongsUser(), 'nullable'], | ||||
|             'transactions.*.budget_name'             => ['min:1', 'max:255', 'nullable', new BelongsUser()], | ||||
|             'transactions.*.category_id'             => ['mustExist:categories,id', new BelongsUser(), 'nullable'], | ||||
|             'transactions.*.category_name'           => 'min:1|max:255|nullable', | ||||
|             'transactions.*.bill_id'                 => ['numeric', 'nullable', 'mustExist:bills,id', new BelongsUser()], | ||||
|             'transactions.*.bill_name'               => ['min:1', 'max:255', 'nullable', new BelongsUser()], | ||||
| 
 | ||||
|             // other interesting fields
 | ||||
|             'transactions.*.reconciled'              => [new IsBoolean()], | ||||
|             'transactions.*.notes'                   => 'min:1|max:32768|nullable', | ||||
|             'transactions.*.tags'                    => 'min:0|max:255|nullable', | ||||
|             'transactions.*.tags.*'                  => 'min:0|max:255', | ||||
| 
 | ||||
|             // meta info fields
 | ||||
|             'transactions.*.internal_reference'      => 'min:1|max:255|nullable', | ||||
|             'transactions.*.external_id'             => 'min:1|max:255|nullable', | ||||
|             'transactions.*.recurrence_id'           => 'min:1|max:255|nullable', | ||||
|             'transactions.*.bunq_payment_id'         => 'min:1|max:255|nullable', | ||||
|             'transactions.*.external_url'            => sprintf('min:1|max:255|nullable|url:%s', $validProtocols), | ||||
| 
 | ||||
|             // SEPA fields:
 | ||||
|             'transactions.*.sepa_cc'                 => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_ct_op'              => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_ct_id'              => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_db'                 => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_country'            => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_ep'                 => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_ci'                 => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_batch_id'           => 'min:1|max:255|nullable', | ||||
| 
 | ||||
|             // dates
 | ||||
|             'transactions.*.interest_date'           => 'date|nullable', | ||||
|             'transactions.*.book_date'               => 'date|nullable', | ||||
|             'transactions.*.process_date'            => 'date|nullable', | ||||
|             'transactions.*.due_date'                => 'date|nullable', | ||||
|             'transactions.*.payment_date'            => 'date|nullable', | ||||
|             'transactions.*.invoice_date'            => 'date|nullable', | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Configure the validator instance. | ||||
|      */ | ||||
|     public function withValidator(Validator $validator): void | ||||
|     { | ||||
|         app('log')->debug('Now in withValidator'); | ||||
| 
 | ||||
|         /** @var TransactionGroup $transactionGroup */ | ||||
|         $transactionGroup = $this->route()->parameter('userGroupTransaction'); | ||||
|         $validator->after( | ||||
|             function (Validator $validator) use ($transactionGroup): void { | ||||
|                 // if more than one, verify that there are journal ID's present.
 | ||||
|                 $this->validateJournalIds($validator, $transactionGroup); | ||||
| 
 | ||||
|                 // all transaction types must be equal:
 | ||||
|                 $this->validateTransactionTypesForUpdate($validator); | ||||
| 
 | ||||
|                 // user wants to update a reconciled transaction.
 | ||||
|                 // source, destination, amount + foreign_amount cannot be changed
 | ||||
|                 // and must be omitted from the request.
 | ||||
|                 $this->preventUpdateReconciled($validator, $transactionGroup); | ||||
| 
 | ||||
|                 // validate source/destination is equal, depending on the transaction journal type.
 | ||||
|                 $this->validateEqualAccountsForUpdate($validator, $transactionGroup); | ||||
| 
 | ||||
|                 // see method:
 | ||||
|                 // $this->preventNoAccountInfo($validator, );
 | ||||
| 
 | ||||
|                 // validate that the currency fits the source and/or destination account.
 | ||||
|                 // validate all account info
 | ||||
|                 $this->validateAccountInformationUpdate($validator, $transactionGroup); | ||||
|             } | ||||
|         ); | ||||
|         if($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Get transaction data. | ||||
|      * | ||||
| @@ -363,4 +242,125 @@ class UpdateRequest extends Request | ||||
| 
 | ||||
|         return $current; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * The rules that the incoming request must be matched against. | ||||
|      */ | ||||
|     public function rules(): array | ||||
|     { | ||||
|         app('log')->debug(sprintf('Now in %s', __METHOD__)); | ||||
|         $validProtocols = config('firefly.valid_url_protocols'); | ||||
| 
 | ||||
|         return [ | ||||
|             // basic fields for group:
 | ||||
|             'group_title'                           => 'min:1|max:1000|nullable', | ||||
|             'apply_rules'                           => [new IsBoolean()], | ||||
| 
 | ||||
|             // transaction rules (in array for splits):
 | ||||
|             'transactions.*.type'                   => 'in:withdrawal,deposit,transfer,opening-balance,reconciliation', | ||||
|             'transactions.*.date'                   => [new IsDateOrTime()], | ||||
|             'transactions.*.order'                  => 'numeric|min:0', | ||||
| 
 | ||||
|             // group id:
 | ||||
|             'transactions.*.transaction_journal_id' => ['nullable', 'numeric', new BelongsUser()], | ||||
| 
 | ||||
|             // currency info
 | ||||
|             'transactions.*.currency_id'            => 'numeric|exists:transaction_currencies,id|nullable', | ||||
|             'transactions.*.currency_code'          => 'min:3|max:51|exists:transaction_currencies,code|nullable', | ||||
|             'transactions.*.foreign_currency_id'    => 'nullable|numeric|exists:transaction_currencies,id', | ||||
|             'transactions.*.foreign_currency_code'  => 'nullable|min:3|max:51|exists:transaction_currencies,code', | ||||
| 
 | ||||
|             // amount
 | ||||
|             'transactions.*.amount'                 => ['nullable', new IsValidPositiveAmount()], | ||||
|             'transactions.*.foreign_amount'         => ['nullable', new IsValidZeroOrMoreAmount()], | ||||
| 
 | ||||
|             // description
 | ||||
|             'transactions.*.description'            => 'nullable|min:1|max:1000', | ||||
| 
 | ||||
|             // source of transaction
 | ||||
|             'transactions.*.source_id'              => ['numeric', 'nullable', new BelongsUser()], | ||||
|             'transactions.*.source_name'            => 'min:1|max:255|nullable', | ||||
| 
 | ||||
|             // destination of transaction
 | ||||
|             'transactions.*.destination_id'         => ['numeric', 'nullable', new BelongsUser()], | ||||
|             'transactions.*.destination_name'       => 'min:1|max:255|nullable', | ||||
| 
 | ||||
|             // budget, category, bill and piggy
 | ||||
|             'transactions.*.budget_id'              => ['mustExist:budgets,id', new BelongsUser(), 'nullable'], | ||||
|             'transactions.*.budget_name'            => ['min:1', 'max:255', 'nullable', new BelongsUser()], | ||||
|             'transactions.*.category_id'            => ['mustExist:categories,id', new BelongsUser(), 'nullable'], | ||||
|             'transactions.*.category_name'          => 'min:1|max:255|nullable', | ||||
|             'transactions.*.bill_id'                => ['numeric', 'nullable', 'mustExist:bills,id', new BelongsUser()], | ||||
|             'transactions.*.bill_name'              => ['min:1', 'max:255', 'nullable', new BelongsUser()], | ||||
| 
 | ||||
|             // other interesting fields
 | ||||
|             'transactions.*.reconciled'             => [new IsBoolean()], | ||||
|             'transactions.*.notes'                  => 'min:1|max:32768|nullable', | ||||
|             'transactions.*.tags'                   => 'min:0|max:255|nullable', | ||||
|             'transactions.*.tags.*'                 => 'min:0|max:255', | ||||
| 
 | ||||
|             // meta info fields
 | ||||
|             'transactions.*.internal_reference'     => 'min:1|max:255|nullable', | ||||
|             'transactions.*.external_id'            => 'min:1|max:255|nullable', | ||||
|             'transactions.*.recurrence_id'          => 'min:1|max:255|nullable', | ||||
|             'transactions.*.bunq_payment_id'        => 'min:1|max:255|nullable', | ||||
|             'transactions.*.external_url'           => sprintf('min:1|max:255|nullable|url:%s', $validProtocols), | ||||
| 
 | ||||
|             // SEPA fields:
 | ||||
|             'transactions.*.sepa_cc'                => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_ct_op'             => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_ct_id'             => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_db'                => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_country'           => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_ep'                => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_ci'                => 'min:1|max:255|nullable', | ||||
|             'transactions.*.sepa_batch_id'          => 'min:1|max:255|nullable', | ||||
| 
 | ||||
|             // dates
 | ||||
|             'transactions.*.interest_date'          => 'date|nullable', | ||||
|             'transactions.*.book_date'              => 'date|nullable', | ||||
|             'transactions.*.process_date'           => 'date|nullable', | ||||
|             'transactions.*.due_date'               => 'date|nullable', | ||||
|             'transactions.*.payment_date'           => 'date|nullable', | ||||
|             'transactions.*.invoice_date'           => 'date|nullable', | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Configure the validator instance. | ||||
|      */ | ||||
|     public function withValidator(Validator $validator): void | ||||
|     { | ||||
|         app('log')->debug('Now in withValidator'); | ||||
| 
 | ||||
|         /** @var TransactionGroup $transactionGroup */ | ||||
|         $transactionGroup = $this->route()->parameter('userGroupTransaction'); | ||||
|         $validator->after( | ||||
|             function (Validator $validator) use ($transactionGroup): void { | ||||
|                 // if more than one, verify that there are journal ID's present.
 | ||||
|                 $this->validateJournalIds($validator, $transactionGroup); | ||||
| 
 | ||||
|                 // all transaction types must be equal:
 | ||||
|                 $this->validateTransactionTypesForUpdate($validator); | ||||
| 
 | ||||
|                 // user wants to update a reconciled transaction.
 | ||||
|                 // source, destination, amount + foreign_amount cannot be changed
 | ||||
|                 // and must be omitted from the request.
 | ||||
|                 $this->preventUpdateReconciled($validator, $transactionGroup); | ||||
| 
 | ||||
|                 // validate source/destination is equal, depending on the transaction journal type.
 | ||||
|                 $this->validateEqualAccountsForUpdate($validator, $transactionGroup); | ||||
| 
 | ||||
|                 // see method:
 | ||||
|                 // $this->preventNoAccountInfo($validator, );
 | ||||
| 
 | ||||
|                 // validate that the currency fits the source and/or destination account.
 | ||||
|                 // validate all account info
 | ||||
|                 $this->validateAccountInformationUpdate($validator, $transactionGroup); | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -26,6 +26,7 @@ namespace FireflyIII\Api\V2\Request\UserGroup; | ||||
| 
 | ||||
| use FireflyIII\Enums\UserRoleEnum; | ||||
| use FireflyIII\Models\UserGroup; | ||||
| use FireflyIII\Rules\IsDefaultUserGroupName; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| @@ -53,7 +54,7 @@ class UpdateRequest extends FormRequest | ||||
|         $userGroup = $this->route()->parameter('userGroup'); | ||||
| 
 | ||||
|         return [ | ||||
|             'title' => sprintf('required|min:1|max:255|unique:user_groups,title,%d', $userGroup->id), | ||||
|             'title' => ['required', 'min:1', 'max:255', sprintf('unique:user_groups,title,%d', $userGroup->id), new IsDefaultUserGroupName($userGroup)], | ||||
|         ]; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -73,6 +73,7 @@ class CorrectDatabase extends Command | ||||
|             // new!
 | ||||
|             'firefly-iii:unify-group-accounts', | ||||
|             'firefly-iii:trigger-credit-recalculation', | ||||
|             'firefly-iii:migrate-preferences', | ||||
|         ]; | ||||
|         foreach ($commands as $command) { | ||||
|             $this->friendlyLine(sprintf('Now executing command "%s"', $command)); | ||||
|   | ||||
| @@ -248,29 +248,14 @@ class FixAccountTypes extends Command | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     private function isLiability(string $destinationType): bool | ||||
|     { | ||||
|         return AccountType::LOAN === $destinationType || AccountType::DEBT === $destinationType || AccountType::MORTGAGE === $destinationType; | ||||
|     } | ||||
| 
 | ||||
|     private function shouldBeTransfer(string $transactionType, string $sourceType, string $destinationType): bool | ||||
|     { | ||||
|         return TransactionType::TRANSFER === $transactionType && AccountType::ASSET === $sourceType && $this->isLiability($destinationType); | ||||
|     } | ||||
| 
 | ||||
|     private function shouldBeDeposit(string $transactionType, string $sourceType, string $destinationType): bool | ||||
|     private function isLiability(string $destinationType): bool | ||||
|     { | ||||
|         return TransactionType::TRANSFER === $transactionType && $this->isLiability($sourceType) && AccountType::ASSET === $destinationType; | ||||
|     } | ||||
| 
 | ||||
|     private function shouldGoToExpenseAccount(string $transactionType, string $sourceType, string $destinationType): bool | ||||
|     { | ||||
|         return TransactionType::WITHDRAWAL === $transactionType && AccountType::ASSET === $sourceType && AccountType::REVENUE === $destinationType; | ||||
|     } | ||||
| 
 | ||||
|     private function shouldComeFromRevenueAccount(string $transactionType, string $sourceType, string $destinationType): bool | ||||
|     { | ||||
|         return TransactionType::DEPOSIT === $transactionType && AccountType::EXPENSE === $sourceType && AccountType::ASSET === $destinationType; | ||||
|         return AccountType::LOAN === $destinationType || AccountType::DEBT === $destinationType || AccountType::MORTGAGE === $destinationType; | ||||
|     } | ||||
| 
 | ||||
|     private function makeTransfer(TransactionJournal $journal): void | ||||
| @@ -286,6 +271,11 @@ class FixAccountTypes extends Command | ||||
|         $this->inspectJournal($journal); | ||||
|     } | ||||
| 
 | ||||
|     private function shouldBeDeposit(string $transactionType, string $sourceType, string $destinationType): bool | ||||
|     { | ||||
|         return TransactionType::TRANSFER === $transactionType && $this->isLiability($sourceType) && AccountType::ASSET === $destinationType; | ||||
|     } | ||||
| 
 | ||||
|     private function makeDeposit(TransactionJournal $journal): void | ||||
|     { | ||||
|         // from a liability to an asset should be a deposit.
 | ||||
| @@ -299,6 +289,11 @@ class FixAccountTypes extends Command | ||||
|         $this->inspectJournal($journal); | ||||
|     } | ||||
| 
 | ||||
|     private function shouldGoToExpenseAccount(string $transactionType, string $sourceType, string $destinationType): bool | ||||
|     { | ||||
|         return TransactionType::WITHDRAWAL === $transactionType && AccountType::ASSET === $sourceType && AccountType::REVENUE === $destinationType; | ||||
|     } | ||||
| 
 | ||||
|     private function makeExpenseDestination(TransactionJournal $journal, Transaction $destination): void | ||||
|     { | ||||
|         // withdrawals with a revenue account as destination instead of an expense account.
 | ||||
| @@ -320,6 +315,11 @@ class FixAccountTypes extends Command | ||||
|         $this->inspectJournal($journal); | ||||
|     } | ||||
| 
 | ||||
|     private function shouldComeFromRevenueAccount(string $transactionType, string $sourceType, string $destinationType): bool | ||||
|     { | ||||
|         return TransactionType::DEPOSIT === $transactionType && AccountType::EXPENSE === $sourceType && AccountType::ASSET === $destinationType; | ||||
|     } | ||||
| 
 | ||||
|     private function makeRevenueSource(TransactionJournal $journal, Transaction $source): void | ||||
|     { | ||||
|         // deposits with an expense account as source instead of a revenue account.
 | ||||
| @@ -355,11 +355,6 @@ class FixAccountTypes extends Command | ||||
|         return in_array($accountType, $validTypes, true); | ||||
|     } | ||||
| 
 | ||||
|     private function canCreateDestination(array $validDestinations): bool | ||||
|     { | ||||
|         return in_array(AccountTypeEnum::EXPENSE->value, $validDestinations, true); | ||||
|     } | ||||
| 
 | ||||
|     private function giveNewRevenue(TransactionJournal $journal, Transaction $source): void | ||||
|     { | ||||
|         app('log')->debug(sprintf('An account of type "%s" could be a valid source.', AccountTypeEnum::REVENUE->value)); | ||||
| @@ -373,6 +368,11 @@ class FixAccountTypes extends Command | ||||
|         $this->inspectJournal($journal); | ||||
|     } | ||||
| 
 | ||||
|     private function canCreateDestination(array $validDestinations): bool | ||||
|     { | ||||
|         return in_array(AccountTypeEnum::EXPENSE->value, $validDestinations, true); | ||||
|     } | ||||
| 
 | ||||
|     private function giveNewExpense(TransactionJournal $journal, Transaction $destination): void | ||||
|     { | ||||
|         app('log')->debug(sprintf('An account of type "%s" could be a valid destination.', AccountTypeEnum::EXPENSE->value)); | ||||
|   | ||||
| @@ -50,7 +50,7 @@ class FixFrontpageAccounts extends Command | ||||
| 
 | ||||
|         /** @var User $user */ | ||||
|         foreach ($users as $user) { | ||||
|             $preference = app('preferences')->getForUser($user, 'frontPageAccounts'); | ||||
|             $preference = app('preferences')->getForUser($user, 'frontpageAccounts'); | ||||
|             if (null !== $preference) { | ||||
|                 $this->fixPreference($preference); | ||||
|             } | ||||
| @@ -83,6 +83,6 @@ class FixFrontpageAccounts extends Command | ||||
|                 } | ||||
|             } | ||||
|         } | ||||
|         app('preferences')->setForUser($preference->user, 'frontPageAccounts', $fixed); | ||||
|         app('preferences')->setForUser($preference->user, 'frontpageAccounts', $fixed); | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -60,18 +60,16 @@ class FixIbans extends Command | ||||
|     { | ||||
|         /** @var Account $account */ | ||||
|         foreach ($accounts as $account) { | ||||
|             $iban = $account->iban; | ||||
|             if (str_contains($iban, ' ')) { | ||||
|                 $iban = app('steam')->filterSpaces((string)$account->iban); | ||||
|                 if ('' !== $iban) { | ||||
|                     $account->iban = $iban; | ||||
|             $iban    = (string) $account->iban; | ||||
|             $newIban = app('steam')->filterSpaces($iban); | ||||
|             if ('' !== $iban && $iban !== $newIban) { | ||||
|                 $account->iban = $newIban; | ||||
|                 $account->save(); | ||||
|                 $this->friendlyInfo(sprintf('Removed spaces from IBAN of account #%d', $account->id)); | ||||
|                 ++$this->count; | ||||
|             } | ||||
|         } | ||||
|     } | ||||
|     } | ||||
| 
 | ||||
|     private function countAndCorrectIbans(Collection $accounts): void | ||||
|     { | ||||
|   | ||||
| @@ -26,6 +26,8 @@ namespace FireflyIII\Console\Commands\Correction; | ||||
| use FireflyIII\Console\Commands\ShowsFriendlyMessages; | ||||
| use FireflyIII\Models\Transaction; | ||||
| use FireflyIII\Models\TransactionJournal; | ||||
| use FireflyIII\Models\TransactionType; | ||||
| use FireflyIII\Support\Models\AccountBalanceCalculator; | ||||
| use Illuminate\Console\Command; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| 
 | ||||
| @@ -38,61 +40,18 @@ class FixUnevenAmount extends Command | ||||
| 
 | ||||
|     protected $description = 'Fix journals with uneven amounts.'; | ||||
|     protected $signature   = 'firefly-iii:fix-uneven-amount'; | ||||
|     private int $count; | ||||
| 
 | ||||
|     /** | ||||
|      * Execute the console command. | ||||
|      */ | ||||
|     public function handle(): int | ||||
|     { | ||||
|         $count    = 0; | ||||
|         $journals = \DB::table('transactions') | ||||
|             ->groupBy('transaction_journal_id') | ||||
|             ->whereNull('deleted_at') | ||||
|             ->get(['transaction_journal_id', \DB::raw('SUM(amount) AS the_sum')]) | ||||
|         ; | ||||
| 
 | ||||
|         /** @var \stdClass $entry */ | ||||
|         foreach ($journals as $entry) { | ||||
|             $sum = (string)$entry->the_sum; | ||||
|             if (!is_numeric($sum) | ||||
|                 || '' === $sum // @phpstan-ignore-line
 | ||||
|                 || str_contains($sum, 'e') | ||||
|                 || str_contains($sum, ',')) { | ||||
|                 $message = sprintf( | ||||
|                     'Journal #%d has an invalid sum ("%s"). No sure what to do.', | ||||
|                     $entry->transaction_journal_id, | ||||
|                     $entry->the_sum | ||||
|                 ); | ||||
|                 $this->friendlyWarning($message); | ||||
|                 app('log')->warning($message); | ||||
|                 ++$count; | ||||
| 
 | ||||
|                 continue; | ||||
|             } | ||||
|             $res = -1; | ||||
| 
 | ||||
|             try { | ||||
|                 $res = bccomp($sum, '0'); | ||||
|             } catch (\ValueError $e) { | ||||
|                 $this->friendlyError(sprintf('Could not bccomp("%s", "0").', $sum)); | ||||
|                 Log::error($e->getMessage()); | ||||
|                 Log::error($e->getTraceAsString()); | ||||
|             } | ||||
|             if (0 !== $res) { | ||||
|                 $message = sprintf( | ||||
|                     'Sum of journal #%d is %s instead of zero.', | ||||
|                     $entry->transaction_journal_id, | ||||
|                     $entry->the_sum | ||||
|                 ); | ||||
|                 $this->friendlyWarning($message); | ||||
|                 app('log')->warning($message); | ||||
|                 $this->fixJournal($entry->transaction_journal_id); | ||||
|                 ++$count; | ||||
|             } | ||||
|         } | ||||
|         if (0 === $count) { | ||||
|             $this->friendlyPositive('Database amount integrity is OK'); | ||||
|         } | ||||
|         $this->count = 0; | ||||
|         $this->convertOldStyleTransfers(); | ||||
|         $this->fixUnevenAmounts(); | ||||
|         $this->matchCurrencies(); | ||||
|         AccountBalanceCalculator::forceRecalculateAll(); | ||||
| 
 | ||||
|         return 0; | ||||
|     } | ||||
| @@ -118,6 +77,7 @@ class FixUnevenAmount extends Command | ||||
|             ); | ||||
|             Transaction::where('transaction_journal_id', $journal->id ?? 0)->forceDelete(); | ||||
|             TransactionJournal::where('id', $journal->id ?? 0)->forceDelete(); | ||||
|             ++$this->count; | ||||
| 
 | ||||
|             return; | ||||
|         } | ||||
| @@ -139,14 +99,194 @@ class FixUnevenAmount extends Command | ||||
| 
 | ||||
|             Transaction::where('transaction_journal_id', $journal->id ?? 0)->forceDelete(); | ||||
|             TransactionJournal::where('id', $journal->id ?? 0)->forceDelete(); | ||||
|             ++$this->count; | ||||
| 
 | ||||
|             return; | ||||
|         } | ||||
| 
 | ||||
|         // may still be able to salvage this journal if it is a transfer with foreign currency info
 | ||||
|         if ($this->isForeignCurrencyTransfer($journal)) { | ||||
|             Log::debug(sprintf('Can skip foreign currency transfer #%d.', $journal->id)); | ||||
| 
 | ||||
|             return; | ||||
|         } | ||||
| 
 | ||||
|         $message             = sprintf('Sum of journal #%d is not zero, journal is broken and now fixed.', $journal->id); | ||||
| 
 | ||||
|         $this->friendlyWarning($message); | ||||
|         app('log')->warning($message); | ||||
| 
 | ||||
|         $destination->amount = $amount; | ||||
|         $destination->save(); | ||||
| 
 | ||||
|         $message             = sprintf('Corrected amount in transaction journal #%d', $param); | ||||
|         $this->friendlyInfo($message); | ||||
|         ++$this->count; | ||||
|     } | ||||
| 
 | ||||
|     private function fixUnevenAmounts(): void | ||||
|     { | ||||
|         $journals = \DB::table('transactions') | ||||
|             ->groupBy('transaction_journal_id') | ||||
|             ->whereNull('deleted_at') | ||||
|             ->get(['transaction_journal_id', \DB::raw('SUM(amount) AS the_sum')]) | ||||
|         ; | ||||
| 
 | ||||
|         /** @var \stdClass $entry */ | ||||
|         foreach ($journals as $entry) { | ||||
|             $sum = (string) $entry->the_sum; | ||||
|             if (!is_numeric($sum) | ||||
|                 || '' === $sum // @phpstan-ignore-line
 | ||||
|                 || str_contains($sum, 'e') | ||||
|                 || str_contains($sum, ',')) { | ||||
|                 $message = sprintf( | ||||
|                     'Journal #%d has an invalid sum ("%s"). No sure what to do.', | ||||
|                     $entry->transaction_journal_id, | ||||
|                     $entry->the_sum | ||||
|                 ); | ||||
|                 $this->friendlyWarning($message); | ||||
|                 app('log')->warning($message); | ||||
|                 ++$this->count; | ||||
| 
 | ||||
|                 continue; | ||||
|             } | ||||
|             $res = -1; | ||||
| 
 | ||||
|             try { | ||||
|                 $res = bccomp($sum, '0'); | ||||
|             } catch (\ValueError $e) { | ||||
|                 $this->friendlyError(sprintf('Could not bccomp("%s", "0").', $sum)); | ||||
|                 Log::error($e->getMessage()); | ||||
|                 Log::error($e->getTraceAsString()); | ||||
|             } | ||||
|             if (0 !== $res) { | ||||
|                 $this->fixJournal($entry->transaction_journal_id); | ||||
|             } | ||||
|         } | ||||
|         if (0 === $this->count) { | ||||
|             $this->friendlyPositive('Database amount integrity is OK'); | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     private function matchCurrencies(): void | ||||
|     { | ||||
|         $journals = TransactionJournal::leftJoin('transactions', 'transaction_journals.id', 'transactions.transaction_journal_id') | ||||
|             ->where('transactions.transaction_currency_id', '!=', \DB::raw('transaction_journals.transaction_currency_id')) | ||||
|             ->get(['transaction_journals.*']) | ||||
|         ; | ||||
| 
 | ||||
|         $count    = 0; | ||||
| 
 | ||||
|         /** @var TransactionJournal $journal */ | ||||
|         foreach ($journals as $journal) { | ||||
|             if (!$this->isForeignCurrencyTransfer($journal)) { | ||||
|                 Transaction::where('transaction_journal_id', $journal->id)->update(['transaction_currency_id' => $journal->transaction_currency_id]); | ||||
|                 ++$count; | ||||
| 
 | ||||
|                 continue; | ||||
|             } | ||||
|             Log::debug(sprintf('Can skip foreign currency transfer #%d.', $journal->id)); | ||||
|         } | ||||
|         if (0 === $count) { | ||||
|             $this->friendlyPositive('Journal currency integrity is OK'); | ||||
| 
 | ||||
|             return; | ||||
|         } | ||||
| 
 | ||||
|         $this->friendlyPositive(sprintf('Fixed %d journal(s) with mismatched currencies.', $journals->count())); | ||||
|     } | ||||
| 
 | ||||
|     private function isForeignCurrencyTransfer(TransactionJournal $journal): bool | ||||
|     { | ||||
|         if (TransactionType::TRANSFER !== $journal->transactionType->type) { | ||||
|             return false; | ||||
|         } | ||||
| 
 | ||||
|         /** @var Transaction $destination */ | ||||
|         $destination = $journal->transactions()->where('amount', '>', 0)->first(); | ||||
| 
 | ||||
|         /** @var Transaction $source */ | ||||
|         $source      = $journal->transactions()->where('amount', '<', 0)->first(); | ||||
| 
 | ||||
|         // safety catch on NULL should not be necessary, we just had that catch.
 | ||||
|         // source amount = dest foreign amount
 | ||||
|         // source currency = dest foreign currency
 | ||||
|         // dest amount = source foreign currency
 | ||||
|         // dest currency = source foreign currency
 | ||||
| 
 | ||||
|         //        Log::debug(sprintf('[a] %s', bccomp(app('steam')->positive($source->amount), app('steam')->positive($destination->foreign_amount))));
 | ||||
|         //        Log::debug(sprintf('[b] %s', bccomp(app('steam')->positive($destination->amount), app('steam')->positive($source->foreign_amount))));
 | ||||
|         //        Log::debug(sprintf('[c] %s', var_export($source->transaction_currency_id === $destination->foreign_currency_id,true)));
 | ||||
|         //        Log::debug(sprintf('[d] %s', var_export((int) $destination->transaction_currency_id ===(int)  $source->foreign_currency_id, true)));
 | ||||
| 
 | ||||
|         if (0 === bccomp(app('steam')->positive($source->amount), app('steam')->positive($destination->foreign_amount)) | ||||
|             && $source->transaction_currency_id === $destination->foreign_currency_id | ||||
|             && 0 === bccomp(app('steam')->positive($destination->amount), app('steam')->positive($source->foreign_amount)) | ||||
|             && (int) $destination->transaction_currency_id === (int) $source->foreign_currency_id | ||||
|         ) { | ||||
|             return true; | ||||
|         } | ||||
| 
 | ||||
|         return false; | ||||
|     } | ||||
| 
 | ||||
|     private function convertOldStyleTransfers(): void | ||||
|     { | ||||
|         Log::debug('convertOldStyleTransfers()'); | ||||
|         // select transactions with a foreign amount and a foreign currency. and it's a transfer. and they are different.
 | ||||
|         $transactions = Transaction::distinct() | ||||
|             ->whereNotNull('foreign_currency_id') | ||||
|             ->whereNotNull('foreign_amount')->get(['transactions.transaction_journal_id']) | ||||
|         ; | ||||
|         $count        = 0; | ||||
| 
 | ||||
|         Log::debug(sprintf('Found %d potential journal(s)', $transactions->count())); | ||||
| 
 | ||||
|         /** @var Transaction $transaction */ | ||||
|         foreach ($transactions as $transaction) { | ||||
|             /** @var null|TransactionJournal $journal */ | ||||
|             $journal     = TransactionJournal::find($transaction->transaction_journal_id); | ||||
|             if (null === $journal) { | ||||
|                 Log::debug('Found no journal, continue.'); | ||||
| 
 | ||||
|                 continue; | ||||
|             } | ||||
|             // needs to be a transfer.
 | ||||
|             if (TransactionType::TRANSFER !== $journal->transactionType->type) { | ||||
|                 Log::debug('Must be a transfer, continue.'); | ||||
| 
 | ||||
|                 continue; | ||||
|             } | ||||
| 
 | ||||
|             /** @var null|Transaction $destination */ | ||||
|             $destination = $journal->transactions()->where('amount', '>', 0)->first(); | ||||
| 
 | ||||
|             /** @var null|Transaction $source */ | ||||
|             $source      = $journal->transactions()->where('amount', '<', 0)->first(); | ||||
|             if (null === $destination || null === $source) { | ||||
|                 Log::debug('Source or destination transaction is NULL, continue.'); | ||||
| 
 | ||||
|                 // will be picked up later.
 | ||||
|                 continue; | ||||
|             } | ||||
|             if ($source->transaction_currency_id === $destination->transaction_currency_id) { | ||||
|                 Log::debug('Ready to swap data between transactions.'); | ||||
|                 $destination->foreign_currency_id     = $source->transaction_currency_id; | ||||
|                 $destination->foreign_amount          = app('steam')->positive($source->amount); | ||||
|                 $destination->transaction_currency_id = $source->foreign_currency_id; | ||||
|                 $destination->amount                  = app('steam')->positive($source->foreign_amount); | ||||
|                 $destination->balance_dirty           = true; | ||||
|                 $source->balance_dirty                = true; | ||||
|                 $destination->save(); | ||||
|                 $source->save(); | ||||
|                 $this->friendlyWarning(sprintf('Corrected foreign amounts of transfer #%d.', $journal->id)); | ||||
|                 ++$count; | ||||
|             } | ||||
|         } | ||||
|         if (0 === $count) { | ||||
|             $this->friendlyPositive('No "old style" foreign currency transfers.'); | ||||
| 
 | ||||
|             return; | ||||
|         } | ||||
|     } | ||||
| } | ||||
|   | ||||
							
								
								
									
										66
									
								
								app/Console/Commands/Correction/MigratePreferences.php
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										66
									
								
								app/Console/Commands/Correction/MigratePreferences.php
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,66 @@ | ||||
| <?php | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| /* | ||||
|  * MigratePreferences.php | ||||
|  * Copyright (c) 2024 james@firefly-iii.org. | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
|  * This program is free software: you can redistribute it and/or modify | ||||
|  * it under the terms of the GNU Affero General Public License as | ||||
|  * published by the Free Software Foundation, either version 3 of the | ||||
|  * License, or (at your option) any later version. | ||||
|  * | ||||
|  * This program is distributed in the hope that it will be useful, | ||||
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see https://www.gnu.org/licenses/. | ||||
|  */ | ||||
| 
 | ||||
| namespace FireflyIII\Console\Commands\Correction; | ||||
| 
 | ||||
| use FireflyIII\Models\Preference; | ||||
| use FireflyIII\User; | ||||
| use Illuminate\Console\Command; | ||||
| use Symfony\Component\Console\Command\Command as CommandAlias; | ||||
| 
 | ||||
| class MigratePreferences extends Command | ||||
| { | ||||
|     protected $description = 'Give Firefly III preferences a user group ID so they can be made administration specific.'; | ||||
| 
 | ||||
|     protected $signature   = 'firefly-iii:migrate-preferences'; | ||||
| 
 | ||||
|     /** | ||||
|      * Execute the console command. | ||||
|      */ | ||||
|     public function handle(): int | ||||
|     { | ||||
|         $items = config('firefly.admin_specific_prefs'); | ||||
|         $users = User::get(); | ||||
| 
 | ||||
|         /** @var User $user */ | ||||
|         foreach ($users as $user) { | ||||
|             $count = 0; | ||||
|             foreach ($items as $item) { | ||||
|                 $preference = Preference::where('name', $item)->where('user_id', $user->id)->first(); | ||||
|                 if (null === $preference) { | ||||
|                     continue; | ||||
|                 } | ||||
|                 if (null !== $preference->user_group_id) { | ||||
|                     $preference->user_group_id = $user->user_group_id; | ||||
|                     $preference->save(); | ||||
|                     ++$count; | ||||
|                 } | ||||
|             } | ||||
|             if ($count > 0) { | ||||
|                 $this->info(sprintf('Migrated %d preference(s) for user #%d ("%s").', $count, $user->id, $user->email)); | ||||
|             } | ||||
|         } | ||||
| 
 | ||||
|         return CommandAlias::SUCCESS; | ||||
|     } | ||||
| } | ||||
| @@ -191,7 +191,7 @@ class ExportData extends Command | ||||
|                 $this->friendlyError(sprintf('%s date "%s" must be formatted YYYY-MM-DD. Field will be ignored.', $field, $this->option('start'))); | ||||
|                 $error = true; | ||||
|             } | ||||
|             if (false === $date) { | ||||
|             if (null === $date) { | ||||
|                 $this->friendlyError(sprintf('%s date "%s" must be formatted YYYY-MM-DD.', $field, $this->option('start'))); | ||||
| 
 | ||||
|                 throw new FireflyException(sprintf('%s date "%s" must be formatted YYYY-MM-DD.', $field, $this->option('start'))); | ||||
|   | ||||
| @@ -57,6 +57,19 @@ class CreateGroupMemberships extends Command | ||||
|         return 0; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * @throws FireflyException | ||||
|      */ | ||||
|     private function createGroupMemberships(): void | ||||
|     { | ||||
|         $users = User::get(); | ||||
| 
 | ||||
|         /** @var User $user */ | ||||
|         foreach ($users as $user) { | ||||
|             self::createGroupMembership($user); | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * TODO move to helper. | ||||
|      * | ||||
| @@ -93,17 +106,4 @@ class CreateGroupMemberships extends Command | ||||
|             $user->save(); | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * @throws FireflyException | ||||
|      */ | ||||
|     private function createGroupMemberships(): void | ||||
|     { | ||||
|         $users = User::get(); | ||||
| 
 | ||||
|         /** @var User $user */ | ||||
|         foreach ($users as $user) { | ||||
|             self::createGroupMembership($user); | ||||
|         } | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -115,7 +115,7 @@ class UpdateGroupInformation extends Command | ||||
|             return; | ||||
|         } | ||||
|         if (0 !== $result) { | ||||
|             $this->friendlyPositive(sprintf('User #%d: Moved %d %s objects to the correct group.', $user->id, $result, str_replace('FireflyIII\\Models\\', '', $className))); | ||||
|             $this->friendlyPositive(sprintf('User #%d: Moved %d %s objects to the correct group.', $user->id, $result, str_replace('FireflyIII\Models\\', '', $className))); | ||||
|         } | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -111,7 +111,7 @@ class ForceDecimalSize extends Command | ||||
|     { | ||||
|         // switch stuff based on database connection:
 | ||||
|         $this->operator          = 'REGEXP'; | ||||
|         $this->regularExpression = '\'\\\\.[\\\\d]{%d}[1-9]+\''; | ||||
|         $this->regularExpression = '\'\\\.[\\\d]{%d}[1-9]+\''; | ||||
|         $this->cast              = 'CHAR'; | ||||
|         if ('pgsql' === config('database.default')) { | ||||
|             $this->operator          = 'SIMILAR TO'; | ||||
| @@ -119,7 +119,7 @@ class ForceDecimalSize extends Command | ||||
|             $this->cast              = 'TEXT'; | ||||
|         } | ||||
|         if ('sqlite' === config('database.default')) { | ||||
|             $this->regularExpression = '"\\.[\d]{%d}[1-9]+"'; | ||||
|             $this->regularExpression = '"\.[\d]{%d}[1-9]+"'; | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
| @@ -307,7 +307,7 @@ class ForceDecimalSize extends Command | ||||
|             /** @var string $field */ | ||||
|             foreach ($fields as $field) { | ||||
|                 $value   = $item->{$field}; | ||||
|                 if (null === $value) { | ||||
|                 if (null === $value || '' === $value) { | ||||
|                     continue; | ||||
|                 } | ||||
|                 // fix $field by rounding it down correctly.
 | ||||
|   | ||||
							
								
								
									
										54
									
								
								app/Console/Commands/System/LaravelPassportKeys.php
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										54
									
								
								app/Console/Commands/System/LaravelPassportKeys.php
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,54 @@ | ||||
| <?php | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| /* | ||||
|  * LaravelPassportKeys.php | ||||
|  * Copyright (c) 2024 james@firefly-iii.org. | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
|  * This program is free software: you can redistribute it and/or modify | ||||
|  * it under the terms of the GNU Affero General Public License as | ||||
|  * published by the Free Software Foundation, either version 3 of the | ||||
|  * License, or (at your option) any later version. | ||||
|  * | ||||
|  * This program is distributed in the hope that it will be useful, | ||||
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see https://www.gnu.org/licenses/. | ||||
|  */ | ||||
| 
 | ||||
| namespace FireflyIII\Console\Commands\System; | ||||
| 
 | ||||
| use FireflyIII\Console\Commands\ShowsFriendlyMessages; | ||||
| use Illuminate\Console\Command; | ||||
| use Illuminate\Support\Facades\Artisan; | ||||
| use Symfony\Component\Console\Command\Command as CommandAlias; | ||||
| 
 | ||||
| class LaravelPassportKeys extends Command | ||||
| { | ||||
|     use ShowsFriendlyMessages; | ||||
| 
 | ||||
|     protected $description = 'Calls the Laravel "passport:keys" but doesn\'t exit 1.'; | ||||
|     protected $signature   = 'firefly-iii:laravel-passport-keys'; | ||||
| 
 | ||||
|     /** | ||||
|      * Execute the console command. | ||||
|      */ | ||||
|     public function handle(): int | ||||
|     { | ||||
|         Artisan::call('passport:keys --no-interaction', []); | ||||
|         $result = Artisan::output(); | ||||
|         if (str_contains($result, 'Encryption keys already exist')) { | ||||
|             $this->friendlyInfo('Encryption keys exist already.'); | ||||
| 
 | ||||
|             return CommandAlias::SUCCESS; | ||||
|         } | ||||
|         $this->friendlyPositive('Encryption keys have been created, nice!'); | ||||
| 
 | ||||
|         return CommandAlias::SUCCESS; | ||||
|     } | ||||
| } | ||||
| @@ -72,6 +72,16 @@ class UpgradeFireflyInstructions extends Command | ||||
|             } | ||||
|         } | ||||
| 
 | ||||
|         // validate some settings.
 | ||||
|         if ('' === $text && 'local' === (string)config('app.env')) { | ||||
|             $text = 'Please set APP_ENV=production for a safer environment.'; | ||||
|         } | ||||
| 
 | ||||
|         $prefix  = 'v'; | ||||
|         if (str_starts_with($version, 'develop')) { | ||||
|             $prefix = ''; | ||||
|         } | ||||
| 
 | ||||
|         $this->newLine(); | ||||
|         $this->showLogo(); | ||||
|         $this->newLine(); | ||||
| @@ -79,7 +89,7 @@ class UpgradeFireflyInstructions extends Command | ||||
| 
 | ||||
|         $this->boxed(''); | ||||
|         if ('' === $text) { | ||||
|             $this->boxed(sprintf('Thank you for updating to Firefly III, v%s', $version)); | ||||
|             $this->boxed(sprintf('Thank you for updating to Firefly III, %s%s', $prefix, $version)); | ||||
|             $this->boxedInfo('There are no extra upgrade instructions.'); | ||||
|             $this->boxed('Firefly III should be ready for use.'); | ||||
|             $this->boxed(''); | ||||
| @@ -88,7 +98,7 @@ class UpgradeFireflyInstructions extends Command | ||||
|             return; | ||||
|         } | ||||
| 
 | ||||
|         $this->boxed(sprintf('Thank you for updating to Firefly III, v%s!', $version)); | ||||
|         $this->boxed(sprintf('Thank you for updating to Firefly III, %s%s!', $prefix, $version)); | ||||
|         $this->boxedInfo($text); | ||||
|         $this->boxed(''); | ||||
|         $this->showLine(); | ||||
| @@ -181,13 +191,24 @@ class UpgradeFireflyInstructions extends Command | ||||
|                 $text = (string)$config[$compare]; | ||||
|             } | ||||
|         } | ||||
| 
 | ||||
|         // validate some settings.
 | ||||
|         if ('' === $text && 'local' === (string)config('app.env')) { | ||||
|             $text = 'Please set APP_ENV=production for a safer environment.'; | ||||
|         } | ||||
| 
 | ||||
|         $prefix  = 'v'; | ||||
|         if (str_starts_with($version, 'develop')) { | ||||
|             $prefix = ''; | ||||
|         } | ||||
| 
 | ||||
|         $this->newLine(); | ||||
|         $this->showLogo(); | ||||
|         $this->newLine(); | ||||
|         $this->showLine(); | ||||
|         $this->boxed(''); | ||||
|         if ('' === $text) { | ||||
|             $this->boxed(sprintf('Thank you for installing Firefly III, v%s!', $version)); | ||||
|             $this->boxed(sprintf('Thank you for installing Firefly III, %s%s!', $prefix, $version)); | ||||
|             $this->boxedInfo('There are no extra installation instructions.'); | ||||
|             $this->boxed('Firefly III should be ready for use.'); | ||||
|             $this->boxed(''); | ||||
| @@ -196,7 +217,7 @@ class UpgradeFireflyInstructions extends Command | ||||
|             return; | ||||
|         } | ||||
| 
 | ||||
|         $this->boxed(sprintf('Thank you for installing Firefly III, v%s!', $version)); | ||||
|         $this->boxed(sprintf('Thank you for installing Firefly III, %s%s!', $prefix, $version)); | ||||
|         $this->boxedInfo($text); | ||||
|         $this->boxed(''); | ||||
|         $this->showLine(); | ||||
|   | ||||
| @@ -1,7 +1,7 @@ | ||||
| <?php | ||||
| /** | ||||
| /* | ||||
|  * ApplyRules.php | ||||
|  * Copyright (c) 2020 james@firefly-iii.org | ||||
|  * Copyright (c) 2024 james@firefly-iii.org. | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
| @@ -16,7 +16,7 @@ | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see <https://www.gnu.org/licenses/>. | ||||
|  * along with this program.  If not, see https://www.gnu.org/licenses/. | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| @@ -285,7 +285,7 @@ class ApplyRules extends Command | ||||
|         if (null !== $endString && '' !== $endString) { | ||||
|             $inputEnd = Carbon::createFromFormat('Y-m-d', $endString); | ||||
|         } | ||||
|         if (false === $inputEnd || false === $inputStart) { | ||||
|         if (null === $inputEnd || null === $inputStart) { | ||||
|             Log::error('Could not parse start or end date in verifyInputDate().'); | ||||
| 
 | ||||
|             return; | ||||
|   | ||||
| @@ -1,8 +1,8 @@ | ||||
| <?php | ||||
| 
 | ||||
| /** | ||||
| /* | ||||
|  * Cron.php | ||||
|  * Copyright (c) 2020 james@firefly-iii.org | ||||
|  * Copyright (c) 2024 james@firefly-iii.org. | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
| @@ -17,7 +17,7 @@ | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see <https://www.gnu.org/licenses/>. | ||||
|  * along with this program.  If not, see https://www.gnu.org/licenses/. | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
|   | ||||
| @@ -110,7 +110,7 @@ class AppendBudgetLimitPeriods extends Command | ||||
|             return 'daily'; | ||||
|         } | ||||
|         // is weekly
 | ||||
|         if ('1' === $limit->start_date->format('N') && '7' === $limit->end_date->format('N') && 6 === $limit->end_date->diffInDays($limit->start_date)) { | ||||
|         if ('1' === $limit->start_date->format('N') && '7' === $limit->end_date->format('N') && 6 === (int)$limit->end_date->diffInDays($limit->start_date, true)) { | ||||
|             return 'weekly'; | ||||
|         } | ||||
| 
 | ||||
| @@ -129,7 +129,7 @@ class AppendBudgetLimitPeriods extends Command | ||||
|         if ( | ||||
|             in_array($limit->start_date->format('j-n'), $start, true) // start of quarter
 | ||||
|             && in_array($limit->end_date->format('j-n'), $end, true) // end of quarter
 | ||||
|             && 2 === $limit->start_date->diffInMonths($limit->end_date) | ||||
|             && 2 === (int)$limit->start_date->diffInMonths($limit->end_date, true) | ||||
|         ) { | ||||
|             return 'quarterly'; | ||||
|         } | ||||
| @@ -139,7 +139,7 @@ class AppendBudgetLimitPeriods extends Command | ||||
|         if ( | ||||
|             in_array($limit->start_date->format('j-n'), $start, true) // start of quarter
 | ||||
|             && in_array($limit->end_date->format('j-n'), $end, true) // end of quarter
 | ||||
|             && 5 === $limit->start_date->diffInMonths($limit->end_date) | ||||
|             && 5 === (int)$limit->start_date->diffInMonths($limit->end_date, true) | ||||
|         ) { | ||||
|             return 'half_year'; | ||||
|         } | ||||
|   | ||||
							
								
								
									
										70
									
								
								app/Console/Commands/Upgrade/CorrectAccountBalance.php
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										70
									
								
								app/Console/Commands/Upgrade/CorrectAccountBalance.php
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,70 @@ | ||||
| <?php | ||||
| /* | ||||
|  * CorrectAccountBalance.php | ||||
|  * Copyright (c) 2024 james@firefly-iii.org. | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
|  * This program is free software: you can redistribute it and/or modify | ||||
|  * it under the terms of the GNU Affero General Public License as | ||||
|  * published by the Free Software Foundation, either version 3 of the | ||||
|  * License, or (at your option) any later version. | ||||
|  * | ||||
|  * This program is distributed in the hope that it will be useful, | ||||
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see https://www.gnu.org/licenses/. | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Console\Commands\Upgrade; | ||||
| 
 | ||||
| use FireflyIII\Console\Commands\ShowsFriendlyMessages; | ||||
| use FireflyIII\Support\Models\AccountBalanceCalculator; | ||||
| use Illuminate\Console\Command; | ||||
| 
 | ||||
| /** | ||||
|  * Class CorrectionSkeleton | ||||
|  */ | ||||
| class CorrectAccountBalance extends Command | ||||
| { | ||||
|     use ShowsFriendlyMessages; | ||||
|     public const string CONFIG_NAME = '610_correct_balances'; | ||||
|     protected $description          = 'Recalculate all account balance amounts'; | ||||
|     protected $signature            = 'firefly-iii:correct-account-balance {--F|force : Force the execution of this command.}'; | ||||
| 
 | ||||
|     public function handle(): int | ||||
|     { | ||||
|         if ($this->isExecuted() && true !== $this->option('force')) { | ||||
|             $this->friendlyInfo('This command has already been executed.'); | ||||
| 
 | ||||
|             return 0; | ||||
|         } | ||||
|         $this->friendlyWarning('This command has been disabled.'); | ||||
|         $this->markAsExecuted(); | ||||
| 
 | ||||
|         //        $this->correctBalanceAmounts();
 | ||||
|         return 0; | ||||
|     } | ||||
| 
 | ||||
|     private function correctBalanceAmounts(): void | ||||
|     { | ||||
|         AccountBalanceCalculator::recalculateAll(); | ||||
|     } | ||||
| 
 | ||||
|     private function isExecuted(): bool | ||||
|     { | ||||
|         $configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false); | ||||
| 
 | ||||
|         return (bool)$configVar?->data; | ||||
|     } | ||||
| 
 | ||||
|     private function markAsExecuted(): void | ||||
|     { | ||||
|         app('fireflyconfig')->set(self::CONFIG_NAME, true); | ||||
|     } | ||||
| } | ||||
							
								
								
									
										182
									
								
								app/Console/Commands/Upgrade/MigrateRuleActions.php
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										182
									
								
								app/Console/Commands/Upgrade/MigrateRuleActions.php
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,182 @@ | ||||
| <?php | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| /* | ||||
|  * MigrateRuleActions.php | ||||
|  * Copyright (c) 2024 james@firefly-iii.org. | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
|  * This program is free software: you can redistribute it and/or modify | ||||
|  * it under the terms of the GNU Affero General Public License as | ||||
|  * published by the Free Software Foundation, either version 3 of the | ||||
|  * License, or (at your option) any later version. | ||||
|  * | ||||
|  * This program is distributed in the hope that it will be useful, | ||||
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see https://www.gnu.org/licenses/. | ||||
|  */ | ||||
| 
 | ||||
| namespace FireflyIII\Console\Commands\Upgrade; | ||||
| 
 | ||||
| use FireflyIII\Console\Commands\ShowsFriendlyMessages; | ||||
| use FireflyIII\Models\RuleAction; | ||||
| use Illuminate\Console\Command; | ||||
| 
 | ||||
| class MigrateRuleActions extends Command | ||||
| { | ||||
|     use ShowsFriendlyMessages; | ||||
| 
 | ||||
|     public const string CONFIG_NAME = '610_migrate_rule_actions'; | ||||
| 
 | ||||
|     protected $description          = 'Migrate rule actions away from expression engine'; | ||||
| 
 | ||||
|     protected $signature            = 'firefly-iii:migrate-rule-actions {--F|force : Force the execution of this command.}'; | ||||
| 
 | ||||
|     /** | ||||
|      * Execute the console command. | ||||
|      */ | ||||
|     public function handle(): int | ||||
|     { | ||||
|         if ($this->isExecuted() && true !== $this->option('force')) { | ||||
|             $this->friendlyInfo('This command has already been executed.'); | ||||
| 
 | ||||
|             return 0; | ||||
|         } | ||||
|         if (false === config('firefly.feature_flags.expression_engine')) { | ||||
|             $this->friendlyInfo('Expression engine is not enabled. Nothing to do.'); | ||||
| 
 | ||||
|             return 0; | ||||
|         } | ||||
|         $this->replaceEqualSign(); | ||||
|         $this->replaceObsoleteActions(); | ||||
| 
 | ||||
|         return 0; | ||||
|     } | ||||
| 
 | ||||
|     private function isExecuted(): bool | ||||
|     { | ||||
|         $configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false); | ||||
|         if (null !== $configVar) { | ||||
|             return (bool)$configVar->data; | ||||
|         } | ||||
| 
 | ||||
|         return false; | ||||
|     } | ||||
| 
 | ||||
|     private function replaceEqualSign(): void | ||||
|     { | ||||
|         $count   = 0; | ||||
|         $actions = RuleAction::get(); | ||||
| 
 | ||||
|         /** @var RuleAction $action */ | ||||
|         foreach ($actions as $action) { | ||||
|             if (str_starts_with($action->action_value, '=')) { | ||||
|                 $action->action_value = sprintf('%s%s', '\=', substr($action->action_value, 1)); | ||||
|                 $action->save(); | ||||
|                 ++$count; | ||||
|             } | ||||
|         } | ||||
|         if ($count > 0) { | ||||
|             $this->friendlyInfo(sprintf('Upgrading %d rule action(s) for the new expression engine.', $count)); | ||||
|         } | ||||
|         if (0 === $count) { | ||||
|             $this->friendlyInfo('All rule actions are up to date.'); | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     private function replaceObsoleteActions(): void | ||||
|     { | ||||
|         $obsolete = [ | ||||
|             'append_description', | ||||
|             'prepend_description', | ||||
|             'append_notes', | ||||
|             'prepend_notes', | ||||
|             'append_descr_to_notes', | ||||
|             'append_notes_to_descr', | ||||
|             'move_descr_to_notes', | ||||
|             'move_notes_to_descr', | ||||
|         ]; | ||||
|         $actions  = RuleAction::whereIn('action_type', $obsolete)->get(); | ||||
| 
 | ||||
|         /** @var RuleAction $action */ | ||||
|         foreach ($actions as $action) { | ||||
|             $oldType = $action->action_type; | ||||
| 
 | ||||
|             switch ($action->action_type) { | ||||
|                 default: | ||||
|                     $this->friendlyError(sprintf('Cannot deal with action type "%s", skip it.', $action->action_type)); | ||||
| 
 | ||||
|                     break; | ||||
| 
 | ||||
|                 case 'append_description': | ||||
|                     $action->action_type  = 'set_description'; | ||||
|                     $action->action_value = sprintf('=description~"%s"', str_replace('"', '\"', $action->action_value)); | ||||
|                     $action->save(); | ||||
|                     $this->friendlyInfo(sprintf('Upgraded action #%d from "%s" to "%s".', $action->id, $oldType, $action->action_type)); | ||||
| 
 | ||||
|                     break; | ||||
| 
 | ||||
|                 case 'prepend_description': | ||||
|                     $action->action_type  = 'set_description'; | ||||
|                     $action->action_value = sprintf('="%s"~description', str_replace('"', '\"', $action->action_value)); | ||||
|                     $action->save(); | ||||
|                     $this->friendlyInfo(sprintf('Upgraded action #%d from "%s" to "%s".', $action->id, $oldType, $action->action_type)); | ||||
| 
 | ||||
|                     break; | ||||
| 
 | ||||
|                 case 'append_notes': | ||||
|                     $action->action_type  = 'set_notes'; | ||||
|                     $action->action_value = sprintf('=notes~"%s"', str_replace('"', '\"', $action->action_value)); | ||||
|                     $action->save(); | ||||
|                     $this->friendlyInfo(sprintf('Upgraded action #%d from "%s" to "%s".', $action->id, $oldType, $action->action_type)); | ||||
| 
 | ||||
|                     break; | ||||
| 
 | ||||
|                 case 'prepend_notes': | ||||
|                     $action->action_type  = 'set_notes'; | ||||
|                     $action->action_value = sprintf('="%s"~notes', str_replace('"', '\"', $action->action_value)); | ||||
|                     $action->save(); | ||||
|                     $this->friendlyInfo(sprintf('Upgraded action #%d from "%s" to "%s".', $action->id, $oldType, $action->action_type)); | ||||
| 
 | ||||
|                     break; | ||||
| 
 | ||||
|                 case 'append_descr_to_notes': | ||||
|                     $action->action_type  = 'set_notes'; | ||||
|                     $action->action_value = '=notes~" "~description'; | ||||
|                     $action->save(); | ||||
|                     $this->friendlyInfo(sprintf('Upgraded action #%d from "%s" to "%s".', $action->id, $oldType, $action->action_type)); | ||||
| 
 | ||||
|                     break; | ||||
| 
 | ||||
|                 case 'append_notes_to_descr': | ||||
|                     $action->action_type  = 'set_description'; | ||||
|                     $action->action_value = '=description~" "~notes'; | ||||
|                     $action->save(); | ||||
|                     $this->friendlyInfo(sprintf('Upgraded action #%d from "%s" to "%s".', $action->id, $oldType, $action->action_type)); | ||||
| 
 | ||||
|                     break; | ||||
| 
 | ||||
|                 case 'move_descr_to_notes': | ||||
|                     $action->action_type  = 'set_notes'; | ||||
|                     $action->action_value = '=description'; | ||||
|                     $action->save(); | ||||
|                     $this->friendlyInfo(sprintf('Upgraded action #%d from "%s" to "%s".', $action->id, $oldType, $action->action_type)); | ||||
| 
 | ||||
|                     break; | ||||
| 
 | ||||
|                 case 'move_notes_to_descr': | ||||
|                     $action->action_type  = 'set_description'; | ||||
|                     $action->action_value = '=notes'; | ||||
|                     $action->save(); | ||||
|                     $this->friendlyInfo(sprintf('Upgraded action #%d from "%s" to "%s".', $action->id, $oldType, $action->action_type)); | ||||
| 
 | ||||
|                     break; | ||||
|             } | ||||
|         } | ||||
|     } | ||||
| } | ||||
| @@ -193,22 +193,6 @@ class MigrateToGroups extends Command | ||||
|         ); | ||||
|     } | ||||
| 
 | ||||
|     private function findOpposingTransaction(TransactionJournal $journal, Transaction $transaction): ?Transaction | ||||
|     { | ||||
|         $set = $journal->transactions->filter( | ||||
|             static function (Transaction $subject) use ($transaction) { | ||||
|                 $amount     = (float) $transaction->amount * -1 === (float) $subject->amount;  // intentional float
 | ||||
|                 $identifier = $transaction->identifier === $subject->identifier; | ||||
|                 app('log')->debug(sprintf('Amount the same? %s', var_export($amount, true))); | ||||
|                 app('log')->debug(sprintf('ID the same?     %s', var_export($identifier, true))); | ||||
| 
 | ||||
|                 return $amount && $identifier; | ||||
|             } | ||||
|         ); | ||||
| 
 | ||||
|         return $set->first(); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * @SuppressWarnings(PHPMD.ExcessiveMethodLength) | ||||
|      */ | ||||
| @@ -299,6 +283,22 @@ class MigrateToGroups extends Command | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     private function findOpposingTransaction(TransactionJournal $journal, Transaction $transaction): ?Transaction | ||||
|     { | ||||
|         $set = $journal->transactions->filter( | ||||
|             static function (Transaction $subject) use ($transaction) { | ||||
|                 $amount     = (float)$transaction->amount * -1 === (float)$subject->amount;  // intentional float
 | ||||
|                 $identifier = $transaction->identifier === $subject->identifier; | ||||
|                 app('log')->debug(sprintf('Amount the same? %s', var_export($amount, true))); | ||||
|                 app('log')->debug(sprintf('ID the same?     %s', var_export($identifier, true))); | ||||
| 
 | ||||
|                 return $amount && $identifier; | ||||
|             } | ||||
|         ); | ||||
| 
 | ||||
|         return $set->first(); | ||||
|     } | ||||
| 
 | ||||
|     private function getTransactionBudget(Transaction $left, Transaction $right): ?int | ||||
|     { | ||||
|         app('log')->debug('Now in getTransactionBudget()'); | ||||
|   | ||||
Some files were not shown because too many files have changed in this diff Show More
		Reference in New Issue
	
	Block a user