mirror of
				https://github.com/firefly-iii/firefly-iii.git
				synced 2025-10-28 22:26:22 +00:00 
			
		
		
		
	Compare commits
	
		
			607 Commits
		
	
	
		
			v6.2.9
			...
			develop-20
		
	
	| Author | SHA1 | Date | |
|---|---|---|---|
|  | 917665feac | ||
|  | 06c50b68c2 | ||
|  | 7035c399d8 | ||
|  | 7c0ac5805c | ||
|  | 3424741583 | ||
|  | baf0297994 | ||
|  | 31d06752fa | ||
|  | 8a27154798 | ||
|  | 6d87e38ec0 | ||
|  | ccdc30a6fb | ||
|  | 90005538d3 | ||
|  | f4e0428ebc | ||
|  | bd1326eca9 | ||
|  | bdfa834251 | ||
|  | 4a9aeb4e44 | ||
|  | 3886c0fbde | ||
|  | d998eff56e | ||
|  | d73df9bf0a | ||
|  | 754f2f3a34 | ||
|  | 43fd7c928a | ||
|  | 05768c2e73 | ||
|  | 3feb2c9955 | ||
|  | 7d9f3ac473 | ||
|  | 8a5755c8f1 | ||
|  | a75a760019 | ||
|  | 78d1a130d2 | ||
|  | 79fd43f32b | ||
|  | 7a7bd65a27 | ||
|  | 01a9ecccac | ||
|  | c1b3c71090 | ||
|  | 323d04fe6c | ||
|  | 80c2f1ea3f | ||
|  | 784494871d | ||
|  | 8e93af5cc7 | ||
|  | ebfdeeedaa | ||
|  | 1d02ed6a56 | ||
|  | cca53cb0e8 | ||
|  | ab33aee4b1 | ||
|  | 41d4fab071 | ||
|  | f0a1913dc6 | ||
|  | b956b463c2 | ||
|  | 43603c4990 | ||
|  | 196e738f60 | ||
|  | 59e2ea357a | ||
|  | 5e9d942069 | ||
|  | 53d5bedd85 | ||
|  | 49c68af07b | ||
|  | c84c8e1aef | ||
|  | a8d43d7174 | ||
|  | 1087278890 | ||
|  | ae5912ab52 | ||
|  | 035bd96ae5 | ||
|  | 7283c616a0 | ||
|  | 5706666bb6 | ||
|  | 4607466fb6 | ||
|  | 34bcfcfe9b | ||
|  | 05986cb6a6 | ||
|  | 0c4ee9f043 | ||
|  | ff222795cf | ||
|  | e0c76695ee | ||
|  | ae126e8322 | ||
|  | 8f9c35fbe8 | ||
|  | 84efd6e2ee | ||
|  | b1fbe4e909 | ||
|  | 8576877072 | ||
|  | c298aced01 | ||
|  | ac61a78d8d | ||
|  | fce90a94c4 | ||
|  | 023a4f178d | ||
|  | ef254995ad | ||
|  | faeb74634b | ||
|  | b5baae373f | ||
|  | 63de711cda | ||
|  | bd28d116cb | ||
|  | 7efc2861bc | ||
|  | 5c689a2ca2 | ||
|  | d5d65df76f | ||
|  | df7d4f700c | ||
|  | efebe3cb41 | ||
|  | 2ba5b6ae49 | ||
|  | 31d93efab2 | ||
|  | 657b95485c | ||
|  | 3bfc12f93b | ||
|  | ccfd2f2ac3 | ||
|  | fb3fe0d87b | ||
|  | c80c6d52fe | ||
|  | 0fb3c0c7bf | ||
|  | 43c625bee2 | ||
|  | 967a5dd256 | ||
|  | 3c9d1bcaa1 | ||
|  | 8cd2de14a9 | ||
|  | 7728a35e04 | ||
|  | 49000da123 | ||
|  | 32a8f89875 | ||
|  | 49e5a81bd3 | ||
|  | a8efe86af0 | ||
|  | 4f07b089d2 | ||
|  | e786bf47c2 | ||
|  | be11778c53 | ||
|  | 3d7325424c | ||
|  | f4ffed99ef | ||
|  | 52dfe9a738 | ||
|  | a0bc8b2ba2 | ||
|  | 4ffca9e2ca | ||
|  | a6afec9afa | ||
|  | 5d859222f8 | ||
|  | 0e3ba14666 | ||
|  | 860767fe5a | ||
|  | 91b0ad625c | ||
|  | 67bab2561a | ||
|  | b7908ebcb4 | ||
|  | a20601ea85 | ||
|  | 14622329a8 | ||
|  | 5577be7b08 | ||
|  | e3bab9d7d8 | ||
|  | e0512bee3d | ||
|  | 20827a5fd1 | ||
|  | 8819dac1e1 | ||
|  | da0a07262c | ||
|  | 9c195dcc66 | ||
|  | 0b45506e52 | ||
|  | 51e58f8d88 | ||
|  | d0c658e79a | ||
|  | 35e0791a9f | ||
|  | 637ecc66d2 | ||
|  | 3a38175b2a | ||
|  | d78fd86d7a | ||
|  | 395332d6dd | ||
|  | c5cbceb81a | ||
|  | ec94f1bcf1 | ||
|  | ee3d18a8ea | ||
|  | a9cd8b6512 | ||
|  | 5bd87036b0 | ||
|  | 0e7d72023d | ||
|  | 314f91ff24 | ||
|  | ed54a5c9a4 | ||
|  | 5d35edb126 | ||
|  | 8bdfdc39cb | ||
|  | d465b51da8 | ||
|  | 3344d2e5f3 | ||
|  | 0521da124e | ||
|  | 7e9c5a668f | ||
|  | 08e2c1684f | ||
|  | 36ab188ad1 | ||
|  | 2e69e09808 | ||
|  | adba360466 | ||
|  | 5be6bb755d | ||
|  | 189a323f3c | ||
|  | adbf785aba | ||
|  | b1258d0b43 | ||
|  | f33ec58e7c | ||
|  | 58bd818539 | ||
|  | b875e67fe0 | ||
|  | b9528c05a0 | ||
|  | bc98100401 | ||
|  | 26bbb21520 | ||
|  | 86a51b5caa | ||
|  | c3e039a757 | ||
|  | 7762f555c5 | ||
|  | e412e23c87 | ||
|  | 2cb14f6b72 | ||
|  | d8f512ca3a | ||
|  | c074fec0a7 | ||
|  | 7c04c4c2bc | ||
|  | df82252c95 | ||
|  | c747f4afd8 | ||
|  | bcd7db0256 | ||
|  | 469acce76d | ||
|  | 568f71ce63 | ||
|  | f6fbcf54aa | ||
|  | c194a1ae20 | ||
|  | 7df3728394 | ||
|  | acad0b5b55 | ||
|  | 1fae39a49d | ||
|  | 605ab38660 | ||
|  | 75b21b20d8 | ||
|  | e82459cd29 | ||
|  | 6dcf80967e | ||
|  | 3d9edaeaac | ||
|  | 659240a98b | ||
|  | 4a5a31bf69 | ||
|  | 5f73e37657 | ||
|  | 7a9c0a8172 | ||
|  | 39914e2380 | ||
|  | 5a3240f69d | ||
|  | 19e5fd6277 | ||
|  | e9844dc2f5 | ||
|  | c9f07c093a | ||
|  | 6a986d8119 | ||
|  | f780de9e71 | ||
|  | b830bd2732 | ||
|  | e333dedeec | ||
|  | 6e5a08245c | ||
|  | 6a82a813e0 | ||
|  | 7992ecf7f6 | ||
|  | 967f7cb015 | ||
|  | 7ca5e03752 | ||
|  | e9644c9679 | ||
|  | abc6c611fa | ||
|  | 7673b939a1 | ||
|  | c029bd42a7 | ||
|  | 63d051d9ba | ||
|  | 1ec5ee08aa | ||
|  | 66be8ee80e | ||
|  | d26d1b4b87 | ||
|  | 3716b50616 | ||
|  | 5e398bd07a | ||
|  | 2ee000debb | ||
|  | b8e33201bd | ||
|  | 1c33be4828 | ||
|  | c40229e9fa | ||
|  | b7ec7625c0 | ||
|  | 64170d4957 | ||
|  | d82c3b55e0 | ||
|  | 01800a3534 | ||
|  | 01404bf9cd | ||
|  | 2f9d73c0b3 | ||
|  | 670c2e4872 | ||
|  | 1261122a57 | ||
|  | 2a17ec9280 | ||
|  | 1424410115 | ||
|  | f20eccf279 | ||
|  | c18cbe1d26 | ||
|  | d5a3ae43e0 | ||
|  | 767abacd27 | ||
|  | 2b3172ba8e | ||
|  | 1ff8a48ca3 | ||
|  | 5b7645b6d5 | ||
|  | ae82474b19 | ||
|  | d38c59c5b1 | ||
|  | a4205afb7b | ||
|  | 75e187ee34 | ||
|  | a37ed82bb4 | ||
|  | a7233de561 | ||
|  | e87c5eee6b | ||
|  | 7a75290709 | ||
|  | 981f6df9ee | ||
|  | c4572c66d3 | ||
|  | 8e7d750a5a | ||
|  | 94961466f9 | ||
|  | 0f3fe45b06 | ||
|  | 0650457ea5 | ||
|  | 2e1ce03f13 | ||
|  | 9b345db623 | ||
|  | c1afcc5219 | ||
|  | fb394b7f45 | ||
|  | 381598f1bb | ||
|  | 25b7a76da9 | ||
|  | 4b03ebe3cb | ||
|  | 664c59136a | ||
|  | 27b61aae73 | ||
|  | d90fcd1889 | ||
|  | 979d5c579b | ||
|  | 5124ca1738 | ||
|  | ac5d9b656a | ||
|  | 9a02739251 | ||
|  | 4af2aadc48 | ||
|  | 84779b8d02 | ||
|  | 145e8d23f0 | ||
|  | d0ba0583a5 | ||
|  | 17d8b54280 | ||
|  | 2cf0bfe3c4 | ||
|  | 070a8cf148 | ||
|  | f94c21446a | ||
|  | 1ef1873016 | ||
|  | 32e4e29e7c | ||
|  | 65ca0dd9e0 | ||
|  | 3385e12c01 | ||
|  | 3566a4afa3 | ||
|  | 68ff033342 | ||
|  | f141b0be5c | ||
|  | d399dd160f | ||
|  | 4c8ed784cd | ||
|  | fb3402acd4 | ||
|  | 8cad430816 | ||
|  | 01502b456e | ||
|  | 9b6314066b | ||
|  | e61dadcbc6 | ||
|  | f7baf5b2fd | ||
|  | 0545826d57 | ||
|  | a29904704c | ||
|  | 899d374222 | ||
|  | 07ff2305fd | ||
|  | ee96dd3ab6 | ||
|  | a766d3a133 | ||
|  | 67545b0371 | ||
|  | 6b86d825ea | ||
|  | 31dbc57e8b | ||
|  | 00050f629c | ||
|  | 3760aabf13 | ||
|  | 22e092b513 | ||
|  | a4f7c90e09 | ||
|  | 4b92ab46a3 | ||
|  | 0573bf2402 | ||
|  | e28e538272 | ||
|  | 6f8f175890 | ||
|  | fbf9ab6c5f | ||
|  | 3c67175e68 | ||
|  | b0d25a1d33 | ||
|  | 9ea8709835 | ||
|  | ae22c59f21 | ||
|  | 12b8ba68b3 | ||
|  | 6b086c9bff | ||
|  | 546a1198a1 | ||
|  | 1001e04b63 | ||
|  | 2c96729d76 | ||
|  | 194d22ad90 | ||
|  | 51e86448c7 | ||
|  | e42107c03c | ||
|  | abd9260193 | ||
|  | 042e2ba97d | ||
|  | d5240f7afd | ||
|  | cda90df995 | ||
|  | 446e855b74 | ||
|  | fb31f25d71 | ||
|  | ba43d8c3f5 | ||
|  | 3924781797 | ||
|  | b99a6a9fc9 | ||
|  | 2967f4d4c7 | ||
|  | 285eeb1d12 | ||
|  | 6374215ebc | ||
|  | 8f0c0f215c | ||
|  | 5fc764e72b | ||
|  | b330313c55 | ||
|  | aa9ce73758 | ||
|  | d97fda41b2 | ||
|  | 945ad79c03 | ||
|  | 6273807525 | ||
|  | 50803a2c24 | ||
|  | a0e9b05680 | ||
|  | 41e74cd816 | ||
|  | b379c8e36b | ||
|  | 76e893f86e | ||
|  | 5da1599959 | ||
|  | 1d997e7c86 | ||
|  | 35e2eba303 | ||
|  | b50f8f8ecd | ||
|  | c16d3be85f | ||
|  | bd1232644f | ||
|  | 37ca460ff2 | ||
|  | 478acdc847 | ||
|  | f9ec94ea97 | ||
|  | 576c5f242c | ||
|  | dba8bba41a | ||
|  | 55a00aa6fe | ||
|  | 22133f64cf | ||
|  | 2efb2377b6 | ||
|  | 9f75a96ad6 | ||
|  | d0be9bb957 | ||
|  | c25adf0a56 | ||
|  | 0ca79fd843 | ||
|  | efc516eb3b | ||
|  | dca3ac9250 | ||
|  | 33668a3688 | ||
|  | 5414a70abb | ||
|  | 85aee63d1e | ||
|  | ad09c851f6 | ||
|  | c57f36820b | ||
|  | 6bb2702e07 | ||
|  | b1dbd3ee17 | ||
|  | 2d41db349a | ||
|  | 6b73b9327a | ||
|  | e3ea54329d | ||
|  | 686a76f32c | ||
|  | cdafb82a49 | ||
|  | 0075f10f98 | ||
|  | b70c0e4ab3 | ||
|  | 01aca092a1 | ||
|  | 8e6449ec12 | ||
|  | 984c4e2449 | ||
|  | 002c5485f5 | ||
|  | 12d74f15c0 | ||
|  | 2e87e179f0 | ||
|  | a861126c0f | ||
|  | 8f5e58e8ad | ||
|  | 6c26f1f677 | ||
|  | d7caaca5e4 | ||
|  | 835c81f329 | ||
|  | 1615b0cb29 | ||
|  | c07a279c81 | ||
|  | 1478dae316 | ||
|  | 83a1e6616a | ||
|  | 66bd786842 | ||
|  | 33d73d8be8 | ||
|  | 75e190ba64 | ||
|  | 820569a52b | ||
|  | 05005eac32 | ||
|  | 5aa677c6fb | ||
|  | 456a3a9216 | ||
|  | be25a7596f | ||
|  | 59a07e5dde | ||
|  | 6946a815e2 | ||
|  | 4a84e94022 | ||
|  | 5ba5d1f90e | ||
|  | beb2bbcdc9 | ||
|  | 805fd5ae08 | ||
|  | 96093e313a | ||
|  | afe9e88f9a | ||
|  | b43048c674 | ||
|  | 11c38a599b | ||
|  | 0ce245f480 | ||
|  | aef15cf3d3 | ||
|  | d1880de30e | ||
|  | 9d900a69ed | ||
|  | 1653f77b15 | ||
|  | 9418436d51 | ||
|  | 1c9a6a194a | ||
|  | 11cfb5a962 | ||
|  | 7d21467447 | ||
|  | 5ce9f32deb | ||
|  | 337440259f | ||
|  | c483e0768f | ||
|  | fd9b0d9417 | ||
|  | c3165f4937 | ||
|  | a5c9adc872 | ||
|  | 59cc007931 | ||
|  | 8b0b12b521 | ||
|  | 6ae1cfd82e | ||
|  | 4d7eb27fd0 | ||
|  | fe0b8d0128 | ||
|  | 04f0fcfbf7 | ||
|  | 7e182cf070 | ||
|  | ad78c302ef | ||
|  | 36b4c69491 | ||
|  | 30bd0711f4 | ||
|  | d847827584 | ||
|  | 786c1fcd58 | ||
|  | 90e7f0c0f7 | ||
|  | 63f334abe5 | ||
|  | 2466cd942f | ||
|  | ea37db87f4 | ||
|  | c168fb6960 | ||
|  | 03fb707b93 | ||
|  | db226c2584 | ||
|  | 1c6ec82c91 | ||
|  | 40eb77ffde | ||
|  | 17ddb01cd1 | ||
|  | ca56c7af70 | ||
|  | 55c428070f | ||
|  | 574eec1c08 | ||
|  | 15cde8173e | ||
|  | ccb581b4ee | ||
|  | c5f8db5b50 | ||
|  | 611748fbaf | ||
|  | b57dfa9432 | ||
|  | 253982d579 | ||
|  | 94c7a19aa0 | ||
|  | e9b360a721 | ||
|  | ebf7f5932a | ||
|  | 4427f2fb99 | ||
|  | 6626dfbac3 | ||
|  | 093a6387a2 | ||
|  | 21ddde9e0d | ||
|  | 44d4e4e6da | ||
|  | e34e53eeb3 | ||
|  | 07fb45bb34 | ||
|  | d381669733 | ||
|  | fb9eb15ae1 | ||
|  | a2127c382b | ||
|  | e10d39c093 | ||
|  | a933b49e7c | ||
|  | 38bcd610df | ||
|  | 5beb476a28 | ||
|  | 3a43ce6546 | ||
|  | c11fddb097 | ||
|  | 98f79cd9bf | ||
|  | a3d3fe758b | ||
|  | 93587cf1b6 | ||
|  | 361e95f102 | ||
|  | be212e7d1d | ||
|  | 003a30727f | ||
|  | 27b662e2dc | ||
|  | 0b4d7ad95e | ||
|  | 7acbfb230a | ||
|  | b974310798 | ||
|  | e391725eed | ||
|  | f505580b33 | ||
|  | 270f932a48 | ||
|  | b9afa908e3 | ||
|  | 6dcc78b9e5 | ||
|  | 7b0e7e8612 | ||
|  | 1ece4abd9d | ||
|  | 07c03b672b | ||
|  | 27ea50ec16 | ||
|  | e1195e6663 | ||
|  | faeb17f319 | ||
|  | db91b1b127 | ||
|  | b5b511c86b | ||
|  | 8c805fe0c9 | ||
|  | b0672eb294 | ||
|  | 750019808c | ||
|  | 7f4510467f | ||
|  | a46f8430df | ||
|  | 5e1ecb2b11 | ||
|  | 4fff59f16b | ||
|  | eea8f5e07e | ||
|  | a3fcd636e7 | ||
|  | de6dc19077 | ||
|  | 7a8e3aca03 | ||
|  | 076047ad24 | ||
|  | a4e1c8c24f | ||
|  | 3bf1c0075e | ||
|  | 1821ade319 | ||
|  | dcd4f072d5 | ||
|  | 1734c7f545 | ||
|  | aef3d340ae | ||
|  | e39d4bc288 | ||
|  | ed35b0f81a | ||
|  | 4805c9e1c9 | ||
|  | eebcbe0f67 | ||
|  | 61e2b79357 | ||
|  | fd3b03d3de | ||
|  | 9423a28158 | ||
|  | 55062068fd | ||
|  | 542b6f670d | ||
|  | 5b163b42b4 | ||
|  | 613dce51fb | ||
|  | 40adb5b203 | ||
|  | fba796fa84 | ||
|  | db4c3f9bfa | ||
|  | d960cc6ad7 | ||
|  | c620ec1f24 | ||
|  | 2d78bba6f4 | ||
|  | b7a3f5d740 | ||
|  | 96def3c5d4 | ||
|  | e1941d9d87 | ||
|  | a30cf03678 | ||
|  | aa0dcd3b7e | ||
|  | 810e92f7a3 | ||
|  | 5dd49fc1e1 | ||
|  | 8517af105d | ||
|  | 442cf7f9b3 | ||
|  | 82878b5214 | ||
|  | b0f1102540 | ||
|  | 2efee7e6de | ||
|  | abcecc7476 | ||
|  | c28005f649 | ||
|  | a369e61f18 | ||
|  | 05d82b6c05 | ||
|  | 68ca8fd250 | ||
|  | b55b565ee5 | ||
|  | fc98d66ef4 | ||
|  | f6642c075d | ||
|  | 458a337521 | ||
|  | 37d2299a1d | ||
|  | f69cffc50b | ||
|  | fd77a17ba5 | ||
|  | b481cf53e7 | ||
|  | a4a4590c45 | ||
|  | 9e398beb07 | ||
|  | 38ae3df423 | ||
|  | 2f17701b68 | ||
|  | 4c797c1d4c | ||
|  | a8e1c22c93 | ||
|  | b60021e0ce | ||
|  | 453ccd3271 | ||
|  | 08f13aebe3 | ||
|  | 26df1be871 | ||
|  | fe2def9684 | ||
|  | db2cab3cef | ||
|  | d84405191f | ||
|  | 349d32a268 | ||
|  | 30b7e17b6f | ||
|  | 2d3d3bc0a4 | ||
|  | a4f887921a | ||
|  | 710732d7f5 | ||
|  | cd08c16dee | ||
|  | a8f36a2490 | ||
|  | 7f12d06989 | ||
|  | 8eb0313841 | ||
|  | 113eb84461 | ||
|  | cdf42e50f0 | ||
|  | e59cf03d80 | ||
|  | 0bd0e6caeb | ||
|  | 605623a7af | ||
|  | 042d055d85 | ||
|  | cc29d0a850 | ||
|  | 7dede49aee | ||
|  | 775282ae02 | ||
|  | e49806078a | ||
|  | 71d8c0d219 | ||
|  | 0031c5a5ad | ||
|  | 3ce111550e | ||
|  | 58af83cc8c | ||
|  | 422a23e700 | ||
|  | 8c2672cdf8 | ||
|  | 764e49985b | ||
|  | 84251f8f10 | ||
|  | 3d878cb5dd | ||
|  | 8b4740d28c | ||
|  | 0845e265c2 | ||
|  | b4455a3802 | ||
|  | 8d12d47691 | ||
|  | 3dc01b0d5c | ||
|  | b442645280 | ||
|  | eda2b5f822 | ||
|  | d9593db5e2 | ||
|  | 9dcb8e2680 | ||
|  | 56bac9fc97 | ||
|  | f7ad9c56c8 | ||
|  | 0086a0ddc8 | ||
|  | 25ebfd6978 | ||
|  | de8149137a | ||
|  | 79ae110368 | ||
|  | 60aef0de1a | ||
|  | 8d464962a8 | ||
|  | b93cfc5de2 | 
| @@ -19,26 +19,24 @@ | ||||
|  * along with this program.  If not, see <https://www.gnu.org/licenses/>. | ||||
|  */ | ||||
| 
 | ||||
| use PhpCsFixer\Runner\Parallel\ParallelConfigFactory; | ||||
| 
 | ||||
| $current = __DIR__; | ||||
| 
 | ||||
| $paths = [ | ||||
|     $current . '/../../app', | ||||
|     $current . '/../../config', | ||||
|     $current . '/../../database', | ||||
|     $current . '/../../routes', | ||||
|     $current . '/../../tests', | ||||
|     $current . '/../../resources/lang/en_US', | ||||
| ]; | ||||
| 
 | ||||
| $finder = PhpCsFixer\Finder::create() | ||||
|                            ->in($paths); | ||||
| 
 | ||||
| 
 | ||||
| $config = new PhpCsFixer\Config(); | ||||
| $config->setParallelConfig(ParallelConfigFactory::detect()); | ||||
| $config = (new PhpCsFixer\Config()) | ||||
|         ->setParallelConfig(PhpCsFixer\Runner\Parallel\ParallelConfigFactory::detect()) | ||||
|         ; | ||||
| return $config->setRules( | ||||
| 
 | ||||
|     [ | ||||
|         // rule sets
 | ||||
|         '@PHP83Migration'               => true, | ||||
| @@ -61,9 +59,15 @@ return $config->setRules( | ||||
|         'comment_to_phpdoc'             => false, // breaks phpstan lines in combination with PHPStorm.
 | ||||
|         'type_declaration_spaces'       => false, | ||||
|         'cast_spaces'                   => false, | ||||
|         'phpdoc_to_comment' => false, // do not overrule single line comment style, breaks phpstan.
 | ||||
| 
 | ||||
|         // enabled rules
 | ||||
|         'global_namespace_import' => true, // matches with rector.
 | ||||
| 
 | ||||
|         // complex rules
 | ||||
|         'phpdoc_to_comment' => ['ignored_tags' => ['var']], | ||||
|         'php_unit_test_case_static_method_calls' => [ | ||||
|             'call_type' => 'this', | ||||
|         ], | ||||
|         'array_syntax'                  => ['syntax' => 'short'], | ||||
|         'binary_operator_spaces'        => [ | ||||
|             'default'   => 'at_least_single_space', | ||||
| @@ -73,5 +77,7 @@ return $config->setRules( | ||||
|                 '??=' => 'align_single_space_minimal_by_scope', | ||||
|             ], | ||||
|         ], | ||||
|     ]) | ||||
|     ] | ||||
| 
 | ||||
| ) | ||||
|               ->setFinder($finder); | ||||
|   | ||||
							
								
								
									
										232
									
								
								.ci/php-cs-fixer/composer.lock
									
									
									
										generated
									
									
									
								
							
							
						
						
									
										232
									
								
								.ci/php-cs-fixer/composer.lock
									
									
									
										generated
									
									
									
								
							| @@ -406,57 +406,59 @@ | ||||
|         }, | ||||
|         { | ||||
|             "name": "friendsofphp/php-cs-fixer", | ||||
|             "version": "v3.69.1", | ||||
|             "version": "v3.84.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer.git", | ||||
|                 "reference": "13b0c0eede38c11cd674b080f2b485d0f14ffa9f" | ||||
|                 "reference": "38dad0767bf2a9b516b976852200ae722fe984ca" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/PHP-CS-Fixer/PHP-CS-Fixer/zipball/13b0c0eede38c11cd674b080f2b485d0f14ffa9f", | ||||
|                 "reference": "13b0c0eede38c11cd674b080f2b485d0f14ffa9f", | ||||
|                 "url": "https://api.github.com/repos/PHP-CS-Fixer/PHP-CS-Fixer/zipball/38dad0767bf2a9b516b976852200ae722fe984ca", | ||||
|                 "reference": "38dad0767bf2a9b516b976852200ae722fe984ca", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
|                 "clue/ndjson-react": "^1.0", | ||||
|                 "composer/semver": "^3.4", | ||||
|                 "composer/xdebug-handler": "^3.0.3", | ||||
|                 "composer/xdebug-handler": "^3.0.5", | ||||
|                 "ext-filter": "*", | ||||
|                 "ext-hash": "*", | ||||
|                 "ext-json": "*", | ||||
|                 "ext-tokenizer": "*", | ||||
|                 "fidry/cpu-core-counter": "^1.2", | ||||
|                 "php": "^7.4 || ^8.0", | ||||
|                 "react/child-process": "^0.6.5", | ||||
|                 "react/child-process": "^0.6.6", | ||||
|                 "react/event-loop": "^1.0", | ||||
|                 "react/promise": "^2.0 || ^3.0", | ||||
|                 "react/promise": "^2.11 || ^3.0", | ||||
|                 "react/socket": "^1.0", | ||||
|                 "react/stream": "^1.0", | ||||
|                 "sebastian/diff": "^4.0 || ^5.1 || ^6.0 || ^7.0", | ||||
|                 "symfony/console": "^5.4 || ^6.4 || ^7.0", | ||||
|                 "symfony/event-dispatcher": "^5.4 || ^6.4 || ^7.0", | ||||
|                 "symfony/filesystem": "^5.4 || ^6.4 || ^7.0", | ||||
|                 "symfony/finder": "^5.4 || ^6.4 || ^7.0", | ||||
|                 "symfony/options-resolver": "^5.4 || ^6.4 || ^7.0", | ||||
|                 "symfony/polyfill-mbstring": "^1.31", | ||||
|                 "symfony/polyfill-php80": "^1.31", | ||||
|                 "symfony/polyfill-php81": "^1.31", | ||||
|                 "symfony/process": "^5.4 || ^6.4 || ^7.2", | ||||
|                 "symfony/stopwatch": "^5.4 || ^6.4 || ^7.0" | ||||
|                 "sebastian/diff": "^4.0.6 || ^5.1.1 || ^6.0.2 || ^7.0", | ||||
|                 "symfony/console": "^5.4.45 || ^6.4.13 || ^7.0", | ||||
|                 "symfony/event-dispatcher": "^5.4.45 || ^6.4.13 || ^7.0", | ||||
|                 "symfony/filesystem": "^5.4.45 || ^6.4.13 || ^7.0", | ||||
|                 "symfony/finder": "^5.4.45 || ^6.4.17 || ^7.0", | ||||
|                 "symfony/options-resolver": "^5.4.45 || ^6.4.16 || ^7.0", | ||||
|                 "symfony/polyfill-mbstring": "^1.32", | ||||
|                 "symfony/polyfill-php80": "^1.32", | ||||
|                 "symfony/polyfill-php81": "^1.32", | ||||
|                 "symfony/process": "^5.4.47 || ^6.4.20 || ^7.2", | ||||
|                 "symfony/stopwatch": "^5.4.45 || ^6.4.19 || ^7.0" | ||||
|             }, | ||||
|             "require-dev": { | ||||
|                 "facile-it/paraunit": "^1.3.1 || ^2.5", | ||||
|                 "infection/infection": "^0.29.10", | ||||
|                 "justinrainbow/json-schema": "^5.3 || ^6.0", | ||||
|                 "keradus/cli-executor": "^2.1", | ||||
|                 "facile-it/paraunit": "^1.3.1 || ^2.6", | ||||
|                 "infection/infection": "^0.29.14", | ||||
|                 "justinrainbow/json-schema": "^5.3 || ^6.4", | ||||
|                 "keradus/cli-executor": "^2.2", | ||||
|                 "mikey179/vfsstream": "^1.6.12", | ||||
|                 "php-coveralls/php-coveralls": "^2.7", | ||||
|                 "php-coveralls/php-coveralls": "^2.8", | ||||
|                 "php-cs-fixer/accessible-object": "^1.1", | ||||
|                 "php-cs-fixer/phpunit-constraint-isidenticalstring": "^1.6", | ||||
|                 "php-cs-fixer/phpunit-constraint-xmlmatchesxsd": "^1.6", | ||||
|                 "phpunit/phpunit": "^9.6.22 || ^10.5.45 || ^11.5.7", | ||||
|                 "symfony/var-dumper": "^5.4.48 || ^6.4.18 || ^7.2.0", | ||||
|                 "symfony/yaml": "^5.4.45 || ^6.4.18 || ^7.2.0" | ||||
|                 "phpunit/phpunit": "^9.6.23 || ^10.5.47 || ^11.5.25", | ||||
|                 "symfony/polyfill-php84": "^1.32", | ||||
|                 "symfony/var-dumper": "^5.4.48 || ^6.4.23 || ^7.3.1", | ||||
|                 "symfony/yaml": "^5.4.45 || ^6.4.23 || ^7.3.1" | ||||
|             }, | ||||
|             "suggest": { | ||||
|                 "ext-dom": "For handling output formats in XML", | ||||
| @@ -497,7 +499,7 @@ | ||||
|             ], | ||||
|             "support": { | ||||
|                 "issues": "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues", | ||||
|                 "source": "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/tree/v3.69.1" | ||||
|                 "source": "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/tree/v3.84.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -505,7 +507,7 @@ | ||||
|                     "type": "github" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2025-02-18T23:57:43+00:00" | ||||
|             "time": "2025-07-15T18:21:57+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "psr/container", | ||||
| @@ -1255,23 +1257,24 @@ | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/console", | ||||
|             "version": "v7.2.1", | ||||
|             "version": "v7.3.1", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/console.git", | ||||
|                 "reference": "fefcc18c0f5d0efe3ab3152f15857298868dc2c3" | ||||
|                 "reference": "9e27aecde8f506ba0fd1d9989620c04a87697101" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/symfony/console/zipball/fefcc18c0f5d0efe3ab3152f15857298868dc2c3", | ||||
|                 "reference": "fefcc18c0f5d0efe3ab3152f15857298868dc2c3", | ||||
|                 "url": "https://api.github.com/repos/symfony/console/zipball/9e27aecde8f506ba0fd1d9989620c04a87697101", | ||||
|                 "reference": "9e27aecde8f506ba0fd1d9989620c04a87697101", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
|                 "php": ">=8.2", | ||||
|                 "symfony/deprecation-contracts": "^2.5|^3", | ||||
|                 "symfony/polyfill-mbstring": "~1.0", | ||||
|                 "symfony/service-contracts": "^2.5|^3", | ||||
|                 "symfony/string": "^6.4|^7.0" | ||||
|                 "symfony/string": "^7.2" | ||||
|             }, | ||||
|             "conflict": { | ||||
|                 "symfony/dependency-injection": "<6.4", | ||||
| @@ -1328,7 +1331,7 @@ | ||||
|                 "terminal" | ||||
|             ], | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/console/tree/v7.2.1" | ||||
|                 "source": "https://github.com/symfony/console/tree/v7.3.1" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -1344,20 +1347,20 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2024-12-11T03:49:26+00:00" | ||||
|             "time": "2025-06-27T19:55:54+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/deprecation-contracts", | ||||
|             "version": "v3.5.1", | ||||
|             "version": "v3.6.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/deprecation-contracts.git", | ||||
|                 "reference": "74c71c939a79f7d5bf3c1ce9f5ea37ba0114c6f6" | ||||
|                 "reference": "63afe740e99a13ba87ec199bb07bbdee937a5b62" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/symfony/deprecation-contracts/zipball/74c71c939a79f7d5bf3c1ce9f5ea37ba0114c6f6", | ||||
|                 "reference": "74c71c939a79f7d5bf3c1ce9f5ea37ba0114c6f6", | ||||
|                 "url": "https://api.github.com/repos/symfony/deprecation-contracts/zipball/63afe740e99a13ba87ec199bb07bbdee937a5b62", | ||||
|                 "reference": "63afe740e99a13ba87ec199bb07bbdee937a5b62", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
| @@ -1370,7 +1373,7 @@ | ||||
|                     "name": "symfony/contracts" | ||||
|                 }, | ||||
|                 "branch-alias": { | ||||
|                     "dev-main": "3.5-dev" | ||||
|                     "dev-main": "3.6-dev" | ||||
|                 } | ||||
|             }, | ||||
|             "autoload": { | ||||
| @@ -1395,7 +1398,7 @@ | ||||
|             "description": "A generic function and convention to trigger deprecation notices", | ||||
|             "homepage": "https://symfony.com", | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/deprecation-contracts/tree/v3.5.1" | ||||
|                 "source": "https://github.com/symfony/deprecation-contracts/tree/v3.6.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -1411,20 +1414,20 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2024-09-25T14:20:29+00:00" | ||||
|             "time": "2024-09-25T14:21:43+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/event-dispatcher", | ||||
|             "version": "v7.2.0", | ||||
|             "version": "v7.3.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/event-dispatcher.git", | ||||
|                 "reference": "910c5db85a5356d0fea57680defec4e99eb9c8c1" | ||||
|                 "reference": "497f73ac996a598c92409b44ac43b6690c4f666d" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/symfony/event-dispatcher/zipball/910c5db85a5356d0fea57680defec4e99eb9c8c1", | ||||
|                 "reference": "910c5db85a5356d0fea57680defec4e99eb9c8c1", | ||||
|                 "url": "https://api.github.com/repos/symfony/event-dispatcher/zipball/497f73ac996a598c92409b44ac43b6690c4f666d", | ||||
|                 "reference": "497f73ac996a598c92409b44ac43b6690c4f666d", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
| @@ -1475,7 +1478,7 @@ | ||||
|             "description": "Provides tools that allow your application components to communicate with each other by dispatching events and listening to them", | ||||
|             "homepage": "https://symfony.com", | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/event-dispatcher/tree/v7.2.0" | ||||
|                 "source": "https://github.com/symfony/event-dispatcher/tree/v7.3.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -1491,20 +1494,20 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2024-09-25T14:21:43+00:00" | ||||
|             "time": "2025-04-22T09:11:45+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/event-dispatcher-contracts", | ||||
|             "version": "v3.5.1", | ||||
|             "version": "v3.6.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/event-dispatcher-contracts.git", | ||||
|                 "reference": "7642f5e970b672283b7823222ae8ef8bbc160b9f" | ||||
|                 "reference": "59eb412e93815df44f05f342958efa9f46b1e586" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/symfony/event-dispatcher-contracts/zipball/7642f5e970b672283b7823222ae8ef8bbc160b9f", | ||||
|                 "reference": "7642f5e970b672283b7823222ae8ef8bbc160b9f", | ||||
|                 "url": "https://api.github.com/repos/symfony/event-dispatcher-contracts/zipball/59eb412e93815df44f05f342958efa9f46b1e586", | ||||
|                 "reference": "59eb412e93815df44f05f342958efa9f46b1e586", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
| @@ -1518,7 +1521,7 @@ | ||||
|                     "name": "symfony/contracts" | ||||
|                 }, | ||||
|                 "branch-alias": { | ||||
|                     "dev-main": "3.5-dev" | ||||
|                     "dev-main": "3.6-dev" | ||||
|                 } | ||||
|             }, | ||||
|             "autoload": { | ||||
| @@ -1551,7 +1554,7 @@ | ||||
|                 "standards" | ||||
|             ], | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/event-dispatcher-contracts/tree/v3.5.1" | ||||
|                 "source": "https://github.com/symfony/event-dispatcher-contracts/tree/v3.6.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -1567,11 +1570,11 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2024-09-25T14:20:29+00:00" | ||||
|             "time": "2024-09-25T14:21:43+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/filesystem", | ||||
|             "version": "v7.2.0", | ||||
|             "version": "v7.3.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/filesystem.git", | ||||
| @@ -1617,7 +1620,7 @@ | ||||
|             "description": "Provides basic utilities for the filesystem", | ||||
|             "homepage": "https://symfony.com", | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/filesystem/tree/v7.2.0" | ||||
|                 "source": "https://github.com/symfony/filesystem/tree/v7.3.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -1637,16 +1640,16 @@ | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/finder", | ||||
|             "version": "v7.2.2", | ||||
|             "version": "v7.3.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/finder.git", | ||||
|                 "reference": "87a71856f2f56e4100373e92529eed3171695cfb" | ||||
|                 "reference": "ec2344cf77a48253bbca6939aa3d2477773ea63d" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/symfony/finder/zipball/87a71856f2f56e4100373e92529eed3171695cfb", | ||||
|                 "reference": "87a71856f2f56e4100373e92529eed3171695cfb", | ||||
|                 "url": "https://api.github.com/repos/symfony/finder/zipball/ec2344cf77a48253bbca6939aa3d2477773ea63d", | ||||
|                 "reference": "ec2344cf77a48253bbca6939aa3d2477773ea63d", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
| @@ -1681,7 +1684,7 @@ | ||||
|             "description": "Finds files and directories via an intuitive fluent interface", | ||||
|             "homepage": "https://symfony.com", | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/finder/tree/v7.2.2" | ||||
|                 "source": "https://github.com/symfony/finder/tree/v7.3.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -1697,20 +1700,20 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2024-12-30T19:00:17+00:00" | ||||
|             "time": "2024-12-30T19:00:26+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/options-resolver", | ||||
|             "version": "v7.2.0", | ||||
|             "version": "v7.3.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/options-resolver.git", | ||||
|                 "reference": "7da8fbac9dcfef75ffc212235d76b2754ce0cf50" | ||||
|                 "reference": "afb9a8038025e5dbc657378bfab9198d75f10fca" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/symfony/options-resolver/zipball/7da8fbac9dcfef75ffc212235d76b2754ce0cf50", | ||||
|                 "reference": "7da8fbac9dcfef75ffc212235d76b2754ce0cf50", | ||||
|                 "url": "https://api.github.com/repos/symfony/options-resolver/zipball/afb9a8038025e5dbc657378bfab9198d75f10fca", | ||||
|                 "reference": "afb9a8038025e5dbc657378bfab9198d75f10fca", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
| @@ -1748,7 +1751,7 @@ | ||||
|                 "options" | ||||
|             ], | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/options-resolver/tree/v7.2.0" | ||||
|                 "source": "https://github.com/symfony/options-resolver/tree/v7.3.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -1764,11 +1767,11 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2024-11-20T11:17:29+00:00" | ||||
|             "time": "2025-04-04T13:12:05+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/polyfill-ctype", | ||||
|             "version": "v1.31.0", | ||||
|             "version": "v1.32.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/polyfill-ctype.git", | ||||
| @@ -1827,7 +1830,7 @@ | ||||
|                 "portable" | ||||
|             ], | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/polyfill-ctype/tree/v1.31.0" | ||||
|                 "source": "https://github.com/symfony/polyfill-ctype/tree/v1.32.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -1847,7 +1850,7 @@ | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/polyfill-intl-grapheme", | ||||
|             "version": "v1.31.0", | ||||
|             "version": "v1.32.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/polyfill-intl-grapheme.git", | ||||
| @@ -1905,7 +1908,7 @@ | ||||
|                 "shim" | ||||
|             ], | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/polyfill-intl-grapheme/tree/v1.31.0" | ||||
|                 "source": "https://github.com/symfony/polyfill-intl-grapheme/tree/v1.32.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -1925,7 +1928,7 @@ | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/polyfill-intl-normalizer", | ||||
|             "version": "v1.31.0", | ||||
|             "version": "v1.32.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/polyfill-intl-normalizer.git", | ||||
| @@ -1986,7 +1989,7 @@ | ||||
|                 "shim" | ||||
|             ], | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/polyfill-intl-normalizer/tree/v1.31.0" | ||||
|                 "source": "https://github.com/symfony/polyfill-intl-normalizer/tree/v1.32.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -2006,19 +2009,20 @@ | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/polyfill-mbstring", | ||||
|             "version": "v1.31.0", | ||||
|             "version": "v1.32.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/polyfill-mbstring.git", | ||||
|                 "reference": "85181ba99b2345b0ef10ce42ecac37612d9fd341" | ||||
|                 "reference": "6d857f4d76bd4b343eac26d6b539585d2bc56493" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/symfony/polyfill-mbstring/zipball/85181ba99b2345b0ef10ce42ecac37612d9fd341", | ||||
|                 "reference": "85181ba99b2345b0ef10ce42ecac37612d9fd341", | ||||
|                 "url": "https://api.github.com/repos/symfony/polyfill-mbstring/zipball/6d857f4d76bd4b343eac26d6b539585d2bc56493", | ||||
|                 "reference": "6d857f4d76bd4b343eac26d6b539585d2bc56493", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
|                 "ext-iconv": "*", | ||||
|                 "php": ">=7.2" | ||||
|             }, | ||||
|             "provide": { | ||||
| @@ -2066,7 +2070,7 @@ | ||||
|                 "shim" | ||||
|             ], | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/polyfill-mbstring/tree/v1.31.0" | ||||
|                 "source": "https://github.com/symfony/polyfill-mbstring/tree/v1.32.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -2082,20 +2086,20 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2024-09-09T11:45:10+00:00" | ||||
|             "time": "2024-12-23T08:48:59+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/polyfill-php80", | ||||
|             "version": "v1.31.0", | ||||
|             "version": "v1.32.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/polyfill-php80.git", | ||||
|                 "reference": "60328e362d4c2c802a54fcbf04f9d3fb892b4cf8" | ||||
|                 "reference": "0cc9dd0f17f61d8131e7df6b84bd344899fe2608" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/symfony/polyfill-php80/zipball/60328e362d4c2c802a54fcbf04f9d3fb892b4cf8", | ||||
|                 "reference": "60328e362d4c2c802a54fcbf04f9d3fb892b4cf8", | ||||
|                 "url": "https://api.github.com/repos/symfony/polyfill-php80/zipball/0cc9dd0f17f61d8131e7df6b84bd344899fe2608", | ||||
|                 "reference": "0cc9dd0f17f61d8131e7df6b84bd344899fe2608", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
| @@ -2146,7 +2150,7 @@ | ||||
|                 "shim" | ||||
|             ], | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/polyfill-php80/tree/v1.31.0" | ||||
|                 "source": "https://github.com/symfony/polyfill-php80/tree/v1.32.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -2162,11 +2166,11 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2024-09-09T11:45:10+00:00" | ||||
|             "time": "2025-01-02T08:10:11+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/polyfill-php81", | ||||
|             "version": "v1.31.0", | ||||
|             "version": "v1.32.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/polyfill-php81.git", | ||||
| @@ -2222,7 +2226,7 @@ | ||||
|                 "shim" | ||||
|             ], | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/polyfill-php81/tree/v1.31.0" | ||||
|                 "source": "https://github.com/symfony/polyfill-php81/tree/v1.32.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -2242,16 +2246,16 @@ | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/process", | ||||
|             "version": "v7.2.0", | ||||
|             "version": "v7.3.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/process.git", | ||||
|                 "reference": "d34b22ba9390ec19d2dd966c40aa9e8462f27a7e" | ||||
|                 "reference": "40c295f2deb408d5e9d2d32b8ba1dd61e36f05af" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/symfony/process/zipball/d34b22ba9390ec19d2dd966c40aa9e8462f27a7e", | ||||
|                 "reference": "d34b22ba9390ec19d2dd966c40aa9e8462f27a7e", | ||||
|                 "url": "https://api.github.com/repos/symfony/process/zipball/40c295f2deb408d5e9d2d32b8ba1dd61e36f05af", | ||||
|                 "reference": "40c295f2deb408d5e9d2d32b8ba1dd61e36f05af", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
| @@ -2283,7 +2287,7 @@ | ||||
|             "description": "Executes commands in sub-processes", | ||||
|             "homepage": "https://symfony.com", | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/process/tree/v7.2.0" | ||||
|                 "source": "https://github.com/symfony/process/tree/v7.3.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -2299,20 +2303,20 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2024-11-06T14:24:19+00:00" | ||||
|             "time": "2025-04-17T09:11:12+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/service-contracts", | ||||
|             "version": "v3.5.1", | ||||
|             "version": "v3.6.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/service-contracts.git", | ||||
|                 "reference": "e53260aabf78fb3d63f8d79d69ece59f80d5eda0" | ||||
|                 "reference": "f021b05a130d35510bd6b25fe9053c2a8a15d5d4" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/symfony/service-contracts/zipball/e53260aabf78fb3d63f8d79d69ece59f80d5eda0", | ||||
|                 "reference": "e53260aabf78fb3d63f8d79d69ece59f80d5eda0", | ||||
|                 "url": "https://api.github.com/repos/symfony/service-contracts/zipball/f021b05a130d35510bd6b25fe9053c2a8a15d5d4", | ||||
|                 "reference": "f021b05a130d35510bd6b25fe9053c2a8a15d5d4", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
| @@ -2330,7 +2334,7 @@ | ||||
|                     "name": "symfony/contracts" | ||||
|                 }, | ||||
|                 "branch-alias": { | ||||
|                     "dev-main": "3.5-dev" | ||||
|                     "dev-main": "3.6-dev" | ||||
|                 } | ||||
|             }, | ||||
|             "autoload": { | ||||
| @@ -2366,7 +2370,7 @@ | ||||
|                 "standards" | ||||
|             ], | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/service-contracts/tree/v3.5.1" | ||||
|                 "source": "https://github.com/symfony/service-contracts/tree/v3.6.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -2382,20 +2386,20 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2024-09-25T14:20:29+00:00" | ||||
|             "time": "2025-04-25T09:37:31+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/stopwatch", | ||||
|             "version": "v7.2.2", | ||||
|             "version": "v7.3.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/stopwatch.git", | ||||
|                 "reference": "e46690d5b9d7164a6d061cab1e8d46141b9f49df" | ||||
|                 "reference": "5a49289e2b308214c8b9c2fda4ea454d8b8ad7cd" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/symfony/stopwatch/zipball/e46690d5b9d7164a6d061cab1e8d46141b9f49df", | ||||
|                 "reference": "e46690d5b9d7164a6d061cab1e8d46141b9f49df", | ||||
|                 "url": "https://api.github.com/repos/symfony/stopwatch/zipball/5a49289e2b308214c8b9c2fda4ea454d8b8ad7cd", | ||||
|                 "reference": "5a49289e2b308214c8b9c2fda4ea454d8b8ad7cd", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
| @@ -2428,7 +2432,7 @@ | ||||
|             "description": "Provides a way to profile code", | ||||
|             "homepage": "https://symfony.com", | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/stopwatch/tree/v7.2.2" | ||||
|                 "source": "https://github.com/symfony/stopwatch/tree/v7.3.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -2444,20 +2448,20 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2024-12-18T14:28:33+00:00" | ||||
|             "time": "2025-02-24T10:49:57+00:00" | ||||
|         }, | ||||
|         { | ||||
|             "name": "symfony/string", | ||||
|             "version": "v7.2.0", | ||||
|             "version": "v7.3.0", | ||||
|             "source": { | ||||
|                 "type": "git", | ||||
|                 "url": "https://github.com/symfony/string.git", | ||||
|                 "reference": "446e0d146f991dde3e73f45f2c97a9faad773c82" | ||||
|                 "reference": "f3570b8c61ca887a9e2938e85cb6458515d2b125" | ||||
|             }, | ||||
|             "dist": { | ||||
|                 "type": "zip", | ||||
|                 "url": "https://api.github.com/repos/symfony/string/zipball/446e0d146f991dde3e73f45f2c97a9faad773c82", | ||||
|                 "reference": "446e0d146f991dde3e73f45f2c97a9faad773c82", | ||||
|                 "url": "https://api.github.com/repos/symfony/string/zipball/f3570b8c61ca887a9e2938e85cb6458515d2b125", | ||||
|                 "reference": "f3570b8c61ca887a9e2938e85cb6458515d2b125", | ||||
|                 "shasum": "" | ||||
|             }, | ||||
|             "require": { | ||||
| @@ -2515,7 +2519,7 @@ | ||||
|                 "utf8" | ||||
|             ], | ||||
|             "support": { | ||||
|                 "source": "https://github.com/symfony/string/tree/v7.2.0" | ||||
|                 "source": "https://github.com/symfony/string/tree/v7.3.0" | ||||
|             }, | ||||
|             "funding": [ | ||||
|                 { | ||||
| @@ -2531,7 +2535,7 @@ | ||||
|                     "type": "tidelift" | ||||
|                 } | ||||
|             ], | ||||
|             "time": "2024-11-13T13:31:26+00:00" | ||||
|             "time": "2025-04-20T20:19:01+00:00" | ||||
|         } | ||||
|     ], | ||||
|     "packages-dev": [], | ||||
|   | ||||
| @@ -28,7 +28,8 @@ composer update --quiet | ||||
| rm -f .php-cs-fixer.cache | ||||
| PHP_CS_FIXER_IGNORE_ENV=true ./vendor/bin/php-cs-fixer fix \ | ||||
|     --config $SCRIPT_DIR/php-cs-fixer/.php-cs-fixer.php \ | ||||
|     --format=txt -v \ | ||||
|     --format=txt \ | ||||
|     -v \ | ||||
|     --allow-risky=yes | ||||
|  | ||||
| EXIT_CODE=$? | ||||
|   | ||||
							
								
								
									
										82
									
								
								.ci/rector.php
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										82
									
								
								.ci/rector.php
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,82 @@ | ||||
| <?php | ||||
| 
 | ||||
| 
 | ||||
| /* | ||||
|  * rector.php | ||||
|  * Copyright (c) 2025 james@firefly-iii.org. | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
|  * This program is free software: you can redistribute it and/or modify | ||||
|  * it under the terms of the GNU Affero General Public License as | ||||
|  * published by the Free Software Foundation, either version 3 of the | ||||
|  * License, or (at your option) any later version. | ||||
|  * | ||||
|  * This program is distributed in the hope that it will be useful, | ||||
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see https://www.gnu.org/licenses/. | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| 
 | ||||
| use Rector\Config\RectorConfig; | ||||
| use Rector\EarlyReturn\Rector\If_\ChangeOrIfContinueToMultiContinueRector; | ||||
| use Rector\Php80\Rector\ClassMethod\AddParamBasedOnParentClassMethodRector; | ||||
| use Rector\Transform\Rector\String_\StringToClassConstantRector; | ||||
| use RectorLaravel\Set\LaravelLevelSetList; | ||||
| 
 | ||||
| 
 | ||||
| return RectorConfig::configure() | ||||
|     ->withSkip([ | ||||
|         ChangeOrIfContinueToMultiContinueRector::class, | ||||
|         AddParamBasedOnParentClassMethodRector::class, | ||||
|         StringToClassConstantRector::class => [ | ||||
|             __DIR__ . '/../app/Http/Controllers/Auth/LoginController.php', | ||||
|         ], | ||||
|         __DIR__.'/../bootstrap/cache/*' | ||||
|     ]) | ||||
|     ->withPaths([ | ||||
|         __DIR__ . '/../app', | ||||
|         __DIR__ . '/../bootstrap', | ||||
|         __DIR__ . '/../config', | ||||
|         __DIR__ . '/../public', | ||||
|         __DIR__ . '/../resources/lang/en_US', | ||||
|         __DIR__ . '/../routes', | ||||
|         __DIR__ . '/../tests', | ||||
|     ]) | ||||
|     ->withSets([ | ||||
|         LaravelLevelSetList::UP_TO_LARAVEL_120, | ||||
|     ]) | ||||
| //    ->withConfiguredRule(ReplaceServiceContainerCallArgRector::class, [
 | ||||
| //        new ReplaceServiceContainerCallArg('log', new ClassConstFetch(new Name('Illuminate\Support\Facades\Log'), 'class')),
 | ||||
| //    ])
 | ||||
|     // uncomment to reach your current PHP version
 | ||||
|     ->withPhpSets() | ||||
|     ->withPreparedSets( | ||||
|         codingStyle: false, // leave false
 | ||||
|         privatization: false, // leave false.
 | ||||
|         naming: false, // leave false
 | ||||
|         instanceOf: true, | ||||
|         earlyReturn: true, | ||||
|         strictBooleans: true, | ||||
|         carbon: true, | ||||
|         rectorPreset: true, | ||||
|         phpunitCodeQuality: true, | ||||
|         doctrineCodeQuality: true, | ||||
|         symfonyCodeQuality: true, | ||||
|         symfonyConfigs: true | ||||
| 
 | ||||
|     ) | ||||
|     ->withComposerBased( | ||||
|         twig: true, | ||||
|         doctrine: true, | ||||
|         phpunit: true, | ||||
|         symfony: true) | ||||
|     ->withTypeCoverageLevel(0) | ||||
|     ->withDeadCodeLevel(0) | ||||
|     ->withCodeQualityLevel(0) | ||||
|     ->withImportNames(removeUnusedImports: true);// import statements instead of full classes.
 | ||||
							
								
								
									
										36
									
								
								.ci/rector.sh
									
									
									
									
									
										Executable file
									
								
							
							
						
						
									
										36
									
								
								.ci/rector.sh
									
									
									
									
									
										Executable file
									
								
							| @@ -0,0 +1,36 @@ | ||||
| #!/usr/bin/env bash | ||||
|  | ||||
| # | ||||
| # phpstan.sh | ||||
| # Copyright (c) 2021 james@firefly-iii.org | ||||
| # | ||||
| # This file is part of Firefly III (https://github.com/firefly-iii). | ||||
| # | ||||
| # This program is free software: you can redistribute it and/or modify | ||||
| # it under the terms of the GNU Affero General Public License as | ||||
| # published by the Free Software Foundation, either version 3 of the | ||||
| # License, or (at your option) any later version. | ||||
| # | ||||
| # This program is distributed in the hope that it will be useful, | ||||
| # but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
| # GNU Affero General Public License for more details. | ||||
| # | ||||
| # You should have received a copy of the GNU Affero General Public License | ||||
| # along with this program.  If not, see <https://www.gnu.org/licenses/>. | ||||
| # | ||||
|  | ||||
| # Install composer packages | ||||
| #composer install --no-scripts --no-ansi | ||||
|  | ||||
| SCRIPT_DIR="$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )" | ||||
|  | ||||
| echo $1 | ||||
|  | ||||
| if [ "$1" == "--dry-run" ]; then | ||||
|     echo "Running rector in dry run." | ||||
|     $SCRIPT_DIR/../vendor/bin/rector --config $SCRIPT_DIR/rector.php --dry-run | ||||
|     exit $? | ||||
| fi | ||||
|  | ||||
| $SCRIPT_DIR/../vendor/bin/rector --config $SCRIPT_DIR/rector.php | ||||
							
								
								
									
										20
									
								
								.env.example
									
									
									
									
									
								
							
							
						
						
									
										20
									
								
								.env.example
									
									
									
									
									
								
							| @@ -164,6 +164,13 @@ MAIL_PASSWORD=null | ||||
| MAIL_ENCRYPTION=null | ||||
| MAIL_SENDMAIL_COMMAND= | ||||
|  | ||||
| # | ||||
| # If you use self-signed certificates for your STMP server, you can use the following settings. | ||||
| # | ||||
| MAIL_ALLOW_SELF_SIGNED=false | ||||
| MAIL_VERIFY_PEER=true | ||||
| MAIL_VERIFY_PEER_NAME=true | ||||
|  | ||||
| # Other mail drivers: | ||||
| # If you use Docker or similar, you can set these variables from a file by appending them with _FILE | ||||
| MAILGUN_DOMAIN= | ||||
| @@ -282,20 +289,13 @@ ALLOW_WEBHOOKS=false | ||||
| # | ||||
| # You can set this variable from a file by appending it with _FILE | ||||
| # | ||||
| STATIC_CRON_TOKEN= | ||||
| STATIC_CRON_TOKEN=PLEASE_REPLACE_WITH_32_CHAR_CODE | ||||
|  | ||||
| # You can fine tune the start-up of a Docker container by editing these environment variables. | ||||
| # Use this at your own risk. Disabling certain checks and features may result in lots of inconsistent data. | ||||
| # However if you know what you're doing you can significantly speed up container start times. | ||||
| # Set each value to true to enable, or false to disable. | ||||
|  | ||||
| # Set this to true to build all locales supported by Firefly III. | ||||
| # This may take quite some time (several minutes) and is generally not recommended. | ||||
| # If you wish to change or alter the list of locales, start your Docker container with | ||||
| # `docker run -v locale.gen:/etc/locale.gen -e DKR_BUILD_LOCALE=true` | ||||
| # and make sure your preferred locales are in your own locale.gen. | ||||
| DKR_BUILD_LOCALE=false | ||||
|  | ||||
| # Check if the SQLite database exists. Can be skipped if you're not using SQLite. | ||||
| # Won't significantly speed up things. | ||||
| DKR_CHECK_SQLITE=true | ||||
| @@ -326,10 +326,10 @@ USE_RUNNING_BALANCE=false | ||||
| FIREFLY_III_LAYOUT=v1 | ||||
|  | ||||
| # | ||||
| # Which Query Parser implementation to use for the search rngine and rules | ||||
| # Which Query Parser implementation to use for the search engine and rules | ||||
| # 'new' is experimental, 'legacy' is the classic one | ||||
| # | ||||
| QUERY_PARSER_IMPLEMENTATION=legacy | ||||
| QUERY_PARSER_IMPLEMENTATION=new | ||||
|  | ||||
| # | ||||
| # Please make sure this URL matches the external URL of your Firefly III installation. | ||||
|   | ||||
							
								
								
									
										13
									
								
								.github/ISSUE_TEMPLATE/bug.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										13
									
								
								.github/ISSUE_TEMPLATE/bug.yml
									
									
									
									
										vendored
									
									
								
							| @@ -1,4 +1,4 @@ | ||||
| name: Bug Report | ||||
| name: Bug report | ||||
| description: Report a bug in Firefly III (or associated tools) | ||||
| body: | ||||
|   - type: checkboxes | ||||
| @@ -12,7 +12,7 @@ body: | ||||
|   - type: checkboxes | ||||
|     attributes: | ||||
|       label: I've found a bug and checked that ... | ||||
|       description: Make sure that your request fulfills all of the following requirements. If one requirement cannot be satisfied, explain in detail why. | ||||
|       description: Make sure that your request fulfills all of the following requirements. If one requirement cannot be satisfied, please explain why. | ||||
|       options: | ||||
|         - label: ... [the documentation](https://docs.firefly-iii.org/) does not mention anything about my problem | ||||
|         - label: ... there are no open or closed issues that are related to my problem | ||||
| @@ -33,13 +33,6 @@ body: | ||||
|     validations: | ||||
|       required: true | ||||
|  | ||||
|   - type: textarea | ||||
|     attributes: | ||||
|       label: Expected behaviour | ||||
|       description: Please describe precisely what you'd expect to happen. Be specific. | ||||
|     validations: | ||||
|       required: false | ||||
|  | ||||
|   - type: textarea | ||||
|     attributes: | ||||
|       label: Steps to reproduce | ||||
| @@ -54,4 +47,4 @@ body: | ||||
|   - type: textarea | ||||
|     attributes: | ||||
|       label: Additional info | ||||
|       description: Please provide any additional information that seem useful. | ||||
|       description: Please provide any additional information that seems useful. | ||||
|   | ||||
							
								
								
									
										3
									
								
								.github/ISSUE_TEMPLATE/config.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										3
									
								
								.github/ISSUE_TEMPLATE/config.yml
									
									
									
									
										vendored
									
									
								
							| @@ -3,3 +3,6 @@ contact_links: | ||||
|   - name: Ask a question | ||||
|     url: https://github.com/firefly-iii/firefly-iii/discussions | ||||
|     about: Please ask and answer questions here. | ||||
|   - name: I need support!  | ||||
|     url: https://github.com/firefly-iii/firefly-iii/discussions | ||||
|     about: I think I broke something... | ||||
|   | ||||
							
								
								
									
										7
									
								
								.github/ISSUE_TEMPLATE/fr.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										7
									
								
								.github/ISSUE_TEMPLATE/fr.yml
									
									
									
									
										vendored
									
									
								
							| @@ -1,4 +1,4 @@ | ||||
| name: Feature Request | ||||
| name: Feature request | ||||
| description: Request a feature or enhancement in Firefly III (or associated tools) | ||||
| body: | ||||
|   - type: checkboxes | ||||
| @@ -31,11 +31,6 @@ body: | ||||
|     validations: | ||||
|       required: true | ||||
|  | ||||
|   - type: textarea | ||||
|     attributes: | ||||
|       label: What are alternatives? | ||||
|       description: Please describe what alternatives currently exist. | ||||
|  | ||||
|   - type: textarea | ||||
|     attributes: | ||||
|       label: Additional context | ||||
|   | ||||
							
								
								
									
										8
									
								
								.github/mergify.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										8
									
								
								.github/mergify.yml
									
									
									
									
										vendored
									
									
								
							| @@ -1,5 +1,11 @@ | ||||
| --- | ||||
| pull_request_rules: | ||||
|   - name: Make sure PR are up to date before merging | ||||
|     description: This automatically updates PRs when they are out-of-date with the | ||||
|       base branch to avoid semantic conflicts (next step is using a merge | ||||
|       queue). | ||||
|     conditions: [] | ||||
|     actions: | ||||
|       update: | ||||
|   - name: Close all on main | ||||
|     conditions: | ||||
|       - base=main | ||||
|   | ||||
							
								
								
									
										2
									
								
								.github/pull_request_template.md
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										2
									
								
								.github/pull_request_template.md
									
									
									
									
										vendored
									
									
								
							| @@ -21,5 +21,3 @@ Changes in this pull request: | ||||
| - | ||||
| - | ||||
| - | ||||
| 
 | ||||
| @JC5 | ||||
|   | ||||
							
								
								
									
										2
									
								
								.github/workflows/close-duplicates.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										2
									
								
								.github/workflows/close-duplicates.yml
									
									
									
									
										vendored
									
									
								
							| @@ -13,7 +13,7 @@ jobs: | ||||
|   close_duplicates: | ||||
|     runs-on: ubuntu-latest | ||||
|     steps: | ||||
|       - uses: github/command@v1.3.0 | ||||
|       - uses: github/command@v2.0.1 | ||||
|         id: command | ||||
|         with: | ||||
|           allowed_contexts: "issue" | ||||
|   | ||||
							
								
								
									
										338
									
								
								.github/workflows/release.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										338
									
								
								.github/workflows/release.yml
									
									
									
									
										vendored
									
									
								
							| @@ -22,32 +22,65 @@ jobs: | ||||
|         uses: actions/checkout@v4 | ||||
|         with: | ||||
|           fetch-depth: 0 | ||||
|       - name: Switch branch | ||||
|         run: | | ||||
|           if [[ "develop" == "$version" ]]; then | ||||
|             git checkout --track origin/develop | ||||
|             git pull | ||||
|           elif [[ "$version" == branch* ]]; then | ||||
|             PULLBRANCH=${version:7} | ||||
|             echo "The branch is '$PULLBRANCH' ($version)" | ||||
|             git checkout --track origin/$PULLBRANCH | ||||
|             git pull | ||||
|           else | ||||
|             git config user.name github-actions | ||||
|             git config user.email 41898282+github-actions[bot]@users.noreply.github.com | ||||
|             git checkout --track origin/develop | ||||
|             git pull | ||||
|             git checkout main | ||||
|             git merge develop | ||||
|           fi | ||||
|         env: | ||||
|           version: ${{ github.event_name == 'schedule' && 'develop' || github.event.inputs.version }} | ||||
|       - name: Import GPG key | ||||
|         uses: crazy-max/ghaction-import-gpg@v6 | ||||
|         with: | ||||
|           gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }} | ||||
|           passphrase: ${{ secrets.PASSPHRASE }} | ||||
|           git_user_signingkey: true | ||||
|           git_commit_gpgsign: true | ||||
|       - name: Setup PHP | ||||
|         uses: shivammathur/setup-php@v2 | ||||
|         with: | ||||
|           php-version: ${{ github.event.inputs.phpversion }} | ||||
|           extensions: mbstring, intl, zip, bcmath | ||||
|       - name: crowdin action | ||||
|       - name: Switch and pull | ||||
|         run: | | ||||
|           # | ||||
|           # Always check out origin/develop, unless its a branch release. | ||||
|           # | ||||
|           BRANCH_TO_PULL=origin/develop | ||||
|           if [[ "$version" == branch* ]]; then | ||||
|             BRANCH_TO_PULL=origin/$version | ||||
|           fi | ||||
|  | ||||
|           echo "Version is '$version', check out '$BRANCH_TO_PULL'-branch" | ||||
|  | ||||
|           git checkout --track $BRANCH_TO_PULL | ||||
|           git pull | ||||
|           echo "Current branch is $(git branch --show-current)" | ||||
|         env: | ||||
|           version: ${{ github.event_name == 'schedule' && 'develop' || github.event.inputs.version }} | ||||
|       - name: Configure Git | ||||
|         run: | | ||||
|           # do some configuration | ||||
|           sudo timedatectl set-timezone Europe/Amsterdam | ||||
|           git config user.name JC5 | ||||
|           git config user.email release@firefly-iii.org | ||||
|           git config advice.addIgnoredFile false | ||||
|           git config push.autoSetupRemote true | ||||
|       - name: Lint PHP | ||||
|         run: | | ||||
|           php_lint_file() | ||||
|           { | ||||
|               local php_file="$1" | ||||
|               php -l "$php_file" &> /dev/null | ||||
|               if [ "$?" -ne 0 ] | ||||
|               then | ||||
|                   echo -e "[FAIL] $php_file" | ||||
|                   return 1 | ||||
|               fi | ||||
|           } | ||||
|  | ||||
|           export -f php_lint_file | ||||
|  | ||||
|           find . -path ./vendor -prune -o -name '*.php' | parallel -j 4 php_lint_file {} | ||||
|  | ||||
|           if [ "$?" -ne 0 ] | ||||
|           then | ||||
|               exit 1 | ||||
|           fi | ||||
|       - name: Crowdin action | ||||
|         uses: crowdin/github-action@v2 | ||||
|         with: | ||||
|           upload_sources: true | ||||
| @@ -76,15 +109,6 @@ jobs: | ||||
|         env: | ||||
|           FIREFLY_III_ROOT: /github/workspace | ||||
|           GH_TOKEN: '' | ||||
|       - name: Extract changelog | ||||
|         id: extract-changelog | ||||
|         uses: JC5/firefly-iii-dev@main | ||||
|         with: | ||||
|           action: 'ff3:extract-changelog' | ||||
|           output: 'output' | ||||
|         env: | ||||
|           FIREFLY_III_ROOT: /github/workspace | ||||
|           GH_TOKEN: "" | ||||
|       - name: Replace version | ||||
|         id: replace-version | ||||
|         uses: JC5/firefly-iii-dev@main | ||||
| @@ -134,18 +158,8 @@ jobs: | ||||
|           composer update --no-dev --no-scripts --no-plugins -q | ||||
|           sudo chown -R runner:docker resources/lang | ||||
|           .ci/phpcs.sh || true | ||||
|       - name: Import GPG key | ||||
|         uses: crazy-max/ghaction-import-gpg@v6 | ||||
|         with: | ||||
|           gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }} | ||||
|           passphrase: ${{ secrets.PASSPHRASE }} | ||||
|       - name: Release | ||||
|       - name: Calculate variables | ||||
|         run: | | ||||
|           # do some configuration | ||||
|           sudo timedatectl set-timezone Europe/Amsterdam | ||||
|           git config user.name github-actions | ||||
|           git config user.email 41898282+github-actions[bot]@users.noreply.github.com | ||||
|           git config advice.addIgnoredFile false | ||||
|  | ||||
|           # set some variables | ||||
|           releaseName=$version | ||||
| @@ -153,10 +167,6 @@ jobs: | ||||
|           zipName=FireflyIII-$version.zip | ||||
|           tarName=FireflyIII-$version.tar.gz | ||||
|  | ||||
|           # update composer (again) | ||||
|           composer update --no-dev --no-scripts --no-plugins | ||||
|           composer dump-autoload | ||||
|  | ||||
|           # if this is a develop build, slightly different variable names. | ||||
|           if [[ "develop" == "$version" ]]; then | ||||
|             #[[ -z $(git status --untracked-files=normal --porcelain) ]] && echo "this branch is clean, no need to push..." && exit 0; | ||||
| @@ -191,35 +201,53 @@ jobs: | ||||
|              tagFound=false | ||||
|             fi | ||||
|           done | ||||
|           echo "Will use tag and release name $releaseName." | ||||
|  | ||||
|           # set some variables | ||||
|           echo "Release name is $releaseName." | ||||
|           echo "Original name is $originalName." | ||||
|           echo "Zip name is $zipName." | ||||
|           echo "Tar name is $tarName." | ||||
|  | ||||
|           # create a new branch to store the difference in. | ||||
|           BRANCH_NAME=release-$(date +'%s') | ||||
|           git checkout -b $BRANCH_NAME | ||||
|  | ||||
|           echo "Temporary branch name is '$BRANCH_NAME'." | ||||
|  | ||||
|           # share variables with next step. | ||||
|           echo "releaseName=$releaseName" >> "$GITHUB_ENV" | ||||
|           echo "originalName=$originalName" >> "$GITHUB_ENV" | ||||
|           echo "zipName=$zipName" >> "$GITHUB_ENV" | ||||
|           echo "tarName=$tarName" >> "$GITHUB_ENV" | ||||
|           echo "BRANCH_NAME=$BRANCH_NAME" >> "$GITHUB_ENV" | ||||
|         env: | ||||
|           version: ${{ github.event_name == 'schedule' && 'develop' || github.event.inputs.version }} | ||||
|       - name: Commit all changes | ||||
|         run: | | ||||
|           # add all content, except output.txt (this contains the changelog and/or the download instructions) | ||||
|           echo 'Add all and reset output.txt' | ||||
|           echo 'Add all' | ||||
|           git add -A | ||||
|           if test -f "output.txt"; then | ||||
|             git reset output.txt | ||||
|           fi | ||||
|           git commit -m "Auto commit for release '$version' on $(date +'%Y-%m-%d')" || true | ||||
|           # push to a new branch. | ||||
|           echo "Auto commit on branch '$(git branch --show-current)'." | ||||
|           git commit -m "🤖 Auto commit for release '$version' on $(date +'%Y-%m-%d')" || true | ||||
|           git push | ||||
|  | ||||
|           # zip and tar everything | ||||
|           echo 'Zip and tar...' | ||||
|           zip -rq $zipName . -x "*.git*" "*.ci*" "*.github*" "*node_modules*" "*output.txt*" "*Procfile*" "*crowdin.yml*" "*sonar-project.properties*" | ||||
|           touch $tarName | ||||
|           tar --exclude=$tarName --exclude=$zipName --exclude='./.git' --exclude='./.ci' --exclude='./.github' --exclude='./node_modules' --exclude='./output.txt' --exclude='./Procfile' --exclude='../crowdin.yml' --exclude='./sonar-project.properties' -czf $tarName . | ||||
|  | ||||
|           # add sha256 sum | ||||
|           echo 'Sha sum ...' | ||||
|           sha256sum -b $zipName > $zipName.sha256 | ||||
|           sha256sum -b $tarName > $tarName.sha256 | ||||
|  | ||||
|           # add signatures: | ||||
|           gpg --armor --detach-sign $zipName | ||||
|           gpg --armor --detach-sign $tarName | ||||
|         env: | ||||
|           version: ${{ github.event_name == 'schedule' && 'develop' || github.event.inputs.version }} | ||||
|       - name: Extract changelog | ||||
|         id: extract-changelog | ||||
|         uses: JC5/firefly-iii-dev@main | ||||
|         with: | ||||
|           action: 'ff3:extract-changelog' | ||||
|           output: 'output' | ||||
|         env: | ||||
|           FIREFLY_III_ROOT: /github/workspace | ||||
|           GH_TOKEN: "" | ||||
|       - name: Describe new release | ||||
|         run: | | ||||
|  | ||||
|           # describe the development release. | ||||
|           if [[ "develop" == "$version" ]]; then | ||||
|             echo 'Develop release.' | ||||
|             echo 'Describe the latest develop release' | ||||
|             rm -f output.txt | ||||
|             touch output.txt | ||||
|             sudo chown -R runner:docker output.txt | ||||
| @@ -231,10 +259,16 @@ jobs: | ||||
|             echo "* Or read the upgrade instructions for [Docker](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/docker/), [Kubernetes](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/kubernetes/) or [self-managed servers](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/self-managed/)" >> output.txt | ||||
|             echo "" >> output.txt | ||||
|             echo ":warning: Please be careful with this pre-release, as it may not work as expected." >> output.txt | ||||
|  | ||||
|             # donations! | ||||
|             echo '' >> output.txt | ||||
|             echo '### Support Firefly III' >> output.txt | ||||
|             echo 'Did you know you can support the development of Firefly III? You can donate in many ways, like GitHub Sponsors or Patreon. For more information, please [follow this link](https://bit.ly/donate-to-Firefly-III) for more information.' >> output.txt | ||||
|             echo '' >> output.txt | ||||
|           fi | ||||
|           # describe a branch release | ||||
|           if [[ "$version" == branch* ]]; then | ||||
|             echo 'Branch release.' | ||||
|             echo 'Describe a branch release' | ||||
|             rm -f output.txt | ||||
|             touch output.txt | ||||
|             sudo chown -R runner:docker output.txt | ||||
| @@ -249,20 +283,38 @@ jobs: | ||||
|           fi | ||||
|           # describe the main release | ||||
|           if [[ "develop" != "$version" ]] && [[ "$version" != branch* ]] && [[ "$version" != *alpha* ]] && [[ "$version" != *beta* ]]; then | ||||
|             echo 'Main release.' | ||||
|             echo 'Describe the latest release' | ||||
|             sudo chown -R runner:docker output.txt | ||||
|  | ||||
|             # the changelog is in output.txt | ||||
|             mv output.txt output2.txt | ||||
|  | ||||
|             touch output.txt | ||||
|             echo '' >> output.txt | ||||
|             echo "Welcome to release $version of Firefly III. It contains the the latest fixes, translations and features. Docker users can find this release under the \`latest\` tag." >> output.txt | ||||
|             echo '' >> output.txt | ||||
|  | ||||
|             # add changelog to file. | ||||
|             cat output2.txt >> output.txt | ||||
|             echo '' >> output.txt | ||||
|             rm -f output2.txt | ||||
|  | ||||
|             echo '### Instructions' >> output.txt | ||||
|             echo '' >> output.txt | ||||
|             echo "* Installation instructions for [Docker](https://docs.firefly-iii.org/how-to/firefly-iii/installation/docker/), [Portainer](https://docs.firefly-iii.org/how-to/firefly-iii/installation/portainer/), [Kubernetes](https://docs.firefly-iii.org/how-to/firefly-iii/installation/kubernetes/) or [self-managed servers](https://docs.firefly-iii.org/how-to/firefly-iii/installation/self-managed/)" >> output.txt | ||||
|             echo "* Or read the upgrade instructions for [Docker](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/docker/), [Kubernetes](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/kubernetes/) or [self-managed servers](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/self-managed/)" >> output.txt | ||||
|             echo "* The releases are signed, and you can verify them using the [Firefly III releases PGP key](https://docs.firefly-iii.org/explanation/more-information/signatures/)." >> output.txt | ||||
|  | ||||
|             # donations! | ||||
|             echo '' >> output.txt | ||||
|             echo '### Support Firefly III' >> output.txt | ||||
|             echo 'Did you know you can support the development of Firefly III? You can donate in many ways, like GitHub Sponsors or Patreon. For more information, please [follow this link](https://bit.ly/donate-to-Firefly-III) for more information.' >> output.txt | ||||
|             echo '' >> output.txt | ||||
|           fi | ||||
|  | ||||
|           # describe alpha release | ||||
|           if [[ "$version" == *alpha* ]]; then | ||||
|             echo 'ALPHA release.' | ||||
|             echo 'Describe an ALPHA release' | ||||
|             rm -f output.txt | ||||
|             touch output.txt | ||||
|             sudo chown -R runner:docker output.txt | ||||
| @@ -280,7 +332,7 @@ jobs: | ||||
|  | ||||
|           # describe beta release | ||||
|           if [[ "$version" == *beta* ]]; then | ||||
|             echo 'BETA release.' | ||||
|             echo 'Describe a BETA release' | ||||
|             rm -f output.txt | ||||
|             touch output.txt | ||||
|             sudo chown -R runner:docker output.txt | ||||
| @@ -295,55 +347,125 @@ jobs: | ||||
|             echo "* The releases are signed, and you can verify them using the [Firefly III releases PGP key](https://docs.firefly-iii.org/explanation/more-information/signatures/)." >> output.txt | ||||
|  | ||||
|           fi | ||||
|         env: | ||||
|           version: ${{ github.event_name == 'schedule' && 'develop' || github.event.inputs.version }} | ||||
|       - name: Merge all into working branch | ||||
|         run: | | ||||
|           MERGE_INTO=develop | ||||
|             if [[ "$version" == branch* ]]; then | ||||
|                 MERGE_INTO=$version | ||||
|             fi | ||||
|  | ||||
|           echo "Merge all changes from $BRANCH_NAME back into '$MERGE_INTO' using a PR" | ||||
|           PR_URL=$(gh pr create -B $MERGE_INTO -H $BRANCH_NAME --title "🤖 Automatic PR to merge all changes into the '$MERGE_INTO' branch." --body '🤖 Created by GitHub action') | ||||
|           echo "PR URL is '$PR_URL'" | ||||
|           IFS='/' read -ra parts <<< "$PR_URL" | ||||
|           PR_NR=$(printf %s\\n "${parts[@]:(-1)}") | ||||
|           echo "PR number is '$PR_NR'" | ||||
|           gh pr merge $PR_NR -b "🤖 Automatically merge the PR into the $MERGE_INTO branch." -d --merge | ||||
|  | ||||
|           # pull the changes from the $MERGE_INTO branch. | ||||
|           git checkout $MERGE_INTO | ||||
|           git merge origin/$MERGE_INTO | ||||
|           git pull | ||||
|           git status | ||||
|           echo "Current branch '$(git branch --show-current)'." | ||||
|  | ||||
|           if [[ "develop" != "$version" ]] && [[ "$version" != branch* ]]; then | ||||
|             git checkout main | ||||
|             git merge origin/main | ||||
|             git pull | ||||
|             git status | ||||
|  | ||||
|             echo "Also merge everything into main since this is a release." | ||||
|             echo 'create PR' | ||||
|             PR_URL=$(gh pr create -B main -H develop --title "🤖 Automatic PR to merge all changes into the main branch." --body "🤖 Created by GitHub action") | ||||
|             echo "PR URL is '$PR_URL'" | ||||
|  | ||||
|             IFS='/' read -ra parts <<< "$PR_URL" | ||||
|             PR_NR=$(printf %s\\n "${parts[@]:(-1)}") | ||||
|             echo "PR number is '$PR_NR'" | ||||
|  | ||||
|             echo 'Merge PR' | ||||
|             gh pr merge $PR_NR -b "🤖 Automatically merge the PR into the main branch." --merge | ||||
|             git checkout main | ||||
|             git merge origin/main | ||||
|             git pull | ||||
|             git status | ||||
|             echo "Current branch '$(git branch --show-current)'." | ||||
|  | ||||
|           fi | ||||
|           echo "DONE!" | ||||
|         env: | ||||
|           GH_TOKEN: ${{ github.token }} | ||||
|           version: ${{ github.event_name == 'schedule' && 'develop' || github.event.inputs.version }} | ||||
|       - name: Create archives | ||||
|         run: | | ||||
|           echo "Create zip file $zipName" | ||||
|           zip -rq $zipName . -x "*.git*" "*.ci*" "*.github*" "*node_modules*" "*output.txt*" "*Procfile*" "*crowdin.yml*" "*sonar-project.properties*" | ||||
|           touch $tarName | ||||
|  | ||||
|           echo "Create tar file $tarName" | ||||
|           tar --exclude=$tarName --exclude=$zipName --exclude='./.git' --exclude='./.ci' --exclude='./.github' --exclude='./node_modules' --exclude='./output.txt' --exclude='./Procfile' --exclude='../crowdin.yml' --exclude='./sonar-project.properties' -czf $tarName . | ||||
|           # add sha256 sum | ||||
|           echo 'Sha sum ...' | ||||
|           sha256sum -b $zipName > $zipName.sha256 | ||||
|           sha256sum -b $tarName > $tarName.sha256 | ||||
|  | ||||
|           # add signatures: | ||||
|           gpg --armor --detach-sign $zipName | ||||
|           gpg --armor --detach-sign $tarName | ||||
|       - name: Create release | ||||
|         run: | | ||||
|  | ||||
|           # create a development release: | ||||
|           if [[ "develop" == "$version" ]]; then | ||||
|             # create the release: | ||||
|             echo "Create develop release." | ||||
|             git tag -a $releaseName -m "Development release '$version' on $(date +'%Y-%m-%d')" | ||||
|             # pull the changes from the develop branch. | ||||
|             git checkout develop | ||||
|             git merge origin/develop | ||||
|             git pull | ||||
|  | ||||
|             # create the release: | ||||
|             echo "Create develop release under tag '$releaseName'." | ||||
|             git tag -a $releaseName -m "🤖 Development release '$version' on $(date +'%Y-%m-%d')" | ||||
|             git push origin $releaseName | ||||
|  | ||||
|             gh release create $releaseName -p --verify-tag \ | ||||
|               -t "Development release for $(date +'%Y-%m-%d')" \ | ||||
|               --latest=false \ | ||||
|               -F output.txt | ||||
|  | ||||
|           fi | ||||
|  | ||||
|           # create a branch release: | ||||
|           if [[ "$version" == branch* ]]; then | ||||
|  | ||||
|             # pull the changes from the branch-* branch. | ||||
|             git checkout $version | ||||
|             git merge origin/$version | ||||
|             git pull | ||||
|  | ||||
|             # create the release: | ||||
|             echo "Create branch release." | ||||
|             git tag -a $releaseName -m "Branch release '$version' on $(date +'%Y-%m-%d')" | ||||
|  | ||||
|             git push origin $releaseName | ||||
|  | ||||
|             gh release create $releaseName -p --verify-tag \ | ||||
|               -t "Branch release for $(date +'%Y-%m-%d')" \ | ||||
|               --latest=false \ | ||||
|               -F output.txt | ||||
|  | ||||
|           fi | ||||
|  | ||||
|           # create a development (nightly) release: | ||||
|           if [[ "develop" == "$version" ]] || [[ "$version" == branch* ]]; then | ||||
|             # add zip file to release. | ||||
|             gh release upload $releaseName $zipName | ||||
|             gh release upload $releaseName $tarName | ||||
|           # Create a production release. | ||||
|           if [[ "develop" != "$version" ]] && [[ "$version" != branch* ]]; then | ||||
|             git checkout main | ||||
|             git merge origin/main | ||||
|             git pull | ||||
|             git status | ||||
|  | ||||
|             # add sha256 sum to release | ||||
|             gh release upload $releaseName $zipName.sha256 | ||||
|             gh release upload $releaseName $tarName.sha256 | ||||
|  | ||||
|             # add signatures to release | ||||
|             gh release upload $releaseName $zipName.asc | ||||
|             gh release upload $releaseName $tarName.asc | ||||
|  | ||||
|             # get current HEAD and add as file to the release | ||||
|             HEAD=$(git rev-parse HEAD) | ||||
|             echo $HEAD > HEAD.txt | ||||
|             gh release upload $releaseName HEAD.txt | ||||
|           else | ||||
|             echo 'MAIN (real) release' | ||||
|             git tag -a $releaseName -m "Here be changelog" | ||||
|             echo "Create prod release." | ||||
|             git tag -a $releaseName -m "Release $version" | ||||
|             git push origin $releaseName | ||||
|  | ||||
|             # do not tag as latest when alpha or beta. | ||||
| @@ -355,24 +477,36 @@ jobs: | ||||
|             # tag as latest when NOT alpha or beta. | ||||
|             if [[ "$version" != *alpha* ]] && [[ "$version" != *beta* ]]; then | ||||
|               echo 'Mark prod as the latest.' | ||||
|               gh release create $releaseName -F output.txt -t "$releaseName" --verify-tag | ||||
|               gh release create $releaseName -F output.txt -t "$releaseName" --verify-tag --latest=true | ||||
|             fi | ||||
|  | ||||
|             # add archive files to release | ||||
|           fi | ||||
|         env: | ||||
|           GH_TOKEN: ${{ github.token }} | ||||
|           version: ${{ github.event_name == 'schedule' && 'develop' || github.event.inputs.version }} | ||||
|       - name: Upload artifacts | ||||
|         run: | | ||||
|           # add zip file to release. | ||||
|           echo "Upload $zipName to $releaseName" | ||||
|           gh release upload $releaseName $zipName | ||||
|           echo "Upload $tarName to $releaseName" | ||||
|           gh release upload $releaseName $tarName | ||||
|  | ||||
|             # add sha256 sums to release | ||||
|           # add sha256 sum to release | ||||
|           echo "Upload $zipName.sha256 to $releaseName" | ||||
|           gh release upload $releaseName $zipName.sha256 | ||||
|           echo "Upload $tarName.sha256 to $releaseName" | ||||
|           gh release upload $releaseName $tarName.sha256 | ||||
|  | ||||
|           # add signatures to release | ||||
|           echo "Upload $zipName.asc to $releaseName" | ||||
|           gh release upload $releaseName $zipName.asc | ||||
|           echo "Upload $tarName.asc to $releaseName" | ||||
|           gh release upload $releaseName $tarName.asc | ||||
|  | ||||
|           # get current HEAD and add as file to the release | ||||
|           HEAD=$(git rev-parse HEAD) | ||||
|           echo $HEAD > HEAD.txt | ||||
|           echo "Upload HEAD.txt to $releaseName" | ||||
|           gh release upload $releaseName HEAD.txt | ||||
|  | ||||
|           # remove all temporary files | ||||
| @@ -382,12 +516,6 @@ jobs: | ||||
|           rm -f $zipName.sha256 | ||||
|           rm -f $tarName | ||||
|           rm -f $tarName.sha256 | ||||
|  | ||||
|             # merge main back into develop | ||||
|             git checkout develop | ||||
|             git merge main | ||||
|             git push | ||||
|           fi | ||||
|         env: | ||||
|           GH_TOKEN: ${{ github.token }} | ||||
|           version: ${{ github.event_name == 'schedule' && 'develop' || github.event.inputs.version }} | ||||
|   | ||||
							
								
								
									
										8
									
								
								.github/workflows/sonarcloud.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										8
									
								
								.github/workflows/sonarcloud.yml
									
									
									
									
										vendored
									
									
								
							| @@ -5,7 +5,6 @@ on: | ||||
|   push: | ||||
|     branches: | ||||
|       - main | ||||
|       - develop | ||||
| env: | ||||
|   DB_CONNECTION: sqlite | ||||
|   APP_KEY: TestTestTestTestTestTestTestTest | ||||
| @@ -51,7 +50,10 @@ jobs: | ||||
|           wget -q https://github.com/firefly-iii/test-fixtures/raw/refs/heads/main/test-database.sqlite -O storage/database/database.sqlite | ||||
|  | ||||
|       - name: "Upgrades the database to the latest version" | ||||
|         run: php artisan firefly-iii:upgrade-database | ||||
|         run: | | ||||
|           php artisan firefly-iii:upgrade-database | ||||
|           chmod 600 storage/oauth-public.key | ||||
|           chmod 600 storage/oauth-private.key | ||||
|  | ||||
|       - name: "Integrity Database Report" | ||||
|         run: php artisan firefly-iii:report-integrity | ||||
| @@ -63,7 +65,7 @@ jobs: | ||||
|         run: sed -i 's@'$GITHUB_WORKSPACE'@/github/workspace/@g' coverage.xml | ||||
|  | ||||
|       - name: SonarCloud Scan | ||||
|         uses: SonarSource/sonarcloud-github-action@master | ||||
|         uses: SonarSource/sonarqube-scan-action@v5.2.0 | ||||
|         env: | ||||
|           GITHUB_TOKEN: ${{ secrets.GH_ACTIONS_PERSONAL_ACCESS_TOKEN }} | ||||
|           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} | ||||
|   | ||||
							
								
								
									
										1
									
								
								.gitignore
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										1
									
								
								.gitignore
									
									
									
									
										vendored
									
									
								
							| @@ -7,6 +7,7 @@ yarn-error.log | ||||
| .env | ||||
| /.ci/php-cs-fixer/vendor | ||||
| coverage.xml | ||||
| output.txt | ||||
|  | ||||
| # ignore generated files. | ||||
| public/build | ||||
|   | ||||
| @@ -4,6 +4,9 @@ Over time, many people have contributed to Firefly III. Their efforts are not al | ||||
| Please find below all the people who contributed to the Firefly III code. Their names are mentioned in the year of their first contribution. | ||||
| 
 | ||||
| ## 2025 | ||||
| - Denis Iskandarov | ||||
| - = | ||||
| - Lompi | ||||
| - Jose Diaz-Gonzalez | ||||
| - SoftBrix | ||||
| 
 | ||||
|   | ||||
| @@ -30,6 +30,7 @@ use FireflyIII\Enums\AccountTypeEnum; | ||||
| use FireflyIII\Exceptions\FireflyException; | ||||
| use FireflyIII\Models\Account; | ||||
| use FireflyIII\Repositories\Account\AccountRepositoryInterface; | ||||
| use FireflyIII\Support\Debug\Timer; | ||||
| use FireflyIII\Support\Facades\Steam; | ||||
| use FireflyIII\Support\Http\Api\AccountFilter; | ||||
| use FireflyIII\User; | ||||
| @@ -42,6 +43,7 @@ use Illuminate\Support\Facades\Log; | ||||
| class AccountController extends Controller | ||||
| { | ||||
|     use AccountFilter; | ||||
| 
 | ||||
|     // this array only exists to test if the constructor will use it properly.
 | ||||
|     protected array $accepts = ['application/json', 'application/vnd.api+json']; | ||||
| 
 | ||||
| @@ -82,10 +84,11 @@ class AccountController extends Controller | ||||
|         $query  = $data['query']; | ||||
|         $date   = $data['date'] ?? today(config('app.timezone')); | ||||
|         $return = []; | ||||
|         Timer::start(sprintf('AC accounts "%s"', $query)); | ||||
|         $result = $this->repository->searchAccount((string) $query, $types, $this->parameters->get('limit')); | ||||
| 
 | ||||
|         // set date to subday + end-of-day for account balance. so it is at $date 23:59:59
 | ||||
|         $date->subDay()->endOfDay(); | ||||
|         $date->endOfDay(); | ||||
| 
 | ||||
|         /** @var Account $account */ | ||||
|         foreach ($result as $account) { | ||||
| @@ -135,6 +138,7 @@ class AccountController extends Controller | ||||
|                 return $posA - $posB; | ||||
|             } | ||||
|         ); | ||||
|         Timer::stop(sprintf('AC accounts "%s"', $query)); | ||||
| 
 | ||||
|         return response()->api($return); | ||||
|     } | ||||
|   | ||||
| @@ -65,13 +65,11 @@ class BillController extends Controller | ||||
|         $data     = $request->getData(); | ||||
|         $result   = $this->repository->searchBill($data['query'], $this->parameters->get('limit')); | ||||
|         $filtered = $result->map( | ||||
|             static function (Bill $item) { | ||||
|                 return [ | ||||
|             static fn (Bill $item) => [ | ||||
|                 'id'     => (string) $item->id, | ||||
|                 'name'   => $item->name, | ||||
|                 'active' => $item->active, | ||||
|                 ]; | ||||
|             } | ||||
|             ] | ||||
|         ); | ||||
| 
 | ||||
|         return response()->api($filtered->toArray()); | ||||
|   | ||||
| @@ -65,12 +65,10 @@ class BudgetController extends Controller | ||||
|         $data     = $request->getData(); | ||||
|         $result   = $this->repository->searchBudget($data['query'], $this->parameters->get('limit')); | ||||
|         $filtered = $result->map( | ||||
|             static function (Budget $item) { | ||||
|                 return [ | ||||
|             static fn (Budget $item) => [ | ||||
|                 'id'   => (string) $item->id, | ||||
|                 'name' => $item->name, | ||||
|                 ]; | ||||
|             } | ||||
|             ] | ||||
|         ); | ||||
| 
 | ||||
|         return response()->api($filtered->toArray()); | ||||
|   | ||||
| @@ -65,12 +65,10 @@ class CategoryController extends Controller | ||||
|         $data     = $request->getData(); | ||||
|         $result   = $this->repository->searchCategory($data['query'], $this->parameters->get('limit')); | ||||
|         $filtered = $result->map( | ||||
|             static function (Category $item) { | ||||
|                 return [ | ||||
|             static fn (Category $item) => [ | ||||
|                 'id'   => (string) $item->id, | ||||
|                 'name' => $item->name, | ||||
|                 ]; | ||||
|             } | ||||
|             ] | ||||
|         ); | ||||
| 
 | ||||
|         return response()->api($filtered->toArray()); | ||||
|   | ||||
| @@ -24,10 +24,11 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Controllers\Autocomplete; | ||||
| 
 | ||||
| use Deprecated; | ||||
| use FireflyIII\Api\V1\Controllers\Controller; | ||||
| use FireflyIII\Api\V1\Requests\Autocomplete\AutocompleteRequest; | ||||
| use FireflyIII\Models\TransactionCurrency; | ||||
| use FireflyIII\Repositories\UserGroups\Currency\CurrencyRepositoryInterface; | ||||
| use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface; | ||||
| use FireflyIII\User; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| 
 | ||||
| @@ -83,9 +84,8 @@ class CurrencyController extends Controller | ||||
|     /** | ||||
|      * Documentation for this endpoint is at: | ||||
|      * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/autocomplete/getCurrenciesCodeAC
 | ||||
|      * | ||||
|      * @deprecated | ||||
|      */ | ||||
|     #[Deprecated]
 | ||||
|     public function currenciesWithCode(AutocompleteRequest $request): JsonResponse | ||||
|     { | ||||
|         $data       = $request->getData(); | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Controllers\Autocomplete; | ||||
| 
 | ||||
| use FireflyIII\Models\TransactionGroup; | ||||
| use FireflyIII\Api\V1\Controllers\Controller; | ||||
| use FireflyIII\Api\V1\Requests\Autocomplete\AutocompleteRequest; | ||||
| use FireflyIII\Enums\UserRoleEnum; | ||||
| @@ -39,11 +40,10 @@ use Illuminate\Support\Collection; | ||||
|  */ | ||||
| class TransactionController extends Controller | ||||
| { | ||||
|     protected array $acceptedRoles = [UserRoleEnum::READ_ONLY]; | ||||
|     private TransactionGroupRepositoryInterface $groupRepository; | ||||
|     private JournalRepositoryInterface          $repository; | ||||
| 
 | ||||
|     protected array $acceptedRoles = [UserRoleEnum::READ_ONLY]; | ||||
| 
 | ||||
|     /** | ||||
|      * TransactionController constructor. | ||||
|      */ | ||||
| @@ -103,7 +103,7 @@ class TransactionController extends Controller | ||||
|         if (is_numeric($data['query'])) { | ||||
|             // search for group, not journal.
 | ||||
|             $firstResult = $this->groupRepository->find((int) $data['query']); | ||||
|             if (null !== $firstResult) { | ||||
|             if ($firstResult instanceof TransactionGroup) { | ||||
|                 // group may contain multiple journals, each a result:
 | ||||
|                 foreach ($firstResult->transactionJournals as $journal) { | ||||
|                     $result->push($journal); | ||||
|   | ||||
| @@ -24,16 +24,22 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Controllers\Chart; | ||||
| 
 | ||||
| use FireflyIII\Exceptions\ValidationException; | ||||
| use FireflyIII\Models\TransactionCurrency; | ||||
| use Carbon\Carbon; | ||||
| use FireflyIII\Api\V1\Controllers\Controller; | ||||
| use FireflyIII\Api\V1\Requests\Chart\ChartRequest; | ||||
| use FireflyIII\Api\V1\Requests\Data\DateRequest; | ||||
| use FireflyIII\Enums\AccountTypeEnum; | ||||
| use FireflyIII\Exceptions\FireflyException; | ||||
| use FireflyIII\Models\Account; | ||||
| use FireflyIII\Models\Preference; | ||||
| use FireflyIII\Repositories\Account\AccountRepositoryInterface; | ||||
| use FireflyIII\Support\Chart\ChartData; | ||||
| use FireflyIII\Support\Facades\Preferences; | ||||
| use FireflyIII\Support\Facades\Steam; | ||||
| use FireflyIII\Support\Http\Api\ApiSupport; | ||||
| use FireflyIII\Support\Http\Api\CollectsAccountsFromFilter; | ||||
| use FireflyIII\User; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| 
 | ||||
| @@ -43,7 +49,9 @@ use Illuminate\Http\JsonResponse; | ||||
| class AccountController extends Controller | ||||
| { | ||||
|     use ApiSupport; | ||||
|     use CollectsAccountsFromFilter; | ||||
| 
 | ||||
|     private ChartData                  $chartData; | ||||
|     private AccountRepositoryInterface $repository; | ||||
| 
 | ||||
|     /** | ||||
| @@ -56,6 +64,7 @@ class AccountController extends Controller | ||||
|             function ($request, $next) { | ||||
|                 /** @var User $user */ | ||||
|                 $user             = auth()->user(); | ||||
|                 $this->chartData  = new ChartData(); | ||||
|                 $this->repository = app(AccountRepositoryInterface::class); | ||||
|                 $this->repository->setUser($user); | ||||
| 
 | ||||
| @@ -64,11 +73,75 @@ class AccountController extends Controller | ||||
|         ); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * TODO fix documentation | ||||
|      * | ||||
|      * @throws FireflyException | ||||
|      */ | ||||
|     public function dashboard(ChartRequest $request): JsonResponse | ||||
|     { | ||||
|         $queryParameters = $request->getParameters(); | ||||
|         $accounts        = $this->getAccountList($queryParameters); | ||||
| 
 | ||||
|         // move date to end of day
 | ||||
|         $queryParameters['start']->startOfDay(); | ||||
|         $queryParameters['end']->endOfDay(); | ||||
| 
 | ||||
|         // loop each account, and collect info:
 | ||||
|         /** @var Account $account */ | ||||
|         foreach ($accounts as $account) { | ||||
|             $this->renderAccountData($queryParameters, $account); | ||||
|         } | ||||
| 
 | ||||
|         return response()->json($this->chartData->render()); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * @throws FireflyException | ||||
|      */ | ||||
|     private function renderAccountData(array $params, Account $account): void | ||||
|     { | ||||
|         $currency     = $this->repository->getAccountCurrency($account); | ||||
|         if (!$currency instanceof TransactionCurrency) { | ||||
|             $currency = $this->default; | ||||
|         } | ||||
|         $currentSet   = [ | ||||
|             'label'                   => $account->name, | ||||
| 
 | ||||
|             // the currency that belongs to the account.
 | ||||
|             'currency_id'             => (string) $currency->id, | ||||
|             'currency_code'           => $currency->code, | ||||
|             'currency_symbol'         => $currency->symbol, | ||||
|             'currency_decimal_places' => $currency->decimal_places, | ||||
| 
 | ||||
|             // the default currency of the user (could be the same!)
 | ||||
|             'date'                    => $params['start']->toAtomString(), | ||||
|             'start'                   => $params['start']->toAtomString(), | ||||
|             'end'                     => $params['end']->toAtomString(), | ||||
|             'period'                  => '1D', | ||||
|             'entries'                 => [], | ||||
|         ]; | ||||
|         $currentStart = clone $params['start']; | ||||
|         $range        = Steam::finalAccountBalanceInRange($account, $params['start'], clone $params['end'], $this->convertToNative); | ||||
| 
 | ||||
|         $previous     = array_values($range)[0]['balance']; | ||||
|         while ($currentStart <= $params['end']) { | ||||
|             $format                        = $currentStart->format('Y-m-d'); | ||||
|             $label                         = $currentStart->toAtomString(); | ||||
|             $balance                       = array_key_exists($format, $range) ? $range[$format]['balance'] : $previous; | ||||
|             $previous                      = $balance; | ||||
| 
 | ||||
|             $currentStart->addDay(); | ||||
|             $currentSet['entries'][$label] = $balance; | ||||
|         } | ||||
|         $this->chartData->add($currentSet); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * This endpoint is documented at: | ||||
|      * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/charts/getChartAccountOverview
 | ||||
|      * | ||||
|      * @throws FireflyException | ||||
|      * @throws ValidationException | ||||
|      */ | ||||
|     public function overview(DateRequest $request): JsonResponse | ||||
|     { | ||||
| @@ -89,7 +162,7 @@ class AccountController extends Controller | ||||
|         $defaultSet = $this->repository->getAccountsByType([AccountTypeEnum::ASSET->value])->pluck('id')->toArray(); | ||||
| 
 | ||||
|         /** @var Preference $frontpage */ | ||||
|         $frontpage  = app('preferences')->get('frontpageAccounts', $defaultSet); | ||||
|         $frontpage  = Preferences::get('frontpageAccounts', $defaultSet); | ||||
| 
 | ||||
|         if (!(is_array($frontpage->data) && count($frontpage->data) > 0)) { | ||||
|             $frontpage->data = $defaultSet; | ||||
|   | ||||
							
								
								
									
										255
									
								
								app/Api/V1/Controllers/Chart/BudgetController.php
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										255
									
								
								app/Api/V1/Controllers/Chart/BudgetController.php
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,255 @@ | ||||
| <?php | ||||
| 
 | ||||
| /* | ||||
|  * BudgetController.php | ||||
|  * Copyright (c) 2023 james@firefly-iii.org | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
|  * This program is free software: you can redistribute it and/or modify | ||||
|  * it under the terms of the GNU Affero General Public License as | ||||
|  * published by the Free Software Foundation, either version 3 of the | ||||
|  * License, or (at your option) any later version. | ||||
|  * | ||||
|  * This program is distributed in the hope that it will be useful, | ||||
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see <https://www.gnu.org/licenses/>. | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Controllers\Chart; | ||||
| 
 | ||||
| use Carbon\Carbon; | ||||
| use FireflyIII\Api\V1\Controllers\Controller; | ||||
| use FireflyIII\Api\V1\Requests\Generic\DateRequest; | ||||
| use FireflyIII\Enums\UserRoleEnum; | ||||
| use FireflyIII\Exceptions\FireflyException; | ||||
| use FireflyIII\Models\Budget; | ||||
| use FireflyIII\Models\BudgetLimit; | ||||
| use FireflyIII\Models\TransactionCurrency; | ||||
| use FireflyIII\Repositories\Budget\BudgetLimitRepositoryInterface; | ||||
| use FireflyIII\Repositories\Budget\BudgetRepositoryInterface; | ||||
| use FireflyIII\Repositories\Budget\OperationsRepositoryInterface; | ||||
| use FireflyIII\Support\Http\Api\CleansChartData; | ||||
| use FireflyIII\Support\Http\Api\ValidatesUserGroupTrait; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Support\Collection; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| 
 | ||||
| /** | ||||
|  * Class BudgetController | ||||
|  */ | ||||
| class BudgetController extends Controller | ||||
| { | ||||
|     use CleansChartData; | ||||
|     use ValidatesUserGroupTrait; | ||||
| 
 | ||||
|     protected array $acceptedRoles                      = [UserRoleEnum::READ_ONLY]; | ||||
| 
 | ||||
|     protected OperationsRepositoryInterface $opsRepository; | ||||
|     private BudgetLimitRepositoryInterface  $blRepository; | ||||
|     private array                           $currencies = []; | ||||
|     private TransactionCurrency             $currency; | ||||
|     private BudgetRepositoryInterface       $repository; | ||||
| 
 | ||||
|     public function __construct() | ||||
|     { | ||||
|         parent::__construct(); | ||||
|         $this->middleware( | ||||
|             function ($request, $next) { | ||||
|                 $this->repository    = app(BudgetRepositoryInterface::class); | ||||
|                 $this->blRepository  = app(BudgetLimitRepositoryInterface::class); | ||||
|                 $this->opsRepository = app(OperationsRepositoryInterface::class); | ||||
|                 $userGroup           = $this->validateUserGroup($request); | ||||
|                 $this->repository->setUserGroup($userGroup); | ||||
|                 $this->opsRepository->setUserGroup($userGroup); | ||||
|                 $this->blRepository->setUserGroup($userGroup); | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
|         ); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * TODO see autocomplete/accountcontroller | ||||
|      */ | ||||
|     public function dashboard(DateRequest $request): JsonResponse | ||||
|     { | ||||
|         $params  = $request->getAll(); | ||||
| 
 | ||||
|         /** @var Carbon $start */ | ||||
|         $start   = $params['start']; | ||||
| 
 | ||||
|         /** @var Carbon $end */ | ||||
|         $end     = $params['end']; | ||||
| 
 | ||||
|         // code from FrontpageChartGenerator, but not in separate class
 | ||||
|         $budgets = $this->repository->getActiveBudgets(); | ||||
|         $data    = []; | ||||
| 
 | ||||
|         /** @var Budget $budget */ | ||||
|         foreach ($budgets as $budget) { | ||||
|             // could return multiple arrays, so merge.
 | ||||
|             $data = array_merge($data, $this->processBudget($budget, $start, $end)); | ||||
|         } | ||||
| 
 | ||||
|         return response()->json($this->clean($data)); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * @throws FireflyException | ||||
|      */ | ||||
|     private function processBudget(Budget $budget, Carbon $start, Carbon $end): array | ||||
|     { | ||||
|         // get all limits:
 | ||||
|         $limits = $this->blRepository->getBudgetLimits($budget, $start, $end); | ||||
|         $rows   = []; | ||||
| 
 | ||||
|         // if no limits
 | ||||
|         if (0 === $limits->count()) { | ||||
|             // return as a single item in an array
 | ||||
|             $rows = $this->noBudgetLimits($budget, $start, $end); | ||||
|         } | ||||
|         if ($limits->count() > 0) { | ||||
|             $rows = $this->budgetLimits($budget, $limits); | ||||
|         } | ||||
|         // is always an array
 | ||||
|         $return = []; | ||||
|         foreach ($rows as $row) { | ||||
|             $current  = [ | ||||
|                 'label'                   => $budget->name, | ||||
|                 'currency_id'             => (string) $row['currency_id'], | ||||
|                 'currency_code'           => $row['currency_code'], | ||||
|                 'currency_name'           => $row['currency_name'], | ||||
|                 'currency_decimal_places' => $row['currency_decimal_places'], | ||||
|                 'period'                  => null, | ||||
|                 'start'                   => $row['start'], | ||||
|                 'end'                     => $row['end'], | ||||
|                 'entries'                 => [ | ||||
|                     'spent'     => $row['spent'], | ||||
|                     'left'      => $row['left'], | ||||
|                     'overspent' => $row['overspent'], | ||||
|                 ], | ||||
|             ]; | ||||
|             $return[] = $current; | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * When no budget limits are present, the expenses of the whole period are collected and grouped. | ||||
|      * This is grouped per currency. Because there is no limit set, "left to spend" and "overspent" are empty. | ||||
|      * | ||||
|      * @throws FireflyException | ||||
|      */ | ||||
|     private function noBudgetLimits(Budget $budget, Carbon $start, Carbon $end): array | ||||
|     { | ||||
|         $spent = $this->opsRepository->listExpenses($start, $end, null, new Collection([$budget])); | ||||
| 
 | ||||
|         return $this->processExpenses($budget->id, $spent, $start, $end); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Shared between the "noBudgetLimits" function and "processLimit". Will take a single set of expenses and return | ||||
|      * its info. | ||||
|      * | ||||
|      * @param array<int, array<int, string>> $array | ||||
|      * | ||||
|      * @throws FireflyException | ||||
|      */ | ||||
|     private function processExpenses(int $budgetId, array $array, Carbon $start, Carbon $end): array | ||||
|     { | ||||
|         $return = []; | ||||
| 
 | ||||
|         /** | ||||
|          * This array contains the expenses in this budget. Grouped per currency. | ||||
|          * The grouping is on the main currency only. | ||||
|          * | ||||
|          * @var int   $currencyId | ||||
|          * @var array $block | ||||
|          */ | ||||
|         foreach ($array as $currencyId => $block) { | ||||
|             $this->currencies[$currencyId] ??= TransactionCurrency::find($currencyId); | ||||
|             $return[$currencyId]           ??= [ | ||||
|                 'currency_id'             => (string) $currencyId, | ||||
|                 'currency_code'           => $block['currency_code'], | ||||
|                 'currency_name'           => $block['currency_name'], | ||||
|                 'currency_symbol'         => $block['currency_symbol'], | ||||
|                 'currency_decimal_places' => (int) $block['currency_decimal_places'], | ||||
|                 'start'                   => $start->toAtomString(), | ||||
|                 'end'                     => $end->toAtomString(), | ||||
|                 'spent'                   => '0', | ||||
|                 'left'                    => '0', | ||||
|                 'overspent'               => '0', | ||||
|             ]; | ||||
|             $currentBudgetArray = $block['budgets'][$budgetId]; | ||||
| 
 | ||||
|             // var_dump($return);
 | ||||
|             /** @var array $journal */ | ||||
|             foreach ($currentBudgetArray['transaction_journals'] as $journal) { | ||||
|                 $return[$currencyId]['spent'] = bcadd($return[$currencyId]['spent'], (string) $journal['amount']); | ||||
|             } | ||||
|         } | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Function that processes each budget limit (per budget). | ||||
|      * | ||||
|      * If you have a budget limit in EUR, only transactions in EUR will be considered. | ||||
|      * If you have a budget limit in GBP, only transactions in GBP will be considered. | ||||
|      * | ||||
|      * If you have a budget limit in EUR, and a transaction in GBP, it will not be considered for the EUR budget limit. | ||||
|      * | ||||
|      * @throws FireflyException | ||||
|      */ | ||||
|     private function budgetLimits(Budget $budget, Collection $limits): array | ||||
|     { | ||||
|         Log::debug(sprintf('Now in budgetLimits(#%d)', $budget->id)); | ||||
|         $data = []; | ||||
| 
 | ||||
|         /** @var BudgetLimit $limit */ | ||||
|         foreach ($limits as $limit) { | ||||
|             $data = array_merge($data, $this->processLimit($budget, $limit)); | ||||
|         } | ||||
| 
 | ||||
|         return $data; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * @throws FireflyException | ||||
|      */ | ||||
|     private function processLimit(Budget $budget, BudgetLimit $limit): array | ||||
|     { | ||||
|         Log::debug(sprintf('Created new ExchangeRateConverter in %s', __METHOD__)); | ||||
|         $end             = clone $limit->end_date; | ||||
|         $end->endOfDay(); | ||||
|         $spent           = $this->opsRepository->listExpenses($limit->start_date, $end, null, new Collection([$budget])); | ||||
|         $limitCurrencyId = $limit->transaction_currency_id; | ||||
| 
 | ||||
|         /** @var array $entry */ | ||||
|         // only spent the entry where the entry's currency matches the budget limit's currency
 | ||||
|         // so $filtered will only have 1 or 0 entries
 | ||||
|         $filtered        = array_filter($spent, fn ($entry) => $entry['currency_id'] === $limitCurrencyId); | ||||
|         $result          = $this->processExpenses($budget->id, $filtered, $limit->start_date, $end); | ||||
|         if (1 === count($result)) { | ||||
|             $compare = bccomp($limit->amount, (string) app('steam')->positive($result[$limitCurrencyId]['spent'])); | ||||
|             if (1 === $compare) { | ||||
|                 // convert this amount into the native currency:
 | ||||
|                 $result[$limitCurrencyId]['left'] = bcadd($limit->amount, (string) $result[$limitCurrencyId]['spent']); | ||||
|             } | ||||
|             if ($compare <= 0) { | ||||
|                 $result[$limitCurrencyId]['overspent'] = app('steam')->positive(bcadd($limit->amount, (string) $result[$limitCurrencyId]['spent'])); | ||||
|             } | ||||
|         } | ||||
| 
 | ||||
|         return $result; | ||||
|     } | ||||
| } | ||||
							
								
								
									
										126
									
								
								app/Api/V1/Controllers/Chart/CategoryController.php
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										126
									
								
								app/Api/V1/Controllers/Chart/CategoryController.php
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,126 @@ | ||||
| <?php | ||||
| 
 | ||||
| /* | ||||
|  * CategoryController.php | ||||
|  * Copyright (c) 2023 james@firefly-iii.org | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
|  * This program is free software: you can redistribute it and/or modify | ||||
|  * it under the terms of the GNU Affero General Public License as | ||||
|  * published by the Free Software Foundation, either version 3 of the | ||||
|  * License, or (at your option) any later version. | ||||
|  * | ||||
|  * This program is distributed in the hope that it will be useful, | ||||
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see <https://www.gnu.org/licenses/>. | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Controllers\Chart; | ||||
| 
 | ||||
| use Carbon\Carbon; | ||||
| use FireflyIII\Api\V2\Controllers\Controller; | ||||
| use FireflyIII\Api\V2\Request\Generic\DateRequest; | ||||
| use FireflyIII\Enums\AccountTypeEnum; | ||||
| use FireflyIII\Enums\TransactionTypeEnum; | ||||
| use FireflyIII\Exceptions\FireflyException; | ||||
| use FireflyIII\Helpers\Collector\GroupCollectorInterface; | ||||
| use FireflyIII\Repositories\Account\AccountRepositoryInterface; | ||||
| use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface; | ||||
| use FireflyIII\Support\Http\Api\CleansChartData; | ||||
| use FireflyIII\Support\Http\Api\ValidatesUserGroupTrait; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| 
 | ||||
| /** | ||||
|  * Class BudgetController | ||||
|  */ | ||||
| class CategoryController extends Controller | ||||
| { | ||||
|     use CleansChartData; | ||||
|     use ValidatesUserGroupTrait; | ||||
| 
 | ||||
|     private AccountRepositoryInterface  $accountRepos; | ||||
|     private CurrencyRepositoryInterface $currencyRepos; | ||||
| 
 | ||||
|     public function __construct() | ||||
|     { | ||||
|         parent::__construct(); | ||||
|         $this->middleware( | ||||
|             function ($request, $next) { | ||||
|                 $this->accountRepos  = app(AccountRepositoryInterface::class); | ||||
|                 $this->currencyRepos = app(CurrencyRepositoryInterface::class); | ||||
|                 $userGroup           = $this->validateUserGroup($request); | ||||
|                 $this->accountRepos->setUserGroup($userGroup); | ||||
|                 $this->currencyRepos->setUserGroup($userGroup); | ||||
| 
 | ||||
|                 return $next($request); | ||||
|             } | ||||
|         ); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * TODO may be worth to move to a handler but the data is simple enough. | ||||
|      * TODO see autoComplete/account controller | ||||
|      * | ||||
|      * @throws FireflyException | ||||
|      * | ||||
|      * @SuppressWarnings("PHPMD.UnusedFormalParameter") | ||||
|      */ | ||||
|     public function dashboard(DateRequest $request): JsonResponse | ||||
|     { | ||||
|         /** @var Carbon $start */ | ||||
|         $start      = $this->parameters->get('start'); | ||||
| 
 | ||||
|         /** @var Carbon $end */ | ||||
|         $end        = $this->parameters->get('end'); | ||||
|         $accounts   = $this->accountRepos->getAccountsByType([AccountTypeEnum::DEBT->value, AccountTypeEnum::LOAN->value, AccountTypeEnum::MORTGAGE->value, AccountTypeEnum::ASSET->value, AccountTypeEnum::DEFAULT->value]); | ||||
|         $currencies = []; | ||||
|         $return     = []; | ||||
| 
 | ||||
|         // get journals for entire period:
 | ||||
|         /** @var GroupCollectorInterface $collector */ | ||||
|         $collector  = app(GroupCollectorInterface::class); | ||||
|         $collector->setRange($start, $end)->withAccountInformation(); | ||||
|         $collector->setXorAccounts($accounts)->withCategoryInformation(); | ||||
|         $collector->setTypes([TransactionTypeEnum::WITHDRAWAL->value, TransactionTypeEnum::RECONCILIATION->value]); | ||||
|         $journals   = $collector->getExtractedJournals(); | ||||
| 
 | ||||
|         /** @var array $journal */ | ||||
|         foreach ($journals as $journal) { | ||||
|             $currencyId              = (int) $journal['currency_id']; | ||||
|             $currency                = $currencies[$currencyId] ?? $this->currencyRepos->find($currencyId); | ||||
|             $currencies[$currencyId] = $currency; | ||||
|             $categoryName            = $journal['category_name'] ?? (string) trans('firefly.no_category'); | ||||
|             $amount                  = app('steam')->positive($journal['amount']); | ||||
|             $key                     = sprintf('%s-%s', $categoryName, $currency->code); | ||||
|             // create arrays
 | ||||
|             $return[$key] ??= [ | ||||
|                 'label'                   => $categoryName, | ||||
|                 'currency_id'             => (string) $currency->id, | ||||
|                 'currency_code'           => $currency->code, | ||||
|                 'currency_name'           => $currency->name, | ||||
|                 'currency_symbol'         => $currency->symbol, | ||||
|                 'currency_decimal_places' => $currency->decimal_places, | ||||
|                 'period'                  => null, | ||||
|                 'start'                   => $start->toAtomString(), | ||||
|                 'end'                     => $end->toAtomString(), | ||||
|                 'amount'                  => '0', | ||||
|             ]; | ||||
| 
 | ||||
|             // add monies
 | ||||
|             $return[$key]['amount']  = bcadd($return[$key]['amount'], (string) $amount); | ||||
|         } | ||||
|         $return     = array_values($return); | ||||
| 
 | ||||
|         // order by amount
 | ||||
|         usort($return, static fn (array $a, array $b) => (float) $a['amount'] < (float) $b['amount'] ? 1 : -1); | ||||
| 
 | ||||
|         return response()->json($this->clean($return)); | ||||
|     } | ||||
| } | ||||
| @@ -32,7 +32,7 @@ use FireflyIII\Models\TransactionCurrency; | ||||
| use FireflyIII\Support\Facades\Amount; | ||||
| use FireflyIII\Support\Facades\Steam; | ||||
| use FireflyIII\Support\Http\Api\ValidatesUserGroupTrait; | ||||
| use FireflyIII\Transformers\V2\AbstractTransformer; | ||||
| use FireflyIII\Transformers\AbstractTransformer; | ||||
| use FireflyIII\User; | ||||
| use Illuminate\Database\Eloquent\Model; | ||||
| use Illuminate\Foundation\Auth\Access\AuthorizesRequests; | ||||
| @@ -40,7 +40,7 @@ use Illuminate\Foundation\Bus\DispatchesJobs; | ||||
| use Illuminate\Foundation\Validation\ValidatesRequests; | ||||
| use Illuminate\Pagination\LengthAwarePaginator; | ||||
| use Illuminate\Routing\Controller as BaseController; | ||||
| use Illuminate\Support\Collection; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use League\Fractal\Manager; | ||||
| use League\Fractal\Pagination\IlluminatePaginatorAdapter; | ||||
| use League\Fractal\Resource\Collection as FractalCollection; | ||||
| @@ -64,13 +64,13 @@ abstract class Controller extends BaseController | ||||
| 
 | ||||
|     protected const string CONTENT_TYPE            = 'application/vnd.api+json'; | ||||
|     protected const string JSON_CONTENT_TYPE       = 'application/json'; | ||||
|     protected array               $accepts         = ['application/json', 'application/vnd.api+json']; | ||||
| 
 | ||||
|     /** @var array<int, string> */ | ||||
|     protected array               $allowedSort; | ||||
|     protected ParameterBag $parameters; | ||||
|     protected bool                $convertToNative = false; | ||||
|     protected array $accepts                 = ['application/json', 'application/vnd.api+json']; | ||||
|     protected TransactionCurrency $nativeCurrency; | ||||
|     protected ParameterBag        $parameters; | ||||
| 
 | ||||
|     /** | ||||
|      * Controller constructor. | ||||
| @@ -124,10 +124,9 @@ abstract class Controller extends BaseController | ||||
|             try { | ||||
|                 $date = request()->query->get($field); | ||||
|             } catch (BadRequestException $e) { | ||||
|                 app('log')->error(sprintf('Request field "%s" contains a non-scalar value. Value set to NULL.', $field)); | ||||
|                 app('log')->error($e->getMessage()); | ||||
|                 app('log')->error($e->getTraceAsString()); | ||||
|                 $value = null; | ||||
|                 Log::error(sprintf('Request field "%s" contains a non-scalar value. Value set to NULL.', $field)); | ||||
|                 Log::error($e->getMessage()); | ||||
|                 Log::error($e->getTraceAsString()); | ||||
|             } | ||||
|             $obj  = null; | ||||
|             if (null !== $date) { | ||||
| @@ -135,7 +134,7 @@ abstract class Controller extends BaseController | ||||
|                     $obj = Carbon::parse((string) $date); | ||||
|                 } catch (InvalidFormatException $e) { | ||||
|                     // don't care
 | ||||
|                     app('log')->warning( | ||||
|                     Log::warning( | ||||
|                         sprintf( | ||||
|                             'Ignored invalid date "%s" in API controller parameter check: %s', | ||||
|                             substr((string) $date, 0, 20), | ||||
| @@ -153,9 +152,9 @@ abstract class Controller extends BaseController | ||||
|             try { | ||||
|                 $value = request()->query->get($integer); | ||||
|             } catch (BadRequestException $e) { | ||||
|                 app('log')->error(sprintf('Request field "%s" contains a non-scalar value. Value set to NULL.', $integer)); | ||||
|                 app('log')->error($e->getMessage()); | ||||
|                 app('log')->error($e->getTraceAsString()); | ||||
|                 Log::error(sprintf('Request field "%s" contains a non-scalar value. Value set to NULL.', $integer)); | ||||
|                 Log::error($e->getMessage()); | ||||
|                 Log::error($e->getTraceAsString()); | ||||
|                 $value = null; | ||||
|             } | ||||
|             if (null !== $value) { | ||||
| @@ -193,9 +192,9 @@ abstract class Controller extends BaseController | ||||
|         try { | ||||
|             $param = (string) request()->query->get('sort'); | ||||
|         } catch (BadRequestException $e) { | ||||
|             app('log')->error('Request field "sort" contains a non-scalar value. Value set to NULL.'); | ||||
|             app('log')->error($e->getMessage()); | ||||
|             app('log')->error($e->getTraceAsString()); | ||||
|             Log::error('Request field "sort" contains a non-scalar value. Value set to NULL.'); | ||||
|             Log::error($e->getMessage()); | ||||
|             Log::error($e->getTraceAsString()); | ||||
|             $param = ''; | ||||
|         } | ||||
|         if ('' === $param) { | ||||
| @@ -263,7 +262,7 @@ abstract class Controller extends BaseController | ||||
| 
 | ||||
|         // the transformer, at this point, needs to collect information that ALL items in the collection
 | ||||
|         // require, like meta-data and stuff like that, and save it for later.
 | ||||
|         $objects  = $transformer->collectMetaData($objects); | ||||
|         // $objects  = $transformer->collectMetaData($objects);
 | ||||
|         $paginator->setCollection($objects); | ||||
| 
 | ||||
|         $resource = new FractalCollection($objects, $transformer, $key); | ||||
| @@ -284,7 +283,7 @@ abstract class Controller extends BaseController | ||||
|         $baseUrl  = sprintf('%s/api/v1', request()->getSchemeAndHttpHost()); | ||||
|         $manager->setSerializer(new JsonApiSerializer($baseUrl)); | ||||
| 
 | ||||
|         $transformer->collectMetaData(new Collection([$object])); | ||||
|         // $transformer->collectMetaData(new Collection([$object]));
 | ||||
| 
 | ||||
|         $resource = new Item($object, $transformer, $key); | ||||
| 
 | ||||
|   | ||||
| @@ -64,7 +64,7 @@ class DestroyController extends Controller | ||||
|     public function destroy(DestroyRequest $request): JsonResponse | ||||
|     { | ||||
|         $objects         = $request->getObjects(); | ||||
|         $this->unused    = $request->boolean('unused', false); | ||||
|         $this->unused    = $request->boolean('unused'); | ||||
| 
 | ||||
|         $allExceptAssets = [AccountTypeEnum::BENEFICIARY->value, AccountTypeEnum::CASH->value, AccountTypeEnum::CREDITCARD->value, AccountTypeEnum::DEFAULT->value, AccountTypeEnum::EXPENSE->value, AccountTypeEnum::IMPORT->value, AccountTypeEnum::INITIAL_BALANCE->value, AccountTypeEnum::LIABILITY_CREDIT->value, AccountTypeEnum::RECONCILIATION->value, AccountTypeEnum::REVENUE->value]; | ||||
|         $all             = [AccountTypeEnum::ASSET->value, AccountTypeEnum::BENEFICIARY->value, AccountTypeEnum::CASH->value, AccountTypeEnum::CREDITCARD->value, AccountTypeEnum::DEBT->value, AccountTypeEnum::DEFAULT->value, AccountTypeEnum::EXPENSE->value, AccountTypeEnum::IMPORT->value, AccountTypeEnum::INITIAL_BALANCE->value, AccountTypeEnum::LIABILITY_CREDIT->value, AccountTypeEnum::LOAN->value, AccountTypeEnum::MORTGAGE->value, AccountTypeEnum::RECONCILIATION->value]; | ||||
| @@ -176,14 +176,14 @@ class DestroyController extends Controller | ||||
|         foreach ($collection as $account) { | ||||
|             $count = $account->transactions()->count(); | ||||
|             if (true === $this->unused && 0 === $count) { | ||||
|                 app('log')->info(sprintf('Deleted unused account #%d "%s"', $account->id, $account->name)); | ||||
|                 Log::info(sprintf('Deleted unused account #%d "%s"', $account->id, $account->name)); | ||||
|                 Log::channel('audit')->info(sprintf('Deleted unused account #%d "%s"', $account->id, $account->name)); | ||||
|                 $service->destroy($account, null); | ||||
| 
 | ||||
|                 continue; | ||||
|             } | ||||
|             if (false === $this->unused) { | ||||
|                 app('log')->info(sprintf('Deleting account #%d "%s"', $account->id, $account->name)); | ||||
|                 Log::info(sprintf('Deleting account #%d "%s"', $account->id, $account->name)); | ||||
|                 Log::channel('audit')->warning(sprintf('Deleted account #%d "%s"', $account->id, $account->name)); | ||||
|                 $service->destroy($account, null); | ||||
|             } | ||||
|   | ||||
| @@ -29,6 +29,9 @@ use FireflyIII\Api\V1\Requests\Data\Export\ExportRequest; | ||||
| use FireflyIII\Exceptions\FireflyException; | ||||
| use FireflyIII\Support\Export\ExportDataGenerator; | ||||
| use Illuminate\Http\Response as LaravelResponse; | ||||
| use Safe\Exceptions\DatetimeException; | ||||
| 
 | ||||
| use function Safe\date; | ||||
| 
 | ||||
| /** | ||||
|  * Class ExportController | ||||
| @@ -70,6 +73,7 @@ class ExportController extends Controller | ||||
| 
 | ||||
|     /** | ||||
|      * @throws FireflyException | ||||
|      * @throws DatetimeException | ||||
|      */ | ||||
|     private function returnExport(string $key): LaravelResponse | ||||
|     { | ||||
| @@ -88,7 +92,7 @@ class ExportController extends Controller | ||||
|             ->header('Expires', '0') | ||||
|             ->header('Cache-Control', 'must-revalidate, post-check=0, pre-check=0') | ||||
|             ->header('Pragma', 'public') | ||||
|             ->header('Content-Length', (string) strlen($data[$key])) | ||||
|             ->header('Content-Length', (string) strlen((string) $data[$key])) | ||||
|         ; | ||||
| 
 | ||||
|         return $response; | ||||
|   | ||||
| @@ -160,7 +160,7 @@ class TagController extends Controller | ||||
|                         'currency_id'      => (string) $currencyId, | ||||
|                         'currency_code'    => $journal['currency_code'], | ||||
|                     ]; | ||||
|                     $response[$key]['difference']       = bcadd($response[$key]['difference'], $journal['amount']); | ||||
|                     $response[$key]['difference']       = bcadd((string) $response[$key]['difference'], (string) $journal['amount']); | ||||
|                     $response[$key]['difference_float'] = (float) $response[$key]['difference']; // float but on purpose.
 | ||||
|                 } | ||||
| 
 | ||||
| @@ -172,7 +172,7 @@ class TagController extends Controller | ||||
|                         'currency_id'      => (string) $foreignCurrencyId, | ||||
|                         'currency_code'    => $journal['foreign_currency_code'], | ||||
|                     ]; | ||||
|                     $response[$foreignKey]['difference']       = bcadd($response[$foreignKey]['difference'], $journal['foreign_amount']); | ||||
|                     $response[$foreignKey]['difference']       = bcadd((string) $response[$foreignKey]['difference'], (string) $journal['foreign_amount']); | ||||
|                     $response[$foreignKey]['difference_float'] = (float) $response[$foreignKey]['difference']; // float but on purpose.
 | ||||
|                 } | ||||
|             } | ||||
|   | ||||
| @@ -75,7 +75,7 @@ class PeriodController extends Controller | ||||
|                 'currency_id'      => (string) $currencyId, | ||||
|                 'currency_code'    => $currencyCode, | ||||
|             ]; | ||||
|             $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], app('steam')->positive($journal[$field])); | ||||
|             $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], (string) app('steam')->positive($journal[$field])); | ||||
|             $response[$currencyId]['difference_float'] = (float) $response[$currencyId]['difference']; // float but on purpose.
 | ||||
|         } | ||||
| 
 | ||||
|   | ||||
| @@ -100,7 +100,7 @@ class TagController extends Controller | ||||
|                 'currency_id'      => (string) $currencyId, | ||||
|                 'currency_code'    => $currencyCode, | ||||
|             ]; | ||||
|             $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], app('steam')->positive($journal[$field])); | ||||
|             $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], (string) app('steam')->positive($journal[$field])); | ||||
|             $response[$currencyId]['difference_float'] = (float) $response[$currencyId]['difference']; | ||||
| 
 | ||||
|         } | ||||
| @@ -154,7 +154,7 @@ class TagController extends Controller | ||||
|                         'currency_id'      => (string) $currencyId, | ||||
|                         'currency_code'    => $journal['currency_code'], | ||||
|                     ]; | ||||
|                     $response[$key]['difference']       = bcadd($response[$key]['difference'], app('steam')->positive($journal['amount'])); | ||||
|                     $response[$key]['difference']       = bcadd((string) $response[$key]['difference'], (string) app('steam')->positive($journal['amount'])); | ||||
|                     $response[$key]['difference_float'] = (float) $response[$key]['difference']; | ||||
|                 } | ||||
| 
 | ||||
| @@ -167,8 +167,8 @@ class TagController extends Controller | ||||
|                         'currency_code'    => $journal['foreign_currency_code'], | ||||
|                     ]; | ||||
|                     $response[$foreignKey]['difference']       = bcadd( | ||||
|                         $response[$foreignKey]['difference'], | ||||
|                         app('steam')->positive($journal['foreign_amount']) | ||||
|                         (string) $response[$foreignKey]['difference'], | ||||
|                         (string) app('steam')->positive($journal['foreign_amount']) | ||||
|                     ); | ||||
|                     $response[$foreignKey]['difference_float'] = (float) $response[$foreignKey]['difference']; | ||||
|                 } | ||||
|   | ||||
| @@ -75,7 +75,7 @@ class PeriodController extends Controller | ||||
|                 'currency_id'      => (string) $currencyId, | ||||
|                 'currency_code'    => $currencyCode, | ||||
|             ]; | ||||
|             $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], app('steam')->positive($journal[$field])); | ||||
|             $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], (string) app('steam')->positive($journal[$field])); | ||||
|             $response[$currencyId]['difference_float'] = (float) $response[$currencyId]['difference']; | ||||
| 
 | ||||
|         } | ||||
|   | ||||
| @@ -99,7 +99,7 @@ class TagController extends Controller | ||||
|                 'currency_id'      => (string) $currencyId, | ||||
|                 'currency_code'    => $currencyCode, | ||||
|             ]; | ||||
|             $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], app('steam')->positive($journal[$field])); | ||||
|             $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], (string) app('steam')->positive($journal[$field])); | ||||
|             $response[$currencyId]['difference_float'] = (float) $response[$currencyId]['difference']; | ||||
| 
 | ||||
|         } | ||||
| @@ -153,7 +153,7 @@ class TagController extends Controller | ||||
|                         'currency_id'      => (string) $currencyId, | ||||
|                         'currency_code'    => $journal['currency_code'], | ||||
|                     ]; | ||||
|                     $response[$key]['difference']       = bcadd($response[$key]['difference'], app('steam')->positive($journal['amount'])); | ||||
|                     $response[$key]['difference']       = bcadd((string) $response[$key]['difference'], (string) app('steam')->positive($journal['amount'])); | ||||
|                     $response[$key]['difference_float'] = (float) $response[$key]['difference']; | ||||
|                 } | ||||
| 
 | ||||
| @@ -166,8 +166,8 @@ class TagController extends Controller | ||||
|                         'currency_code'    => $journal['foreign_currency_code'], | ||||
|                     ]; | ||||
|                     $response[$foreignKey]['difference']       = bcadd( | ||||
|                         $response[$foreignKey]['difference'], | ||||
|                         app('steam')->positive($journal['foreign_amount']) | ||||
|                         (string) $response[$foreignKey]['difference'], | ||||
|                         (string) app('steam')->positive($journal['foreign_amount']) | ||||
|                     ); | ||||
|                     $response[$foreignKey]['difference_float'] = (float) $response[$foreignKey]['difference']; // intentional float
 | ||||
|                 } | ||||
|   | ||||
| @@ -97,7 +97,6 @@ class ShowController extends Controller | ||||
|         $admin       = auth()->user(); | ||||
|         $enrichment  = new AccountEnrichment(); | ||||
|         $enrichment->setUser($admin); | ||||
|         $enrichment->setConvertToNative($this->convertToNative); | ||||
|         $enrichment->setNative($this->nativeCurrency); | ||||
|         $accounts    = $enrichment->enrich($accounts); | ||||
| 
 | ||||
| @@ -133,7 +132,6 @@ class ShowController extends Controller | ||||
|         $admin       = auth()->user(); | ||||
|         $enrichment  = new AccountEnrichment(); | ||||
|         $enrichment->setUser($admin); | ||||
|         $enrichment->setConvertToNative($this->convertToNative); | ||||
|         $enrichment->setNative($this->nativeCurrency); | ||||
|         $account     = $enrichment->enrichSingle($account); | ||||
| 
 | ||||
|   | ||||
| @@ -76,7 +76,6 @@ class StoreController extends Controller | ||||
|         $admin       = auth()->user(); | ||||
|         $enrichment  = new AccountEnrichment(); | ||||
|         $enrichment->setUser($admin); | ||||
|         $enrichment->setConvertToNative($this->convertToNative); | ||||
|         $enrichment->setNative($this->nativeCurrency); | ||||
|         $account     = $enrichment->enrichSingle($account); | ||||
| 
 | ||||
|   | ||||
| @@ -32,6 +32,7 @@ use FireflyIII\Support\JsonApi\Enrichments\AccountEnrichment; | ||||
| use FireflyIII\Transformers\AccountTransformer; | ||||
| use FireflyIII\User; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use League\Fractal\Resource\Item; | ||||
| 
 | ||||
| /** | ||||
| @@ -67,7 +68,7 @@ class UpdateController extends Controller | ||||
|      */ | ||||
|     public function update(UpdateRequest $request, Account $account): JsonResponse | ||||
|     { | ||||
|         app('log')->debug(sprintf('Now in %s', __METHOD__)); | ||||
|         Log::debug(sprintf('Now in %s', __METHOD__)); | ||||
|         $data         = $request->getUpdateData(); | ||||
|         $data['type'] = config('firefly.shortNamesByFullName.'.$account->accountType->type); | ||||
|         $account      = $this->repository->update($account, $data); | ||||
| @@ -80,7 +81,6 @@ class UpdateController extends Controller | ||||
|         $admin        = auth()->user(); | ||||
|         $enrichment   = new AccountEnrichment(); | ||||
|         $enrichment->setUser($admin); | ||||
|         $enrichment->setConvertToNative($this->convertToNative); | ||||
|         $enrichment->setNative($this->nativeCurrency); | ||||
|         $account      = $enrichment->enrichSingle($account); | ||||
| 
 | ||||
|   | ||||
| @@ -80,7 +80,7 @@ class StoreController extends Controller | ||||
| 
 | ||||
|             throw new NotFoundHttpException(); | ||||
|         } | ||||
|         app('log')->debug(sprintf('Now in %s', __METHOD__)); | ||||
|         Log::debug(sprintf('Now in %s', __METHOD__)); | ||||
|         $data        = $request->getAll(); | ||||
|         $attachment  = $this->repository->store($data); | ||||
|         $manager     = $this->getManager(); | ||||
| @@ -109,13 +109,13 @@ class StoreController extends Controller | ||||
|         $helper = app(AttachmentHelperInterface::class); | ||||
|         $body   = $request->getContent(); | ||||
|         if ('' === $body) { | ||||
|             app('log')->error('Body of attachment is empty.'); | ||||
|             Log::error('Body of attachment is empty.'); | ||||
| 
 | ||||
|             return response()->json([], 422); | ||||
|         } | ||||
|         $result = $helper->saveAttachmentFromApi($attachment, $body); | ||||
|         if (false === $result) { | ||||
|             app('log')->error('Could not save attachment from API.'); | ||||
|             Log::error('Could not save attachment from API.'); | ||||
| 
 | ||||
|             return response()->json([], 422); | ||||
|         } | ||||
|   | ||||
| @@ -69,7 +69,6 @@ class StoreController extends Controller | ||||
|         $data               = $request->getAll(); | ||||
|         $data['start_date'] = $data['start']; | ||||
|         $data['end_date']   = $data['end']; | ||||
|         $data['notes']      = $data['notes']; | ||||
|         $data['budget_id']  = $budget->id; | ||||
| 
 | ||||
|         $budgetLimit        = $this->blRepository->store($data); | ||||
|   | ||||
| @@ -24,13 +24,14 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Controllers\Models\CurrencyExchangeRate; | ||||
| 
 | ||||
| use Carbon\Carbon; | ||||
| use FireflyIII\Api\V1\Controllers\Controller; | ||||
| use FireflyIII\Api\V1\Requests\Models\CurrencyExchangeRate\DestroyRequest; | ||||
| use FireflyIII\Enums\UserRoleEnum; | ||||
| use FireflyIII\Exceptions\ValidationException; | ||||
| use FireflyIII\Models\CurrencyExchangeRate; | ||||
| use FireflyIII\Models\TransactionCurrency; | ||||
| use FireflyIII\Repositories\UserGroups\ExchangeRate\ExchangeRateRepositoryInterface; | ||||
| use FireflyIII\Repositories\ExchangeRate\ExchangeRateRepositoryInterface; | ||||
| use FireflyIII\Support\Http\Api\ValidatesUserGroupTrait; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Symfony\Component\HttpKernel\Exception\NotFoundHttpException; | ||||
| @@ -39,10 +40,8 @@ class DestroyController extends Controller | ||||
| { | ||||
|     use ValidatesUserGroupTrait; | ||||
| 
 | ||||
|     protected array $acceptedRoles   = [UserRoleEnum::OWNER]; | ||||
| 
 | ||||
|     public const string RESOURCE_KEY = 'exchange-rates'; | ||||
| 
 | ||||
|     protected array $acceptedRoles   = [UserRoleEnum::OWNER]; | ||||
|     private ExchangeRateRepositoryInterface $repository; | ||||
| 
 | ||||
|     public function __construct() | ||||
| @@ -61,11 +60,11 @@ class DestroyController extends Controller | ||||
|     public function destroy(DestroyRequest $request, TransactionCurrency $from, TransactionCurrency $to): JsonResponse | ||||
|     { | ||||
|         $date = $request->getDate(); | ||||
|         if (null === $date) { | ||||
|         if (!$date instanceof Carbon) { | ||||
|             throw new ValidationException('Date is required'); | ||||
|         } | ||||
|         $rate = $this->repository->getSpecificRateOnDate($from, $to, $date); | ||||
|         if (null === $rate) { | ||||
|         if (!$rate instanceof CurrencyExchangeRate) { | ||||
|             throw new NotFoundHttpException(); | ||||
|         } | ||||
|         $this->repository->deleteRate($rate); | ||||
|   | ||||
| @@ -25,9 +25,9 @@ declare(strict_types=1); | ||||
| namespace FireflyIII\Api\V1\Controllers\Models\CurrencyExchangeRate; | ||||
| 
 | ||||
| use FireflyIII\Api\V2\Controllers\Controller; | ||||
| use FireflyIII\Repositories\UserGroups\ExchangeRate\ExchangeRateRepositoryInterface; | ||||
| use FireflyIII\Repositories\ExchangeRate\ExchangeRateRepositoryInterface; | ||||
| use FireflyIII\Support\Http\Api\ValidatesUserGroupTrait; | ||||
| use FireflyIII\Transformers\V2\ExchangeRateTransformer; | ||||
| use FireflyIII\Transformers\ExchangeRateTransformer; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Pagination\LengthAwarePaginator; | ||||
| 
 | ||||
|   | ||||
| @@ -27,9 +27,9 @@ namespace FireflyIII\Api\V1\Controllers\Models\CurrencyExchangeRate; | ||||
| use FireflyIII\Api\V2\Controllers\Controller; | ||||
| use FireflyIII\Models\CurrencyExchangeRate; | ||||
| use FireflyIII\Models\TransactionCurrency; | ||||
| use FireflyIII\Repositories\UserGroups\ExchangeRate\ExchangeRateRepositoryInterface; | ||||
| use FireflyIII\Repositories\ExchangeRate\ExchangeRateRepositoryInterface; | ||||
| use FireflyIII\Support\Http\Api\ValidatesUserGroupTrait; | ||||
| use FireflyIII\Transformers\V2\ExchangeRateTransformer; | ||||
| use FireflyIII\Transformers\ExchangeRateTransformer; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Pagination\LengthAwarePaginator; | ||||
| 
 | ||||
|   | ||||
| @@ -24,11 +24,12 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Controllers\Models\CurrencyExchangeRate; | ||||
| 
 | ||||
| use FireflyIII\Models\CurrencyExchangeRate; | ||||
| use FireflyIII\Api\V1\Requests\Models\CurrencyExchangeRate\StoreRequest; | ||||
| use FireflyIII\Api\V2\Controllers\Controller; | ||||
| use FireflyIII\Repositories\UserGroups\ExchangeRate\ExchangeRateRepositoryInterface; | ||||
| use FireflyIII\Repositories\ExchangeRate\ExchangeRateRepositoryInterface; | ||||
| use FireflyIII\Support\Http\Api\ValidatesUserGroupTrait; | ||||
| use FireflyIII\Transformers\V2\ExchangeRateTransformer; | ||||
| use FireflyIII\Transformers\ExchangeRateTransformer; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| 
 | ||||
| class StoreController extends Controller | ||||
| @@ -61,11 +62,11 @@ class StoreController extends Controller | ||||
| 
 | ||||
|         // already has rate?
 | ||||
|         $object      = $this->repository->getSpecificRateOnDate($from, $to, $date); | ||||
|         if (null !== $object) { | ||||
|         if ($object instanceof CurrencyExchangeRate) { | ||||
|             // just update it, no matter.
 | ||||
|             $rate = $this->repository->updateExchangeRate($object, $rate, $date); | ||||
|         } | ||||
|         if (null === $object) { | ||||
|         if (!$object instanceof CurrencyExchangeRate) { | ||||
|             // store new
 | ||||
|             $rate = $this->repository->storeExchangeRate($from, $to, $rate, $date); | ||||
|         } | ||||
|   | ||||
| @@ -27,9 +27,9 @@ namespace FireflyIII\Api\V1\Controllers\Models\CurrencyExchangeRate; | ||||
| use FireflyIII\Api\V1\Requests\Models\CurrencyExchangeRate\UpdateRequest; | ||||
| use FireflyIII\Api\V2\Controllers\Controller; | ||||
| use FireflyIII\Models\CurrencyExchangeRate; | ||||
| use FireflyIII\Repositories\UserGroups\ExchangeRate\ExchangeRateRepositoryInterface; | ||||
| use FireflyIII\Repositories\ExchangeRate\ExchangeRateRepositoryInterface; | ||||
| use FireflyIII\Support\Http\Api\ValidatesUserGroupTrait; | ||||
| use FireflyIII\Transformers\V2\ExchangeRateTransformer; | ||||
| use FireflyIII\Transformers\ExchangeRateTransformer; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| 
 | ||||
| class UpdateController extends Controller | ||||
|   | ||||
| @@ -84,7 +84,6 @@ class ListController extends Controller | ||||
|         $admin       = auth()->user(); | ||||
|         $enrichment  = new AccountEnrichment(); | ||||
|         $enrichment->setUser($admin); | ||||
|         $enrichment->setConvertToNative($this->convertToNative); | ||||
|         $enrichment->setNative($this->nativeCurrency); | ||||
|         $accounts    = $enrichment->enrich($accounts); | ||||
| 
 | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Controllers\Models\RuleGroup; | ||||
| 
 | ||||
| use Exception; | ||||
| use FireflyIII\Api\V1\Controllers\Controller; | ||||
| use FireflyIII\Api\V1\Requests\Models\RuleGroup\TestRequest; | ||||
| use FireflyIII\Api\V1\Requests\Models\RuleGroup\TriggerRequest; | ||||
| @@ -128,7 +129,7 @@ class TriggerController extends Controller | ||||
|      * | ||||
|      * Execute the given rule group on a set of existing transactions. | ||||
|      * | ||||
|      * @throws \Exception | ||||
|      * @throws Exception | ||||
|      */ | ||||
|     public function triggerGroup(TriggerRequest $request, RuleGroup $group): JsonResponse | ||||
|     { | ||||
|   | ||||
| @@ -34,6 +34,7 @@ use FireflyIII\Repositories\Journal\JournalRepositoryInterface; | ||||
| use FireflyIII\Repositories\TransactionGroup\TransactionGroupRepository; | ||||
| use FireflyIII\User; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| 
 | ||||
| /** | ||||
|  * Class DestroyController | ||||
| @@ -73,7 +74,7 @@ class DestroyController extends Controller | ||||
|      */ | ||||
|     public function destroy(TransactionGroup $transactionGroup): JsonResponse | ||||
|     { | ||||
|         app('log')->debug(sprintf('Now in %s', __METHOD__)); | ||||
|         Log::debug(sprintf('Now in %s', __METHOD__)); | ||||
|         // grab asset account(s) from group:
 | ||||
|         $accounts = []; | ||||
| 
 | ||||
| @@ -95,7 +96,7 @@ class DestroyController extends Controller | ||||
| 
 | ||||
|         /** @var Account $account */ | ||||
|         foreach ($accounts as $account) { | ||||
|             app('log')->debug(sprintf('Now going to trigger updated account event for account #%d', $account->id)); | ||||
|             Log::debug(sprintf('Now going to trigger updated account event for account #%d', $account->id)); | ||||
|             event(new UpdatedAccount($account)); | ||||
|         } | ||||
| 
 | ||||
|   | ||||
| @@ -50,9 +50,8 @@ class StoreController extends Controller | ||||
| { | ||||
|     use TransactionFilter; | ||||
| 
 | ||||
|     private TransactionGroupRepositoryInterface $groupRepository; | ||||
| 
 | ||||
|     protected array $acceptedRoles = [UserRoleEnum::MANAGE_TRANSACTIONS]; | ||||
|     private TransactionGroupRepositoryInterface $groupRepository; | ||||
| 
 | ||||
|     /** | ||||
|      * TransactionController constructor. | ||||
| @@ -85,7 +84,7 @@ class StoreController extends Controller | ||||
|      */ | ||||
|     public function store(StoreRequest $request): JsonResponse | ||||
|     { | ||||
|         app('log')->debug('Now in API StoreController::store()'); | ||||
|         Log::debug('Now in API StoreController::store()'); | ||||
|         $data               = $request->getAll(); | ||||
|         $data['user']       = auth()->user(); | ||||
|         $data['user_group'] = $this->userGroup; | ||||
| @@ -96,13 +95,13 @@ class StoreController extends Controller | ||||
|         try { | ||||
|             $transactionGroup = $this->groupRepository->store($data); | ||||
|         } catch (DuplicateTransactionException $e) { | ||||
|             app('log')->warning('Caught a duplicate transaction. Return error message.'); | ||||
|             Log::warning('Caught a duplicate transaction. Return error message.'); | ||||
|             $validator = Validator::make(['transactions' => [['description' => $e->getMessage()]]], ['transactions.0.description' => new IsDuplicateTransaction()]); | ||||
| 
 | ||||
|             throw new ValidationException($validator); | ||||
|         } catch (FireflyException $e) { | ||||
|             app('log')->warning('Caught an exception. Return error message.'); | ||||
|             app('log')->error($e->getMessage()); | ||||
|             Log::warning('Caught an exception. Return error message.'); | ||||
|             Log::error($e->getMessage()); | ||||
|             $message   = sprintf('Internal exception: %s', $e->getMessage()); | ||||
|             $validator = Validator::make(['transactions' => [['description' => $message]]], ['transactions.0.description' => new IsDuplicateTransaction()]); | ||||
| 
 | ||||
|   | ||||
| @@ -34,6 +34,7 @@ use FireflyIII\Support\JsonApi\Enrichments\TransactionGroupEnrichment; | ||||
| use FireflyIII\Transformers\TransactionGroupTransformer; | ||||
| use FireflyIII\User; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use League\Fractal\Resource\Item; | ||||
| use Symfony\Component\HttpKernel\Exception\NotFoundHttpException; | ||||
| 
 | ||||
| @@ -71,15 +72,18 @@ class UpdateController extends Controller | ||||
|      */ | ||||
|     public function update(UpdateRequest $request, TransactionGroup $transactionGroup): JsonResponse | ||||
|     { | ||||
|         app('log')->debug('Now in update routine for transaction group'); | ||||
|         Log::debug('Now in update routine for transaction group'); | ||||
|         $data              = $request->getAll(); | ||||
|         $oldHash           = $this->groupRepository->getCompareHash($transactionGroup); | ||||
|         $transactionGroup  = $this->groupRepository->update($transactionGroup, $data); | ||||
|         $newHash           = $this->groupRepository->getCompareHash($transactionGroup); | ||||
|         $manager           = $this->getManager(); | ||||
| 
 | ||||
|         app('preferences')->mark(); | ||||
|         $applyRules        = $data['apply_rules'] ?? true; | ||||
|         $fireWebhooks      = $data['fire_webhooks'] ?? true; | ||||
|         event(new UpdatedTransactionGroup($transactionGroup, $applyRules, $fireWebhooks)); | ||||
|         $runRecalculations = $oldHash !== $newHash; | ||||
|         event(new UpdatedTransactionGroup($transactionGroup, $applyRules, $fireWebhooks, $runRecalculations)); | ||||
| 
 | ||||
|         /** @var User $admin */ | ||||
|         $admin             = auth()->user(); | ||||
|   | ||||
| @@ -24,13 +24,15 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Controllers\Models\TransactionCurrency; | ||||
| 
 | ||||
| use Illuminate\Support\Facades\Validator; | ||||
| use FireflyIII\Api\V1\Controllers\Controller; | ||||
| use FireflyIII\Exceptions\FireflyException; | ||||
| use FireflyIII\Models\TransactionCurrency; | ||||
| use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface; | ||||
| use FireflyIII\Repositories\User\UserRepositoryInterface; | ||||
| use FireflyIII\Repositories\UserGroups\Currency\CurrencyRepositoryInterface; | ||||
| use FireflyIII\User; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Validation\ValidationException; | ||||
| 
 | ||||
| /** | ||||
|  * Class DestroyController | ||||
| @@ -64,6 +66,7 @@ class DestroyController extends Controller | ||||
|      * Remove the specified resource from storage. | ||||
|      * | ||||
|      * @throws FireflyException | ||||
|      * @throws ValidationException | ||||
|      */ | ||||
|     public function destroy(TransactionCurrency $currency): JsonResponse | ||||
|     { | ||||
| @@ -74,15 +77,15 @@ class DestroyController extends Controller | ||||
|         if (!$this->userRepository->hasRole($admin, 'owner')) { | ||||
|             // access denied:
 | ||||
|             $messages = ['currency_code' => '200005: You need the "owner" role to do this.']; | ||||
|             \Validator::make([], $rules, $messages)->validate(); | ||||
|             Validator::make([], $rules, $messages)->validate(); | ||||
|         } | ||||
|         if ($this->repository->currencyInUse($currency)) { | ||||
|             $messages = ['currency_code' => '200006: Currency in use.']; | ||||
|             \Validator::make([], $rules, $messages)->validate(); | ||||
|             Validator::make([], $rules, $messages)->validate(); | ||||
|         } | ||||
|         if ($this->repository->isFallbackCurrency($currency)) { | ||||
|             $messages = ['currency_code' => '200026: Currency is fallback.']; | ||||
|             \Validator::make([], $rules, $messages)->validate(); | ||||
|             Validator::make([], $rules, $messages)->validate(); | ||||
|         } | ||||
| 
 | ||||
|         $this->repository->destroy($currency); | ||||
|   | ||||
| @@ -107,7 +107,6 @@ class ListController extends Controller | ||||
|         $admin             = auth()->user(); | ||||
|         $enrichment        = new AccountEnrichment(); | ||||
|         $enrichment->setUser($admin); | ||||
|         $enrichment->setConvertToNative($this->convertToNative); | ||||
|         $enrichment->setNative($this->nativeCurrency); | ||||
|         $accounts          = $enrichment->enrich($accounts); | ||||
| 
 | ||||
| @@ -178,9 +177,7 @@ class ListController extends Controller | ||||
| 
 | ||||
|         // filter and paginate list:
 | ||||
|         $collection  = $unfiltered->filter( | ||||
|             static function (Bill $bill) use ($currency) { | ||||
|                 return $bill->transaction_currency_id === $currency->id; | ||||
|             } | ||||
|             static fn (Bill $bill) => $bill->transaction_currency_id === $currency->id | ||||
|         ); | ||||
|         $count       = $collection->count(); | ||||
|         $bills       = $collection->slice(($this->parameters->get('page') - 1) * $pageSize, $pageSize); | ||||
| @@ -253,11 +250,9 @@ class ListController extends Controller | ||||
|         $collection     = $unfiltered->filter( | ||||
|             static function (Recurrence $recurrence) use ($currency) {  // @phpstan-ignore-line
 | ||||
|                 /** @var RecurrenceTransaction $transaction */ | ||||
|                 foreach ($recurrence->recurrenceTransactions as $transaction) { | ||||
|                     if ($transaction->transaction_currency_id === $currency->id || $transaction->foreign_currency_id === $currency->id) { | ||||
|                 if (array_any($recurrence->recurrenceTransactions, fn ($transaction) => $transaction->transaction_currency_id === $currency->id || $transaction->foreign_currency_id === $currency->id)) { | ||||
|                     return $recurrence; | ||||
|                 } | ||||
|                 } | ||||
| 
 | ||||
|                 return null; | ||||
|             } | ||||
| @@ -300,11 +295,9 @@ class ListController extends Controller | ||||
|         $collection  = $unfiltered->filter( | ||||
|             static function (Rule $rule) use ($currency) { // @phpstan-ignore-line
 | ||||
|                 /** @var RuleTrigger $trigger */ | ||||
|                 foreach ($rule->ruleTriggers as $trigger) { | ||||
|                     if ('currency_is' === $trigger->trigger_type && $currency->name === $trigger->trigger_value) { | ||||
|                 if (array_any($rule->ruleTriggers, fn ($trigger) => 'currency_is' === $trigger->trigger_type && $currency->name === $trigger->trigger_value)) { | ||||
|                     return $rule; | ||||
|                 } | ||||
|                 } | ||||
| 
 | ||||
|                 return null; | ||||
|             } | ||||
|   | ||||
| @@ -27,7 +27,7 @@ namespace FireflyIII\Api\V1\Controllers\Models\TransactionCurrency; | ||||
| use FireflyIII\Api\V1\Controllers\Controller; | ||||
| use FireflyIII\Exceptions\FireflyException; | ||||
| use FireflyIII\Models\TransactionCurrency; | ||||
| use FireflyIII\Repositories\UserGroups\Currency\CurrencyRepositoryInterface; | ||||
| use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface; | ||||
| use FireflyIII\Support\Http\Api\AccountFilter; | ||||
| use FireflyIII\Support\Http\Api\TransactionFilter; | ||||
| use FireflyIII\Transformers\CurrencyTransformer; | ||||
|   | ||||
| @@ -27,7 +27,7 @@ namespace FireflyIII\Api\V1\Controllers\Models\TransactionCurrency; | ||||
| use FireflyIII\Api\V1\Controllers\Controller; | ||||
| use FireflyIII\Api\V1\Requests\Models\TransactionCurrency\StoreRequest; | ||||
| use FireflyIII\Exceptions\FireflyException; | ||||
| use FireflyIII\Repositories\UserGroups\Currency\CurrencyRepositoryInterface; | ||||
| use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface; | ||||
| use FireflyIII\Support\Http\Api\AccountFilter; | ||||
| use FireflyIII\Support\Http\Api\TransactionFilter; | ||||
| use FireflyIII\Transformers\CurrencyTransformer; | ||||
|   | ||||
| @@ -28,7 +28,7 @@ use FireflyIII\Api\V1\Controllers\Controller; | ||||
| use FireflyIII\Api\V1\Requests\Models\TransactionCurrency\UpdateRequest; | ||||
| use FireflyIII\Exceptions\FireflyException; | ||||
| use FireflyIII\Models\TransactionCurrency; | ||||
| use FireflyIII\Repositories\UserGroups\Currency\CurrencyRepositoryInterface; | ||||
| use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface; | ||||
| use FireflyIII\Support\Http\Api\AccountFilter; | ||||
| use FireflyIII\Support\Http\Api\TransactionFilter; | ||||
| use FireflyIII\Transformers\CurrencyTransformer; | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Controllers\Models\TransactionLink; | ||||
| 
 | ||||
| use FireflyIII\Models\TransactionJournal; | ||||
| use FireflyIII\Api\V1\Controllers\Controller; | ||||
| use FireflyIII\Api\V1\Requests\Models\TransactionLink\StoreRequest; | ||||
| use FireflyIII\Exceptions\FireflyException; | ||||
| @@ -81,7 +82,7 @@ class StoreController extends Controller | ||||
|         $data              = $request->getAll(); | ||||
|         $inward            = $this->journalRepository->find($data['inward_id'] ?? 0); | ||||
|         $outward           = $this->journalRepository->find($data['outward_id'] ?? 0); | ||||
|         if (null === $inward || null === $outward) { | ||||
|         if (!$inward instanceof TransactionJournal || !$outward instanceof TransactionJournal) { | ||||
|             throw new FireflyException('200024: Source or destination does not exist.'); | ||||
|         } | ||||
|         $data['direction'] = 'inward'; | ||||
|   | ||||
| @@ -24,15 +24,16 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Controllers\Models\TransactionLinkType; | ||||
| 
 | ||||
| use Illuminate\Support\Facades\Validator; | ||||
| use FireflyIII\Api\V1\Controllers\Controller; | ||||
| use FireflyIII\Api\V1\Requests\Models\TransactionLinkType\StoreRequest; | ||||
| use FireflyIII\Exceptions\FireflyException; | ||||
| use FireflyIII\Repositories\LinkType\LinkTypeRepositoryInterface; | ||||
| use FireflyIII\Repositories\User\UserRepositoryInterface; | ||||
| use FireflyIII\Support\Http\Api\TransactionFilter; | ||||
| use FireflyIII\Transformers\LinkTypeTransformer; | ||||
| use FireflyIII\User; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Validation\ValidationException; | ||||
| use League\Fractal\Resource\Item; | ||||
| 
 | ||||
| /** | ||||
| @@ -70,7 +71,7 @@ class StoreController extends Controller | ||||
|      * | ||||
|      * Store new object. | ||||
|      * | ||||
|      * @throws FireflyException | ||||
|      * @throws ValidationException | ||||
|      */ | ||||
|     public function store(StoreRequest $request): JsonResponse | ||||
|     { | ||||
| @@ -81,7 +82,7 @@ class StoreController extends Controller | ||||
|         if (!$this->userRepository->hasRole($admin, 'owner')) { | ||||
|             // access denied:
 | ||||
|             $messages = ['name' => '200005: You need the "owner" role to do this.']; | ||||
|             \Validator::make([], $rules, $messages)->validate(); | ||||
|             Validator::make([], $rules, $messages)->validate(); | ||||
|         } | ||||
|         $data        = $request->getAll(); | ||||
|         // if currency ID is 0, find the currency by the code:
 | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Controllers\Models\TransactionLinkType; | ||||
| 
 | ||||
| use Illuminate\Support\Facades\Validator; | ||||
| use FireflyIII\Api\V1\Controllers\Controller; | ||||
| use FireflyIII\Api\V1\Requests\Models\TransactionLinkType\UpdateRequest; | ||||
| use FireflyIII\Exceptions\FireflyException; | ||||
| @@ -34,6 +35,7 @@ use FireflyIII\Support\Http\Api\TransactionFilter; | ||||
| use FireflyIII\Transformers\LinkTypeTransformer; | ||||
| use FireflyIII\User; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Validation\ValidationException; | ||||
| use League\Fractal\Resource\Item; | ||||
| 
 | ||||
| /** | ||||
| @@ -72,6 +74,7 @@ class UpdateController extends Controller | ||||
|      * Update object. | ||||
|      * | ||||
|      * @throws FireflyException | ||||
|      * @throws ValidationException | ||||
|      */ | ||||
|     public function update(UpdateRequest $request, LinkType $linkType): JsonResponse | ||||
|     { | ||||
| @@ -85,7 +88,7 @@ class UpdateController extends Controller | ||||
| 
 | ||||
|         if (!$this->userRepository->hasRole($admin, 'owner')) { | ||||
|             $messages = ['name' => '200005: You need the "owner" role to do this.']; | ||||
|             \Validator::make([], $rules, $messages)->validate(); | ||||
|             Validator::make([], $rules, $messages)->validate(); | ||||
|         } | ||||
| 
 | ||||
|         $data        = $request->getAll(); | ||||
|   | ||||
| @@ -30,6 +30,7 @@ use FireflyIII\Models\UserGroup; | ||||
| use FireflyIII\Repositories\UserGroup\UserGroupRepositoryInterface; | ||||
| use FireflyIII\Transformers\UserGroupTransformer; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| 
 | ||||
| class UpdateController extends Controller | ||||
| { | ||||
| @@ -54,7 +55,7 @@ class UpdateController extends Controller | ||||
| 
 | ||||
|     public function update(UpdateRequest $request, UserGroup $userGroup): JsonResponse | ||||
|     { | ||||
|         app('log')->debug(sprintf('Now in %s', __METHOD__)); | ||||
|         Log::debug(sprintf('Now in %s', __METHOD__)); | ||||
|         $data        = $request->getData(); | ||||
|         $userGroup   = $this->repository->update($userGroup, $data); | ||||
|         $userGroup->refresh(); | ||||
|   | ||||
| @@ -34,6 +34,7 @@ use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Http\Request; | ||||
| use Illuminate\Http\Response; | ||||
| use Illuminate\Pagination\LengthAwarePaginator; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use League\Fractal\Pagination\IlluminatePaginatorAdapter; | ||||
| use League\Fractal\Resource\Collection as FractalCollection; | ||||
| 
 | ||||
| @@ -71,7 +72,7 @@ class AccountController extends Controller | ||||
|         if ('' === $query || !in_array($field, $this->validFields, true)) { | ||||
|             return response(null, 422); | ||||
|         } | ||||
|         app('log')->debug(sprintf('Now in account search("%s", "%s")', $field, $query)); | ||||
|         Log::debug(sprintf('Now in account search("%s", "%s")', $field, $query)); | ||||
|         $types       = $this->mapAccountTypes($type); | ||||
| 
 | ||||
|         /** @var AccountSearch $search */ | ||||
| @@ -88,7 +89,6 @@ class AccountController extends Controller | ||||
|         $admin       = auth()->user(); | ||||
|         $enrichment  = new AccountEnrichment(); | ||||
|         $enrichment->setUser($admin); | ||||
|         $enrichment->setConvertToNative($this->convertToNative); | ||||
|         $enrichment->setNative($this->nativeCurrency); | ||||
|         $accounts    = $enrichment->enrich($accounts); | ||||
| 
 | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Controllers\Summary; | ||||
| 
 | ||||
| use Exception; | ||||
| use Carbon\Carbon; | ||||
| use FireflyIII\Api\V1\Controllers\Controller; | ||||
| use FireflyIII\Api\V1\Requests\Data\DateRequest; | ||||
| @@ -37,10 +38,13 @@ use FireflyIII\Repositories\Bill\BillRepositoryInterface; | ||||
| use FireflyIII\Repositories\Budget\AvailableBudgetRepositoryInterface; | ||||
| use FireflyIII\Repositories\Budget\BudgetRepositoryInterface; | ||||
| use FireflyIII\Repositories\Budget\OperationsRepositoryInterface; | ||||
| use FireflyIII\Repositories\UserGroups\Currency\CurrencyRepositoryInterface; | ||||
| use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface; | ||||
| use FireflyIII\Support\Facades\Amount; | ||||
| use FireflyIII\Support\Http\Api\ExchangeRateConverter; | ||||
| use FireflyIII\Support\Report\Summarizer\TransactionSummarizer; | ||||
| use FireflyIII\User; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Support\Collection; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| 
 | ||||
| /** | ||||
| @@ -88,7 +92,7 @@ class BasicController extends Controller | ||||
|      * This endpoint is documented at: | ||||
|      * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/summary/getBasicSummary
 | ||||
|      * | ||||
|      * @throws \Exception | ||||
|      * @throws Exception | ||||
|      */ | ||||
|     public function basic(DateRequest $request): JsonResponse | ||||
|     { | ||||
| @@ -97,10 +101,9 @@ class BasicController extends Controller | ||||
|         $start        = $dates['start']; | ||||
|         $end          = $dates['end']; | ||||
|         $code         = $request->get('currency_code'); | ||||
| 
 | ||||
|         // balance information:
 | ||||
|         $balanceData  = $this->getBalanceInformation($start, $end); | ||||
|         $billData     = $this->getBillInformation($start, $end); | ||||
|         $billData     = $this->getSubscriptionInformation($start, $end); | ||||
|         $spentData    = $this->getLeftToSpendInfo($start, $end); | ||||
|         $netWorthData = $this->getNetWorthInfo($end); | ||||
|         //                        $balanceData  = [];
 | ||||
| @@ -122,55 +125,117 @@ class BasicController extends Controller | ||||
| 
 | ||||
|     private function getBalanceInformation(Carbon $start, Carbon $end): array | ||||
|     { | ||||
|         Log::debug('getBalanceInformation'); | ||||
|         // some config settings
 | ||||
|         $convertToNative = Amount::convertToNative(); | ||||
|         $default         = Amount::getNativeCurrency(); | ||||
|         // prep some arrays:
 | ||||
|         $incomes         = []; | ||||
|         $expenses        = []; | ||||
|         $sums            = []; | ||||
|         $return          = []; | ||||
|         $currencies      = [ | ||||
|             $default->id => $default, | ||||
|         ]; | ||||
| 
 | ||||
|         // collect income of user using the new group collector.
 | ||||
|         /** @var GroupCollectorInterface $collector */ | ||||
|         $collector       = app(GroupCollectorInterface::class); | ||||
|         $collector->setRange($start, $end)->setPage($this->parameters->get('page'))->setTypes([TransactionTypeEnum::DEPOSIT->value]); | ||||
|         $summarizer      = new TransactionSummarizer(); | ||||
|         $set             = $collector->setRange($start, $end)->setTypes([TransactionTypeEnum::DEPOSIT->value])->getExtractedJournals(); | ||||
|         $incomes         = $summarizer->groupByCurrencyId($set, 'positive', false); | ||||
| 
 | ||||
|         $set             = $collector->getExtractedJournals(); | ||||
| 
 | ||||
|         /** @var array $journal */ | ||||
|         foreach ($set as $journal) { | ||||
|             $currencyId           = $convertToNative ? $default->id : (int) $journal['currency_id']; | ||||
|             $amount               = Amount::getAmountFromJournal($journal); | ||||
|             $incomes[$currencyId] ??= '0'; | ||||
|             $incomes[$currencyId] = bcadd( | ||||
|                 $incomes[$currencyId], | ||||
|                 bcmul($amount, '-1') | ||||
|             ); | ||||
|             $sums[$currencyId]    ??= '0'; | ||||
|             $sums[$currencyId]    = bcadd($sums[$currencyId], bcmul($amount, '-1')); | ||||
|         } | ||||
| 
 | ||||
|         // collect expenses of user.
 | ||||
|         // collect expenses of user using the new group collector.
 | ||||
|         /** @var GroupCollectorInterface $collector */ | ||||
|         $collector       = app(GroupCollectorInterface::class); | ||||
|         $collector->setRange($start, $end)->setPage($this->parameters->get('page'))->setTypes([TransactionTypeEnum::WITHDRAWAL->value]); | ||||
|         $set             = $collector->getExtractedJournals(); | ||||
|         $set             = $collector->setRange($start, $end)->setPage($this->parameters->get('page'))->setTypes([TransactionTypeEnum::WITHDRAWAL->value])->getExtractedJournals(); | ||||
|         $expenses        = $summarizer->groupByCurrencyId($set, 'negative', false); | ||||
| 
 | ||||
|         /** @var array $journal */ | ||||
|         foreach ($set as $journal) { | ||||
|             $currencyId            = $convertToNative ? $default->id : (int) $journal['currency_id']; | ||||
|             $amount                = Amount::getAmountFromJournal($journal); | ||||
|             $expenses[$currencyId] ??= '0'; | ||||
|             $expenses[$currencyId] = bcadd($expenses[$currencyId], $amount); | ||||
|             $sums[$currencyId]     ??= '0'; | ||||
|             $sums[$currencyId]     = bcadd($sums[$currencyId], $amount); | ||||
|         // if convert to native, do so right now.
 | ||||
|         if ($convertToNative) { | ||||
|             $newExpenses = [ | ||||
|                 $default->id => [ | ||||
|                     'currency_id'             => $default->id, | ||||
|                     'currency_code'           => $default->code, | ||||
|                     'currency_symbol'         => $default->symbol, | ||||
|                     'currency_decimal_places' => $default->decimal_places, | ||||
|                     'sum'                     => '0', | ||||
|                 ], | ||||
|             ]; | ||||
|             $newIncomes  = [ | ||||
|                 $default->id => [ | ||||
|                     'currency_id'             => $default->id, | ||||
|                     'currency_code'           => $default->code, | ||||
|                     'currency_symbol'         => $default->symbol, | ||||
|                     'currency_decimal_places' => $default->decimal_places, | ||||
|                     'sum'                     => '0', | ||||
|                 ], | ||||
|             ]; | ||||
|             $sums        = [ | ||||
|                 $default->id => [ | ||||
|                     'currency_id'             => $default->id, | ||||
|                     'currency_code'           => $default->code, | ||||
|                     'currency_symbol'         => $default->symbol, | ||||
|                     'currency_decimal_places' => $default->decimal_places, | ||||
|                     'sum'                     => '0', | ||||
|                 ], | ||||
|             ]; | ||||
| 
 | ||||
|             $converter   = new ExchangeRateConverter(); | ||||
|             // loop over income and expenses
 | ||||
|             foreach ([$expenses, $incomes] as $index => $array) { | ||||
| 
 | ||||
|                 // loop over either one.
 | ||||
|                 foreach ($array as $entry) { | ||||
| 
 | ||||
|                     // if it is the native currency already.
 | ||||
|                     if ($entry['currency_id'] === $default->id) { | ||||
|                         $sums[$default->id]['sum'] = bcadd((string) $entry['sum'], $sums[$default->id]['sum']); | ||||
| 
 | ||||
|                         // don't forget to add it to newExpenses and newIncome
 | ||||
|                         if (0 === $index) { | ||||
|                             $newExpenses[$default->id]['sum'] = bcadd($newExpenses[$default->id]['sum'], (string) $entry['sum']); | ||||
|                         } | ||||
|                         if (1 === $index) { | ||||
|                             $newIncomes[$default->id]['sum'] = bcadd($newIncomes[$default->id]['sum'], (string) $entry['sum']); | ||||
|                         } | ||||
| 
 | ||||
|                         continue; | ||||
|                     } | ||||
| 
 | ||||
|                     $currencies[$entry['currency_id']] ??= $this->currencyRepos->find($entry['currency_id']); | ||||
|                     $convertedSum              = $converter->convert($currencies[$entry['currency_id']], $default, $start, $entry['sum']); | ||||
|                     $sums[$default->id]['sum'] = bcadd($sums[$default->id]['sum'], $convertedSum); | ||||
|                     if (0 === $index) { | ||||
|                         $newExpenses[$default->id]['sum'] = bcadd($newExpenses[$default->id]['sum'], $convertedSum); | ||||
|                     } | ||||
|                     if (1 === $index) { | ||||
|                         $newIncomes[$default->id]['sum'] = bcadd($newIncomes[$default->id]['sum'], $convertedSum); | ||||
|                     } | ||||
|                 } | ||||
|             } | ||||
|             $incomes     = $newIncomes; | ||||
|             $expenses    = $newExpenses; | ||||
|         } | ||||
|         if (!$convertToNative) { | ||||
|             foreach ([$expenses, $incomes] as $array) { | ||||
|                 foreach ($array as $entry) { | ||||
|                     $currencyId               = $entry['currency_id']; | ||||
|                     $sums[$currencyId] ??= [ | ||||
|                         'currency_id'             => $entry['currency_id'], | ||||
|                         'currency_code'           => $entry['currency_code'], | ||||
|                         'currency_symbol'         => $entry['currency_symbol'], | ||||
|                         'currency_decimal_places' => $entry['currency_decimal_places'], | ||||
|                         'sum'                     => '0', | ||||
|                     ]; | ||||
|                     $sums[$currencyId]['sum'] = bcadd($sums[$currencyId]['sum'], (string) $entry['sum']); | ||||
|                 } | ||||
|             } | ||||
|         } | ||||
|         // format amounts:
 | ||||
|         $keys            = array_keys($sums); | ||||
|         foreach ($keys as $currencyId) { | ||||
|             $currency = $this->currencyRepos->find($currencyId); | ||||
|             $currency = $currencies[$currencyId] ?? $this->currencyRepos->find($currencyId); | ||||
|             if (null === $currency) { | ||||
|                 continue; | ||||
|             } | ||||
| @@ -178,37 +243,78 @@ class BasicController extends Controller | ||||
|             $return[] = [ | ||||
|                 'key'                     => sprintf('balance-in-%s', $currency->code), | ||||
|                 'title'                   => trans('firefly.box_balance_in_currency', ['currency' => $currency->symbol]), | ||||
|                 'monetary_value'          => $sums[$currencyId] ?? '0', | ||||
|                 'monetary_value'          => $sums[$currencyId]['sum'] ?? '0', | ||||
|                 'currency_id'             => (string) $currency->id, | ||||
|                 'currency_code'           => $currency->code, | ||||
|                 'currency_symbol'         => $currency->symbol, | ||||
|                 'currency_decimal_places' => $currency->decimal_places, | ||||
|                 'value_parsed'            => app('amount')->formatAnything($currency, $sums[$currencyId] ?? '0', false), | ||||
|                 'value_parsed'            => app('amount')->formatAnything($currency, $sums[$currencyId]['sum'] ?? '0', false), | ||||
|                 'local_icon'              => 'balance-scale', | ||||
|                 'sub_title'               => app('amount')->formatAnything($currency, $expenses[$currencyId] ?? '0', false). | ||||
|                                              ' + '.app('amount')->formatAnything($currency, $incomes[$currencyId] ?? '0', false), | ||||
|                 'sub_title'               => app('amount')->formatAnything($currency, $expenses[$currencyId]['sum'] ?? '0', false) | ||||
|                                              .' + '.app('amount')->formatAnything($currency, $incomes[$currencyId]['sum'] ?? '0', false), | ||||
|             ]; | ||||
|             $return[] = [ | ||||
|                 'key'                     => sprintf('spent-in-%s', $currency->code), | ||||
|                 'title'                   => trans('firefly.box_spent_in_currency', ['currency' => $currency->symbol]), | ||||
|                 'monetary_value'          => $expenses[$currencyId] ?? '0', | ||||
|                 'monetary_value'          => $expenses[$currencyId]['sum'] ?? '0', | ||||
|                 'currency_id'             => (string) $currency->id, | ||||
|                 'currency_code'           => $currency->code, | ||||
|                 'currency_symbol'         => $currency->symbol, | ||||
|                 'currency_decimal_places' => $currency->decimal_places, | ||||
|                 'value_parsed'            => app('amount')->formatAnything($currency, $expenses[$currencyId] ?? '0', false), | ||||
|                 'value_parsed'            => app('amount')->formatAnything($currency, $expenses[$currencyId]['sum'] ?? '0', false), | ||||
|                 'local_icon'              => 'balance-scale', | ||||
|                 'sub_title'               => '', | ||||
|             ]; | ||||
|             $return[] = [ | ||||
|                 'key'                     => sprintf('earned-in-%s', $currency->code), | ||||
|                 'title'                   => trans('firefly.box_earned_in_currency', ['currency' => $currency->symbol]), | ||||
|                 'monetary_value'          => $incomes[$currencyId] ?? '0', | ||||
|                 'monetary_value'          => $incomes[$currencyId]['sum'] ?? '0', | ||||
|                 'currency_id'             => (string) $currency->id, | ||||
|                 'currency_code'           => $currency->code, | ||||
|                 'currency_symbol'         => $currency->symbol, | ||||
|                 'currency_decimal_places' => $currency->decimal_places, | ||||
|                 'value_parsed'            => app('amount')->formatAnything($currency, $incomes[$currencyId] ?? '0', false), | ||||
|                 'value_parsed'            => app('amount')->formatAnything($currency, $incomes[$currencyId]['sum'] ?? '0', false), | ||||
|                 'local_icon'              => 'balance-scale', | ||||
|                 'sub_title'               => '', | ||||
|             ]; | ||||
|         } | ||||
|         if (0 === count($return)) { | ||||
|             $currency = $this->nativeCurrency; | ||||
|             // create objects for big array.
 | ||||
|             $return[] = [ | ||||
|                 'key'                     => sprintf('balance-in-%s', $currency->code), | ||||
|                 'title'                   => trans('firefly.box_balance_in_currency', ['currency' => $currency->symbol]), | ||||
|                 'monetary_value'          => '0', | ||||
|                 'currency_id'             => (string) $currency->id, | ||||
|                 'currency_code'           => $currency->code, | ||||
|                 'currency_symbol'         => $currency->symbol, | ||||
|                 'currency_decimal_places' => $currency->decimal_places, | ||||
|                 'value_parsed'            => app('amount')->formatAnything($currency, '0', false), | ||||
|                 'local_icon'              => 'balance-scale', | ||||
|                 'sub_title'               => app('amount')->formatAnything($currency, '0', false) | ||||
|                                              .' + '.app('amount')->formatAnything($currency, '0', false), | ||||
|             ]; | ||||
|             $return[] = [ | ||||
|                 'key'                     => sprintf('spent-in-%s', $currency->code), | ||||
|                 'title'                   => trans('firefly.box_spent_in_currency', ['currency' => $currency->symbol]), | ||||
|                 'monetary_value'          => '0', | ||||
|                 'currency_id'             => (string) $currency->id, | ||||
|                 'currency_code'           => $currency->code, | ||||
|                 'currency_symbol'         => $currency->symbol, | ||||
|                 'currency_decimal_places' => $currency->decimal_places, | ||||
|                 'value_parsed'            => app('amount')->formatAnything($currency, '0', false), | ||||
|                 'local_icon'              => 'balance-scale', | ||||
|                 'sub_title'               => '', | ||||
|             ]; | ||||
|             $return[] = [ | ||||
|                 'key'                     => sprintf('earned-in-%s', $currency->code), | ||||
|                 'title'                   => trans('firefly.box_earned_in_currency', ['currency' => $currency->symbol]), | ||||
|                 'monetary_value'          => '0', | ||||
|                 'currency_id'             => (string) $currency->id, | ||||
|                 'currency_code'           => $currency->code, | ||||
|                 'currency_symbol'         => $currency->symbol, | ||||
|                 'currency_decimal_places' => $currency->decimal_places, | ||||
|                 'value_parsed'            => app('amount')->formatAnything($currency, '0', false), | ||||
|                 'local_icon'              => 'balance-scale', | ||||
|                 'sub_title'               => '', | ||||
|             ]; | ||||
| @@ -217,15 +323,72 @@ class BasicController extends Controller | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     private function getBillInformation(Carbon $start, Carbon $end): array | ||||
|     private function getSubscriptionInformation(Carbon $start, Carbon $end): array | ||||
|     { | ||||
|         app('log')->debug(sprintf('Now in getBillInformation("%s", "%s")', $start->format('Y-m-d'), $end->format('Y-m-d-'))); | ||||
|         Log::debug(sprintf('Now in getBillInformation("%s", "%s")', $start->format('Y-m-d'), $end->format('Y-m-d-'))); | ||||
|         /* | ||||
|          * Since both this method and the chart use the exact same data, we can suffice | ||||
|          * with calling the one method in the bill repository that will get this amount. | ||||
|          */ | ||||
|         $paidAmount   = $this->billRepository->sumPaidInRange($start, $end); | ||||
|         $unpaidAmount = $this->billRepository->sumUnpaidInRange($start, $end); | ||||
|         $currencies   = [ | ||||
|             $this->nativeCurrency->id => $this->nativeCurrency, | ||||
|         ]; | ||||
| 
 | ||||
|         if ($this->convertToNative) { | ||||
|             $converter       = new ExchangeRateConverter(); | ||||
|             $newPaidAmount   = [[ | ||||
|                 'id'             => $this->nativeCurrency->id, | ||||
|                 'name'           => $this->nativeCurrency->name, | ||||
|                 'symbol'         => $this->nativeCurrency->symbol, | ||||
|                 'code'           => $this->nativeCurrency->code, | ||||
|                 'decimal_places' => $this->nativeCurrency->decimal_places, | ||||
|                 'sum'            => '0', | ||||
|             ]]; | ||||
| 
 | ||||
|             $newUnpaidAmount = [[ | ||||
|                 'id'             => $this->nativeCurrency->id, | ||||
|                 'name'           => $this->nativeCurrency->name, | ||||
|                 'symbol'         => $this->nativeCurrency->symbol, | ||||
|                 'code'           => $this->nativeCurrency->code, | ||||
|                 'decimal_places' => $this->nativeCurrency->decimal_places, | ||||
|                 'sum'            => '0', | ||||
|             ]]; | ||||
|             foreach ([$paidAmount, $unpaidAmount] as $index => $array) { | ||||
|                 foreach ($array as $item) { | ||||
|                     $currencyId                = (int) $item['id']; | ||||
|                     if (0 === $index) { | ||||
|                         // paid amount
 | ||||
|                         if ($currencyId === $this->nativeCurrency->id) { | ||||
|                             $newPaidAmount[0]['sum'] = bcadd($newPaidAmount[0]['sum'], (string) $item['sum']); | ||||
| 
 | ||||
|                             continue; | ||||
|                         } | ||||
|                         $currencies[$currencyId] ??= $this->currencyRepos->find($currencyId); | ||||
|                         $convertedAmount         = $converter->convert($currencies[$currencyId], $this->nativeCurrency, $start, $item['sum']); | ||||
|                         $newPaidAmount[0]['sum'] = bcadd($newPaidAmount[0]['sum'], $convertedAmount); | ||||
| 
 | ||||
|                         continue; | ||||
|                     } | ||||
|                     // unpaid amount
 | ||||
|                     if ($currencyId === $this->nativeCurrency->id) { | ||||
|                         $newUnpaidAmount[0]['sum'] = bcadd($newUnpaidAmount[0]['sum'], (string) $item['sum']); | ||||
| 
 | ||||
|                         continue; | ||||
|                     } | ||||
|                     $currencies[$currencyId] ??= $this->currencyRepos->find($currencyId); | ||||
|                     $convertedAmount           = $converter->convert($currencies[$currencyId], $this->nativeCurrency, $start, $item['sum']); | ||||
|                     $newUnpaidAmount[0]['sum'] = bcadd($newUnpaidAmount[0]['sum'], $convertedAmount); | ||||
|                 } | ||||
|             } | ||||
|             $paidAmount      = $newPaidAmount; | ||||
|             $unpaidAmount    = $newUnpaidAmount; | ||||
|         } | ||||
| 
 | ||||
|         //        var_dump($paidAmount);
 | ||||
|         //        var_dump($unpaidAmount);
 | ||||
|         //        exit;
 | ||||
| 
 | ||||
|         $return       = []; | ||||
| 
 | ||||
| @@ -233,7 +396,7 @@ class BasicController extends Controller | ||||
|          * @var array $info | ||||
|          */ | ||||
|         foreach ($paidAmount as $info) { | ||||
|             $amount   = bcmul($info['sum'], '-1'); | ||||
|             $amount   = bcmul((string) $info['sum'], '-1'); | ||||
|             $return[] = [ | ||||
|                 'key'                     => sprintf('bills-paid-in-%s', $info['code']), | ||||
|                 'title'                   => trans('firefly.box_bill_paid_in_currency', ['currency' => $info['symbol']]), | ||||
| @@ -252,7 +415,7 @@ class BasicController extends Controller | ||||
|          * @var array $info | ||||
|          */ | ||||
|         foreach ($unpaidAmount as $info) { | ||||
|             $amount   = bcmul($info['sum'], '-1'); | ||||
|             $amount   = bcmul((string) $info['sum'], '-1'); | ||||
|             $return[] = [ | ||||
|                 'key'                     => sprintf('bills-unpaid-in-%s', $info['code']), | ||||
|                 'title'                   => trans('firefly.box_bill_unpaid_in_currency', ['currency' => $info['symbol']]), | ||||
| @@ -266,16 +429,48 @@ class BasicController extends Controller | ||||
|                 'sub_title'               => '', | ||||
|             ]; | ||||
|         } | ||||
|         app('log')->debug(sprintf('Done with getBillInformation("%s", "%s")', $start->format('Y-m-d'), $end->format('Y-m-d-'))); | ||||
|         Log::debug(sprintf('Done with getBillInformation("%s", "%s")', $start->format('Y-m-d'), $end->format('Y-m-d-'))); | ||||
| 
 | ||||
|         if (0 === count($return)) { | ||||
|             $currency = $this->nativeCurrency; | ||||
|             unset($info, $amount); | ||||
| 
 | ||||
|             $return[] = [ | ||||
|                 'key'                     => sprintf('bills-paid-in-%s', $currency->code), | ||||
|                 'title'                   => trans('firefly.box_bill_paid_in_currency', ['currency' => $currency->symbol]), | ||||
|                 'monetary_value'          => '0', | ||||
|                 'currency_id'             => (string) $currency->id, | ||||
|                 'currency_code'           => $currency->code, | ||||
|                 'currency_symbol'         => $currency->symbol, | ||||
|                 'currency_decimal_places' => $currency->decimal_places, | ||||
|                 'value_parsed'            => app('amount')->formatFlat($currency->symbol, $currency->decimal_places, '0', false), | ||||
|                 'local_icon'              => 'check', | ||||
|                 'sub_title'               => '', | ||||
|             ]; | ||||
|             $return[] = [ | ||||
|                 'key'                     => sprintf('bills-unpaid-in-%s', $currency->code), | ||||
|                 'title'                   => trans('firefly.box_bill_unpaid_in_currency', ['currency' => $currency->symbol]), | ||||
|                 'monetary_value'          => '0', | ||||
|                 'currency_id'             => (string) $currency->id, | ||||
|                 'currency_code'           => $currency->code, | ||||
|                 'currency_symbol'         => $currency->symbol, | ||||
|                 'currency_decimal_places' => $currency->decimal_places, | ||||
|                 'value_parsed'            => app('amount')->formatFlat($currency->symbol, $currency->decimal_places, '0', false), | ||||
|                 'local_icon'              => 'calendar-o', | ||||
|                 'sub_title'               => '', | ||||
|             ]; | ||||
|         } | ||||
| 
 | ||||
| 
 | ||||
|         return $return; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * @throws \Exception | ||||
|      * @throws Exception | ||||
|      */ | ||||
|     private function getLeftToSpendInfo(Carbon $start, Carbon $end): array | ||||
|     { | ||||
| 
 | ||||
|         Log::debug(sprintf('Now in getLeftToSpendInfo("%s", "%s")', $start->format('Y-m-d H:i:s'), $end->format('Y-m-d H:i:s'))); | ||||
|         $return     = []; | ||||
|         $today      = today(config('app.timezone')); | ||||
| @@ -283,13 +478,41 @@ class BasicController extends Controller | ||||
|         $budgets    = $this->budgetRepository->getActiveBudgets(); | ||||
|         $spent      = $this->opsRepository->sumExpenses($start, $end, null, $budgets); | ||||
|         $days       = (int) $today->diffInDays($end, true) + 1; | ||||
|         $currencies = []; | ||||
| 
 | ||||
|         // first, create an entry for each entry in the "available" array.
 | ||||
|         /** @var array $availableBudget */ | ||||
|         foreach ($available as $currencyId => $availableBudget) { | ||||
|             $currencies[$currencyId] ??= $this->currencyRepos->find($currencyId); | ||||
|             $return[$currencyId] = [ | ||||
|                 'key'                     => sprintf('left-to-spend-in-%s', $currencies[$currencyId]->code), | ||||
|                 'title'                   => trans('firefly.box_left_to_spend_in_currency', ['currency' => $currencies[$currencyId]->symbol]), | ||||
|                 'no_available_budgets'    => false, | ||||
|                 'monetary_value'          => $availableBudget, | ||||
|                 'currency_id'             => (string) $currencies[$currencyId]->id, | ||||
|                 'currency_code'           => $currencies[$currencyId]->code, | ||||
|                 'currency_symbol'         => $currencies[$currencyId]->symbol, | ||||
|                 'currency_decimal_places' => $currencies[$currencyId]->decimal_places, | ||||
|                 'value_parsed'            => app('amount')->formatFlat($currencies[$currencyId]->symbol, $currencies[$currencyId]->decimal_places, $availableBudget, false), | ||||
|                 'local_icon'              => 'money', | ||||
|                 'sub_title'               => app('amount')->formatFlat( | ||||
|                     $currencies[$currencyId]->symbol, | ||||
|                     $currencies[$currencyId]->decimal_places, | ||||
|                     $availableBudget, | ||||
|                     false | ||||
|                 ), | ||||
|             ]; | ||||
|         } | ||||
|         foreach ($spent as $row) { | ||||
|             // either an amount was budgeted or 0 is available.
 | ||||
|             $currencyId      = $row['currency_id']; | ||||
|             $currencyId          = (int) $row['currency_id']; | ||||
|             $amount              = (string) ($available[$currencyId] ?? '0'); | ||||
|             if (0 === bccomp($amount, '0')) { | ||||
|                 // #9858 skip over currencies with no available budget.
 | ||||
|                 continue; | ||||
|             } | ||||
|             $spentInCurrency     = $row['sum']; | ||||
|             $leftToSpend     = bcadd($amount, $spentInCurrency); | ||||
|             $leftToSpend         = bcadd($amount, (string) $spentInCurrency); | ||||
|             $perDay              = '0'; | ||||
|             if (0 !== $days && bccomp($leftToSpend, '0') > -1) { | ||||
|                 $perDay = bcdiv($leftToSpend, (string) $days); | ||||
| @@ -297,9 +520,10 @@ class BasicController extends Controller | ||||
| 
 | ||||
|             Log::debug(sprintf('Spent %s %s', $row['currency_code'], $row['sum'])); | ||||
| 
 | ||||
|             $return[]        = [ | ||||
|             $return[$currencyId] = [ | ||||
|                 'key'                     => sprintf('left-to-spend-in-%s', $row['currency_code']), | ||||
|                 'title'                   => trans('firefly.box_left_to_spend_in_currency', ['currency' => $row['currency_symbol']]), | ||||
|                 'no_available_budgets'    => false, | ||||
|                 'monetary_value'          => $leftToSpend, | ||||
|                 'currency_id'             => (string) $row['currency_id'], | ||||
|                 'currency_code'           => $row['currency_code'], | ||||
| @@ -315,8 +539,66 @@ class BasicController extends Controller | ||||
|                 ), | ||||
|             ]; | ||||
|         } | ||||
|         unset($leftToSpend); | ||||
|         if (0 === count($return)) { | ||||
|             // a small trick to get every expense in this period, regardless of budget.
 | ||||
|             $spent = $this->opsRepository->sumExpenses($start, $end, null, new Collection()); | ||||
|             foreach ($spent as $row) { | ||||
|                 // either an amount was budgeted or 0 is available.
 | ||||
|                 $currencyId          = (int) $row['currency_id']; | ||||
|                 $spentInCurrency     = $row['sum']; | ||||
|                 $perDay              = '0'; | ||||
|                 if (0 !== $days && -1 === bccomp((string) $spentInCurrency, '0')) { | ||||
|                     $perDay = bcdiv((string) $spentInCurrency, (string) $days); | ||||
|                 } | ||||
| 
 | ||||
|         return $return; | ||||
|                 Log::debug(sprintf('Spent %s %s', $row['currency_code'], $row['sum'])); | ||||
| 
 | ||||
|                 $return[$currencyId] = [ | ||||
|                     'key'                     => sprintf('left-to-spend-in-%s', $row['currency_code']), | ||||
|                     'title'                   => trans('firefly.spent'), | ||||
|                     'no_available_budgets'    => true, | ||||
|                     'monetary_value'          => $spentInCurrency, | ||||
|                     'currency_id'             => (string) $row['currency_id'], | ||||
|                     'currency_code'           => $row['currency_code'], | ||||
|                     'currency_symbol'         => $row['currency_symbol'], | ||||
|                     'currency_decimal_places' => $row['currency_decimal_places'], | ||||
|                     'value_parsed'            => app('amount')->formatFlat($row['currency_symbol'], $row['currency_decimal_places'], $spentInCurrency, false), | ||||
|                     'local_icon'              => 'money', | ||||
|                     'sub_title'               => app('amount')->formatFlat( | ||||
|                         $row['currency_symbol'], | ||||
|                         $row['currency_decimal_places'], | ||||
|                         $perDay, | ||||
|                         false | ||||
|                     ), | ||||
|                 ]; | ||||
|             } | ||||
| 
 | ||||
|             //            $amount = '0';
 | ||||
|             //            // $days
 | ||||
|             //            // fill in by money spent, just count it.
 | ||||
|             //            $currency              = $this->nativeCurrency;
 | ||||
|             //            $return[$currency->id] = [
 | ||||
|             //                'key'                     => sprintf('left-to-spend-in-%s', $currency->code),
 | ||||
|             //                'title'                   => trans('firefly.box_left_to_spend_in_currency', ['currency' => $currency->symbol]),
 | ||||
|             //                'monetary_value'          => '0',
 | ||||
|             //                'no_available_budgets'    => true,
 | ||||
|             //                'currency_id'             => (string) $currency->id,
 | ||||
|             //                'currency_code'           => $currency->code,
 | ||||
|             //                'currency_symbol'         => $currency->symbol,
 | ||||
|             //                'currency_decimal_places' => $currency->decimal_places,
 | ||||
|             //                'value_parsed'            => app('amount')->formatFlat($currency->symbol, $currency->decimal_places, '0', false),
 | ||||
|             //                'local_icon'              => 'money',
 | ||||
|             //                'sub_title'               => app('amount')->formatFlat(
 | ||||
|             //                    $currency->symbol,
 | ||||
|             //                    $currency->decimal_places,
 | ||||
|             //                    '0',
 | ||||
|             //                    false
 | ||||
|             //                ),
 | ||||
|             //            ];
 | ||||
|         } | ||||
| 
 | ||||
|         return array_values($return); | ||||
|     } | ||||
| 
 | ||||
|     private function getNetWorthInfo(Carbon $end): array | ||||
| @@ -348,7 +630,7 @@ class BasicController extends Controller | ||||
|                 continue; | ||||
|             } | ||||
|             $amount   = $data['balance']; | ||||
|             if (0 === bccomp($amount, '0')) { | ||||
|             if (0 === bccomp((string) $amount, '0')) { | ||||
|                 continue; | ||||
|             } | ||||
|             // return stuff
 | ||||
| @@ -391,15 +673,14 @@ class BasicController extends Controller | ||||
|      */ | ||||
|     protected function notInDateRange(Carbon $date, Carbon $start, Carbon $end): bool // Validate a preference
 | ||||
|     { | ||||
|         $result = false; | ||||
|         if ($start->greaterThanOrEqualTo($date) && $end->greaterThanOrEqualTo($date)) { | ||||
|             $result = true; | ||||
|             return true; | ||||
|         } | ||||
|         // start and end in the past? use $end
 | ||||
|         if ($start->lessThanOrEqualTo($date) && $end->lessThanOrEqualTo($date)) { | ||||
|             $result = true; | ||||
|             return true; | ||||
|         } | ||||
| 
 | ||||
|         return $result; | ||||
|         return false; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -24,12 +24,16 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Controllers\System; | ||||
| 
 | ||||
| use FireflyIII\Support\Facades\FireflyConfig; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Support\Facades\Validator; | ||||
| use FireflyIII\Api\V1\Controllers\Controller; | ||||
| use FireflyIII\Api\V1\Requests\System\UpdateRequest; | ||||
| use FireflyIII\Exceptions\FireflyException; | ||||
| use FireflyIII\Repositories\User\UserRepositoryInterface; | ||||
| use FireflyIII\Support\Binder\EitherConfigKey; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Validation\ValidationException; | ||||
| 
 | ||||
| /** | ||||
|  * Class ConfigurationController | ||||
| @@ -64,8 +68,8 @@ class ConfigurationController extends Controller | ||||
|         try { | ||||
|             $dynamicData = $this->getDynamicConfiguration(); | ||||
|         } catch (FireflyException $e) { | ||||
|             app('log')->error($e->getMessage()); | ||||
|             app('log')->error($e->getTraceAsString()); | ||||
|             Log::error($e->getMessage()); | ||||
|             Log::error($e->getTraceAsString()); | ||||
| 
 | ||||
|             throw new FireflyException('200030: Could not load config variables.', 0, $e); | ||||
|         } | ||||
| @@ -91,13 +95,15 @@ class ConfigurationController extends Controller | ||||
| 
 | ||||
|     /** | ||||
|      * Get all config values. | ||||
|      * | ||||
|      * @throws FireflyException | ||||
|      */ | ||||
|     private function getDynamicConfiguration(): array | ||||
|     { | ||||
|         $isDemoSite  = app('fireflyconfig')->get('is_demo_site'); | ||||
|         $updateCheck = app('fireflyconfig')->get('permission_update_check'); | ||||
|         $lastCheck   = app('fireflyconfig')->get('last_update_check'); | ||||
|         $singleUser  = app('fireflyconfig')->get('single_user_mode'); | ||||
|         $isDemoSite  = FireflyConfig::get('is_demo_site'); | ||||
|         $updateCheck = FireflyConfig::get('permission_update_check'); | ||||
|         $lastCheck   = FireflyConfig::get('last_update_check'); | ||||
|         $singleUser  = FireflyConfig::get('single_user_mode'); | ||||
| 
 | ||||
|         return [ | ||||
|             'is_demo_site'            => $isDemoSite?->data, | ||||
| @@ -152,18 +158,19 @@ class ConfigurationController extends Controller | ||||
|      * Update the configuration. | ||||
|      * | ||||
|      * @throws FireflyException | ||||
|      * @throws ValidationException | ||||
|      */ | ||||
|     public function update(UpdateRequest $request, string $name): JsonResponse | ||||
|     { | ||||
|         $rules     = ['value' => 'required']; | ||||
|         if (!$this->repository->hasRole(auth()->user(), 'owner')) { | ||||
|             $messages = ['value' => '200005: You need the "owner" role to do this.']; | ||||
|             \Validator::make([], $rules, $messages)->validate(); | ||||
|             Validator::make([], $rules, $messages)->validate(); | ||||
|         } | ||||
|         $data      = $request->getAll(); | ||||
|         $shortName = str_replace('configuration.', '', $name); | ||||
| 
 | ||||
|         app('fireflyconfig')->set($shortName, $data['value']); | ||||
|         FireflyConfig::set($shortName, $data['value']); | ||||
| 
 | ||||
|         // get updated config:
 | ||||
|         $newConfig = $this->getDynamicConfiguration(); | ||||
|   | ||||
| @@ -28,6 +28,7 @@ use FireflyIII\Api\V1\Controllers\Controller; | ||||
| use FireflyIII\Api\V1\Requests\System\CronRequest; | ||||
| use FireflyIII\Support\Http\Controllers\CronRunner; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| 
 | ||||
| /** | ||||
|  * Class CronController | ||||
| @@ -44,8 +45,8 @@ class CronController extends Controller | ||||
|     { | ||||
|         $config                           = $request->getAll(); | ||||
| 
 | ||||
|         app('log')->debug(sprintf('Now in %s', __METHOD__)); | ||||
|         app('log')->debug(sprintf('Date is %s', $config['date']->toIsoString())); | ||||
|         Log::debug(sprintf('Now in %s', __METHOD__)); | ||||
|         Log::debug(sprintf('Date is %s', $config['date']->toIsoString())); | ||||
|         $return                           = []; | ||||
|         $return['recurring_transactions'] = $this->runRecurring($config['force'], $config['date']); | ||||
|         $return['auto_budgets']           = $this->runAutoBudget($config['force'], $config['date']); | ||||
|   | ||||
| @@ -33,6 +33,7 @@ use FireflyIII\Transformers\UserTransformer; | ||||
| use FireflyIII\User; | ||||
| use Illuminate\Http\JsonResponse; | ||||
| use Illuminate\Pagination\LengthAwarePaginator; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use League\Fractal\Pagination\IlluminatePaginatorAdapter; | ||||
| use League\Fractal\Resource\Collection as FractalCollection; | ||||
| use League\Fractal\Resource\Item; | ||||
| @@ -174,7 +175,7 @@ class UserController extends Controller | ||||
| 
 | ||||
|         // can only update 'blocked' when user is admin.
 | ||||
|         if (!$this->repository->hasRole(auth()->user(), 'owner')) { | ||||
|             app('log')->debug('Quietly drop fields "blocked" and "blocked_code" from request.'); | ||||
|             Log::debug('Quietly drop fields "blocked" and "blocked_code" from request.'); | ||||
|             unset($data['blocked'], $data['blocked_code']); | ||||
|         } | ||||
| 
 | ||||
|   | ||||
| @@ -138,7 +138,7 @@ class ShowController extends Controller | ||||
|             throw new NotFoundHttpException('Webhooks are not enabled.'); | ||||
|         } | ||||
| 
 | ||||
|         app('log')->debug(sprintf('Now in triggerTransaction(%d, %d)', $webhook->id, $group->id)); | ||||
|         Log::debug(sprintf('Now in triggerTransaction(%d, %d)', $webhook->id, $group->id)); | ||||
|         Log::channel('audit')->info(sprintf('User triggers webhook #%d on transaction group #%d.', $webhook->id, $group->id)); | ||||
| 
 | ||||
|         /** @var MessageGeneratorInterface $engine */ | ||||
| @@ -155,7 +155,7 @@ class ShowController extends Controller | ||||
|         $engine->generateMessages(); | ||||
| 
 | ||||
|         // trigger event to send them:
 | ||||
|         app('log')->debug('send event RequestedSendWebhookMessages'); | ||||
|         Log::debug('send event RequestedSendWebhookMessages'); | ||||
|         event(new RequestedSendWebhookMessages()); | ||||
| 
 | ||||
|         return response()->json([], 204); | ||||
|   | ||||
| @@ -76,6 +76,6 @@ class SubmitController extends Controller | ||||
|             SendWebhookMessage::dispatch($message)->afterResponse(); | ||||
|         } | ||||
| 
 | ||||
|         return response()->json([]); | ||||
|         return response()->json(); | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -23,6 +23,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Middleware; | ||||
| 
 | ||||
| use Closure; | ||||
| use FireflyIII\User; | ||||
| use Illuminate\Http\Request; | ||||
| 
 | ||||
| @@ -36,7 +37,7 @@ class ApiDemoUser | ||||
|      * | ||||
|      * @return mixed | ||||
|      */ | ||||
|     public function handle(Request $request, \Closure $next) | ||||
|     public function handle(Request $request, Closure $next) | ||||
|     { | ||||
|         /** @var null|User $user */ | ||||
|         $user = $request->user(); | ||||
|   | ||||
| @@ -58,7 +58,7 @@ class AutocompleteRequest extends FormRequest | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'date' => 'date|after:1900-01-01|before:2099-12-31', | ||||
|             'date' => 'date|after:1970-01-02|before:2038-01-17', | ||||
|         ]; | ||||
|     } | ||||
| } | ||||
|   | ||||
							
								
								
									
										91
									
								
								app/Api/V1/Requests/Chart/ChartRequest.php
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										91
									
								
								app/Api/V1/Requests/Chart/ChartRequest.php
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,91 @@ | ||||
| <?php | ||||
| 
 | ||||
| /* | ||||
|  * DashboardChartRequest.php | ||||
|  * Copyright (c) 2023 james@firefly-iii.org | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
|  * This program is free software: you can redistribute it and/or modify | ||||
|  * it under the terms of the GNU Affero General Public License as | ||||
|  * published by the Free Software Foundation, either version 3 of the | ||||
|  * License, or (at your option) any later version. | ||||
|  * | ||||
|  * This program is distributed in the hope that it will be useful, | ||||
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see <https://www.gnu.org/licenses/>. | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Chart; | ||||
| 
 | ||||
| use Illuminate\Contracts\Validation\Validator; | ||||
| use FireflyIII\Enums\UserRoleEnum; | ||||
| use FireflyIII\Support\Http\Api\ValidatesUserGroupTrait; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| 
 | ||||
| /** | ||||
|  * Class ChartRequest | ||||
|  */ | ||||
| class ChartRequest extends FormRequest | ||||
| { | ||||
|     use ChecksLogin; | ||||
|     use ConvertsDataTypes; | ||||
|     use ValidatesUserGroupTrait; | ||||
| 
 | ||||
|     protected array $acceptedRoles = [UserRoleEnum::READ_ONLY]; | ||||
| 
 | ||||
|     public function getParameters(): array | ||||
|     { | ||||
|         return [ | ||||
|             'start'       => $this->convertDateTime('start')?->startOfDay(), | ||||
|             'end'         => $this->convertDateTime('end')?->endOfDay(), | ||||
|             'preselected' => $this->convertString('preselected', 'empty'), | ||||
|             'period'      => $this->convertString('period', '1M'), | ||||
|             'accounts'    => $this->arrayFromValue($this->get('accounts')), | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * The rules that the incoming request must be matched against. | ||||
|      */ | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'start'       => 'required|date|after:1970-01-02|before:2038-01-17|before_or_equal:end', | ||||
|             'end'         => 'required|date|after:1970-01-02|before:2038-01-17|after_or_equal:start', | ||||
|             'preselected' => sprintf('nullable|in:%s', implode(',', config('firefly.preselected_accounts'))), | ||||
|             'period'      => sprintf('nullable|in:%s', implode(',', config('firefly.valid_view_ranges'))), | ||||
|             'accounts.*'  => 'exists:accounts,id', | ||||
|         ]; | ||||
| 
 | ||||
|     } | ||||
| 
 | ||||
|     public function withValidator(Validator $validator): void | ||||
|     { | ||||
|         $validator->after( | ||||
|             static function (Validator $validator): void { | ||||
|                 // validate transaction query data.
 | ||||
|                 $data = $validator->getData(); | ||||
|                 if (!array_key_exists('accounts', $data)) { | ||||
|                     // $validator->errors()->add('accounts', trans('validation.filled', ['attribute' => 'accounts']));
 | ||||
|                     return; | ||||
|                 } | ||||
|                 if (!is_array($data['accounts'])) { | ||||
|                     $validator->errors()->add('accounts', trans('validation.filled', ['attribute' => 'accounts'])); | ||||
|                 } | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', self::class), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| } | ||||
| @@ -24,12 +24,12 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Data\Bulk; | ||||
| 
 | ||||
| use Illuminate\Contracts\Validation\Validator; | ||||
| use FireflyIII\Repositories\Account\AccountRepositoryInterface; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Validation\Validator; | ||||
| 
 | ||||
| /** | ||||
|  * Class MoveTransactionsRequest | ||||
| @@ -74,7 +74,7 @@ class MoveTransactionsRequest extends FormRequest | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', self::class), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|   | ||||
| @@ -24,6 +24,8 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Data\Bulk; | ||||
| 
 | ||||
| use Illuminate\Contracts\Validation\Validator; | ||||
| use JsonException; | ||||
| use FireflyIII\Enums\ClauseType; | ||||
| use FireflyIII\Rules\IsValidBulkClause; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| @@ -31,7 +33,8 @@ use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use FireflyIII\Validation\Api\Data\Bulk\ValidatesBulkTransactionQuery; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Validation\Validator; | ||||
| 
 | ||||
| use function Safe\json_decode; | ||||
| 
 | ||||
| /** | ||||
|  * Class TransactionRequest | ||||
| @@ -50,9 +53,9 @@ class TransactionRequest extends FormRequest | ||||
|             $data = [ | ||||
|                 'query' => json_decode($this->get('query'), true, 8, JSON_THROW_ON_ERROR), | ||||
|             ]; | ||||
|         } catch (\JsonException $e) { | ||||
|             // dont really care. the validation should catch invalid json.
 | ||||
|             app('log')->error($e->getMessage()); | ||||
|         } catch (JsonException $e) { | ||||
|             // don't really care. the validation should catch invalid json.
 | ||||
|             Log::error($e->getMessage()); | ||||
|         } | ||||
| 
 | ||||
|         return $data; | ||||
| @@ -74,7 +77,7 @@ class TransactionRequest extends FormRequest | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', self::class), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -65,9 +65,9 @@ class DateRequest extends FormRequest | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'date'  => 'date|after:1900-01-01|before:2099-12-31', | ||||
|             'start' => 'date|after:1900-01-01|before:2099-12-31|before:end|required_with:end', | ||||
|             'end'   => 'date|after:1900-01-01|before:2099-12-31|after:start|required_with:start', | ||||
|             'date'  => 'date|after:1970-01-02|before:2038-01-17', | ||||
|             'start' => 'date|after:1970-01-02|before:2038-01-17|before:end|required_with:end', | ||||
|             'end'   => 'date|after:1970-01-02|before:2038-01-17|after:start|required_with:start', | ||||
|         ]; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -49,9 +49,9 @@ class DestroyRequest extends FormRequest | ||||
|      */ | ||||
|     public function rules(): array | ||||
|     { | ||||
|         $valid = 'budgets,bills,piggy_banks,rules,recurring,categories,tags,object_groups'. | ||||
|                  ',accounts,asset_accounts,expense_accounts,revenue_accounts,liabilities,transactions,withdrawals,deposits,transfers'. | ||||
|                  ',not_assets_liabilities'; | ||||
|         $valid = 'budgets,bills,piggy_banks,rules,recurring,categories,tags,object_groups' | ||||
|                  .',accounts,asset_accounts,expense_accounts,revenue_accounts,liabilities,transactions,withdrawals,deposits,transfers' | ||||
|                  .',not_assets_liabilities'; | ||||
| 
 | ||||
|         return [ | ||||
|             'objects' => sprintf('required|max:255|min:1|string|in:%s', $valid), | ||||
|   | ||||
							
								
								
									
										62
									
								
								app/Api/V1/Requests/Generic/DateRequest.php
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										62
									
								
								app/Api/V1/Requests/Generic/DateRequest.php
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,62 @@ | ||||
| <?php | ||||
| 
 | ||||
| /* | ||||
|  * DateRequest.php | ||||
|  * Copyright (c) 2021 james@firefly-iii.org | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
|  * This program is free software: you can redistribute it and/or modify | ||||
|  * it under the terms of the GNU Affero General Public License as | ||||
|  * published by the Free Software Foundation, either version 3 of the | ||||
|  * License, or (at your option) any later version. | ||||
|  * | ||||
|  * This program is distributed in the hope that it will be useful, | ||||
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see <https://www.gnu.org/licenses/>. | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Generic; | ||||
| 
 | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| 
 | ||||
| /** | ||||
|  * Request class for end points that require date parameters. | ||||
|  * | ||||
|  * Class DateRequest | ||||
|  */ | ||||
| class DateRequest extends FormRequest | ||||
| { | ||||
|     use ChecksLogin; | ||||
|     use ConvertsDataTypes; | ||||
| 
 | ||||
|     /** | ||||
|      * Get all data from the request. | ||||
|      */ | ||||
|     public function getAll(): array | ||||
|     { | ||||
|         return [ | ||||
|             'start' => $this->getCarbonDate('start')->startOfDay(), | ||||
|             'end'   => $this->getCarbonDate('end')->endOfDay(), | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * The rules that the incoming request must be matched against. | ||||
|      */ | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'start' => 'required|date|after:1970-01-02|before:2038-01-17', | ||||
|             'end'   => 'required|date|after_or_equal:start|before:2038-01-17|after:1970-01-02', | ||||
|         ]; | ||||
|     } | ||||
| } | ||||
							
								
								
									
										59
									
								
								app/Api/V1/Requests/Generic/SingleDateRequest.php
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										59
									
								
								app/Api/V1/Requests/Generic/SingleDateRequest.php
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,59 @@ | ||||
| <?php | ||||
| 
 | ||||
| /* | ||||
|  * DateRequest.php | ||||
|  * Copyright (c) 2021 james@firefly-iii.org | ||||
|  * | ||||
|  * This file is part of Firefly III (https://github.com/firefly-iii). | ||||
|  * | ||||
|  * This program is free software: you can redistribute it and/or modify | ||||
|  * it under the terms of the GNU Affero General Public License as | ||||
|  * published by the Free Software Foundation, either version 3 of the | ||||
|  * License, or (at your option) any later version. | ||||
|  * | ||||
|  * This program is distributed in the hope that it will be useful, | ||||
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the | ||||
|  * GNU Affero General Public License for more details. | ||||
|  * | ||||
|  * You should have received a copy of the GNU Affero General Public License | ||||
|  * along with this program.  If not, see <https://www.gnu.org/licenses/>. | ||||
|  */ | ||||
| 
 | ||||
| declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Generic; | ||||
| 
 | ||||
| use Carbon\Carbon; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| 
 | ||||
| /** | ||||
|  * Request class for end points that require a date parameter. | ||||
|  * | ||||
|  * Class SingleDateRequest | ||||
|  */ | ||||
| class SingleDateRequest extends FormRequest | ||||
| { | ||||
|     use ChecksLogin; | ||||
|     use ConvertsDataTypes; | ||||
| 
 | ||||
|     /** | ||||
|      * Get all data from the request. | ||||
|      */ | ||||
|     public function getDate(): Carbon | ||||
|     { | ||||
|         return $this->getCarbonDate('date'); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * The rules that the incoming request must be matched against. | ||||
|      */ | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'date' => 'required|date|after:1970-01-02|before:2038-01-17', | ||||
|         ]; | ||||
|     } | ||||
| } | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Models\Account; | ||||
| 
 | ||||
| use Illuminate\Contracts\Validation\Validator; | ||||
| use FireflyIII\Models\Account; | ||||
| use FireflyIII\Models\Location; | ||||
| use FireflyIII\Repositories\Account\AccountRepositoryInterface; | ||||
| @@ -35,7 +36,6 @@ use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Validation\Validator; | ||||
| 
 | ||||
| /** | ||||
|  * Class UpdateRequest | ||||
| @@ -144,7 +144,7 @@ class UpdateRequest extends FormRequest | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', self::class), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -58,9 +58,7 @@ class StoreRequest extends FormRequest | ||||
|     { | ||||
|         $models = config('firefly.valid_attachment_models'); | ||||
|         $models = array_map( | ||||
|             static function (string $className) { | ||||
|                 return str_replace('FireflyIII\Models\\', '', $className); | ||||
|             }, | ||||
|             static fn (string $className) => str_replace('FireflyIII\Models\\', '', $className), | ||||
|             $models | ||||
|         ); | ||||
|         $models = implode(',', $models); | ||||
|   | ||||
| @@ -60,9 +60,7 @@ class UpdateRequest extends FormRequest | ||||
|     { | ||||
|         $models = config('firefly.valid_attachment_models'); | ||||
|         $models = array_map( | ||||
|             static function (string $className) { | ||||
|                 return str_replace('FireflyIII\Models\\', '', $className); | ||||
|             }, | ||||
|             static fn (string $className) => str_replace('FireflyIII\Models\\', '', $className), | ||||
|             $models | ||||
|         ); | ||||
|         $models = implode(',', $models); | ||||
|   | ||||
| @@ -24,13 +24,13 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Models\AvailableBudget; | ||||
| 
 | ||||
| use Illuminate\Contracts\Validation\Validator; | ||||
| use Carbon\Carbon; | ||||
| use FireflyIII\Rules\IsValidPositiveAmount; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Validation\Validator; | ||||
| 
 | ||||
| /** | ||||
|  * Class Request | ||||
| @@ -66,8 +66,8 @@ class Request extends FormRequest | ||||
|             'currency_id'   => 'numeric|exists:transaction_currencies,id', | ||||
|             'currency_code' => 'min:3|max:51|exists:transaction_currencies,code', | ||||
|             'amount'        => ['nullable', new IsValidPositiveAmount()], | ||||
|             'start'         => 'date|after:1900-01-01|before:2099-12-31', | ||||
|             'end'           => 'date|after:1900-01-01|before:2099-12-31', | ||||
|             'start'         => 'date|after:1970-01-02|before:2038-01-17', | ||||
|             'end'           => 'date|after:1970-01-02|before:2038-01-17', | ||||
|         ]; | ||||
|     } | ||||
| 
 | ||||
| @@ -90,7 +90,7 @@ class Request extends FormRequest | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', self::class), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -24,13 +24,15 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Models\Bill; | ||||
| 
 | ||||
| use Illuminate\Contracts\Validation\Validator; | ||||
| use ValueError; | ||||
| use TypeError; | ||||
| use FireflyIII\Rules\IsBoolean; | ||||
| use FireflyIII\Rules\IsValidPositiveAmount; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Validation\Validator; | ||||
| 
 | ||||
| /** | ||||
|  * Class StoreRequest | ||||
| @@ -45,7 +47,7 @@ class StoreRequest extends FormRequest | ||||
|      */ | ||||
|     public function getAll(): array | ||||
|     { | ||||
|         app('log')->debug('Raw fields in Bill StoreRequest', $this->all()); | ||||
|         Log::debug('Raw fields in Bill StoreRequest', $this->all()); | ||||
|         $fields = [ | ||||
|             'name'               => ['name', 'convertString'], | ||||
|             'amount_min'         => ['amount_min', 'convertString'], | ||||
| @@ -78,9 +80,9 @@ class StoreRequest extends FormRequest | ||||
|             'amount_max'     => ['required', new IsValidPositiveAmount()], | ||||
|             'currency_id'    => 'numeric|exists:transaction_currencies,id', | ||||
|             'currency_code'  => 'min:3|max:51|exists:transaction_currencies,code', | ||||
|             'date'           => 'date|required|after:1900-01-01|before:2099-12-31', | ||||
|             'end_date'       => 'nullable|date|after:date|after:1900-01-01|before:2099-12-31', | ||||
|             'extension_date' => 'nullable|date|after:date|after:1900-01-01|before:2099-12-31', | ||||
|             'date'           => 'date|required|after:1970-01-02|before:2038-01-17', | ||||
|             'end_date'       => 'nullable|date|after:date|after:1970-01-02|before:2038-01-17', | ||||
|             'extension_date' => 'nullable|date|after:date|after:1970-01-02|before:2038-01-17', | ||||
|             'repeat_freq'    => 'in:weekly,monthly,quarterly,half-year,yearly|required', | ||||
|             'skip'           => 'min:0|max:31|numeric', | ||||
|             'active'         => [new IsBoolean()], | ||||
| @@ -109,7 +111,7 @@ class StoreRequest extends FormRequest | ||||
| 
 | ||||
|                 try { | ||||
|                     $result = bccomp($min, $max); | ||||
|                 } catch (\ValueError $e) { | ||||
|                 } catch (ValueError $e) { | ||||
|                     Log::error($e->getMessage()); | ||||
|                     $validator->errors()->add('amount_min', (string) trans('validation.generic_invalid')); | ||||
|                     $validator->errors()->add('amount_max', (string) trans('validation.generic_invalid')); | ||||
| @@ -124,12 +126,11 @@ class StoreRequest extends FormRequest | ||||
| 
 | ||||
|         try { | ||||
|             $failed = $validator->fails(); | ||||
|         } catch (\TypeError $e) { | ||||
|         } catch (TypeError $e) { | ||||
|             Log::error($e->getMessage()); | ||||
|             $failed = false; | ||||
|         } | ||||
|         if ($failed) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', self::class), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Models\Bill; | ||||
| 
 | ||||
| use Illuminate\Contracts\Validation\Validator; | ||||
| use FireflyIII\Models\Bill; | ||||
| use FireflyIII\Rules\IsBoolean; | ||||
| use FireflyIII\Rules\IsValidPositiveAmount; | ||||
| @@ -31,7 +32,6 @@ use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Validation\Validator; | ||||
| 
 | ||||
| /** | ||||
|  * Class UpdateRequest | ||||
| @@ -81,9 +81,9 @@ class UpdateRequest extends FormRequest | ||||
|             'amount_max'     => ['nullable', new IsValidPositiveAmount()], | ||||
|             'currency_id'    => 'numeric|exists:transaction_currencies,id', | ||||
|             'currency_code'  => 'min:3|max:51|exists:transaction_currencies,code', | ||||
|             'date'           => 'date|after:1900-01-01|before:2099-12-31', | ||||
|             'end_date'       => 'date|after:date|after:1900-01-01|before:2099-12-31', | ||||
|             'extension_date' => 'date|after:date|after:1900-01-01|before:2099-12-31', | ||||
|             'date'           => 'date|after:1970-01-02|before:2038-01-17', | ||||
|             'end_date'       => 'date|after:date|after:1970-01-02|before:2038-01-17', | ||||
|             'extension_date' => 'date|after:date|after:1970-01-02|before:2038-01-17', | ||||
|             'repeat_freq'    => 'in:weekly,monthly,quarterly,half-year,yearly', | ||||
|             'skip'           => 'min:0|max:31|numeric', | ||||
|             'active'         => [new IsBoolean()], | ||||
| @@ -110,7 +110,7 @@ class UpdateRequest extends FormRequest | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', self::class), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Models\Budget; | ||||
| 
 | ||||
| use Illuminate\Contracts\Validation\Validator; | ||||
| use FireflyIII\Rules\IsBoolean; | ||||
| use FireflyIII\Rules\IsValidPositiveAmount; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| @@ -31,7 +32,6 @@ use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use FireflyIII\Validation\AutoBudget\ValidatesAutoBudgetRequest; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Validation\Validator; | ||||
| 
 | ||||
| /** | ||||
|  * Class StoreRequest | ||||
| @@ -94,7 +94,7 @@ class StoreRequest extends FormRequest | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', self::class), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Models\Budget; | ||||
| 
 | ||||
| use Illuminate\Contracts\Validation\Validator; | ||||
| use FireflyIII\Models\Budget; | ||||
| use FireflyIII\Rules\IsBoolean; | ||||
| use FireflyIII\Rules\IsValidPositiveAmount; | ||||
| @@ -32,7 +33,6 @@ use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use FireflyIII\Validation\AutoBudget\ValidatesAutoBudgetRequest; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Validation\Validator; | ||||
| 
 | ||||
| /** | ||||
|  * Class UpdateRequest | ||||
| @@ -106,7 +106,7 @@ class UpdateRequest extends FormRequest | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', self::class), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -24,13 +24,13 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Models\BudgetLimit; | ||||
| 
 | ||||
| use Illuminate\Contracts\Validation\Validator; | ||||
| use Carbon\Carbon; | ||||
| use FireflyIII\Rules\IsValidPositiveAmount; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Validation\Validator; | ||||
| 
 | ||||
| /** | ||||
|  * Class UpdateRequest | ||||
| @@ -67,8 +67,8 @@ class UpdateRequest extends FormRequest | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'start'         => 'date|after:1900-01-01|before:2099-12-31', | ||||
|             'end'           => 'date|after:1900-01-01|before:2099-12-31', | ||||
|             'start'         => 'date|after:1970-01-02|before:2038-01-17', | ||||
|             'end'           => 'date|after:1970-01-02|before:2038-01-17', | ||||
|             'amount'        => ['nullable', new IsValidPositiveAmount()], | ||||
|             'currency_id'   => 'numeric|exists:transaction_currencies,id', | ||||
|             'currency_code' => 'min:3|max:51|exists:transaction_currencies,code', | ||||
| @@ -96,7 +96,7 @@ class UpdateRequest extends FormRequest | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', self::class), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -45,7 +45,7 @@ class DestroyRequest extends FormRequest | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'date'  => 'required|date|after:1900-01-01|before:2099-12-31', | ||||
|             'date' => 'required|date|after:1970-01-02|before:2038-01-17', | ||||
|         ]; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -40,16 +40,16 @@ class StoreRequest extends FormRequest | ||||
|         return $this->getCarbonDate('date'); | ||||
|     } | ||||
| 
 | ||||
|     public function getRate(): string | ||||
|     { | ||||
|         return (string) $this->get('rate'); | ||||
|     } | ||||
| 
 | ||||
|     public function getFromCurrency(): TransactionCurrency | ||||
|     { | ||||
|         return TransactionCurrency::where('code', $this->get('from'))->first(); | ||||
|     } | ||||
| 
 | ||||
|     public function getRate(): string | ||||
|     { | ||||
|         return (string) $this->get('rate'); | ||||
|     } | ||||
| 
 | ||||
|     public function getToCurrency(): TransactionCurrency | ||||
|     { | ||||
|         return TransactionCurrency::where('code', $this->get('to'))->first(); | ||||
| @@ -61,7 +61,7 @@ class StoreRequest extends FormRequest | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'date' => 'required|date|after:1900-01-01|before:2099-12-31', | ||||
|             'date' => 'required|date|after:1970-01-02|before:2038-01-17', | ||||
|             'rate' => 'required|numeric|gt:0', | ||||
|             'from' => 'required|exists:transaction_currencies,code', | ||||
|             'to'   => 'required|exists:transaction_currencies,code', | ||||
|   | ||||
| @@ -50,7 +50,7 @@ class UpdateRequest extends FormRequest | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'date'  => 'date|after:1900-01-01|before:2099-12-31', | ||||
|             'date' => 'date|after:1970-01-02|before:2038-01-17', | ||||
|             'rate' => 'required|numeric|gt:0', | ||||
|         ]; | ||||
|     } | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Models\PiggyBank; | ||||
| 
 | ||||
| use Illuminate\Contracts\Validation\Validator; | ||||
| use FireflyIII\Exceptions\FireflyException; | ||||
| use FireflyIII\Models\TransactionCurrency; | ||||
| use FireflyIII\Repositories\Account\AccountRepositoryInterface; | ||||
| @@ -32,7 +33,6 @@ use FireflyIII\Support\Request\ChecksLogin; | ||||
| use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Validation\Validator; | ||||
| 
 | ||||
| /** | ||||
|  * Class StoreRequest | ||||
| @@ -126,7 +126,7 @@ class StoreRequest extends FormRequest | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', self::class), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|   | ||||
| @@ -82,7 +82,7 @@ class UpdateRequest extends FormRequest | ||||
|             'accounts'                  => 'required', | ||||
|             'accounts.*'                => 'array|required', | ||||
|             'accounts.*.account_id'     => ['required', 'numeric', 'belongsToUser:accounts,id'], | ||||
|             'accounts.*.current_amount' => ['numeric', new IsValidZeroOrMoreAmount()], | ||||
|             'accounts.*.current_amount' => ['numeric', 'nullable', new IsValidZeroOrMoreAmount(true)], | ||||
|             'object_group_id'           => 'numeric|belongsToUser:object_groups,id', | ||||
|             'object_group_title'        => ['min:1', 'max:255'], | ||||
|             'transaction_currency_id'   => 'exists:transaction_currencies,id|nullable', | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Models\Recurrence; | ||||
| 
 | ||||
| use Illuminate\Contracts\Validation\Validator; | ||||
| use FireflyIII\Rules\BelongsUser; | ||||
| use FireflyIII\Rules\IsBoolean; | ||||
| use FireflyIII\Rules\IsValidPositiveAmount; | ||||
| @@ -35,7 +36,6 @@ use FireflyIII\Validation\RecurrenceValidation; | ||||
| use FireflyIII\Validation\TransactionValidation; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Validation\Validator; | ||||
| 
 | ||||
| /** | ||||
|  * Class StoreRequest | ||||
| @@ -76,7 +76,7 @@ class StoreRequest extends FormRequest | ||||
| 
 | ||||
|     /** | ||||
|      * Returns the transaction data as it is found in the submitted data. It's a complex method according to code | ||||
|      * standards but it just has a lot of ??-statements because of the fields that may or may not exist. | ||||
|      * standards, but it just has a lot of ??-statements because of the fields that may or may not exist. | ||||
|      */ | ||||
|     private function getTransactionData(): array | ||||
|     { | ||||
| @@ -193,7 +193,7 @@ class StoreRequest extends FormRequest | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', self::class), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Models\Recurrence; | ||||
| 
 | ||||
| use Illuminate\Contracts\Validation\Validator; | ||||
| use FireflyIII\Models\Recurrence; | ||||
| use FireflyIII\Rules\BelongsUser; | ||||
| use FireflyIII\Rules\IsBoolean; | ||||
| @@ -36,7 +37,6 @@ use FireflyIII\Validation\RecurrenceValidation; | ||||
| use FireflyIII\Validation\TransactionValidation; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Validation\Validator; | ||||
| 
 | ||||
| /** | ||||
|  * Class UpdateRequest | ||||
| @@ -122,7 +122,7 @@ class UpdateRequest extends FormRequest | ||||
| 
 | ||||
|     /** | ||||
|      * Returns the transaction data as it is found in the submitted data. It's a complex method according to code | ||||
|      * standards but it just has a lot of ??-statements because of the fields that may or may not exist. | ||||
|      * standards, but it just has a lot of ??-statements because of the fields that may or may not exist. | ||||
|      */ | ||||
|     private function getTransactionData(): array | ||||
|     { | ||||
| @@ -154,7 +154,7 @@ class UpdateRequest extends FormRequest | ||||
|         return [ | ||||
|             'title'                                => sprintf('min:1|max:255|uniqueObjectForUser:recurrences,title,%d', $recurrence->id), | ||||
|             'description'                          => 'min:1|max:32768', | ||||
|             'first_date'                           => 'date|after:1900-01-01|before:2099-12-31', | ||||
|             'first_date'                           => 'date|after:1970-01-02|before:2038-01-17', | ||||
|             'apply_rules'                          => [new IsBoolean()], | ||||
|             'active'                               => [new IsBoolean()], | ||||
|             'repeat_until'                         => 'nullable|date', | ||||
| @@ -208,7 +208,7 @@ class UpdateRequest extends FormRequest | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', self::class), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Models\Rule; | ||||
| 
 | ||||
| use Illuminate\Contracts\Validation\Validator; | ||||
| use FireflyIII\Rules\IsBoolean; | ||||
| use FireflyIII\Rules\IsValidActionExpression; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| @@ -31,7 +32,6 @@ use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use FireflyIII\Support\Request\GetRuleConfiguration; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Validation\Validator; | ||||
| 
 | ||||
| /** | ||||
|  * Class StoreRequest | ||||
| @@ -148,7 +148,7 @@ class StoreRequest extends FormRequest | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', self::class), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|   | ||||
| @@ -71,8 +71,8 @@ class TestRequest extends FormRequest | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'start'      => 'date|after:1900-01-01|before:2099-12-31', | ||||
|             'end'        => 'date|after_or_equal:start|after:1900-01-01|before:2099-12-31', | ||||
|             'start'      => 'date|after:1970-01-02|before:2038-01-17', | ||||
|             'end'        => 'date|after_or_equal:start|after:1970-01-02|before:2038-01-17', | ||||
|             'accounts'   => '', | ||||
|             'accounts.*' => 'required|exists:accounts,id|belongsToUser:accounts', | ||||
|         ]; | ||||
|   | ||||
| @@ -65,8 +65,8 @@ class TriggerRequest extends FormRequest | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'start'      => 'date|after:1900-01-01|before:2099-12-31', | ||||
|             'end'        => 'date|after_or_equal:start|after:1900-01-01|before:2099-12-31', | ||||
|             'start'      => 'date|after:1970-01-02|before:2038-01-17', | ||||
|             'end'        => 'date|after_or_equal:start|after:1970-01-02|before:2038-01-17', | ||||
|             'accounts'   => '', | ||||
|             'accounts.*' => 'exists:accounts,id|belongsToUser:accounts', | ||||
|         ]; | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Models\Rule; | ||||
| 
 | ||||
| use Illuminate\Contracts\Validation\Validator; | ||||
| use FireflyIII\Models\Rule; | ||||
| use FireflyIII\Rules\IsBoolean; | ||||
| use FireflyIII\Rules\IsValidActionExpression; | ||||
| @@ -32,7 +33,6 @@ use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use FireflyIII\Support\Request\GetRuleConfiguration; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Validation\Validator; | ||||
| 
 | ||||
| /** | ||||
|  * Class UpdateRequest | ||||
| @@ -168,7 +168,7 @@ class UpdateRequest extends FormRequest | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', self::class), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|   | ||||
| @@ -65,8 +65,8 @@ class TestRequest extends FormRequest | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'start'      => 'date|after:1900-01-01|before:2099-12-31', | ||||
|             'end'        => 'date|after_or_equal:start|after:1900-01-01|before:2099-12-31', | ||||
|             'start'      => 'date|after:1970-01-02|before:2038-01-17', | ||||
|             'end'        => 'date|after_or_equal:start|after:1970-01-02|before:2038-01-17', | ||||
|             'accounts'   => '', | ||||
|             'accounts.*' => 'exists:accounts,id|belongsToUser:accounts', | ||||
|         ]; | ||||
|   | ||||
| @@ -69,8 +69,8 @@ class TriggerRequest extends FormRequest | ||||
|     public function rules(): array | ||||
|     { | ||||
|         return [ | ||||
|             'start' => 'date|after:1900-01-01|before:2099-12-31', | ||||
|             'end'   => 'date|after_or_equal:start|after:1900-01-01|before:2099-12-31', | ||||
|             'start' => 'date|after:1970-01-02|before:2038-01-17', | ||||
|             'end'   => 'date|after_or_equal:start|after:1970-01-02|before:2038-01-17', | ||||
|         ]; | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -62,7 +62,7 @@ class StoreRequest extends FormRequest | ||||
|         $rules = [ | ||||
|             'tag'         => 'required|min:1|uniqueObjectForUser:tags,tag|max:1024', | ||||
|             'description' => 'min:1|nullable|max:32768', | ||||
|             'date'        => 'date|nullable|after:1900-01-01|before:2099-12-31', | ||||
|             'date'        => 'date|nullable|after:1970-01-02|before:2038-01-17', | ||||
|         ]; | ||||
| 
 | ||||
|         return Location::requestRules($rules); | ||||
|   | ||||
| @@ -66,7 +66,7 @@ class UpdateRequest extends FormRequest | ||||
|         $rules = [ | ||||
|             'tag'         => 'min:1|max:1024|uniqueObjectForUser:tags,tag,'.$tag->id, | ||||
|             'description' => 'min:1|nullable|max:32768', | ||||
|             'date'        => 'date|nullable|after:1900-01-01|before:2099-12-31', | ||||
|             'date'        => 'date|nullable|after:1970-01-02|before:2038-01-17', | ||||
|         ]; | ||||
| 
 | ||||
|         return Location::requestRules($rules); | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Models\Transaction; | ||||
| 
 | ||||
| use Illuminate\Contracts\Validation\Validator; | ||||
| use FireflyIII\Models\Location; | ||||
| use FireflyIII\Rules\BelongsUser; | ||||
| use FireflyIII\Rules\IsBoolean; | ||||
| @@ -39,7 +40,6 @@ use FireflyIII\Validation\GroupValidation; | ||||
| use FireflyIII\Validation\TransactionValidation; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Validation\Validator; | ||||
| 
 | ||||
| /** | ||||
|  * Class StoreRequest | ||||
| @@ -58,7 +58,7 @@ class StoreRequest extends FormRequest | ||||
|      */ | ||||
|     public function getAll(): array | ||||
|     { | ||||
|         app('log')->debug('get all data in TransactionStoreRequest'); | ||||
|         Log::debug('get all data in TransactionStoreRequest'); | ||||
| 
 | ||||
|         return [ | ||||
|             'group_title'             => $this->convertString('group_title'), | ||||
| @@ -175,7 +175,7 @@ class StoreRequest extends FormRequest | ||||
|      */ | ||||
|     public function rules(): array | ||||
|     { | ||||
|         app('log')->debug('Collect rules of TransactionStoreRequest'); | ||||
|         Log::debug('Collect rules of TransactionStoreRequest'); | ||||
|         $validProtocols = config('firefly.valid_url_protocols'); | ||||
|         $locationRules  = Location::requestRules([]); | ||||
| 
 | ||||
| @@ -276,9 +276,9 @@ class StoreRequest extends FormRequest | ||||
|                 $this->validateTransactionArray($validator); | ||||
| 
 | ||||
|                 // must submit at least one transaction.
 | ||||
|                 app('log')->debug('Now going to validateOneTransaction'); | ||||
|                 Log::debug('Now going to validateOneTransaction'); | ||||
|                 $this->validateOneTransaction($validator); | ||||
|                 app('log')->debug('Now done with validateOneTransaction'); | ||||
|                 Log::debug('Now done with validateOneTransaction'); | ||||
| 
 | ||||
|                 // all journals must have a description
 | ||||
|                 $this->validateDescriptions($validator); | ||||
| @@ -300,7 +300,7 @@ class StoreRequest extends FormRequest | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', self::class), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Models\Transaction; | ||||
| 
 | ||||
| use Illuminate\Contracts\Validation\Validator; | ||||
| use FireflyIII\Exceptions\FireflyException; | ||||
| use FireflyIII\Models\TransactionGroup; | ||||
| use FireflyIII\Rules\BelongsUser; | ||||
| @@ -37,7 +38,6 @@ use FireflyIII\Validation\GroupValidation; | ||||
| use FireflyIII\Validation\TransactionValidation; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Validation\Validator; | ||||
| 
 | ||||
| /** | ||||
|  * Class UpdateRequest | ||||
| @@ -183,7 +183,7 @@ class UpdateRequest extends FormRequest | ||||
|         foreach ($this->dateFields as $fieldName) { | ||||
|             app('log')->debug(sprintf('Now at date field %s', $fieldName)); | ||||
|             if (array_key_exists($fieldName, $transaction)) { | ||||
|                 app('log')->debug(sprintf('New value: "%s"', (string) $transaction[$fieldName])); | ||||
|                 Log::debug(sprintf('New value: "%s"', $transaction[$fieldName])); | ||||
|                 $current[$fieldName] = $this->dateFromValue((string) $transaction[$fieldName]); | ||||
|             } | ||||
|         } | ||||
| @@ -359,7 +359,7 @@ class UpdateRequest extends FormRequest | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', self::class), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| } | ||||
|   | ||||
| @@ -24,6 +24,7 @@ declare(strict_types=1); | ||||
| 
 | ||||
| namespace FireflyIII\Api\V1\Requests\Models\TransactionLink; | ||||
| 
 | ||||
| use Illuminate\Contracts\Validation\Validator; | ||||
| use FireflyIII\Repositories\Journal\JournalRepositoryInterface; | ||||
| use FireflyIII\Repositories\LinkType\LinkTypeRepositoryInterface; | ||||
| use FireflyIII\Support\Request\ChecksLogin; | ||||
| @@ -31,7 +32,6 @@ use FireflyIII\Support\Request\ConvertsDataTypes; | ||||
| use FireflyIII\User; | ||||
| use Illuminate\Foundation\Http\FormRequest; | ||||
| use Illuminate\Support\Facades\Log; | ||||
| use Illuminate\Validation\Validator; | ||||
| 
 | ||||
| /** | ||||
|  * Class StoreRequest | ||||
| @@ -80,7 +80,7 @@ class StoreRequest extends FormRequest | ||||
|             } | ||||
|         ); | ||||
|         if ($validator->fails()) { | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', __CLASS__), $validator->errors()->toArray()); | ||||
|             Log::channel('audit')->error(sprintf('Validation errors in %s', self::class), $validator->errors()->toArray()); | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|   | ||||
Some files were not shown because too many files have changed in this diff Show More
		Reference in New Issue
	
	Block a user