From 0877bd5770b8853dc81132c64b971bdb81b56d8c Mon Sep 17 00:00:00 2001 From: Norm Brandinger Date: Fri, 16 Apr 2021 10:24:51 -0400 Subject: [PATCH] [Core] switch_rtp: fix switch_rtp_set_max_missed_packets logging Warning message about missed packets is misleading. Message indicates greater (>) however, the conditional is greater than or equals (>=). The message prints the value of rtp_sesstion->missed_count twice instead of printing the value of rtp_session->max_missed_packets. --- src/switch_rtp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/switch_rtp.c b/src/switch_rtp.c index e879436206..1b0d407dec 100644 --- a/src/switch_rtp.c +++ b/src/switch_rtp.c @@ -2913,11 +2913,11 @@ SWITCH_DECLARE(void) switch_rtp_set_max_missed_packets(switch_rtp_t *rtp_session return; } - if (rtp_session->missed_count >= max) { + if (rtp_session->missed_count > max) { switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(rtp_session->session), SWITCH_LOG_WARNING, "new max missed packets(%d->%d) greater than current missed packets(%d). RTP will timeout.\n", - rtp_session->missed_count, max, rtp_session->missed_count); + rtp_session->max_missed_packets, max, rtp_session->missed_count); } rtp_session->max_missed_packets = max;