Thu May 14 13:05:43 CDT 2009 Pekka Pessi <first.last@nokia.com>

* nta: clarify outgoing_ack() logic
  Ignore-this: a745b3e7df63835d9768ec9dc3d5c5b2
  
  Coverity issue.


git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@13354 d0543943-73ff-0310-b7d9-9358b9ac24b2
This commit is contained in:
Michael Jerris 2009-05-15 16:19:19 +00:00
parent 61c23ee5d1
commit 0dbb31daab
2 changed files with 10 additions and 13 deletions

View File

@ -1 +1 @@
Fri May 15 11:17:32 CDT 2009 Fri May 15 11:18:36 CDT 2009

View File

@ -9353,7 +9353,6 @@ static int outgoing_duplicate(nta_outgoing_t *orq,
*/ */
void outgoing_ack(nta_outgoing_t *orq, sip_t *sip) void outgoing_ack(nta_outgoing_t *orq, sip_t *sip)
{ {
nta_outgoing_t *ack;
msg_t *ackmsg; msg_t *ackmsg;
assert(orq); assert(orq);
@ -9367,18 +9366,16 @@ void outgoing_ack(nta_outgoing_t *orq, sip_t *sip)
assert(orq->orq_tport); assert(orq->orq_tport);
ackmsg = outgoing_ackmsg(orq, SIP_METHOD_ACK, SIPTAG_TO(sip->sip_to), TAG_END()); ackmsg = outgoing_ackmsg(orq, SIP_METHOD_ACK, SIPTAG_TO(sip->sip_to), TAG_END());
if (!ackmsg)
return;
if (ackmsg) { if (!outgoing_create(orq->orq_agent, NULL, NULL,
if ((ack = outgoing_create(orq->orq_agent, NULL, NULL,
NULL, orq->orq_tpn, ackmsg, NULL, orq->orq_tpn, ackmsg,
NTATAG_BRANCH_KEY(sip->sip_via->v_branch), NTATAG_BRANCH_KEY(sip->sip_via->v_branch),
NTATAG_USER_VIA(1), NTATAG_USER_VIA(1),
NTATAG_STATELESS(1), NTATAG_STATELESS(1),
TAG_END()))) TAG_END()))
;
else
msg_destroy(ackmsg); msg_destroy(ackmsg);
}
} }
/** Generate messages for hop-by-hop ACK or CANCEL. /** Generate messages for hop-by-hop ACK or CANCEL.