kenmirrors/freeswitch
1
0
Fork 0
mirror of https://github.com/signalwire/freeswitch.git synced 2025-04-02 11:19:28 +00:00
Code Issues Projects Releases Wiki Activity

FS-11280: Allow overriding permissionCallback per Verto dialog

Browse Source 
Currently the 'permissionCallback' object is only available at the Verto
instance level. This is problematic in multi-call scenarios, where an
individual call dialog needs access to the onGranted/onDenied callback
functions.

The patch adds a check for existence of onGranted/onDenied callback functions
at the dialog level, with a fallback to the original behavior of calling
onGranted/onDenied from the Verto instance if it's not available on the dialog.
This preserves backwards compatibility while allowing per-dialog overrides
going forward.
This commit is contained in:
Chad Phillips 2018-07-26 13:37:32 -05:00
parent d5af929660
commit 36d9f7bc5e
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
html5/verto/js/src/jquery.verto.js
View File

@ -2053,7 +2053,11 @@
}; };
RTCcallbacks.onStream = function(rtc, stream) { RTCcallbacks.onStream = function(rtc, stream) {
if (dialog.verto.options.permissionCallback && if (dialog.callbacks.permissionCallback &&
typeof dialog.callbacks.permissionCallback.onGranted === 'function') {
dialog.callbacks.permissionCallback.onGranted(stream);
}
else if (dialog.verto.options.permissionCallback &&
typeof dialog.verto.options.permissionCallback.onGranted === 'function'){ typeof dialog.verto.options.permissionCallback.onGranted === 'function'){
dialog.verto.options.permissionCallback.onGranted(stream); dialog.verto.options.permissionCallback.onGranted(stream);
} }
@ -2061,7 +2065,11 @@
}; };
RTCcallbacks.onError = function(e) { RTCcallbacks.onError = function(e) {
if (dialog.verto.options.permissionCallback && if (dialog.callbacks.permissionCallback &&
typeof dialog.callbacks.permissionCallback.onDenied === 'function') {
dialog.callbacks.permissionCallback.onDenied();
}
else if (dialog.verto.options.permissionCallback &&
typeof dialog.verto.options.permissionCallback.onDenied === 'function'){ typeof dialog.verto.options.permissionCallback.onDenied === 'function'){
dialog.verto.options.permissionCallback.onDenied(); dialog.verto.options.permissionCallback.onDenied();
} }