From 6f1cc570d5e304ddc490fb4ee4fbbb10393aa839 Mon Sep 17 00:00:00 2001 From: Yossi Neiman Date: Wed, 14 Feb 2024 20:12:04 -0600 Subject: [PATCH] [mod_sofia] I cannot certify that on SWITCH_MESSAGE_INDICATE_TRANSCODING_NECESSARY that we should be following this code path, but it does not look like there's anything that gets changed when we enter sofia_receive_message() in this case. Thus there's no sense in locking tech_pvt->sofia_mutex , thus avoiding the deadlock described in issue #2290. --- src/mod/endpoints/mod_sofia/mod_sofia.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mod/endpoints/mod_sofia/mod_sofia.c b/src/mod/endpoints/mod_sofia/mod_sofia.c index c5ce6e3855..f9a416119b 100644 --- a/src/mod/endpoints/mod_sofia/mod_sofia.c +++ b/src/mod/endpoints/mod_sofia/mod_sofia.c @@ -1482,6 +1482,9 @@ static switch_status_t sofia_receive_message(switch_core_session_t *session, swi sofia_clear_flag(tech_pvt, TFLAG_EARLY_MEDIA); } goto end; + case SWITCH_MESSAGE_INDICATE_TRANSCODING_NECESSARY: + // There doesn't seem to be anything needing to be done, so let's skip the mutex deadlock in issue 2290 + goto end; case SWITCH_MESSAGE_INDICATE_ANSWER: case SWITCH_MESSAGE_INDICATE_PROGRESS: {