kenmirrors
/
freeswitch
mirror of https://github.com/signalwire/freeswitch.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

[CORE] Fix video disruptions caused by dropping entire frame when only single packet is missed 

Currently when single packet is missed and there is subsequent packet already available in buffer, which belongs to the same frame, or missed packet is marked, the entire frame is dropped.
Together with buffer resync, that causes video disruptions.

With this fix, we don't drop any frame, just because of loss of single packet. We carry on and pass the broken frame to decoder, which does all it's best to conceals errors.
Because one step back we've requested new keyframe, video will recover anyway in a moment and there will be smooth transition from the bad state we've encountered.
This commit is contained in:
Jakub Karolczyk 2021-06-10 12:36:52 +01:00
parent 7f86d25c6c
commit 860a9d7af0
1 changed files with 1 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/switch_jitterbuffer.c
View File

@ -743,8 +743,6 @@ static inline switch_status_t jb_next_packet_by_seq(switch_jb_t *jb, switch_jb_n
{ {
switch_jb_node_t *node = NULL; switch_jb_node_t *node = NULL;
top:
if (jb->type == SJB_VIDEO) { if (jb->type == SJB_VIDEO) {
if (jb->dropped) { if (jb->dropped) {
jb->dropped = 0; jb->dropped = 0;
@ -774,38 +772,13 @@ static inline switch_status_t jb_next_packet_by_seq(switch_jb_t *jb, switch_jb_n
jb_miss(jb); jb_miss(jb);
if (jb->type == SJB_VIDEO) { if (jb->type == SJB_VIDEO) {
int x;
if (jb->session) { if (jb->session) {
switch_core_session_request_video_refresh(jb->session); switch_core_session_request_video_refresh(jb->session);
} }
for (x = 0; x < 10; x++) { increment_seq(jb);
increment_seq(jb);
if ((node = switch_core_inthash_find(jb->node_hash, jb->target_seq))) {
jb_debug(jb, 2, "FOUND incremental seq: %u\n", ntohs(jb->target_seq));
if (node->packet.header.m || node->packet.header.ts == jb->highest_read_ts) {
jb_debug(jb, 2, "%s", "SAME FRAME DROPPING\n");
jb->dropped++;
drop_ts(jb, node->packet.header.ts);
jb->highest_dropped_ts = ntohl(node->packet.header.ts);
if (jb->period_miss_count > 2 && jb->period_miss_inc < 1) {
jb->period_miss_inc++;
jb_frame_inc(jb, 1);
}
node = NULL;
goto top;
}
break;
} else {
jb_debug(jb, 2, "MISSING incremental seq: %u\n", ntohs(jb->target_seq));
}
}
} else { } else {
increment_seq(jb); increment_seq(jb);
} }