kenmirrors
/
freeswitch
mirror of https://github.com/signalwire/freeswitch.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

FS-11903: Fix errors reported by PVS-Studio Static Code Analyzer for switch_stun.c

This commit is contained in:
Andrey Volk 2019-07-12 20:46:20 +04:00
parent b5d8ffcb5e
commit b765bd46b5
1 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/switch_stun.c
View File

@ -809,26 +809,23 @@ SWITCH_DECLARE(switch_status_t) switch_stun_lookup(char **ip,
end_buf = buf + ((sizeof(buf) > packet->header.length) ? packet->header.length : sizeof(buf)); end_buf = buf + ((sizeof(buf) > packet->header.length) ? packet->header.length : sizeof(buf));
switch_stun_packet_first_attribute(packet, attr); switch_stun_packet_first_attribute(packet, attr);
switch_assert(attr);
do { do {
switch (attr->type) { switch (attr->type) {
case SWITCH_STUN_ATTR_MAPPED_ADDRESS: case SWITCH_STUN_ATTR_MAPPED_ADDRESS:
if (attr->type) { if (funny) {
if (funny) { switch_stun_ip_t *tmp = (switch_stun_ip_t *) attr->value;
switch_stun_ip_t *tmp = (switch_stun_ip_t *) attr->value; tmp->address ^= ntohl(0xabcdabcd);
tmp->address ^= ntohl(0xabcdabcd);
}
switch_stun_packet_attribute_get_mapped_address(attr, rip, sizeof(rip), &rport);
} }
switch_stun_packet_attribute_get_mapped_address(attr, rip, sizeof(rip), &rport);
break; break;
case SWITCH_STUN_ATTR_XOR_MAPPED_ADDRESS: case SWITCH_STUN_ATTR_XOR_MAPPED_ADDRESS:
if (attr->type) { switch_stun_packet_attribute_get_xor_mapped_address(attr, &packet->header, rip, sizeof(rip), &rport);
switch_stun_packet_attribute_get_xor_mapped_address(attr, &packet->header, rip, sizeof(rip), &rport);
}
break; break;
case SWITCH_STUN_ATTR_USERNAME: case SWITCH_STUN_ATTR_USERNAME:
if (attr->type) { switch_stun_packet_attribute_get_username(attr, username, 32);
switch_stun_packet_attribute_get_username(attr, username, 32);
}
break; break;
} }