kenmirrors
/
freeswitch
mirror of https://github.com/signalwire/freeswitch.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

FS-10304: [mod_callcenter] Prevent infinite logging when a stale queue member in found in the database 

Having a member from a queue that is no longer found on the current system
causes infinite logging about skipping a member.

There is already cleanup code for abandoned calls in same function, but it can
never be reached for this case, because there is no queue.

If the queue is never found again in the system, the logging would continue
forever or until the stale record gets removed from the database.

FS-10304 #resolve
This commit is contained in:
Eduardo Marinho 2017-05-11 09:27:34 -03:00
parent b12bbbc98f
commit be741eab2c
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/mod/applications/mod_callcenter/mod_callcenter.c
View File

@ -2361,7 +2361,10 @@ static int members_callback(void *pArg, int argc, char **argv, char **columnName
cbt.member_system = argv[10]; cbt.member_system = argv[10];
if (!cbt.queue_name || !(queue = get_queue(cbt.queue_name))) { if (!cbt.queue_name || !(queue = get_queue(cbt.queue_name))) {
switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_WARNING, "Queue %s not found locally, skip this member\n", cbt.queue_name); switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_WARNING, "Queue %s not found locally, delete this member\n", cbt.queue_name);
sql = switch_mprintf("DELETE FROM members WHERE uuid = '%q' AND system = '%q'", cbt.member_uuid, cbt.member_system);
cc_execute_sql(NULL, sql, NULL);
switch_safe_free(sql);
goto end; goto end;
} else { } else {
queue_name = strdup(queue->name); queue_name = strdup(queue->name);