kenmirrors
/
freeswitch
mirror of https://github.com/signalwire/freeswitch.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Save to a temp file first, then rename 

This allows the GET request to return a different mime type (and extension) to what was previously stored
This commit is contained in:
Joshua Gigg 2020-09-10 20:47:00 +01:00 committed by GitHub
parent 59eaa4c221
commit c475f5d8ab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/mod/applications/mod_httapi/mod_httapi.c
View File

@ -2781,8 +2781,12 @@ static switch_status_t locate_url_file(http_file_context_t *context, const char
switch_status_t status = SWITCH_STATUS_FALSE;
time_t now = switch_epoch_time_now(NULL);
char *metadata;
const char *cache_file_temp;
const char *ext = NULL;
const char *err_msg = NULL;
const char *ct = NULL;
const char *newext = NULL;
load_cache_data(context, url);
@ -2852,11 +2856,31 @@ static switch_status_t locate_url_file(http_file_context_t *context, const char
}
if ((status = fetch_cache_data(context, url, &headers, context->cache_file, &err_msg)) != SWITCH_STATUS_SUCCESS) {
/*
* Save to a temp file first, then rename
* Just in case the extension changes
*/
cache_file_temp = switch_core_sprintf(context->pool, "%s.tmp", context->cache_file_base);
if ((status = fetch_cache_data(context, url, &headers, cache_file_temp, &err_msg)) != SWITCH_STATUS_SUCCESS) {
switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "Error fetching file at URL \"%s\" (%s)\n", url, err_msg ? err_msg : "");
goto end;
}
if (headers && (ct = switch_event_get_header(headers, "content-type"))) {
newext = switch_core_mime_type2ext(ct);
}
if (newext && (zstr(ext) || strcmp(ext, newext) != 0)) {
/*
* HTTP Request has returned the file with a different extension
* Update the cache_file path for when the rename happens
*/
ext = newext;
context->cache_file = switch_core_sprintf(context->pool, "%s.%s", context->cache_file_base, newext);
}
rename(cache_file_temp, context->cache_file);
metadata = switch_core_sprintf(context->pool, "%s:%s:%s:%s:%s",
url,