kenmirrors
/
freeswitch
mirror of https://github.com/signalwire/freeswitch.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #482 from dragos-oancea/mod_portaudio-nullptr 

[mod_portaudio] scan-build: Access to field 'next' results in a dereference of a null pointer (loaded from variable 'previous').
This commit is contained in:
Andrey Volk 2020-03-12 21:03:50 +04:00 committed by GitHub
parent d1ab723582 0b5c7307a7
commit da4068e744
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/mod/endpoints/mod_portaudio/mod_portaudio.c
View File

@ -644,7 +644,9 @@ static void remove_stream(audio_stream_t * stream, int already_locked)
for (previous = globals.stream_list; previous && previous->next && previous->next != stream; previous = previous->next) { for (previous = globals.stream_list; previous && previous->next && previous->next != stream; previous = previous->next) {
; ;
} }
previous->next = stream->next; if (previous) {
previous->next = stream->next;
}
} }
if (! already_locked) { if (! already_locked) {
switch_mutex_unlock(globals.streams_lock); switch_mutex_unlock(globals.streams_lock);
@ -1180,7 +1182,6 @@ static switch_call_cause_t channel_outgoing_channel(switch_core_session_t *sessi
} }
if (outbound_profile->destination_number && !strncasecmp(outbound_profile->destination_number, "endpoint", sizeof("endpoint")-1)) { if (outbound_profile->destination_number && !strncasecmp(outbound_profile->destination_number, "endpoint", sizeof("endpoint")-1)) {
codec_ms = -1;
endpoint = NULL; endpoint = NULL;
endpoint_name = switch_core_strdup(outbound_profile->pool, outbound_profile->destination_number); endpoint_name = switch_core_strdup(outbound_profile->pool, outbound_profile->destination_number);
endpoint_name = strchr(endpoint_name, '/'); endpoint_name = strchr(endpoint_name, '/');