From e3b4e6b227c50b223a68d6b876ad46a1f5586354 Mon Sep 17 00:00:00 2001 From: Michael Jerris Date: Mon, 28 Apr 2014 13:01:12 -0400 Subject: [PATCH] fix deref before null check --- src/switch_curl.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/switch_curl.c b/src/switch_curl.c index c0f08bbefa..5bd2e52db3 100644 --- a/src/switch_curl.c +++ b/src/switch_curl.c @@ -81,21 +81,21 @@ SWITCH_DECLARE(switch_status_t) switch_curl_process_form_post_params(switch_even if (!strncasecmp(hp->name, "attach_file:", 12)) { char *pname = strdup(hp->name + 12); - char *fname = strchr(pname, ':'); - if (fname && pname) { - *fname++ = '\0'; + if (pname) { + char *fname = strchr(pname, ':'); + if (fname) { + *fname++ = '\0'; - curl_formadd(&formpost, - &lastptr, - CURLFORM_COPYNAME, pname, - CURLFORM_FILENAME, fname, - CURLFORM_FILE, hp->value, - CURLFORM_END); + curl_formadd(&formpost, + &lastptr, + CURLFORM_COPYNAME, pname, + CURLFORM_FILENAME, fname, + CURLFORM_FILE, hp->value, + CURLFORM_END); + } + free(pname); } - - free(pname); - } else { curl_formadd(&formpost, &lastptr,